• N
    PCI: tegra: Revert tegra124 raw_violation_fixup · e7b856df
    Nicolas Chauvet 提交于
    As reported in https://bugzilla.kernel.org/206217 , raw_violation_fixup
    is causing more harm than good in some common use-cases.
    
    This patch is a partial revert of commit:
    
    191cd6fb ("PCI: tegra: Add SW fixup for RAW violations")
    
    and fixes the following regression since then.
    
    * Description:
    
    When both the NIC and MMC are used one can see the following message:
    
      NETDEV WATCHDOG: enp1s0 (r8169): transmit queue 0 timed out
    
    and
    
      pcieport 0000:00:02.0: AER: Uncorrected (Non-Fatal) error received: 0000:01:00.0
      r8169 0000:01:00.0: AER: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID)
      r8169 0000:01:00.0: AER:   device [10ec:8168] error status/mask=00004000/00400000
      r8169 0000:01:00.0: AER:    [14] CmpltTO                (First)
      r8169 0000:01:00.0: AER: can't recover (no error_detected callback)
      pcieport 0000:00:02.0: AER: device recovery failed
    
    After that, the ethernet NIC is not functional anymore even after
    reloading the r8169 module. After a reboot, this is reproducible by
    copying a large file over the NIC to the MMC.
    
    For some reason this is not reproducible when files are copied to a tmpfs.
    
    * Little background on the fixup, by Manikanta Maddireddy:
      "In the internal testing with dGPU on Tegra124, CmplTO is reported by
    dGPU. This happened because FIFO queue in AFI(AXI to PCIe) module
    get full by upstream posted writes. Back to back upstream writes
    interleaved with infrequent reads, triggers RAW violation and CmpltTO.
    This is fixed by reducing the posted write credits and by changing
    updateFC timer frequency. These settings are fixed after stress test.
    
    In the current case, RTL NIC is also reporting CmplTO. These settings
    seems to be aggravating the issue instead of fixing it."
    
    Link: https://lore.kernel.org/r/20200718100710.15398-1-kwizart@gmail.com
    Fixes: 191cd6fb ("PCI: tegra: Add SW fixup for RAW violations")
    Signed-off-by: NNicolas Chauvet <kwizart@gmail.com>
    Signed-off-by: NLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Reviewed-by: NManikanta Maddireddy <mmaddireddy@nvidia.com>
    Cc: stable@vger.kernel.org
    e7b856df
pci-tegra.c 72.5 KB