• C
    bcache: reap c->btree_cache_freeable from the tail in bch_mca_scan() · d5c9c470
    Coly Li 提交于
    In order to skip the most recently freed btree node cahce, currently
    in bch_mca_scan() the first 3 caches in c->btree_cache_freeable list
    are skipped when shrinking bcache node caches in bch_mca_scan(). The
    related code in bch_mca_scan() is,
    
     737 list_for_each_entry_safe(b, t, &c->btree_cache_freeable, list) {
     738         if (nr <= 0)
     739                 goto out;
     740
     741         if (++i > 3 &&
     742             !mca_reap(b, 0, false)) {
                 		lines free cache memory
     746         }
     747         nr--;
     748 }
    
    The problem is, if virtual memory code calls bch_mca_scan() and
    the calculated 'nr' is 1 or 2, then in the above loop, nothing will
    be shunk. In such case, if slub/slab manager calls bch_mca_scan()
    for many times with small scan number, it does not help to shrink
    cache memory and just wasts CPU cycles.
    
    This patch just selects btree node caches from tail of the
    c->btree_cache_freeable list, then the newly freed host cache can
    still be allocated by mca_alloc(), and at least 1 node can be shunk.
    Signed-off-by: NColy Li <colyli@suse.de>
    Signed-off-by: NJens Axboe <axboe@kernel.dk>
    d5c9c470
btree.c 60.6 KB