• A
    writeback: do not lose wake-ups in the forker thread - 1 · c5f7ad23
    Artem Bityutskiy 提交于
    Currently the forker thread can lose wake-ups which may lead to unnecessary
    delays in processing bdi works. E.g., consider the following scenario.
    
    1. 'bdi_forker_thread()' walks the 'bdi_list', finds out there is nothing to
       do, and is about to finish the loop.
    2. A bdi thread decides to exit because it was inactive for long time.
    3. 'bdi_queue_work()' adds a work to the bdi which just exited, so it wakes up
       the forker thread.
    4. but 'bdi_forker_thread()' executes 'set_current_state(TASK_INTERRUPTIBLE)'
       and goes sleep. We lose a wake-up.
    
    Losing the wake-up is not fatal, but this means that the bdi work processing
    will be delayed by up to 5 sec. This race is theoretical, I never hit it, but
    it is worth fixing.
    
    The fix is to execute 'set_current_state(TASK_INTERRUPTIBLE)' _before_ walking
    'bdi_list', not after.
    Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
    Reviewed-by: NChristoph Hellwig <hch@lst.de>
    Signed-off-by: NJens Axboe <jaxboe@fusionio.com>
    c5f7ad23
backing-dev.c 17.2 KB