• A
    writeback: cleanup bdi_register · c284de61
    Artem Bityutskiy 提交于
    This patch makes sure we first initialize everything and set the BDI_registered
    flag, and only after this we add the bdi to 'bdi_list'. Current code adds the
    bdi to the list too early, and as a result I the
    
    WARN(!test_bit(BDI_registered, &bdi->state)
    
    in bdi forker is triggered. Also, it is in general good practice to make things
    visible only when they are fully initialized.
    
    Also, this patch does few micro clean-ups:
    1. Removes the 'exit' label which does not do anything, just returns. This
       allows to get rid of few braces and 'ret' variable and make the code smaller.
    2. If 'kthread_run()' fails, remove the error code it returns, not hard-coded
       '-ENOMEM'. Theoretically, some day 'kthread_run()' can return something
       else. Also, in case of failure it is not necessary to set 'bdi->wb.task' to
       NULL.
    Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
    Signed-off-by: NJens Axboe <jaxboe@fusionio.com>
    c284de61
backing-dev.c 18.7 KB