• C
    xfs: Add helper for checking per-inode extent count overflow · b9b7e1dc
    Chandan Babu R 提交于
    XFS does not check for possible overflow of per-inode extent counter
    fields when adding extents to either data or attr fork.
    
    For e.g.
    1. Insert 5 million xattrs (each having a value size of 255 bytes) and
       then delete 50% of them in an alternating manner.
    
    2. On a 4k block sized XFS filesystem instance, the above causes 98511
       extents to be created in the attr fork of the inode.
    
       xfsaild/loop0  2008 [003]  1475.127209: probe:xfs_inode_to_disk: (ffffffffa43fb6b0) if_nextents=98511 i_ino=131
    
    3. The incore inode fork extent counter is a signed 32-bit
       quantity. However the on-disk extent counter is an unsigned 16-bit
       quantity and hence cannot hold 98511 extents.
    
    4. The following incorrect value is stored in the attr extent counter,
       # xfs_db -f -c 'inode 131' -c 'print core.naextents' /dev/loop0
       core.naextents = -32561
    
    This commit adds a new helper function (i.e.
    xfs_iext_count_may_overflow()) to check for overflow of the per-inode
    data and xattr extent counters. Future patches will use this function to
    make sure that an FS operation won't cause the extent counter to
    overflow.
    Suggested-by: NDarrick J. Wong <darrick.wong@oracle.com>
    Reviewed-by: NAllison Henderson <allison.henderson@oracle.com>
    Reviewed-by: NChristoph Hellwig <hch@lst.de>
    Reviewed-by: NDarrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: NChandan Babu R <chandanrlinux@gmail.com>
    Signed-off-by: NDarrick J. Wong <darrick.wong@oracle.com>
    b9b7e1dc
xfs_inode_fork.c 19.2 KB