• M
    modpost: rename merror() to error() · bc72d723
    Masahiro Yamada 提交于
    The log function names, warn(), merror(), fatal() are inconsistent.
    
    Commit 2a116659 ("kbuild: distinguish between errors and warnings
    in modpost") intentionally chose merror() to avoid the conflict with
    the library function error(). See man page of error(3).
    
    But, we are already causing the conflict with warn() because it is also
    a library function. See man page of warn(3). err() would be a problem
    for the same reason.
    
    The common technique to work around name conflicts is to use macros.
    For example:
    
        /* in a header */
        #define error(fmt, ...)  __error(fmt, ##__VA_ARGS__)
        #define warn(fmt, ...)   __warn(fmt, ##__VA_ARGS__)
    
        /* function definition */
        void __error(const char *fmt, ...)
        {
                <our implementation>
        }
    
        void __warn(const char *fmt, ...)
        {
                <our implementation>
        }
    
    In this way, we can implement our own warn() and error(), still we can
    include <error.h> and <err.h> with no problem.
    
    And, commit 93c95e52 ("modpost: rework and consolidate logging
    interface") already did that.
    
    Since the log functions are all macros, we can use error() without
    causing "conflicting types" errors.
    Signed-off-by: NMasahiro Yamada <masahiroy@kernel.org>
    bc72d723
modpost.c 68.5 KB