• S
    nvme: fix possible deadlock when I/O is blocked · b3f87175
    Sagi Grimberg 提交于
    stable inclusion
    from linux-4.19.149
    commit 03dfb191acea76e6f92379abdbb5335139b28ffa
    
    --------------------------------
    
    [ Upstream commit 3b4b1972 ]
    
    Revert fab7772b ("nvme-multipath: revalidate nvme_ns_head gendisk
    in nvme_validate_ns")
    
    When adding a new namespace to the head disk (via nvme_mpath_set_live)
    we will see partition scan which triggers I/O on the mpath device node.
    This process will usually be triggered from the scan_work which holds
    the scan_lock. If I/O blocks (if we got ana change currently have only
    available paths but none are accessible) this can deadlock on the head
    disk bd_mutex as both partition scan I/O takes it, and head disk revalidation
    takes it to check for resize (also triggered from scan_work on a different
    path). See trace [1].
    
    The mpath disk revalidation was originally added to detect online disk
    size change, but this is no longer needed since commit cb224c3a
    ("nvme: Convert to use set_capacity_revalidate_and_notify") which already
    updates resize info without unnecessarily revalidating the disk (the
    mpath disk doesn't even implement .revalidate_disk fop).
    
    [1]:
    Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
    b3f87175
core.c 95.6 KB