• L
    blk-mq: initialize 'struct request' and associated data to zero · ac211175
    Linus Torvalds 提交于
    Jan Engelhardt reports a strange oops with an invalid ->sense_buffer
    pointer in scsi_init_cmd_errh() with the blk-mq code.
    
    The sense_buffer pointer should have been initialized by the call to
    scsi_init_request() from blk_mq_init_rq_map(), but there seems to be
    some non-repeatable memory corruptor.
    
    This patch makes sure we initialize the whole struct request allocation
    (and the associated 'struct scsi_cmnd' for the SCSI case) to zero, by
    using __GFP_ZERO in the allocation.  The old code initialized a couple
    of individual fields, leaving the rest undefined (although many of them
    are then initialized in later phases, like blk_mq_rq_ctx_init() etc.
    
    It's not entirely clear why this matters, but it's the rigth thing to do
    regardless, and with 4.0 imminent this is the defensive "let's just make
    sure everything is initialized properly" patch.
    Tested-by: NJan Engelhardt <jengelh@inai.de>
    Acked-by: NJens Axboe <axboe@kernel.dk>
    Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
    ac211175
blk-mq.c 51.5 KB