• J
    drivers core: Use sysfs_emit and sysfs_emit_at for show(device *...) functions · aa838896
    Joe Perches 提交于
    Convert the various sprintf fmaily calls in sysfs device show functions
    to sysfs_emit and sysfs_emit_at for PAGE_SIZE buffer safety.
    
    Done with:
    
    $ spatch -sp-file sysfs_emit_dev.cocci --in-place --max-width=80 .
    
    And cocci script:
    
    $ cat sysfs_emit_dev.cocci
    @@
    identifier d_show;
    identifier dev, attr, buf;
    @@
    
    ssize_t d_show(struct device *dev, struct device_attribute *attr, char *buf)
    {
    	<...
    	return
    -	sprintf(buf,
    +	sysfs_emit(buf,
    	...);
    	...>
    }
    
    @@
    identifier d_show;
    identifier dev, attr, buf;
    @@
    
    ssize_t d_show(struct device *dev, struct device_attribute *attr, char *buf)
    {
    	<...
    	return
    -	snprintf(buf, PAGE_SIZE,
    +	sysfs_emit(buf,
    	...);
    	...>
    }
    
    @@
    identifier d_show;
    identifier dev, attr, buf;
    @@
    
    ssize_t d_show(struct device *dev, struct device_attribute *attr, char *buf)
    {
    	<...
    	return
    -	scnprintf(buf, PAGE_SIZE,
    +	sysfs_emit(buf,
    	...);
    	...>
    }
    
    @@
    identifier d_show;
    identifier dev, attr, buf;
    expression chr;
    @@
    
    ssize_t d_show(struct device *dev, struct device_attribute *attr, char *buf)
    {
    	<...
    	return
    -	strcpy(buf, chr);
    +	sysfs_emit(buf, chr);
    	...>
    }
    
    @@
    identifier d_show;
    identifier dev, attr, buf;
    identifier len;
    @@
    
    ssize_t d_show(struct device *dev, struct device_attribute *attr, char *buf)
    {
    	<...
    	len =
    -	sprintf(buf,
    +	sysfs_emit(buf,
    	...);
    	...>
    	return len;
    }
    
    @@
    identifier d_show;
    identifier dev, attr, buf;
    identifier len;
    @@
    
    ssize_t d_show(struct device *dev, struct device_attribute *attr, char *buf)
    {
    	<...
    	len =
    -	snprintf(buf, PAGE_SIZE,
    +	sysfs_emit(buf,
    	...);
    	...>
    	return len;
    }
    
    @@
    identifier d_show;
    identifier dev, attr, buf;
    identifier len;
    @@
    
    ssize_t d_show(struct device *dev, struct device_attribute *attr, char *buf)
    {
    	<...
    	len =
    -	scnprintf(buf, PAGE_SIZE,
    +	sysfs_emit(buf,
    	...);
    	...>
    	return len;
    }
    
    @@
    identifier d_show;
    identifier dev, attr, buf;
    identifier len;
    @@
    
    ssize_t d_show(struct device *dev, struct device_attribute *attr, char *buf)
    {
    	<...
    -	len += scnprintf(buf + len, PAGE_SIZE - len,
    +	len += sysfs_emit_at(buf, len,
    	...);
    	...>
    	return len;
    }
    
    @@
    identifier d_show;
    identifier dev, attr, buf;
    expression chr;
    @@
    
    ssize_t d_show(struct device *dev, struct device_attribute *attr, char *buf)
    {
    	...
    -	strcpy(buf, chr);
    -	return strlen(buf);
    +	return sysfs_emit(buf, chr);
    }
    Signed-off-by: NJoe Perches <joe@perches.com>
    Link: https://lore.kernel.org/r/3d033c33056d88bbe34d4ddb62afd05ee166ab9a.1600285923.git.joe@perches.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    aa838896
node.c 26.8 KB