• Z
    btrfs: Fix scrub panic when leaf crosses stripes · a323e813
    Zhao Lei 提交于
    Scrub panic in following operation:
      mkfs.ext4 /dev/vdh
      btrfs-convert /dev/vdh
      mount /dev/vdh /mnt/tmp1
      btrfs scrub start -B /dev/vdh
      (panic)
    
    Reason:
      1: In some case, leaf created by btrfs-convert was splited into 2
         strips.
      2: Scrub bypassed part of above wrong leaf data, but remain data
         caused panic in scrub_checksum_tree_block().
    
    For reason 1:
      we can get following information after some simple operation.
      a. mkfs.ext4 /dev/vdh
         btrfs-convert /dev/vdh
      b. btrfs-debug-tree /dev/vdh
         we can see following item in extent tree:
         item 25 key (27054080 METADATA_ITEM 0) itemoff 15083 itemsize 33
         Its logical address is [27054080, 27070464)
         and acrossed 2 strips:
         [27000832, 27066368)
         [27066368, 27131904)
      Will be fixed in btrfs-progs(btrfs-convert, btrfsck, ...)
    
    For reason 2:
      Scrub is trying to do a "bypass" in this case, but the result is
      "panic", because current code lacks of some condition in bypass,
      and let some wrong leaf data escaped.
    
    This patch fixed above scrub code.
    
    Before patch:
      # btrfs scrub start -B /dev/vdh
      (panic)
    
    After patch:
      # btrfs scrub start -B /dev/vdh
      scrub done for 353cec8f-da31-4a94-aa35-be72d997b06e
      ...
      # dmesg
      ...
      [   59.088697] BTRFS error (device vdh): scrub: tree block 27054080 spanning stripes, ignored. logical=27000832
      [   59.089929] BTRFS error (device vdh): scrub: tree block 27054080 spanning stripes, ignored. logical=27066368
      #
    Reported-by: NChris Murphy <lists@colorremedies.com>
    Signed-off-by: NZhao Lei <zhaolei@cn.fujitsu.com>
    Signed-off-by: NChris Mason <clm@fb.com>
    a323e813
scrub.c 111.1 KB