• G
    irqchip/qcom: Use struct_size() in devm_kzalloc() · b744c3bc
    Gustavo A. R. Silva 提交于
    One of the more common cases of allocation size calculations is finding
    the size of a structure that has a zero-sized array at the end, along
    with memory for some number of elements for that array. For example:
    
    struct foo {
        int stuff;
        struct boo entry[];
    };
    
    size = sizeof(struct foo) + count * sizeof(struct boo);
    instance = devm_kzalloc(dev, size, GFP_KERNEL);
    
    Instead of leaving these open-coded and prone to type mistakes, we can
    now use the new struct_size() helper:
    
    instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);
    
    Notice that, in this case, variable alloc_sz is not necessary, hence it
    is removed.
    
    This code was detected with the help of Coccinelle.
    Signed-off-by: NGustavo A. R. Silva <gustavo@embeddedor.com>
    Signed-off-by: NMarc Zyngier <marc.zyngier@arm.com>
    b744c3bc
qcom-irq-combiner.c 7.4 KB