• S
    KVM: x86: Fix implicit enum conversion goof in scattered reverse CPUID code · 90772c12
    Sean Christopherson 提交于
    mainline inclusion
    from mainline-5.13
    commit 462f8dde
    category: feature
    bugzilla: https://gitee.com/openeuler/intel-kernel/issues/I5EZEK
    CVE: NA
    
    Intel-SIG: commit 462f8dde KVM: x86: Fix implicit enum conversion
    goof in scattered reverse CPUID code.
    Backport for SGX virtualization support
    
    --------------------------------
    
    Take "enum kvm_only_cpuid_leafs" in scattered specific CPUID helpers
    (which is obvious in hindsight), and use "unsigned int" for leafs that
    can be the kernel's standard "enum cpuid_leaf" or the aforementioned
    KVM-only variant.  Loss of the enum params is a bit disapponting, but
    gcc obviously isn't providing any extra sanity checks, and the various
    BUILD_BUG_ON() assertions ensure the input is in range.
    
    This fixes implicit enum conversions that are detected by clang-11:
    
    arch/x86/kvm/cpuid.c:499:29: warning: implicit conversion from enumeration type 'enum kvm_only_cpuid_leafs' to different enumeration type 'enum cpuid_leafs' [-Wenum-conversion]
            kvm_cpu_cap_init_scattered(CPUID_12_EAX,
            ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~
    arch/x86/kvm/cpuid.c:837:31: warning: implicit conversion from enumeration type 'enum kvm_only_cpuid_leafs' to different enumeration type 'enum cpuid_leafs' [-Wenum-conversion]
                    cpuid_entry_override(entry, CPUID_12_EAX);
                    ~~~~~~~~~~~~~~~~~~~~        ^~~~~~~~~~~~
    2 warnings generated.
    
    Fixes: 4e66c0cb ("KVM: x86: Add support for reverse CPUID lookup of scattered features")
    Cc: Kai Huang <kai.huang@intel.com>
    Signed-off-by: NSean Christopherson <seanjc@google.com>
    Message-Id: <20210421010850.3009718-1-seanjc@google.com>
    Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: NZhiquan Li <zhiquan1.li@intel.com>
    90772c12
cpuid.h 10.5 KB