• G
    net: hns3: ignore reset event before initialization process is done · 8cc95319
    Guangbin Huang 提交于
    mainline inclusion
    from mainline-v5.15
    commit 0251d196
    category: feature
    bugzilla: https://gitee.com/openeuler/kernel/issues/I4I7P7
    CVE: NA
    
    Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0251d196b0e1
    
    ----------------------------------------------------------------------
    
    Currently, if there is a reset event triggered by RAS during device in
    initialization process, driver may run reset process concurrently with
    initialization process. In this case, it may cause problem. For example,
    the RSS indirection table may has not been alloc memory in initialization
    process yet, but it is used in reset process, it will cause a call trace
    like this:
    
    [61228.744836] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000
    ...
    [61228.897677] Workqueue: hclgevf hclgevf_service_task [hclgevf]
    [61228.911390] pstate: 40400009 (nZcv daif +PAN -UAO -TCO BTYPE=--)
    [61228.918670] pc : hclgevf_set_rss_indir_table+0xb4/0x190 [hclgevf]
    [61228.927812] lr : hclgevf_set_rss_indir_table+0x90/0x190 [hclgevf]
    [61228.937248] sp : ffff8000162ebb50
    [61228.941087] x29: ffff8000162ebb50 x28: ffffb77add72dbc0 x27: ffff0820c7dc8080
    [61228.949516] x26: 0000000000000000 x25: ffff0820ad4fc880 x24: ffff0820c7dc8080
    [61228.958220] x23: ffff0820c7dc8090 x22: 00000000ffffffff x21: 0000000000000040
    [61228.966360] x20: ffffb77add72b9c0 x19: 0000000000000000 x18: 0000000000000030
    [61228.974646] x17: 0000000000000000 x16: ffffb77ae713feb0 x15: ffff0820ad4fcce8
    [61228.982808] x14: ffffffffffffffff x13: ffff8000962eb7f7 x12: 00003834ec70c960
    [61228.991990] x11: 00e0fafa8c206982 x10: 9670facc78a8f9a8 x9 : ffffb77add717530
    [61229.001123] x8 : ffff0820ad4fd6b8 x7 : 0000000000000000 x6 : 0000000000000011
    [61229.010249] x5 : 00000000000cb1b0 x4 : 0000000000002adb x3 : 0000000000000049
    [61229.018662] x2 : ffff8000162ebbb8 x1 : 0000000000000000 x0 : 0000000000000480
    [61229.027002] Call trace:
    [61229.030177]  hclgevf_set_rss_indir_table+0xb4/0x190 [hclgevf]
    [61229.039009]  hclgevf_rss_init_hw+0x128/0x1b4 [hclgevf]
    [61229.046809]  hclgevf_reset_rebuild+0x17c/0x69c [hclgevf]
    [61229.053862]  hclgevf_reset_service_task+0x4cc/0xa80 [hclgevf]
    [61229.061306]  hclgevf_service_task+0x6c/0x630 [hclgevf]
    [61229.068491]  process_one_work+0x1dc/0x48c
    [61229.074121]  worker_thread+0x15c/0x464
    [61229.078562]  kthread+0x168/0x16c
    [61229.082873]  ret_from_fork+0x10/0x18
    [61229.088221] Code: 7900e7f6 f904a683 d503201f 9101a3e2 (38616b43)
    [61229.095357] ---[ end trace 153661a538f6768c ]---
    
    To fix this problem, don't schedule reset task before initialization
    process is done.
    Signed-off-by: NGuangbin Huang <huangguangbin2@huawei.com>
    Signed-off-by: NDavid S. Miller <davem@davemloft.net>
    Reviewed-by: NYongxin Li <liyongxin1@huawei.com>
    Signed-off-by: NJunxin Chen <chenjunxin1@huawei.com>
    Signed-off-by: NZheng Zengkai <zhengzengkai@huawei.com>
    8cc95319
hclgevf_main.c 104.6 KB