• A
    perf top: Fix counter name fixup when fallbacking to cpu-clock · 895d9766
    Arnaldo Carvalho de Melo 提交于
    In 40491eaa "perf top: Update event name when falling back to cpu-clock"
    we freed counter->name but didn't reset it to NULL, then when setting it
    to the result of event_name(), event_name() would use the cached value,
    which by now was overwritten and thus we got garbage or a zero lenght
    string.
    
    Fix it by just freeing and setting counter->name to NULL, this way
    event_name() when called afterwards, will find the right counter name
    and cache it again.
    
    Found while trying 'cycles:pp' on a machine were :pp couldn't be
    honoured. Probably the best fallback here is to tell the user that that
    level of precision is not available on the PMU and then go removing 'p',
    levels of precision till we get to play 'cycles' and if even that fails,
    _then_ get to 'cpu-clock'.
    
    But that is the matter for another patch, this one just needs to fix the
    caching issue, which in the end will show 'cpu-clock' when tools ask for
    the event name being used, which clarifies things for the user, that
    will see that 'cycles:pp' or whatever not support event is not being
    used, some sort of fallback happened.
    
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Namhyung Kim <namhyung@gmail.com>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/n/tip-w1neie2dqli89we1bzwkf4id@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
    895d9766
builtin-top.c 34.3 KB