• B
    xfs: fix log recovery op header validation assert · 848ccfc8
    Brian Foster 提交于
    Commit 89cebc84 ("xfs: validate transaction header length on log
    recovery") added additional validation of the on-disk op header length
    to protect from buffer overflow during log recovery. It accounts for the
    fact that the transaction header can be split across multiple op
    headers. It added an assert for when this occurs that verifies the
    length of the second part of a split transaction header is less than a
    full transaction header. In other words, it expects that the first op
    header of a split transaction header includes at least some portion of
    the transaction header.
    
    This expectation is not always valid as a zero-length op header can
    exist for the first op header of a split transaction header (see
    xlog_recover_add_to_trans() for details). This means that the second op
    header can have a valid, full length transaction header and thus the
    full header is copied in xlog_recover_add_to_cont_trans(). Fix the
    assert in xlog_recover_add_to_cont_trans() to handle this case correctly
    and require that the op header length is less than or equal to a full
    transaction header.
    Signed-off-by: NBrian Foster <bfoster@redhat.com>
    Reviewed-by: NDave Chinner <dchinner@redhat.com>
    Signed-off-by: NDave Chinner <david@fromorbit.com>
    
    848ccfc8
xfs_log_recover.c 131.5 KB