• L
    mmu_gather: fix the CONFIG_MMU_GATHER_NO_RANGE case · 7fb5e508
    Linus Torvalds 提交于
    Sudip reports that alpha doesn't build properly, with errors like
    
      include/asm-generic/tlb.h:401:1: error: redefinition of 'tlb_update_vma_flags'
        401 | tlb_update_vma_flags(struct mmu_gather *tlb, struct vm_area_struct *vma)
            | ^~~~~~~~~~~~~~~~~~~~
      include/asm-generic/tlb.h:372:1: note: previous definition of 'tlb_update_vma_flags' with type 'void(struct mmu_gather *, struct vm_area_struct *)'
        372 | tlb_update_vma_flags(struct mmu_gather *tlb, struct vm_area_struct *vma) { }
    
    the cause being that We have this odd situation where some architectures
    were never converted to the newer TLB flushing interfaces that have a
    range for the flush.  Instead people left them alone, and we have them
    select the MMU_GATHER_NO_RANGE config option to make the tlb header
    files account for this.
    
    Peter Zijlstra cleaned some of these nasty header file games up in
    commits
    
      1e9fdf21 ("mmu_gather: Remove per arch tlb_{start,end}_vma()")
      18ba064e ("mmu_gather: Let there be one tlb_{start,end}_vma() implementation")
    
    but tlb_update_vma_flags() was left alone, and then commit b67fbebd
    ("mmu_gather: Force tlb-flush VM_PFNMAP vmas") ended up removing only
    _one_ of the two stale duplicate dummy inline functions.
    
    This removes the other stale one.
    
    Somebody braver than me should try to remove MMU_GATHER_NO_RANGE
    entirely, but it requires fixing up the oddball architectures that use
    it: alpha, m68k, microblaze, nios2 and openrisc.
    
    The fixups should be fairly straightforward ("fix the build errors it
    exposes by adding the appropriate range arguments"), but the reason this
    wasn't done in the first place is that so few people end up working on
    those architectures.  But it could be done one architecture at a time,
    hint, hint.
    Reported-by: NSudip Mukherjee (Codethink) <sudipm.mukherjee@gmail.com>
    Fixes: b67fbebd ("mmu_gather: Force tlb-flush VM_PFNMAP vmas")
    Link: https://lore.kernel.org/all/YtpXh0QHWwaEWVAY@debian/
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Will Deacon <will@kernel.org>
    Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Nick Piggin <npiggin@gmail.com>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
    7fb5e508
tlb.h 19.3 KB