• S
    drivers/video/i810/i810-i2c.c: fix i2c bus handling · 748103e7
    Stefani Seibold 提交于
    These patch fix a longstanding bug in the i810 frame buffer driver.
    
    The handling of the i2c bus is wrong: A 1 bit should not written to the
    i2c, these will be done by switch the i2c to input. Driving an 1 bit
    active is against the i2c spec.
    
    An active driven of a 1 bit will result in very strange error, depending
    which side is the more powerful one. In my case it depends on the
    temperature of the Display-Controller-EEprom: With an cold eprom a got
    the correct EDID datas, with a warm one some of the 1 bits was 0 :-(
    
    The same bug is also in the intelfb driver in the file
    drivers/video/intelfb/intelfb_i2c.c. The functions intelfb_gpio_setscl()
    and intelfb_gpio_setsda() do drive the 1 bit active to the i2c bus. But
    since i have no card which is used by the intelfb driver i cannot fix
    it.
    Signed-off-by: NStefani Seibold <stefani@seibold.net>
    Cc: Paul Mundt <lethal@linux-sh.org>
    Cc: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: NPaul Mundt <lethal@linux-sh.org>
    748103e7
i810-i2c.c 5.0 KB