• P
    PCI: aardvark: Don't touch PCIe registers if no card connected · 70e38025
    Pali Rohár 提交于
    When there is no PCIe card connected and advk_pcie_rd_conf() or
    advk_pcie_wr_conf() is called for PCI bus which doesn't belong to emulated
    root bridge, the aardvark driver throws the following error message:
    
      advk-pcie d0070000.pcie: config read/write timed out
    
    Obviously accessing PCIe registers of disconnected card is not possible.
    
    Extend check in advk_pcie_valid_device() function for validating
    availability of PCIe bus. If PCIe link is down, then the device is marked
    as Not Found and the driver does not try to access these registers.
    
    This is just an optimization to prevent accessing PCIe registers when card
    is disconnected. Trying to access PCIe registers of disconnected card does
    not cause any crash, kernel just needs to wait for a timeout. So if card
    disappear immediately after checking for PCIe link (before accessing PCIe
    registers), it does not cause any problems.
    
    Link: https://lore.kernel.org/r/20200702083036.12230-1-pali@kernel.orgSigned-off-by: NPali Rohár <pali@kernel.org>
    Signed-off-by: NLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    70e38025
pci-aardvark.c 32.5 KB