• S
    libceph: fix osd request queuing on osdmap updates · 6f6c7006
    Sage Weil 提交于
    If we send a request to osd A, and the request's pg remaps to osd B and
    then back to A in quick succession, we need to resend the request to A. The
    old code was only calling kick_requests after processing all incremental
    maps in a message, so it was very possible to not resend a request that
    needed to be resent.  This would make the osd eventually time out (at least
    with the current default of osd timeouts enabled).
    
    The correct approach is to scan requests on every map incremental.  This
    patch refactors the kick code in a few ways:
     - all requests are either on req_lru (in flight), req_unsent (ready to
       send), or req_notarget (currently map to no up osd)
     - mapping always done by map_request (previous map_osds)
     - if the mapping changes, we requeue.  requests are resent only after all
       map incrementals are processed.
     - some osd reset code is moved out of kick_requests into a separate
       function
     - the "kick this osd" functionality is moved to kick_osd_requests, as it
       is unrelated to scanning for request->pg->osd mapping changes
    Signed-off-by: NSage Weil <sage@newdream.net>
    6f6c7006
osd_client.c 45.0 KB