• L
    net:tipc: Fix a double free in tipc_sk_mcast_rcv · 6bf24dc0
    Lv Yunlong 提交于
    In the if(skb_peek(arrvq) == skb) branch, it calls __skb_dequeue(arrvq) to get
    the skb by skb = skb_peek(arrvq). Then __skb_dequeue() unlinks the skb from arrvq
    and returns the skb which equals to skb_peek(arrvq). After __skb_dequeue(arrvq)
    finished, the skb is freed by kfree_skb(__skb_dequeue(arrvq)) in the first time.
    
    Unfortunately, the same skb is freed in the second time by kfree_skb(skb) after
    the branch completed.
    
    My patch removes kfree_skb() in the if(skb_peek(arrvq) == skb) branch, because
    this skb will be freed by kfree_skb(skb) finally.
    
    Fixes: cb1b7280 ("tipc: eliminate race condition at multicast reception")
    Signed-off-by: NLv Yunlong <lyl2019@mail.ustc.edu.cn>
    Signed-off-by: NDavid S. Miller <davem@davemloft.net>
    6bf24dc0
socket.c 104.3 KB