• D
    KVM: x86/mmu: Rename slot_handle_leaf to slot_handle_level_4k · 610265ea
    David Matlack 提交于
    slot_handle_leaf is a misnomer because it only operates on 4K SPTEs
    whereas "leaf" is used to describe any valid terminal SPTE (4K or
    large page). Rename slot_handle_leaf to slot_handle_level_4k to
    avoid confusion.
    
    Making this change makes it more obvious there is a benign discrepency
    between the legacy MMU and the TDP MMU when it comes to dirty logging.
    The legacy MMU only iterates through 4K SPTEs when zapping for
    collapsing and when clearing D-bits. The TDP MMU, on the other hand,
    iterates through SPTEs on all levels.
    
    The TDP MMU behavior of zapping SPTEs at all levels is technically
    overkill for its current dirty logging implementation, which always
    demotes to 4k SPTES, but both the TDP MMU and legacy MMU zap if and only
    if the SPTE can be replaced by a larger page, i.e. will not spuriously
    zap 2m (or larger) SPTEs. Opportunistically add comments to explain this
    discrepency in the code.
    Signed-off-by: NDavid Matlack <dmatlack@google.com>
    Message-Id: <20211019162223.3935109-1-dmatlack@google.com>
    Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
    610265ea
mmu.c 166.3 KB