• J
    [media] DVB: dvb_net_init: return -errno on error · 58fae673
    Jonathan Nieder 提交于
    dvb_net_init unconditionally returns 0.  Callers such as
    videobuf_dvb_register_frontend examine dvbnet->dvbdev instead of the
    return value to tell whether the operation succeeded.  If it has been
    set to a valid pointer, success; if it was left equal to NULL,
    failure.
    
    Alas, there is an edge case where that logic does not work as well:
    when network support has been compiled out (CONFIG_DVB_NET=n), we want
    dvb_net_init and related operations to behave as no-ops and always
    succeed, but there is no appropriate value to which to set dvb->dvbdev
    to indicate this.
    
    Let dvb_net_init return a meaningful error code, as preparation for
    adapting callers to look at that instead.
    
    The only immediate impact of this patch should be to make the few
    callers that already check for an error code from dvb_net_init behave
    a little more sensibly when it fails.
    Signed-off-by: NJonathan Nieder <jrnieder@gmail.com>
    Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
    58fae673
dvb_net.c 41.9 KB