• A
    eeepc-laptop: fix value of pwm1_enable to match documentation · 48718688
    Alan Jenkins 提交于
    Documentation/hwmon/sysfs-interface tells us that automatic fan speed
    control should be represented by a value of 2 or above for pwm1_enable.
    Fix eeepc_get_fan_ctrl() to return 2 for automatic fan control.
    
    Setting "1" for manual control is already consistent with the
    documentation, so this remains unchanged.
    
    Let's preserve the ABI for this specific driver, so that writing "0"
    will still invoke automatic control.
    
    (The documentation says setting "0" should leave the fan at full speed
    all the time.  This mode is not directly supported by our hardware. Full
    speed is rather noisy on my 701 and the automatic control has never used
    it.  If you really want this e.g. to prolong the life of an EeePC used
    as a server, you can always use manual mode.  hwmon has always been
    fairly machine-specific, and you're in a tiny minority (or elite :-).
    I'm sure you're smart enough to notice that the fan doesn't turn on to
    full speed when you try this mode, either by ear or checking
    fan_input1.
    
    We could even claim to be honouring the spirit of the documentation.
    "0" really means "safe mode".  EeePCs default to automatic mode, ie that
    is what Asus will actually test.  Since we do not provide any way to
    tamper with the temperature threshold, automatic mode _is_ the safe
    option).
    Signed-off-by: NAlan Jenkins <alan-jenkins@tuffmail.co.uk>
    Signed-off-by: NLen Brown <len.brown@intel.com>
    48718688
eeepc-laptop.c 31.3 KB