• J
    tty: make linux/tty_flip.h self-contained · 48344460
    Jiri Slaby 提交于
    If someone includes linux/tty_flip.h before linux/tty.h, they see
    many compiler errors like:
     include/linux/tty_flip.h:23:30: error: invalid use of undefined type 'struct tty_port'
     include/linux/tty_flip.h:26:14: error: invalid use of undefined type 'struct tty_buffer'
    
    tty_flip.h actually lexicographically sorts before tty.h. So if people
    sort includes (as I tried in amiserial), the compilation suddenly
    breaks.
    
    Solve this by including linux/tty.h from linux/tty_flip.h, so that
    everything is defined as needed.
    
    Another alternative would be to uninline tty_insert_flip_char and just
    insert forward declarations of tty_port and tty_buffer structs into
    tty_flip.h as that inline is the only real user. But that would mean
    slowing down the fast path without any good reason. (Provided the fix
    is that easy and there were no real problems with this until now.)
    Signed-off-by: NJiri Slaby <jslaby@suse.cz>
    Link: https://lore.kernel.org/r/20210625073511.4514-1-jslaby@suse.czSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    48344460
tty_flip.h 1.6 KB