• G
    dccp: Remove manual influence on NDP Count feature · 4098dce5
    Gerrit Renker 提交于
    Updating the NDP count feature is handled automatically now:
     * for CCID-2 it is disabled, since the code does not use NDP counts;
     * for CCID-3 it is enabled, as NDP counts are used to determine loss lengths.
    
    Allowing the user to change NDP values leads to unpredictable and failing
    behaviour, since it is then possible to disable NDP counts even when they
    are needed (e.g. in CCID-3).
    
    This means that only those user settings are sensible that agree with the
    values for Send NDP Count implied by the choice of CCID. But those settings
    are already activated by the feature negotiation (CCID dependency tracking),
    hence this form of support is redundant.
    
    At startup the initialisation of the NDP count feature uses the default
    value of 0, which is done implicitly by the zeroing-out of the socket when
    it is allocated. If the choice of CCID or feature negotiation enables NDP
    count, this will then be updated via the NDP activation handler.
    Signed-off-by: NGerrit Renker <gerrit@erg.abdn.ac.uk>
    Acked-by: NIan McDonald <ian.mcdonald@jandi.co.nz>
    Signed-off-by: NDavid S. Miller <davem@davemloft.net>
    4098dce5
feat.c 37.4 KB