• X
    batman-adv: Fix refcnt leak in batadv_v_ogm_process · 6f91a3f7
    Xiyu Yang 提交于
    batadv_v_ogm_process() invokes batadv_hardif_neigh_get(), which returns
    a reference of the neighbor object to "hardif_neigh" with increased
    refcount.
    
    When batadv_v_ogm_process() returns, "hardif_neigh" becomes invalid, so
    the refcount should be decreased to keep refcount balanced.
    
    The reference counting issue happens in one exception handling paths of
    batadv_v_ogm_process(). When batadv_v_ogm_orig_get() fails to get the
    orig node and returns NULL, the refcnt increased by
    batadv_hardif_neigh_get() is not decreased, causing a refcnt leak.
    
    Fix this issue by jumping to "out" label when batadv_v_ogm_orig_get()
    fails to get the orig node.
    
    Fixes: 9323158e ("batman-adv: OGMv2 - implement originators logic")
    Signed-off-by: NXiyu Yang <xiyuyang19@fudan.edu.cn>
    Signed-off-by: NXin Tan <tanxin.ctf@gmail.com>
    Signed-off-by: NSven Eckelmann <sven@narfation.org>
    Signed-off-by: NSimon Wunderlich <sw@simonwunderlich.de>
    6f91a3f7
bat_v_ogm.c 32.7 KB