• L
    ACPI / EC: Remove non-root-caused busy polling quirks. · 3174abcf
    Lv Zheng 提交于
    { Update to correct 1 patch subject in the description }
    
    We have fixed a lot of race issues in the EC driver recently.
    
    The following commit introduces MSI udelay()/msleep() quirk to MSI laptops
    to make EC firmware working for bug 12011 without root causing any EC
    driver race issues:
      Commit: 5423a0cb
      Subject: ACPI: EC: Add delay for slow MSI controller
      Commit: 34ff4dbc
      Subject: ACPI: EC: Separate delays for MSI hardware
    
    The following commit extends ECDT validation quirk to MSI laptops to make
    EC driver locating EC registers properly for bug 12461:
      Commit: a5032bfd
      Subject: ACPI: EC: Always parse EC device
    This is a different quirk than the MSI udelay()/msleep() quirk. This patch
    keeps validating ECDT for only "Micro-Star MS-171F" as reported.
    
    The following commit extends MSI udelay()/msleep() quirk to Quanta laptops
    to make EC firmware working for bug 20242, there is no requirement to
    validate ECDT for Quanta laptops:
      Commit: 534bc4e3 Mon Sep 17 00:00:00 2001
      Subject: ACPI EC: enable MSI workaround for Quanta laptops
    
    The following commit extends MSI udelay()/msleep() quirk to Clevo laptops
    to make EC firmware working for bug 77431, there is no requirement to
    validate ECDT for Clevo laptops:
      Commit: 777cb382
      Subject: ACPI / EC: Add msi quirk for Clevo W350etq
    
    All udelay()/msleep() quirks for MSI/Quanta/Clevo seem to be the wrong
    fixes generated without fixing the EC driver race issues.
    And even if it is not wrong, the guarding can be covered by the following
    commits in wait polling mode:
      Commit: 9e295ac1
      Subject: ACPI / EC: Reduce ec_poll() by referencing the last register access timestamp.
      Commit: commit in the same series
      Subject: ACPI / EC: Fix and clean up register access guarding logics.
    The only case that is not covered is the inter-transaction guarding. And
    there is no evidence that we need the inter-transaction guarding upon
    reading the noted bug entries.
    
    So it is time to remove the quirks and let the users to try again. If there
    is a regression, the only thing we need to do is to restore the
    inter-transaction guarding for the reported platforms.
    
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=12011
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=12461
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=20242
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=77431Signed-off-by: NLv Zheng <lv.zheng@intel.com>
    Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
    3174abcf
ec.c 37.9 KB