• J
    ceph: have ceph_writepages_start call pagevec_lookup_range_tag · 2e169296
    Jeff Layton 提交于
    Currently it calls pagevec_lookup_range_nr_tag(), but that may be
    inefficient, as we might end up having to search several times as we get
    down to looking for fewer pages to fill the array.
    
    Thus spake Willy:
    
    "I think ceph is misusing pagevec_lookup_range_nr_tag().  Let's suppose
     you get a range which is AAAAbbbbAAAAbbbbAAAAbbbbbbbb(...)bbbbAAAA and
     you try to fetch max_pages=13.  First loop will get AAAAbbbbAAAAb and
     have 8 locked_pages.  The next call will get bbbAA and now
     locked_pages=10.  Next call gets AAb ... and now you're iterating your
     way through all the 'b' one page at a time until you find that first A."
    
    'A' here refers to pages that are eligible for writeback and 'b'
    represents ones that aren't (for whatever reason).
    
    Not capping the number of return pages may mean that we sometimes find
    more pages than are needed, but the extra references will just get put
    at the end.
    
    Ceph is also the only caller of pagevec_lookup_range_nr_tag(), so this
    change should allow us to eliminate that call as well. That will be done
    in a follow-on patch.
    Reported-by: NMatthew Wilcox <willy@infradead.org>
    Signed-off-by: NJeff Layton <jlayton@kernel.org>
    Reviewed-by: NMatthew Wilcox <willy@infradead.org>
    Signed-off-by: NIlya Dryomov <idryomov@gmail.com>
    2e169296
addr.c 56.2 KB