• S
    block: Limit number of items taken from the I/O scheduler in one go · 28d65729
    Salman Qazi 提交于
    Flushes bypass the I/O scheduler and get added to hctx->dispatch
    in blk_mq_sched_bypass_insert.  This can happen while a kworker is running
    hctx->run_work work item and is past the point in
    blk_mq_sched_dispatch_requests where hctx->dispatch is checked.
    
    The blk_mq_do_dispatch_sched call is not guaranteed to end in bounded time,
    because the I/O scheduler can feed an arbitrary number of commands.
    
    Since we have only one hctx->run_work, the commands waiting in
    hctx->dispatch will wait an arbitrary length of time for run_work to be
    rerun.
    
    A similar phenomenon exists with dispatches from the software queue.
    
    The solution is to poll hctx->dispatch in blk_mq_do_dispatch_sched and
    blk_mq_do_dispatch_ctx and return from the run_work handler and let it
    rerun.
    Signed-off-by: NSalman Qazi <sqazi@google.com>
    Reviewed-by: NMing Lei <ming.lei@redhat.com>
    Signed-off-by: NJens Axboe <axboe@kernel.dk>
    28d65729
blk-mq-sched.c 17.3 KB