• A
    USB: EHCI: bugfix: urb->hcpriv should not be NULL · 2656a9ab
    Alan Stern 提交于
    This patch (as1632b) fixes a bug in ehci-hcd.  The USB core uses
    urb->hcpriv to determine whether or not an URB is active; host
    controller drivers are supposed to set this pointer to a non-NULL
    value when an URB is queued.  However ehci-hcd sets it to NULL for
    isochronous URBs, which defeats the check in usbcore.
    
    In itself this isn't a big deal.  But people have recently found that
    certain sequences of actions will cause the snd-usb-audio driver to
    reuse URBs without waiting for them to complete.  In the absence of
    proper checking by usbcore, the URBs get added to their endpoint list
    twice.  This leads to list corruption and a system freeze.
    
    The patch makes ehci-hcd assign a meaningful value to urb->hcpriv for
    isochronous URBs.  Improving robustness always helps.
    Signed-off-by: NAlan Stern <stern@rowland.harvard.edu>
    Reported-by: NArtem S. Tashkinov <t.artem@lycos.com>
    Reported-by: NChristof Meerwald <cmeerw@cmeerw.org>
    CC: <stable@vger.kernel.org>
    Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    2656a9ab
ehci-q.c 37.5 KB