• A
    perf config: Fix caching and memory leak in perf_home_perfconfig() · 261f4911
    Arnaldo Carvalho de Melo 提交于
    Acaict, perf_home_perfconfig() is supposed to cache the result of
    home_perfconfig, which returns the default location of perfconfig for
    the user, given the HOME environment variable.
    
    However, the current implementation calls home_perfconfig every time
    perf_home_perfconfig() is called (so no caching is actually performed),
    replacing the previous pointer, thus also causing a memory leak.
    
    This patch adds a check of whether either config or failed is set and,
    in that case, directly returns config without calling home_perfconfig at
    each invocation.
    
    Fixes: f5f03e19 ("perf config: Add perf_home_perfconfig function")
    Signed-off-by: NRiccardo Mancini <rickyman7@gmail.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Jin Yao <yao.jin@linux.intel.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Song Liu <song@kernel.org>
    Link: http://lore.kernel.org/lkml/20210820130817.740536-1-rickyman7@gmail.com
    [ Removed needless double check for the 'failed' variable ]
    Signed-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
    261f4911
config.c 18.2 KB