• F
    net: dsa: Properly propagate errors from dsa_switch_setup_one · 24595346
    Florian Fainelli 提交于
    While shuffling some code around, dsa_switch_setup_one() was introduced,
    and it was modified to return either an error code using ERR_PTR() or a
    NULL pointer when running out of memory or failing to setup a switch.
    
    This is a problem for its caler: dsa_switch_setup() which uses IS_ERR()
    and expects to find an error code, not a NULL pointer, so we still try
    to proceed with dsa_switch_setup() and operate on invalid memory
    addresses. This can be easily reproduced by having e.g: the bcm_sf2
    driver built-in, but having no such switch, such that drv->setup will
    fail.
    
    Fix this by using PTR_ERR() consistently which is both more informative
    and avoids for the caller to use IS_ERR_OR_NULL().
    
    Fixes: df197195 ("net: dsa: split dsa_switch_setup into two functions")
    Reported-by: NAndrew Lunn <andrew@lunn.ch>
    Signed-off-by: NFlorian Fainelli <f.fainelli@gmail.com>
    Tested-by: NAndrew Lunn <andrew@lunn.ch>
    Signed-off-by: NDavid S. Miller <davem@davemloft.net>
    24595346
dsa.c 19.8 KB