• C
    cifs: truncate fallout · 1b947463
    Christoph Hellwig 提交于
    Remove the calls to inode_newsize_ok given that we already did it as
    part of inode_change_ok in the beginning of cifs_setattr_(no)unix.
    
    No need to call ->truncate if cifs doesn't have one, so remove the
    explicit call in cifs_vmtruncate, and replace the calls to vmtruncate
    with truncate_setsize which is vmtruncate minus inode_newsize_ok
    and the call to ->truncate.
    
    Rename cifs_vmtruncate to cifs_setsize to match the new calling conventions.
    
    Question 1:  why does cifs do the pagecache munging and i_size update twice
    	for each setattr call, once opencoded in cifs_vmtruncate, and once
    	using the VFS helpers?
    Question 2: what is supposed to be protected by i_lock in cifs_vmtruncate?
    	Do we need it around the call to inode_change_ok?
    
    [AV: fixed build breakage]
    Signed-off-by: NChristoph Hellwig <hch@lst.de>
    Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>
    1b947463
inode.c 54.7 KB