• J
    RDMA/hns: Work around broken constant propagation in gcc 8 · 14351f08
    Jason Gunthorpe 提交于
    gcc 8.3 and 5.4 throw this:
    
    In function 'modify_qp_init_to_rtr',
    ././include/linux/compiler_types.h:322:38: error: call to '__compiletime_assert_1859' declared with attribute error: FIELD_PREP: value too large for the field
      _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
    [..]
    drivers/infiniband/hw/hns/hns_roce_common.h:91:52: note: in expansion of macro 'FIELD_PREP'
       *((__le32 *)ptr + (field_h) / 32) |= cpu_to_le32(FIELD_PREP(   \
                                                        ^~~~~~~~~~
    drivers/infiniband/hw/hns/hns_roce_common.h:95:39: note: in expansion of macro '_hr_reg_write'
     #define hr_reg_write(ptr, field, val) _hr_reg_write(ptr, field, val)
                                           ^~~~~~~~~~~~~
    drivers/infiniband/hw/hns/hns_roce_hw_v2.c:4412:2: note: in expansion of macro 'hr_reg_write'
      hr_reg_write(context, QPC_LP_PKTN_INI, lp_pktn_ini);
    
    Because gcc has miscalculated the constantness of lp_pktn_ini:
    
    	mtu = ib_mtu_enum_to_int(ib_mtu);
    	if (WARN_ON(mtu < 0)) [..]
    	lp_pktn_ini = ilog2(MAX_LP_MSG_LEN / mtu);
    
    Since mtu is limited to {256,512,1024,2048,4096} lp_pktn_ini is between 4
    and 8 which is compatible with the 4 bit field in the FIELD_PREP.
    
    Work around this broken compiler by adding a 'can never be true'
    constraint on lp_pktn_ini's value which clears out the problem.
    
    Fixes: f0cb411a ("RDMA/hns: Use new interface to modify QP context")
    Link: https://lore.kernel.org/r/0-v1-c773ecb137bc+11f-hns_gcc8_jgg@nvidia.comReported-by: NGeert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: NJason Gunthorpe <jgg@nvidia.com>
    14351f08
hns_roce_hw_v2.c 183.6 KB