• C
    printk/panic: Avoid deadlock in printk() · 0cc12581
    Cheng Jian 提交于
    hulk inclusion
    category: bugfix
    bugzilla: 34546, https://gitee.com/openeuler/kernel/issues/I4JKT1
    CVE: NA
    
    -----------------------------------------------
    
    A deadlock caused by logbuf_lock occurs when panic:
    
    	a) Panic CPU is running in non-NMI context
    	b) Panic CPU sends out shutdown IPI via NMI vector
    	c) One of the CPUs that we bring down via NMI vector holded logbuf_lock
    	d) Panic CPU try to hold logbuf_lock, then deadlock occurs.
    
    we try to re-init the logbuf_lock in printk_safe_flush_on_panic()
    to avoid deadlock, but it does not work here, because :
    
    Firstly, it is inappropriate to check num_online_cpus() here.
    When the CPU bring down via NMI vector, the panic CPU willn't
    wait too long for other cores to stop, so when this problem
    occurs, num_online_cpus() may be greater than 1.
    
    Secondly, printk_safe_flush_on_panic() is called after panic
    notifier callback, so if printk() is called in panic notifier
    callback, deadlock will still occurs. Eg, if ftrace_dump_on_oops
    is set, we print some debug information, it will try to hold the
    logbuf_lock.
    
    To avoid this deadlock, attempt to re-init logbuf_lock from panic
    CPU before panic_notifier_list callback,
    Signed-off-by: NCheng Jian <cj.chengjian@huawei.com>
    Reviewed-by: NXie XiuQi <xiexiuqi@huawei.com>
    Signed-off-by: NChen Zhou <chenzhou10@huawei.com>
    Signed-off-by: NCheng Jian <cj.chengjian@huawei.com>
    Reviewed-by: NXie XiuQi <xiexiuqi@huawei.com>
    Signed-off-by: NZheng Zengkai <zhengzengkai@huawei.com>
    0cc12581
printk.h 17.7 KB