• T
    acpi: fix bogus preemption logic · 0a7992c9
    Thomas Gleixner 提交于
    The ACPI_PREEMPTION_POINT() logic was introduced in commit 8bd108d1
    (ACPICA: add preemption point after each opcode parse).  The follow up
    commits abe1dfab, 138d1569, c084ca70 tried to fix the preemption logic
    back and forth, but nobody noticed that the usage of
    in_atomic_preempt_off() in that context is wrong.
    
    The check which guards the call of cond_resched() is:
    
        if (!in_atomic_preempt_off() && !irqs_disabled())
    
    in_atomic_preempt_off() is not intended for general use as the comment
    above the macro definition clearly says:
    
     * Check whether we were atomic before we did preempt_disable():
     * (used by the scheduler, *after* releasing the kernel lock)
    
    On a CONFIG_PREEMPT=n kernel the usage of in_atomic_preempt_off() works by
    accident, but with CONFIG_PREEMPT=y it's just broken.
    
    The whole purpose of the ACPI_PREEMPTION_POINT() is to reduce the latency
    on a CONFIG_PREEMPT=n kernel, so make ACPI_PREEMPTION_POINT() depend on
    CONFIG_PREEMPT=n and remove the in_atomic_preempt_off() check.
    
    Addresses https://bugzilla.kernel.org/show_bug.cgi?id=16210
    
    [akpm@linux-foundation.org: fix build]
    Signed-off-by: NThomas Gleixner <tglx@linutronix.de>
    Cc: Len Brown <lenb@kernel.org>
    Cc: Francois Valenduc <francois.valenduc@tvcablenet.be>
    Cc: Lin Ming <ming.m.lin@intel.com>
    Cc: <stable@kernel.org>
    Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
    0a7992c9
aclinux.h 5.0 KB