• W
    module: Fix link failure due to invalid relocation on namespace offset · 069e1c07
    Will Deacon 提交于
    Commit 8651ec01 ("module: add support for symbol namespaces.")
    broke linking for arm64 defconfig:
    
      | lib/crypto/arc4.o: In function `__ksymtab_arc4_setkey':
      | arc4.c:(___ksymtab+arc4_setkey+0x8): undefined reference to `no symbol'
      | lib/crypto/arc4.o: In function `__ksymtab_arc4_crypt':
      | arc4.c:(___ksymtab+arc4_crypt+0x8): undefined reference to `no symbol'
    
    This is because the dummy initialisation of the 'namespace_offset' field
    in 'struct kernel_symbol' when using EXPORT_SYMBOL on architectures with
    support for PREL32 locations uses an offset from an absolute address (0)
    in an effort to trick 'offset_to_pointer' into behaving as a NOP,
    allowing non-namespaced symbols to be treated in the same way as those
    belonging to a namespace.
    
    Unfortunately, place-relative relocations require a symbol reference
    rather than an absolute value and, although x86 appears to get away with
    this due to placing the kernel text at the top of the address space, it
    almost certainly results in a runtime failure if the kernel is relocated
    dynamically as a result of KASLR.
    
    Rework 'namespace_offset' so that a value of 0, which cannot occur for a
    valid namespaced symbol, indicates that the corresponding symbol does
    not belong to a namespace.
    
    Cc: Matthias Maennich <maennich@google.com>
    Cc: Jessica Yu <jeyu@kernel.org>
    Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
    Cc: Catalin Marinas <catalin.marinas@arm.com>
    Fixes: 8651ec01 ("module: add support for symbol namespaces.")
    Reported-by: Nkbuild test robot <lkp@intel.com>
    Tested-by: NMatthias Maennich <maennich@google.com>
    Tested-by: NArd Biesheuvel <ard.biesheuvel@linaro.org>
    Reviewed-by: NMatthias Maennich <maennich@google.com>
    Acked-by: NArd Biesheuvel <ard.biesheuvel@linaro.org>
    Signed-off-by: NWill Deacon <will@kernel.org>
    Signed-off-by: NJessica Yu <jeyu@kernel.org>
    069e1c07
export.h 7.1 KB