• J
    tty: don't store semi-state into tty drivers · 0524513a
    Jiri Slaby 提交于
    When a tty driver pointer is used as a return value of struct
    console's device() hook, don't store a semi-state into global variable
    which holds the tty driver. It could mean console::device() would return
    a bogus value. This is important esp. after the next patch where we
    switch from alloc_tty_driver to tty_alloc_driver. tty_alloc_driver
    returns ERR_PTR in case of error and that might have unexpected results
    as the code doesn't expect this.
    
    Cc: Geert Uytterhoeven <geert@linux-m68k.org>
    Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
    Cc: Helge Deller <deller@gmx.de>
    Cc: Chris Zankel <chris@zankel.net>
    Cc: Max Filippov <jcmvbkbc@gmail.com>
    Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
    Cc: Felipe Balbi <balbi@kernel.org>
    Reviewed-by: NMax Filippov <jcmvbkbc@gmail.com>
    Acked-by: Helge Deller <deller@gmx.de>	# parisc
    Signed-off-by: NJiri Slaby <jslaby@suse.cz>
    Link: https://lore.kernel.org/r/20210723074317.32690-4-jslaby@suse.czSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    0524513a
console.c 5.0 KB