privcmd.c 15.0 KB
Newer Older
J
Jeremy Fitzhardinge 已提交
1 2 3 4 5 6 7 8
/******************************************************************************
 * privcmd.c
 *
 * Interface to privileged domain-0 commands.
 *
 * Copyright (c) 2002-2004, K A Fraser, B Dragovic
 */

J
Joe Perches 已提交
9 10
#define pr_fmt(fmt) "xen:" KBUILD_MODNAME ": " fmt

J
Jeremy Fitzhardinge 已提交
11
#include <linux/kernel.h>
B
Bastian Blank 已提交
12
#include <linux/module.h>
J
Jeremy Fitzhardinge 已提交
13 14 15 16 17 18 19 20 21 22 23
#include <linux/sched.h>
#include <linux/slab.h>
#include <linux/string.h>
#include <linux/errno.h>
#include <linux/mm.h>
#include <linux/mman.h>
#include <linux/uaccess.h>
#include <linux/swap.h>
#include <linux/highmem.h>
#include <linux/pagemap.h>
#include <linux/seq_file.h>
B
Bastian Blank 已提交
24
#include <linux/miscdevice.h>
J
Jeremy Fitzhardinge 已提交
25 26 27 28 29 30 31 32 33 34 35 36

#include <asm/pgalloc.h>
#include <asm/pgtable.h>
#include <asm/tlb.h>
#include <asm/xen/hypervisor.h>
#include <asm/xen/hypercall.h>

#include <xen/xen.h>
#include <xen/privcmd.h>
#include <xen/interface/xen.h>
#include <xen/features.h>
#include <xen/page.h>
37
#include <xen/xen-ops.h>
38
#include <xen/balloon.h>
39

B
Bastian Blank 已提交
40 41 42 43
#include "privcmd.h"

MODULE_LICENSE("GPL");

44 45
#define PRIV_VMA_LOCKED ((void *)1)

46 47 48 49
static int privcmd_vma_range_is_mapped(
               struct vm_area_struct *vma,
               unsigned long addr,
               unsigned long nr_pages);
J
Jeremy Fitzhardinge 已提交
50 51 52 53 54 55 56 57 58

static long privcmd_ioctl_hypercall(void __user *udata)
{
	struct privcmd_hypercall hypercall;
	long ret;

	if (copy_from_user(&hypercall, udata, sizeof(hypercall)))
		return -EFAULT;

59
	xen_preemptible_hcall_begin();
J
Jeremy Fitzhardinge 已提交
60 61 62 63
	ret = privcmd_call(hypercall.op,
			   hypercall.arg[0], hypercall.arg[1],
			   hypercall.arg[2], hypercall.arg[3],
			   hypercall.arg[4]);
64
	xen_preemptible_hcall_end();
J
Jeremy Fitzhardinge 已提交
65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86

	return ret;
}

static void free_page_list(struct list_head *pages)
{
	struct page *p, *n;

	list_for_each_entry_safe(p, n, pages, lru)
		__free_page(p);

	INIT_LIST_HEAD(pages);
}

/*
 * Given an array of items in userspace, return a list of pages
 * containing the data.  If copying fails, either because of memory
 * allocation failure or a problem reading user memory, return an
 * error code; its up to the caller to dispose of any partial list.
 */
static int gather_array(struct list_head *pagelist,
			unsigned nelem, size_t size,
87
			const void __user *data)
J
Jeremy Fitzhardinge 已提交
88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136
{
	unsigned pageidx;
	void *pagedata;
	int ret;

	if (size > PAGE_SIZE)
		return 0;

	pageidx = PAGE_SIZE;
	pagedata = NULL;	/* quiet, gcc */
	while (nelem--) {
		if (pageidx > PAGE_SIZE-size) {
			struct page *page = alloc_page(GFP_KERNEL);

			ret = -ENOMEM;
			if (page == NULL)
				goto fail;

			pagedata = page_address(page);

			list_add_tail(&page->lru, pagelist);
			pageidx = 0;
		}

		ret = -EFAULT;
		if (copy_from_user(pagedata + pageidx, data, size))
			goto fail;

		data += size;
		pageidx += size;
	}

	ret = 0;

fail:
	return ret;
}

/*
 * Call function "fn" on each element of the array fragmented
 * over a list of pages.
 */
static int traverse_pages(unsigned nelem, size_t size,
			  struct list_head *pos,
			  int (*fn)(void *data, void *state),
			  void *state)
{
	void *pagedata;
	unsigned pageidx;
137
	int ret = 0;
J
Jeremy Fitzhardinge 已提交
138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161

	BUG_ON(size > PAGE_SIZE);

	pageidx = PAGE_SIZE;
	pagedata = NULL;	/* hush, gcc */

	while (nelem--) {
		if (pageidx > PAGE_SIZE-size) {
			struct page *page;
			pos = pos->next;
			page = list_entry(pos, struct page, lru);
			pagedata = page_address(page);
			pageidx = 0;
		}

		ret = (*fn)(pagedata + pageidx, state);
		if (ret)
			break;
		pageidx += size;
	}

	return ret;
}

162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195
/*
 * Similar to traverse_pages, but use each page as a "block" of
 * data to be processed as one unit.
 */
static int traverse_pages_block(unsigned nelem, size_t size,
				struct list_head *pos,
				int (*fn)(void *data, int nr, void *state),
				void *state)
{
	void *pagedata;
	unsigned pageidx;
	int ret = 0;

	BUG_ON(size > PAGE_SIZE);

	pageidx = PAGE_SIZE;

	while (nelem) {
		int nr = (PAGE_SIZE/size);
		struct page *page;
		if (nr > nelem)
			nr = nelem;
		pos = pos->next;
		page = list_entry(pos, struct page, lru);
		pagedata = page_address(page);
		ret = (*fn)(pagedata, nr, state);
		if (ret)
			break;
		nelem -= nr;
	}

	return ret;
}

196
struct mmap_gfn_state {
J
Jeremy Fitzhardinge 已提交
197 198 199 200 201
	unsigned long va;
	struct vm_area_struct *vma;
	domid_t domain;
};

202
static int mmap_gfn_range(void *data, void *state)
J
Jeremy Fitzhardinge 已提交
203 204
{
	struct privcmd_mmap_entry *msg = data;
205
	struct mmap_gfn_state *st = state;
J
Jeremy Fitzhardinge 已提交
206 207 208 209 210 211 212 213 214 215 216 217 218
	struct vm_area_struct *vma = st->vma;
	int rc;

	/* Do not allow range to wrap the address space. */
	if ((msg->npages > (LONG_MAX >> PAGE_SHIFT)) ||
	    ((unsigned long)(msg->npages << PAGE_SHIFT) >= -st->va))
		return -EINVAL;

	/* Range chunks must be contiguous in va space. */
	if ((msg->va != st->va) ||
	    ((msg->va+(msg->npages<<PAGE_SHIFT)) > vma->vm_end))
		return -EINVAL;

219
	rc = xen_remap_domain_gfn_range(vma,
220 221 222
					msg->va & PAGE_MASK,
					msg->mfn, msg->npages,
					vma->vm_page_prot,
223
					st->domain, NULL);
J
Jeremy Fitzhardinge 已提交
224 225 226 227 228 229 230 231 232 233 234 235 236 237 238
	if (rc < 0)
		return rc;

	st->va += msg->npages << PAGE_SHIFT;

	return 0;
}

static long privcmd_ioctl_mmap(void __user *udata)
{
	struct privcmd_mmap mmapcmd;
	struct mm_struct *mm = current->mm;
	struct vm_area_struct *vma;
	int rc;
	LIST_HEAD(pagelist);
239
	struct mmap_gfn_state state;
J
Jeremy Fitzhardinge 已提交
240

241 242 243 244
	/* We only support privcmd_ioctl_mmap_batch for auto translated. */
	if (xen_feature(XENFEAT_auto_translated_physmap))
		return -ENOSYS;

J
Jeremy Fitzhardinge 已提交
245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264
	if (copy_from_user(&mmapcmd, udata, sizeof(mmapcmd)))
		return -EFAULT;

	rc = gather_array(&pagelist,
			  mmapcmd.num, sizeof(struct privcmd_mmap_entry),
			  mmapcmd.entry);

	if (rc || list_empty(&pagelist))
		goto out;

	down_write(&mm->mmap_sem);

	{
		struct page *page = list_first_entry(&pagelist,
						     struct page, lru);
		struct privcmd_mmap_entry *msg = page_address(page);

		vma = find_vma(mm, msg->va);
		rc = -EINVAL;

265
		if (!vma || (msg->va != vma->vm_start) || vma->vm_private_data)
J
Jeremy Fitzhardinge 已提交
266
			goto out_up;
267
		vma->vm_private_data = PRIV_VMA_LOCKED;
J
Jeremy Fitzhardinge 已提交
268 269 270 271 272 273 274 275
	}

	state.va = vma->vm_start;
	state.vma = vma;
	state.domain = mmapcmd.dom;

	rc = traverse_pages(mmapcmd.num, sizeof(struct privcmd_mmap_entry),
			    &pagelist,
276
			    mmap_gfn_range, &state);
J
Jeremy Fitzhardinge 已提交
277 278 279 280 281 282 283 284 285 286 287 288 289 290 291


out_up:
	up_write(&mm->mmap_sem);

out:
	free_page_list(&pagelist);

	return rc;
}

struct mmap_batch_state {
	domid_t domain;
	unsigned long va;
	struct vm_area_struct *vma;
292
	int index;
293 294 295 296 297 298 299
	/* A tristate:
	 *      0 for no errors
	 *      1 if at least one error has happened (and no
	 *          -ENOENT errors have happened)
	 *      -ENOENT if at least 1 -ENOENT has happened.
	 */
	int global_error;
300
	int version;
301

302 303
	/* User-space gfn array to store errors in the second pass for V1. */
	xen_pfn_t __user *user_gfn;
304 305
	/* User-space int array to store errors in the second pass for V2. */
	int __user *user_err;
J
Jeremy Fitzhardinge 已提交
306 307
};

308 309
/* auto translated dom0 note: if domU being created is PV, then gfn is
 * mfn(addr on bus). If it's auto xlated, then gfn is pfn (input to HAP).
310
 */
311
static int mmap_batch_fn(void *data, int nr, void *state)
J
Jeremy Fitzhardinge 已提交
312
{
313
	xen_pfn_t *gfnp = data;
J
Jeremy Fitzhardinge 已提交
314
	struct mmap_batch_state *st = state;
315 316
	struct vm_area_struct *vma = st->vma;
	struct page **pages = vma->vm_private_data;
317
	struct page **cur_pages = NULL;
318 319
	int ret;

320
	if (xen_feature(XENFEAT_auto_translated_physmap))
321
		cur_pages = &pages[st->index];
322

323
	BUG_ON(nr < 0);
324 325
	ret = xen_remap_domain_gfn_array(st->vma, st->va & PAGE_MASK, gfnp, nr,
					 (int *)gfnp, st->vma->vm_page_prot,
326
					 st->domain, cur_pages);
J
Jeremy Fitzhardinge 已提交
327

328 329
	/* Adjust the global_error? */
	if (ret != nr) {
330 331 332 333 334 335 336
		if (ret == -ENOENT)
			st->global_error = -ENOENT;
		else {
			/* Record that at least one error has happened. */
			if (st->global_error == 0)
				st->global_error = 1;
		}
J
Jeremy Fitzhardinge 已提交
337
	}
338 339
	st->va += PAGE_SIZE * nr;
	st->index += nr;
J
Jeremy Fitzhardinge 已提交
340 341 342 343

	return 0;
}

344
static int mmap_return_error(int err, struct mmap_batch_state *st)
J
Jeremy Fitzhardinge 已提交
345
{
346
	int ret;
347

348
	if (st->version == 1) {
349
		if (err) {
350
			xen_pfn_t gfn;
351

352
			ret = get_user(gfn, st->user_gfn);
353 354 355 356
			if (ret < 0)
				return ret;
			/*
			 * V1 encodes the error codes in the 32bit top
357
			 * nibble of the gfn (with its known
358 359
			 * limitations vis-a-vis 64 bit callers).
			 */
360
			gfn |= (err == -ENOENT) ?
361 362
				PRIVCMD_MMAPBATCH_PAGED_ERROR :
				PRIVCMD_MMAPBATCH_MFN_ERROR;
363
			return __put_user(gfn, st->user_gfn++);
364
		} else
365
			st->user_gfn++;
366 367 368 369 370 371 372 373
	} else { /* st->version == 2 */
		if (err)
			return __put_user(err, st->user_err++);
		else
			st->user_err++;
	}

	return 0;
J
Jeremy Fitzhardinge 已提交
374 375
}

376 377 378 379 380 381 382 383 384 385 386 387 388 389 390
static int mmap_return_errors(void *data, int nr, void *state)
{
	struct mmap_batch_state *st = state;
	int *errs = data;
	int i;
	int ret;

	for (i = 0; i < nr; i++) {
		ret = mmap_return_error(errs[i], st);
		if (ret < 0)
			return ret;
	}
	return 0;
}

391
/* Allocate pfns that are then mapped with gfns from foreign domid. Update
392 393 394 395 396 397 398 399 400 401 402 403
 * the vma with the page info to use later.
 * Returns: 0 if success, otherwise -errno
 */
static int alloc_empty_pages(struct vm_area_struct *vma, int numpgs)
{
	int rc;
	struct page **pages;

	pages = kcalloc(numpgs, sizeof(pages[0]), GFP_KERNEL);
	if (pages == NULL)
		return -ENOMEM;

404
	rc = alloc_xenballooned_pages(numpgs, pages);
405 406 407 408 409 410
	if (rc != 0) {
		pr_warn("%s Could not alloc %d pfns rc:%d\n", __func__,
			numpgs, rc);
		kfree(pages);
		return -ENOMEM;
	}
411
	BUG_ON(vma->vm_private_data != NULL);
412 413 414 415 416
	vma->vm_private_data = pages;

	return 0;
}

417
static const struct vm_operations_struct privcmd_vm_ops;
418

419
static long privcmd_ioctl_mmap_batch(void __user *udata, int version)
J
Jeremy Fitzhardinge 已提交
420 421
{
	int ret;
422
	struct privcmd_mmapbatch_v2 m;
J
Jeremy Fitzhardinge 已提交
423 424 425 426 427 428
	struct mm_struct *mm = current->mm;
	struct vm_area_struct *vma;
	unsigned long nr_pages;
	LIST_HEAD(pagelist);
	struct mmap_batch_state state;

429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447
	switch (version) {
	case 1:
		if (copy_from_user(&m, udata, sizeof(struct privcmd_mmapbatch)))
			return -EFAULT;
		/* Returns per-frame error in m.arr. */
		m.err = NULL;
		if (!access_ok(VERIFY_WRITE, m.arr, m.num * sizeof(*m.arr)))
			return -EFAULT;
		break;
	case 2:
		if (copy_from_user(&m, udata, sizeof(struct privcmd_mmapbatch_v2)))
			return -EFAULT;
		/* Returns per-frame error code in m.err. */
		if (!access_ok(VERIFY_WRITE, m.err, m.num * (sizeof(*m.err))))
			return -EFAULT;
		break;
	default:
		return -EINVAL;
	}
J
Jeremy Fitzhardinge 已提交
448

449
	nr_pages = DIV_ROUND_UP(m.num, XEN_PFN_PER_PAGE);
J
Jeremy Fitzhardinge 已提交
450 451 452
	if ((m.num <= 0) || (nr_pages > (LONG_MAX >> PAGE_SHIFT)))
		return -EINVAL;

453
	ret = gather_array(&pagelist, m.num, sizeof(xen_pfn_t), m.arr);
J
Jeremy Fitzhardinge 已提交
454

455
	if (ret)
J
Jeremy Fitzhardinge 已提交
456
		goto out;
457 458 459 460 461
	if (list_empty(&pagelist)) {
		ret = -EINVAL;
		goto out;
	}

462 463 464 465 466 467
	if (version == 2) {
		/* Zero error array now to only copy back actual errors. */
		if (clear_user(m.err, sizeof(int) * m.num)) {
			ret = -EFAULT;
			goto out;
		}
468
	}
J
Jeremy Fitzhardinge 已提交
469 470 471 472 473

	down_write(&mm->mmap_sem);

	vma = find_vma(mm, m.addr);
	if (!vma ||
474
	    vma->vm_ops != &privcmd_vm_ops) {
475
		ret = -EINVAL;
476
		goto out_unlock;
J
Jeremy Fitzhardinge 已提交
477
	}
478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496

	/*
	 * Caller must either:
	 *
	 * Map the whole VMA range, which will also allocate all the
	 * pages required for the auto_translated_physmap case.
	 *
	 * Or
	 *
	 * Map unmapped holes left from a previous map attempt (e.g.,
	 * because those foreign frames were previously paged out).
	 */
	if (vma->vm_private_data == NULL) {
		if (m.addr != vma->vm_start ||
		    m.addr + (nr_pages << PAGE_SHIFT) != vma->vm_end) {
			ret = -EINVAL;
			goto out_unlock;
		}
		if (xen_feature(XENFEAT_auto_translated_physmap)) {
497
			ret = alloc_empty_pages(vma, nr_pages);
498 499 500 501 502 503 504 505 506 507 508 509 510
			if (ret < 0)
				goto out_unlock;
		} else
			vma->vm_private_data = PRIV_VMA_LOCKED;
	} else {
		if (m.addr < vma->vm_start ||
		    m.addr + (nr_pages << PAGE_SHIFT) > vma->vm_end) {
			ret = -EINVAL;
			goto out_unlock;
		}
		if (privcmd_vma_range_is_mapped(vma, m.addr, nr_pages)) {
			ret = -EINVAL;
			goto out_unlock;
511 512
		}
	}
J
Jeremy Fitzhardinge 已提交
513

514 515 516
	state.domain        = m.dom;
	state.vma           = vma;
	state.va            = m.addr;
517
	state.index         = 0;
518
	state.global_error  = 0;
519
	state.version       = version;
J
Jeremy Fitzhardinge 已提交
520

521
	BUILD_BUG_ON(((PAGE_SIZE / sizeof(xen_pfn_t)) % XEN_PFN_PER_PAGE) != 0);
522
	/* mmap_batch_fn guarantees ret == 0 */
523 524
	BUG_ON(traverse_pages_block(m.num, sizeof(xen_pfn_t),
				    &pagelist, mmap_batch_fn, &state));
J
Jeremy Fitzhardinge 已提交
525 526 527

	up_write(&mm->mmap_sem);

528 529
	if (state.global_error) {
		/* Write back errors in second pass. */
530
		state.user_gfn = (xen_pfn_t *)m.arr;
531
		state.user_err = m.err;
532 533
		ret = traverse_pages_block(m.num, sizeof(xen_pfn_t),
					   &pagelist, mmap_return_errors, &state);
534 535
	} else
		ret = 0;
536 537 538 539 540

	/* If we have not had any EFAULT-like global errors then set the global
	 * error to -ENOENT if necessary. */
	if ((ret == 0) && (state.global_error == -ENOENT))
		ret = -ENOENT;
J
Jeremy Fitzhardinge 已提交
541 542 543 544

out:
	free_page_list(&pagelist);
	return ret;
545 546 547 548

out_unlock:
	up_write(&mm->mmap_sem);
	goto out;
J
Jeremy Fitzhardinge 已提交
549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566
}

static long privcmd_ioctl(struct file *file,
			  unsigned int cmd, unsigned long data)
{
	int ret = -ENOSYS;
	void __user *udata = (void __user *) data;

	switch (cmd) {
	case IOCTL_PRIVCMD_HYPERCALL:
		ret = privcmd_ioctl_hypercall(udata);
		break;

	case IOCTL_PRIVCMD_MMAP:
		ret = privcmd_ioctl_mmap(udata);
		break;

	case IOCTL_PRIVCMD_MMAPBATCH:
567 568 569 570 571
		ret = privcmd_ioctl_mmap_batch(udata, 1);
		break;

	case IOCTL_PRIVCMD_MMAPBATCH_V2:
		ret = privcmd_ioctl_mmap_batch(udata, 2);
J
Jeremy Fitzhardinge 已提交
572 573 574 575 576 577 578 579 580 581
		break;

	default:
		ret = -EINVAL;
		break;
	}

	return ret;
}

582 583 584
static void privcmd_close(struct vm_area_struct *vma)
{
	struct page **pages = vma->vm_private_data;
M
Muhammad Falak R Wani 已提交
585
	int numpgs = vma_pages(vma);
586
	int numgfns = (vma->vm_end - vma->vm_start) >> XEN_PAGE_SHIFT;
587
	int rc;
588

589
	if (!xen_feature(XENFEAT_auto_translated_physmap) || !numpgs || !pages)
590 591
		return;

592
	rc = xen_unmap_domain_gfn_range(vma, numgfns, pages);
593 594 595 596 597
	if (rc == 0)
		free_xenballooned_pages(numpgs, pages);
	else
		pr_crit("unable to unmap MFN range: leaking %d pages. rc=%d\n",
			numpgs, rc);
598 599 600
	kfree(pages);
}

J
Jeremy Fitzhardinge 已提交
601 602
static int privcmd_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
{
603 604
	printk(KERN_DEBUG "privcmd_fault: vma=%p %lx-%lx, pgoff=%lx, uv=%p\n",
	       vma, vma->vm_start, vma->vm_end,
605
	       vmf->pgoff, (void *)vmf->address);
606

J
Jeremy Fitzhardinge 已提交
607 608 609
	return VM_FAULT_SIGBUS;
}

610
static const struct vm_operations_struct privcmd_vm_ops = {
611
	.close = privcmd_close,
J
Jeremy Fitzhardinge 已提交
612 613 614 615 616
	.fault = privcmd_fault
};

static int privcmd_mmap(struct file *file, struct vm_area_struct *vma)
{
617 618
	/* DONTCOPY is essential for Xen because copy_page_range doesn't know
	 * how to recreate these mappings */
619 620
	vma->vm_flags |= VM_IO | VM_PFNMAP | VM_DONTCOPY |
			 VM_DONTEXPAND | VM_DONTDUMP;
J
Jeremy Fitzhardinge 已提交
621 622 623 624 625 626
	vma->vm_ops = &privcmd_vm_ops;
	vma->vm_private_data = NULL;

	return 0;
}

627 628 629 630 631 632 633 634 635 636 637 638 639 640 641
/*
 * For MMAPBATCH*. This allows asserting the singleshot mapping
 * on a per pfn/pte basis. Mapping calls that fail with ENOENT
 * can be then retried until success.
 */
static int is_mapped_fn(pte_t *pte, struct page *pmd_page,
	                unsigned long addr, void *data)
{
	return pte_none(*pte) ? 0 : -EBUSY;
}

static int privcmd_vma_range_is_mapped(
	           struct vm_area_struct *vma,
	           unsigned long addr,
	           unsigned long nr_pages)
J
Jeremy Fitzhardinge 已提交
642
{
643 644
	return apply_to_page_range(vma->vm_mm, addr, nr_pages << PAGE_SHIFT,
				   is_mapped_fn, NULL) != 0;
J
Jeremy Fitzhardinge 已提交
645 646
}

B
Bastian Blank 已提交
647 648
const struct file_operations xen_privcmd_fops = {
	.owner = THIS_MODULE,
J
Jeremy Fitzhardinge 已提交
649 650 651
	.unlocked_ioctl = privcmd_ioctl,
	.mmap = privcmd_mmap,
};
B
Bastian Blank 已提交
652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668
EXPORT_SYMBOL_GPL(xen_privcmd_fops);

static struct miscdevice privcmd_dev = {
	.minor = MISC_DYNAMIC_MINOR,
	.name = "xen/privcmd",
	.fops = &xen_privcmd_fops,
};

static int __init privcmd_init(void)
{
	int err;

	if (!xen_domain())
		return -ENODEV;

	err = misc_register(&privcmd_dev);
	if (err != 0) {
J
Joe Perches 已提交
669
		pr_err("Could not register Xen privcmd device\n");
B
Bastian Blank 已提交
670 671 672 673 674 675 676 677 678 679 680 681
		return err;
	}
	return 0;
}

static void __exit privcmd_exit(void)
{
	misc_deregister(&privcmd_dev);
}

module_init(privcmd_init);
module_exit(privcmd_exit);