ec.c 29.1 KB
Newer Older
L
Linus Torvalds 已提交
1
/*
2
 *  ec.c - ACPI Embedded Controller Driver (v2.1)
L
Linus Torvalds 已提交
3
 *
4
 *  Copyright (C) 2006-2008 Alexey Starikovskiy <astarikovskiy@suse.de>
5
 *  Copyright (C) 2006 Denis Sadykov <denis.m.sadykov@intel.com>
L
Linus Torvalds 已提交
6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
 *  Copyright (C) 2004 Luming Yu <luming.yu@intel.com>
 *  Copyright (C) 2001, 2002 Andy Grover <andrew.grover@intel.com>
 *  Copyright (C) 2001, 2002 Paul Diefenbaugh <paul.s.diefenbaugh@intel.com>
 *
 * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or (at
 *  your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful, but
 *  WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 *  General Public License for more details.
 *
 *  You should have received a copy of the GNU General Public License along
 *  with this program; if not, write to the Free Software Foundation, Inc.,
 *  59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
 *
 * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 */

29
/* Uncomment next line to get verbose printout */
30 31
/* #define DEBUG */

L
Linus Torvalds 已提交
32 33 34 35 36 37 38
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/types.h>
#include <linux/delay.h>
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
D
Dmitry Torokhov 已提交
39
#include <linux/interrupt.h>
40
#include <linux/list.h>
41
#include <linux/spinlock.h>
L
Linus Torvalds 已提交
42 43 44
#include <asm/io.h>
#include <acpi/acpi_bus.h>
#include <acpi/acpi_drivers.h>
45
#include <linux/dmi.h>
L
Linus Torvalds 已提交
46 47 48 49

#define ACPI_EC_CLASS			"embedded_controller"
#define ACPI_EC_DEVICE_NAME		"Embedded Controller"
#define ACPI_EC_FILE_INFO		"info"
50

51
#define PREFIX				"ACPI: EC: "
52

53
/* EC status register */
L
Linus Torvalds 已提交
54 55
#define ACPI_EC_FLAG_OBF	0x01	/* Output buffer full */
#define ACPI_EC_FLAG_IBF	0x02	/* Input buffer full */
D
Dmitry Torokhov 已提交
56
#define ACPI_EC_FLAG_BURST	0x10	/* burst mode */
L
Linus Torvalds 已提交
57
#define ACPI_EC_FLAG_SCI	0x20	/* EC-SCI occurred */
58

59
/* EC commands */
60
enum ec_command {
A
Alexey Starikovskiy 已提交
61 62 63 64 65
	ACPI_EC_COMMAND_READ = 0x80,
	ACPI_EC_COMMAND_WRITE = 0x81,
	ACPI_EC_BURST_ENABLE = 0x82,
	ACPI_EC_BURST_DISABLE = 0x83,
	ACPI_EC_COMMAND_QUERY = 0x84,
66
};
67

68
#define ACPI_EC_DELAY		500	/* Wait 500ms max. during EC ops */
69
#define ACPI_EC_UDELAY_GLK	1000	/* Wait 1ms max. to get global lock */
70
#define ACPI_EC_CDELAY		10	/* Wait 10us before polling EC */
71
#define ACPI_EC_MSI_UDELAY	550	/* Wait 550us for MSI EC */
72

73
#define ACPI_EC_STORM_THRESHOLD 8	/* number of false interrupts
74 75
					   per one transaction */

76 77
enum {
	EC_FLAGS_QUERY_PENDING,		/* Query is pending */
78
	EC_FLAGS_GPE_STORM,		/* GPE storm detected */
79
	EC_FLAGS_HANDLERS_INSTALLED,	/* Handlers for GPE and
80
					 * OpReg are installed */
81
	EC_FLAGS_FROZEN,		/* Transactions are suspended */
L
Linus Torvalds 已提交
82
};
83 84

/* If we find an EC via the ECDT, we need to keep a ptr to its context */
85
/* External interfaces use first EC only, so remember */
86 87 88 89 90 91 92 93 94 95
typedef int (*acpi_ec_query_func) (void *data);

struct acpi_ec_query_handler {
	struct list_head node;
	acpi_ec_query_func func;
	acpi_handle handle;
	void *data;
	u8 query_bit;
};

96
struct transaction {
97 98 99
	const u8 *wdata;
	u8 *rdata;
	unsigned short irq_count;
100
	u8 command;
101 102
	u8 wi;
	u8 ri;
103 104
	u8 wlen;
	u8 rlen;
105
	bool done;
106 107
};

108
static struct acpi_ec {
109
	acpi_handle handle;
110
	unsigned long gpe;
111 112
	unsigned long command_addr;
	unsigned long data_addr;
113
	unsigned long global_lock;
114
	unsigned long flags;
115
	struct mutex lock;
116
	wait_queue_head_t wait;
117
	struct list_head list;
118 119
	struct transaction *curr;
	spinlock_t curr_lock;
120
} *boot_ec, *first_ec;
121

122
static int EC_FLAGS_MSI; /* Out-of-spec MSI controller */
A
Alexey Starikovskiy 已提交
123
static int EC_FLAGS_VALIDATE_ECDT; /* ASUStec ECDTs need to be validated */
124
static int EC_FLAGS_SKIP_DSDT_SCAN; /* Not all BIOS survive early DSDT scan */
125

L
Linus Torvalds 已提交
126 127 128 129
/* --------------------------------------------------------------------------
                             Transaction Management
   -------------------------------------------------------------------------- */

130
static inline u8 acpi_ec_read_status(struct acpi_ec *ec)
L
Linus Torvalds 已提交
131
{
132
	u8 x = inb(ec->command_addr);
133
	pr_debug(PREFIX "---> status = 0x%2.2x\n", x);
134
	return x;
D
Dmitry Torokhov 已提交
135 136
}

137
static inline u8 acpi_ec_read_data(struct acpi_ec *ec)
138
{
139
	u8 x = inb(ec->data_addr);
140
	pr_debug(PREFIX "---> data = 0x%2.2x\n", x);
141
	return x;
142 143
}

144
static inline void acpi_ec_write_cmd(struct acpi_ec *ec, u8 command)
L
Luming Yu 已提交
145
{
146
	pr_debug(PREFIX "<--- command = 0x%2.2x\n", command);
147
	outb(command, ec->command_addr);
L
Luming Yu 已提交
148 149
}

150
static inline void acpi_ec_write_data(struct acpi_ec *ec, u8 data)
L
Luming Yu 已提交
151
{
152
	pr_debug(PREFIX "<--- data = 0x%2.2x\n", data);
153
	outb(data, ec->data_addr);
154
}
L
Luming Yu 已提交
155

156
static int ec_transaction_done(struct acpi_ec *ec)
157
{
158 159
	unsigned long flags;
	int ret = 0;
160
	spin_lock_irqsave(&ec->curr_lock, flags);
161
	if (!ec->curr || ec->curr->done)
162
		ret = 1;
163
	spin_unlock_irqrestore(&ec->curr_lock, flags);
164
	return ret;
L
Luming Yu 已提交
165
}
D
Dmitry Torokhov 已提交
166

167 168 169 170 171 172 173
static void start_transaction(struct acpi_ec *ec)
{
	ec->curr->irq_count = ec->curr->wi = ec->curr->ri = 0;
	ec->curr->done = false;
	acpi_ec_write_cmd(ec, ec->curr->command);
}

174
static void advance_transaction(struct acpi_ec *ec, u8 status)
175
{
176
	unsigned long flags;
177 178
	spin_lock_irqsave(&ec->curr_lock, flags);
	if (!ec->curr)
179
		goto unlock;
180 181 182 183 184
	if (ec->curr->wlen > ec->curr->wi) {
		if ((status & ACPI_EC_FLAG_IBF) == 0)
			acpi_ec_write_data(ec,
				ec->curr->wdata[ec->curr->wi++]);
		else
185
			goto err;
186
	} else if (ec->curr->rlen > ec->curr->ri) {
187
		if ((status & ACPI_EC_FLAG_OBF) == 1) {
188 189
			ec->curr->rdata[ec->curr->ri++] = acpi_ec_read_data(ec);
			if (ec->curr->rlen == ec->curr->ri)
190
				ec->curr->done = true;
191
		} else
192
			goto err;
193 194
	} else if (ec->curr->wlen == ec->curr->wi &&
		   (status & ACPI_EC_FLAG_IBF) == 0)
195 196 197 198
		ec->curr->done = true;
	goto unlock;
err:
	/* false interrupt, state didn't change */
199 200
	if (in_interrupt())
		++ec->curr->irq_count;
201
unlock:
202
	spin_unlock_irqrestore(&ec->curr_lock, flags);
A
Alexey Starikovskiy 已提交
203
}
204

205
static int acpi_ec_sync_query(struct acpi_ec *ec);
206

207
static int ec_check_sci_sync(struct acpi_ec *ec, u8 state)
208
{
209 210
	if (state & ACPI_EC_FLAG_SCI) {
		if (!test_and_set_bit(EC_FLAGS_QUERY_PENDING, &ec->flags))
211
			return acpi_ec_sync_query(ec);
212 213 214 215 216 217
	}
	return 0;
}

static int ec_poll(struct acpi_ec *ec)
{
218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236
	unsigned long flags;
	int repeat = 2; /* number of command restarts */
	while (repeat--) {
		unsigned long delay = jiffies +
			msecs_to_jiffies(ACPI_EC_DELAY);
		do {
			/* don't sleep with disabled interrupts */
			if (EC_FLAGS_MSI || irqs_disabled()) {
				udelay(ACPI_EC_MSI_UDELAY);
				if (ec_transaction_done(ec))
					return 0;
			} else {
				if (wait_event_timeout(ec->wait,
						ec_transaction_done(ec),
						msecs_to_jiffies(1)))
					return 0;
			}
			advance_transaction(ec, acpi_ec_read_status(ec));
		} while (time_before(jiffies, delay));
237
		if (acpi_ec_read_status(ec) & ACPI_EC_FLAG_IBF)
238 239 240 241 242
			break;
		pr_debug(PREFIX "controller reset, restart transaction\n");
		spin_lock_irqsave(&ec->curr_lock, flags);
		start_transaction(ec);
		spin_unlock_irqrestore(&ec->curr_lock, flags);
243
	}
244
	return -ETIME;
L
Linus Torvalds 已提交
245 246
}

247
static int acpi_ec_transaction_unlocked(struct acpi_ec *ec,
248
					struct transaction *t)
L
Luming Yu 已提交
249
{
250 251
	unsigned long tmp;
	int ret = 0;
252
	if (EC_FLAGS_MSI)
253
		udelay(ACPI_EC_MSI_UDELAY);
254
	/* start transaction */
255
	spin_lock_irqsave(&ec->curr_lock, tmp);
256
	/* following two actions should be kept atomic */
257
	ec->curr = t;
258
	start_transaction(ec);
259
	if (ec->curr->command == ACPI_EC_COMMAND_QUERY)
260
		clear_bit(EC_FLAGS_QUERY_PENDING, &ec->flags);
261
	spin_unlock_irqrestore(&ec->curr_lock, tmp);
262
	ret = ec_poll(ec);
263 264 265
	spin_lock_irqsave(&ec->curr_lock, tmp);
	ec->curr = NULL;
	spin_unlock_irqrestore(&ec->curr_lock, tmp);
266 267 268 269 270 271 272
	return ret;
}

static int ec_check_ibf0(struct acpi_ec *ec)
{
	u8 status = acpi_ec_read_status(ec);
	return (status & ACPI_EC_FLAG_IBF) == 0;
L
Luming Yu 已提交
273 274
}

275 276 277 278 279
static int ec_wait_ibf0(struct acpi_ec *ec)
{
	unsigned long delay = jiffies + msecs_to_jiffies(ACPI_EC_DELAY);
	/* interrupt wait manually if GPE mode is not active */
	while (time_before(jiffies, delay))
280 281
		if (wait_event_timeout(ec->wait, ec_check_ibf0(ec),
					msecs_to_jiffies(1)))
282 283
			return 0;
	return -ETIME;
L
Luming Yu 已提交
284 285
}

286
static int acpi_ec_transaction(struct acpi_ec *ec, struct transaction *t)
L
Linus Torvalds 已提交
287
{
288
	int status;
L
Len Brown 已提交
289
	u32 glk;
290
	if (!ec || (!t) || (t->wlen && !t->wdata) || (t->rlen && !t->rdata))
291
		return -EINVAL;
292 293
	if (t->rdata)
		memset(t->rdata, 0, t->rlen);
294
	mutex_lock(&ec->lock);
295 296 297 298
	if (test_bit(EC_FLAGS_FROZEN, &ec->flags)) {
		status = -EINVAL;
		goto unlock;
	}
299
	if (ec->global_lock) {
L
Linus Torvalds 已提交
300
		status = acpi_acquire_global_lock(ACPI_EC_UDELAY_GLK, &glk);
301
		if (ACPI_FAILURE(status)) {
302 303
			status = -ENODEV;
			goto unlock;
304
		}
L
Linus Torvalds 已提交
305
	}
306
	if (ec_wait_ibf0(ec)) {
307 308
		pr_err(PREFIX "input buffer is not empty, "
				"aborting transaction\n");
309
		status = -ETIME;
D
Dmitry Torokhov 已提交
310
		goto end;
311
	}
312 313 314
	pr_debug(PREFIX "transaction start\n");
	/* disable GPE during transaction if storm is detected */
	if (test_bit(EC_FLAGS_GPE_STORM, &ec->flags)) {
315 316 317 318
		/*
		 * It has to be disabled at the hardware level regardless of the
		 * GPE reference counting, so that it doesn't trigger.
		 */
319
		acpi_set_gpe(NULL, ec->gpe, ACPI_GPE_DISABLE);
320 321
	}

322
	status = acpi_ec_transaction_unlocked(ec, t);
323 324 325 326

	/* check if we received SCI during transaction */
	ec_check_sci_sync(ec, acpi_ec_read_status(ec));
	if (test_bit(EC_FLAGS_GPE_STORM, &ec->flags)) {
327
		msleep(1);
328 329 330 331 332
		/*
		 * It is safe to enable the GPE outside of the transaction.  Use
		 * acpi_set_gpe() for that, since we used it to disable the GPE
		 * above.
		 */
333
		acpi_set_gpe(NULL, ec->gpe, ACPI_GPE_ENABLE);
334 335 336 337 338
	} else if (t->irq_count > ACPI_EC_STORM_THRESHOLD) {
		pr_info(PREFIX "GPE storm detected, "
			"transactions will use polling mode\n");
		set_bit(EC_FLAGS_GPE_STORM, &ec->flags);
	}
339
	pr_debug(PREFIX "transaction end\n");
340
end:
341
	if (ec->global_lock)
L
Linus Torvalds 已提交
342
		acpi_release_global_lock(glk);
343
unlock:
344
	mutex_unlock(&ec->lock);
345
	return status;
L
Linus Torvalds 已提交
346 347
}

348
static int acpi_ec_burst_enable(struct acpi_ec *ec)
349 350
{
	u8 d;
351 352 353 354
	struct transaction t = {.command = ACPI_EC_BURST_ENABLE,
				.wdata = NULL, .rdata = &d,
				.wlen = 0, .rlen = 1};

355
	return acpi_ec_transaction(ec, &t);
356 357
}

358
static int acpi_ec_burst_disable(struct acpi_ec *ec)
359
{
360 361 362 363
	struct transaction t = {.command = ACPI_EC_BURST_DISABLE,
				.wdata = NULL, .rdata = NULL,
				.wlen = 0, .rlen = 0};

364
	return (acpi_ec_read_status(ec) & ACPI_EC_FLAG_BURST) ?
365
				acpi_ec_transaction(ec, &t) : 0;
366 367
}

A
Alexey Starikovskiy 已提交
368
static int acpi_ec_read(struct acpi_ec *ec, u8 address, u8 * data)
369 370 371
{
	int result;
	u8 d;
372 373 374
	struct transaction t = {.command = ACPI_EC_COMMAND_READ,
				.wdata = &address, .rdata = &d,
				.wlen = 1, .rlen = 1};
375

376
	result = acpi_ec_transaction(ec, &t);
377 378 379
	*data = d;
	return result;
}
380

381 382
static int acpi_ec_write(struct acpi_ec *ec, u8 address, u8 data)
{
A
Alexey Starikovskiy 已提交
383
	u8 wdata[2] = { address, data };
384 385 386 387
	struct transaction t = {.command = ACPI_EC_COMMAND_WRITE,
				.wdata = wdata, .rdata = NULL,
				.wlen = 2, .rlen = 0};

388
	return acpi_ec_transaction(ec, &t);
389 390
}

L
Linus Torvalds 已提交
391 392 393
/*
 * Externally callable EC access functions. For now, assume 1 EC only
 */
394 395 396 397
int ec_burst_enable(void)
{
	if (!first_ec)
		return -ENODEV;
398
	return acpi_ec_burst_enable(first_ec);
399 400 401 402 403 404 405 406
}

EXPORT_SYMBOL(ec_burst_enable);

int ec_burst_disable(void)
{
	if (!first_ec)
		return -ENODEV;
407
	return acpi_ec_burst_disable(first_ec);
408 409 410 411
}

EXPORT_SYMBOL(ec_burst_disable);

A
Alexey Starikovskiy 已提交
412
int ec_read(u8 addr, u8 * val)
L
Linus Torvalds 已提交
413 414
{
	int err;
415
	u8 temp_data;
L
Linus Torvalds 已提交
416 417 418 419

	if (!first_ec)
		return -ENODEV;

420
	err = acpi_ec_read(first_ec, addr, &temp_data);
L
Linus Torvalds 已提交
421 422 423 424

	if (!err) {
		*val = temp_data;
		return 0;
L
Len Brown 已提交
425
	} else
L
Linus Torvalds 已提交
426 427
		return err;
}
L
Len Brown 已提交
428

L
Linus Torvalds 已提交
429 430
EXPORT_SYMBOL(ec_read);

L
Len Brown 已提交
431
int ec_write(u8 addr, u8 val)
L
Linus Torvalds 已提交
432 433 434 435 436 437
{
	int err;

	if (!first_ec)
		return -ENODEV;

438
	err = acpi_ec_write(first_ec, addr, val);
L
Linus Torvalds 已提交
439 440 441

	return err;
}
L
Len Brown 已提交
442

L
Linus Torvalds 已提交
443 444
EXPORT_SYMBOL(ec_write);

445
int ec_transaction(u8 command,
446
		   const u8 * wdata, unsigned wdata_len,
447 448
		   u8 * rdata, unsigned rdata_len,
		   int force_poll)
L
Luming Yu 已提交
449
{
450 451 452
	struct transaction t = {.command = command,
				.wdata = wdata, .rdata = rdata,
				.wlen = wdata_len, .rlen = rdata_len};
453 454
	if (!first_ec)
		return -ENODEV;
L
Luming Yu 已提交
455

456
	return acpi_ec_transaction(first_ec, &t);
L
Luming Yu 已提交
457
}
L
Linus Torvalds 已提交
458

459 460
EXPORT_SYMBOL(ec_transaction);

461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486
void acpi_ec_suspend_transactions(void)
{
	struct acpi_ec *ec = first_ec;

	if (!ec)
		return;

	mutex_lock(&ec->lock);
	/* Prevent transactions from being carried out */
	set_bit(EC_FLAGS_FROZEN, &ec->flags);
	mutex_unlock(&ec->lock);
}

void acpi_ec_resume_transactions(void)
{
	struct acpi_ec *ec = first_ec;

	if (!ec)
		return;

	mutex_lock(&ec->lock);
	/* Allow transactions to be carried out again */
	clear_bit(EC_FLAGS_FROZEN, &ec->flags);
	mutex_unlock(&ec->lock);
}

487
static int acpi_ec_query_unlocked(struct acpi_ec *ec, u8 * data)
488 489
{
	int result;
A
Alexey Starikovskiy 已提交
490
	u8 d;
491 492 493
	struct transaction t = {.command = ACPI_EC_COMMAND_QUERY,
				.wdata = NULL, .rdata = &d,
				.wlen = 0, .rlen = 1};
A
Alexey Starikovskiy 已提交
494 495 496 497 498 499 500
	if (!ec || !data)
		return -EINVAL;
	/*
	 * Query the EC to find out which _Qxx method we need to evaluate.
	 * Note that successful completion of the query causes the ACPI_EC_SCI
	 * bit to be cleared (and thus clearing the interrupt source).
	 */
501
	result = acpi_ec_transaction_unlocked(ec, &t);
A
Alexey Starikovskiy 已提交
502 503 504 505 506 507
	if (result)
		return result;
	if (!d)
		return -ENODATA;
	*data = d;
	return 0;
L
Linus Torvalds 已提交
508 509 510 511 512
}

/* --------------------------------------------------------------------------
                                Event Management
   -------------------------------------------------------------------------- */
513 514 515 516 517 518 519 520 521 522 523 524 525 526
int acpi_ec_add_query_handler(struct acpi_ec *ec, u8 query_bit,
			      acpi_handle handle, acpi_ec_query_func func,
			      void *data)
{
	struct acpi_ec_query_handler *handler =
	    kzalloc(sizeof(struct acpi_ec_query_handler), GFP_KERNEL);
	if (!handler)
		return -ENOMEM;

	handler->query_bit = query_bit;
	handler->handle = handle;
	handler->func = func;
	handler->data = data;
	mutex_lock(&ec->lock);
527
	list_add(&handler->node, &ec->list);
528 529 530 531 532 533 534 535
	mutex_unlock(&ec->lock);
	return 0;
}

EXPORT_SYMBOL_GPL(acpi_ec_add_query_handler);

void acpi_ec_remove_query_handler(struct acpi_ec *ec, u8 query_bit)
{
A
Adrian Bunk 已提交
536
	struct acpi_ec_query_handler *handler, *tmp;
537
	mutex_lock(&ec->lock);
A
Adrian Bunk 已提交
538
	list_for_each_entry_safe(handler, tmp, &ec->list, node) {
539 540 541 542 543 544 545 546 547
		if (query_bit == handler->query_bit) {
			list_del(&handler->node);
			kfree(handler);
		}
	}
	mutex_unlock(&ec->lock);
}

EXPORT_SYMBOL_GPL(acpi_ec_remove_query_handler);
L
Linus Torvalds 已提交
548

549
static void acpi_ec_run(void *cxt)
L
Luming Yu 已提交
550
{
551 552
	struct acpi_ec_query_handler *handler = cxt;
	if (!handler)
553
		return;
554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569
	pr_debug(PREFIX "start query execution\n");
	if (handler->func)
		handler->func(handler->data);
	else if (handler->handle)
		acpi_evaluate_object(handler->handle, NULL, NULL, NULL);
	pr_debug(PREFIX "stop query execution\n");
	kfree(handler);
}

static int acpi_ec_sync_query(struct acpi_ec *ec)
{
	u8 value = 0;
	int status;
	struct acpi_ec_query_handler *handler, *copy;
	if ((status = acpi_ec_query_unlocked(ec, &value)))
		return status;
570 571 572
	list_for_each_entry(handler, &ec->list, node) {
		if (value == handler->query_bit) {
			/* have custom handler for this bit */
573 574 575 576 577
			copy = kmalloc(sizeof(*handler), GFP_KERNEL);
			if (!copy)
				return -ENOMEM;
			memcpy(copy, handler, sizeof(*copy));
			pr_debug(PREFIX "push query execution (0x%2x) on queue\n", value);
578 579
			return acpi_os_execute((copy->func) ?
				OSL_NOTIFY_HANDLER : OSL_GPE_HANDLER,
580
				acpi_ec_run, copy);
581 582
		}
	}
583 584 585 586 587 588 589 590 591 592
	return 0;
}

static void acpi_ec_gpe_query(void *ec_cxt)
{
	struct acpi_ec *ec = ec_cxt;
	if (!ec)
		return;
	mutex_lock(&ec->lock);
	acpi_ec_sync_query(ec);
593
	mutex_unlock(&ec->lock);
L
Luming Yu 已提交
594
}
L
Linus Torvalds 已提交
595

596 597 598 599 600 601 602 603 604 605 606 607 608 609
static void acpi_ec_gpe_query(void *ec_cxt);

static int ec_check_sci(struct acpi_ec *ec, u8 state)
{
	if (state & ACPI_EC_FLAG_SCI) {
		if (!test_and_set_bit(EC_FLAGS_QUERY_PENDING, &ec->flags)) {
			pr_debug(PREFIX "push gpe query to the queue\n");
			return acpi_os_execute(OSL_NOTIFY_HANDLER,
				acpi_ec_gpe_query, ec);
		}
	}
	return 0;
}

L
Len Brown 已提交
610
static u32 acpi_ec_gpe_handler(void *data)
L
Linus Torvalds 已提交
611
{
612
	struct acpi_ec *ec = data;
613

614
	pr_debug(PREFIX "~~~> interrupt\n");
615

616 617 618
	advance_transaction(ec, acpi_ec_read_status(ec));
	if (ec_transaction_done(ec) &&
	    (acpi_ec_read_status(ec) & ACPI_EC_FLAG_IBF) == 0) {
619
		wake_up(&ec->wait);
620 621
		ec_check_sci(ec, acpi_ec_read_status(ec));
	}
622
	return ACPI_INTERRUPT_HANDLED;
A
Alexey Starikovskiy 已提交
623 624
}

L
Linus Torvalds 已提交
625 626 627 628 629
/* --------------------------------------------------------------------------
                             Address Space Management
   -------------------------------------------------------------------------- */

static acpi_status
630
acpi_ec_space_handler(u32 function, acpi_physical_address address,
L
Lin Ming 已提交
631
		      u32 bits, u64 *value,
L
Len Brown 已提交
632
		      void *handler_context, void *region_context)
L
Linus Torvalds 已提交
633
{
634
	struct acpi_ec *ec = handler_context;
635
	int result = 0, i;
636
	u8 temp = 0;
L
Linus Torvalds 已提交
637 638

	if ((address > 0xFF) || !value || !handler_context)
639
		return AE_BAD_PARAMETER;
L
Linus Torvalds 已提交
640

641
	if (function != ACPI_READ && function != ACPI_WRITE)
642
		return AE_BAD_PARAMETER;
L
Linus Torvalds 已提交
643

644 645
	if (bits != 8 && acpi_strict)
		return AE_BAD_PARAMETER;
L
Linus Torvalds 已提交
646

647 648
	if (EC_FLAGS_MSI)
		acpi_ec_burst_enable(ec);
649

650 651 652 653 654 655 656 657 658 659
	if (function == ACPI_READ) {
		result = acpi_ec_read(ec, address, &temp);
		*value = temp;
	} else {
		temp = 0xff & (*value);
		result = acpi_ec_write(ec, address, temp);
	}

	for (i = 8; unlikely(bits - i > 0); i += 8) {
		++address;
660 661
		if (function == ACPI_READ) {
			result = acpi_ec_read(ec, address, &temp);
L
Lin Ming 已提交
662
			(*value) |= ((u64)temp) << i;
663 664 665 666
		} else {
			temp = 0xff & ((*value) >> i);
			result = acpi_ec_write(ec, address, temp);
		}
L
Linus Torvalds 已提交
667 668
	}

669 670
	if (EC_FLAGS_MSI)
		acpi_ec_burst_disable(ec);
671

L
Linus Torvalds 已提交
672 673
	switch (result) {
	case -EINVAL:
674
		return AE_BAD_PARAMETER;
L
Linus Torvalds 已提交
675 676
		break;
	case -ENODEV:
677
		return AE_NOT_FOUND;
L
Linus Torvalds 已提交
678 679
		break;
	case -ETIME:
680
		return AE_TIME;
L
Linus Torvalds 已提交
681 682
		break;
	default:
683
		return AE_OK;
L
Linus Torvalds 已提交
684 685 686 687 688 689 690
	}
}

/* --------------------------------------------------------------------------
                              FS Interface (/proc)
   -------------------------------------------------------------------------- */

L
Len Brown 已提交
691
static struct proc_dir_entry *acpi_ec_dir;
L
Linus Torvalds 已提交
692

L
Len Brown 已提交
693
static int acpi_ec_read_info(struct seq_file *seq, void *offset)
L
Linus Torvalds 已提交
694
{
695
	struct acpi_ec *ec = seq->private;
L
Linus Torvalds 已提交
696 697 698 699

	if (!ec)
		goto end;

700 701 702 703
	seq_printf(seq, "gpe:\t\t\t0x%02x\n", (u32) ec->gpe);
	seq_printf(seq, "ports:\t\t\t0x%02x, 0x%02x\n",
		   (unsigned)ec->command_addr, (unsigned)ec->data_addr);
	seq_printf(seq, "use global lock:\t%s\n",
704
		   ec->global_lock ? "yes" : "no");
L
Len Brown 已提交
705
      end:
706
	return 0;
L
Linus Torvalds 已提交
707 708 709 710 711 712 713
}

static int acpi_ec_info_open_fs(struct inode *inode, struct file *file)
{
	return single_open(file, acpi_ec_read_info, PDE(inode)->data);
}

J
Jan Engelhardt 已提交
714
static const struct file_operations acpi_ec_info_ops = {
L
Len Brown 已提交
715 716 717 718
	.open = acpi_ec_info_open_fs,
	.read = seq_read,
	.llseek = seq_lseek,
	.release = single_release,
L
Linus Torvalds 已提交
719 720 721
	.owner = THIS_MODULE,
};

L
Len Brown 已提交
722
static int acpi_ec_add_fs(struct acpi_device *device)
L
Linus Torvalds 已提交
723
{
L
Len Brown 已提交
724
	struct proc_dir_entry *entry = NULL;
L
Linus Torvalds 已提交
725 726 727

	if (!acpi_device_dir(device)) {
		acpi_device_dir(device) = proc_mkdir(acpi_device_bid(device),
L
Len Brown 已提交
728
						     acpi_ec_dir);
L
Linus Torvalds 已提交
729
		if (!acpi_device_dir(device))
730
			return -ENODEV;
L
Linus Torvalds 已提交
731 732
	}

733 734 735
	entry = proc_create_data(ACPI_EC_FILE_INFO, S_IRUGO,
				 acpi_device_dir(device),
				 &acpi_ec_info_ops, acpi_driver_data(device));
L
Linus Torvalds 已提交
736
	if (!entry)
737 738
		return -ENODEV;
	return 0;
L
Linus Torvalds 已提交
739 740
}

L
Len Brown 已提交
741
static int acpi_ec_remove_fs(struct acpi_device *device)
L
Linus Torvalds 已提交
742 743 744 745 746 747 748 749
{

	if (acpi_device_dir(device)) {
		remove_proc_entry(ACPI_EC_FILE_INFO, acpi_device_dir(device));
		remove_proc_entry(acpi_device_bid(device), acpi_ec_dir);
		acpi_device_dir(device) = NULL;
	}

750
	return 0;
L
Linus Torvalds 已提交
751 752 753 754 755
}

/* --------------------------------------------------------------------------
                               Driver Interface
   -------------------------------------------------------------------------- */
756 757 758 759 760 761 762 763
static acpi_status
ec_parse_io_ports(struct acpi_resource *resource, void *context);

static struct acpi_ec *make_acpi_ec(void)
{
	struct acpi_ec *ec = kzalloc(sizeof(struct acpi_ec), GFP_KERNEL);
	if (!ec)
		return NULL;
764
	ec->flags = 1 << EC_FLAGS_QUERY_PENDING;
765 766
	mutex_init(&ec->lock);
	init_waitqueue_head(&ec->wait);
767
	INIT_LIST_HEAD(&ec->list);
768
	spin_lock_init(&ec->curr_lock);
769 770
	return ec;
}
771

772 773 774 775
static acpi_status
acpi_ec_register_query_methods(acpi_handle handle, u32 level,
			       void *context, void **return_value)
{
776 777
	char node_name[5];
	struct acpi_buffer buffer = { sizeof(node_name), node_name };
778 779
	struct acpi_ec *ec = context;
	int value = 0;
780 781 782 783 784
	acpi_status status;

	status = acpi_get_name(handle, ACPI_SINGLE_NAME, &buffer);

	if (ACPI_SUCCESS(status) && sscanf(node_name, "_Q%x", &value) == 1) {
785 786 787 788 789
		acpi_ec_add_query_handler(ec, value, handle, NULL, NULL);
	}
	return AE_OK;
}

790 791
static acpi_status
ec_parse_device(acpi_handle handle, u32 Level, void *context, void **retval)
792
{
793
	acpi_status status;
794
	unsigned long long tmp = 0;
795 796

	struct acpi_ec *ec = context;
797 798 799 800

	/* clear addr values, ec_parse_io_ports depend on it */
	ec->command_addr = ec->data_addr = 0;

801 802 803 804
	status = acpi_walk_resources(handle, METHOD_NAME__CRS,
				     ec_parse_io_ports, ec);
	if (ACPI_FAILURE(status))
		return status;
805 806 807

	/* Get GPE bit assignment (EC events). */
	/* TODO: Add support for _GPE returning a package */
808
	status = acpi_evaluate_integer(handle, "_GPE", NULL, &tmp);
809 810
	if (ACPI_FAILURE(status))
		return status;
811
	ec->gpe = tmp;
812
	/* Use the global lock for all EC transactions? */
813
	tmp = 0;
814 815
	acpi_evaluate_integer(handle, "_GLK", NULL, &tmp);
	ec->global_lock = tmp;
816
	ec->handle = handle;
817
	return AE_CTRL_TERMINATE;
818 819
}

820 821 822 823 824 825 826 827 828 829
static int ec_install_handlers(struct acpi_ec *ec)
{
	acpi_status status;
	if (test_bit(EC_FLAGS_HANDLERS_INSTALLED, &ec->flags))
		return 0;
	status = acpi_install_gpe_handler(NULL, ec->gpe,
				  ACPI_GPE_EDGE_TRIGGERED,
				  &acpi_ec_gpe_handler, ec);
	if (ACPI_FAILURE(status))
		return -ENODEV;
830 831

	acpi_enable_gpe(NULL, ec->gpe, ACPI_GPE_TYPE_RUNTIME);
832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847
	status = acpi_install_address_space_handler(ec->handle,
						    ACPI_ADR_SPACE_EC,
						    &acpi_ec_space_handler,
						    NULL, ec);
	if (ACPI_FAILURE(status)) {
		if (status == AE_NOT_FOUND) {
			/*
			 * Maybe OS fails in evaluating the _REG object.
			 * The AE_NOT_FOUND error will be ignored and OS
			 * continue to initialize EC.
			 */
			printk(KERN_ERR "Fail in evaluating the _REG object"
				" of EC device. Broken bios is suspected.\n");
		} else {
			acpi_remove_gpe_handler(NULL, ec->gpe,
				&acpi_ec_gpe_handler);
848
			acpi_disable_gpe(NULL, ec->gpe, ACPI_GPE_TYPE_RUNTIME);
849 850 851 852 853 854 855 856
			return -ENODEV;
		}
	}

	set_bit(EC_FLAGS_HANDLERS_INSTALLED, &ec->flags);
	return 0;
}

857 858
static void ec_remove_handlers(struct acpi_ec *ec)
{
859
	acpi_disable_gpe(NULL, ec->gpe, ACPI_GPE_TYPE_RUNTIME);
860 861
	if (ACPI_FAILURE(acpi_remove_address_space_handler(ec->handle,
				ACPI_ADR_SPACE_EC, &acpi_ec_space_handler)))
862
		pr_err(PREFIX "failed to remove space handler\n");
863 864
	if (ACPI_FAILURE(acpi_remove_gpe_handler(NULL, ec->gpe,
				&acpi_ec_gpe_handler)))
865
		pr_err(PREFIX "failed to remove gpe handler\n");
866
	clear_bit(EC_FLAGS_HANDLERS_INSTALLED, &ec->flags);
867 868
}

869
static int acpi_ec_add(struct acpi_device *device)
L
Linus Torvalds 已提交
870
{
871
	struct acpi_ec *ec = NULL;
B
Bjorn Helgaas 已提交
872
	int ret;
L
Luming Yu 已提交
873

874 875 876
	strcpy(acpi_device_name(device), ACPI_EC_DEVICE_NAME);
	strcpy(acpi_device_class(device), ACPI_EC_CLASS);

877
	/* Check for boot EC */
878 879 880 881 882 883 884 885 886
	if (boot_ec &&
	    (boot_ec->handle == device->handle ||
	     boot_ec->handle == ACPI_ROOT_OBJECT)) {
		ec = boot_ec;
		boot_ec = NULL;
	} else {
		ec = make_acpi_ec();
		if (!ec)
			return -ENOMEM;
887 888 889
	}
	if (ec_parse_device(device->handle, 0, ec, NULL) !=
		AE_CTRL_TERMINATE) {
890 891
			kfree(ec);
			return -EINVAL;
892 893
	}

894
	ec->handle = device->handle;
895 896 897

	/* Find and register all query methods */
	acpi_walk_namespace(ACPI_TYPE_METHOD, ec->handle, 1,
898
			    acpi_ec_register_query_methods, NULL, ec, NULL);
899

900 901
	if (!first_ec)
		first_ec = ec;
902
	device->driver_data = ec;
903
	acpi_ec_add_fs(device);
904
	pr_info(PREFIX "GPE = 0x%lx, I/O: command/status = 0x%lx, data = 0x%lx\n",
905
			  ec->gpe, ec->command_addr, ec->data_addr);
906 907 908 909 910 911

	ret = ec_install_handlers(ec);

	/* EC is fully operational, allow queries */
	clear_bit(EC_FLAGS_QUERY_PENDING, &ec->flags);
	return ret;
L
Linus Torvalds 已提交
912 913
}

L
Len Brown 已提交
914
static int acpi_ec_remove(struct acpi_device *device, int type)
L
Linus Torvalds 已提交
915
{
916
	struct acpi_ec *ec;
917
	struct acpi_ec_query_handler *handler, *tmp;
L
Linus Torvalds 已提交
918 919

	if (!device)
920
		return -EINVAL;
L
Linus Torvalds 已提交
921 922

	ec = acpi_driver_data(device);
B
Bjorn Helgaas 已提交
923
	ec_remove_handlers(ec);
924
	mutex_lock(&ec->lock);
925
	list_for_each_entry_safe(handler, tmp, &ec->list, node) {
926 927 928 929
		list_del(&handler->node);
		kfree(handler);
	}
	mutex_unlock(&ec->lock);
L
Linus Torvalds 已提交
930
	acpi_ec_remove_fs(device);
931
	device->driver_data = NULL;
932
	if (ec == first_ec)
933
		first_ec = NULL;
934
	kfree(ec);
935
	return 0;
L
Linus Torvalds 已提交
936 937 938
}

static acpi_status
939
ec_parse_io_ports(struct acpi_resource *resource, void *context)
L
Linus Torvalds 已提交
940
{
941
	struct acpi_ec *ec = context;
L
Linus Torvalds 已提交
942

943
	if (resource->type != ACPI_RESOURCE_TYPE_IO)
L
Linus Torvalds 已提交
944 945 946 947 948 949 950
		return AE_OK;

	/*
	 * The first address region returned is the data port, and
	 * the second address region returned is the status/command
	 * port.
	 */
951
	if (ec->data_addr == 0)
952
		ec->data_addr = resource->data.io.minimum;
953
	else if (ec->command_addr == 0)
954
		ec->command_addr = resource->data.io.minimum;
955
	else
L
Linus Torvalds 已提交
956 957 958 959 960
		return AE_CTRL_TERMINATE;

	return AE_OK;
}

961 962
int __init acpi_boot_ec_enable(void)
{
963
	if (!boot_ec || test_bit(EC_FLAGS_HANDLERS_INSTALLED, &boot_ec->flags))
964 965 966 967 968 969 970 971
		return 0;
	if (!ec_install_handlers(boot_ec)) {
		first_ec = boot_ec;
		return 0;
	}
	return -EFAULT;
}

972 973 974 975 976
static const struct acpi_device_id ec_device_ids[] = {
	{"PNP0C09", 0},
	{"", 0},
};

977 978 979 980 981 982 983
/* Some BIOS do not survive early DSDT scan, skip it */
static int ec_skip_dsdt_scan(const struct dmi_system_id *id)
{
	EC_FLAGS_SKIP_DSDT_SCAN = 1;
	return 0;
}

A
Alexey Starikovskiy 已提交
984 985 986 987 988 989 990 991 992 993
/* ASUStek often supplies us with broken ECDT, validate it */
static int ec_validate_ecdt(const struct dmi_system_id *id)
{
	EC_FLAGS_VALIDATE_ECDT = 1;
	return 0;
}

/* MSI EC needs special treatment, enable it */
static int ec_flag_msi(const struct dmi_system_id *id)
{
994
	printk(KERN_DEBUG PREFIX "Detected MSI hardware, enabling workarounds.\n");
A
Alexey Starikovskiy 已提交
995 996 997 998 999 1000
	EC_FLAGS_MSI = 1;
	EC_FLAGS_VALIDATE_ECDT = 1;
	return 0;
}

static struct dmi_system_id __initdata ec_dmi_table[] = {
1001 1002 1003 1004
	{
	ec_skip_dsdt_scan, "Compal JFL92", {
	DMI_MATCH(DMI_BIOS_VENDOR, "COMPAL"),
	DMI_MATCH(DMI_BOARD_NAME, "JFL92") }, NULL},
A
Alexey Starikovskiy 已提交
1005 1006
	{
	ec_flag_msi, "MSI hardware", {
1007 1008 1009 1010 1011 1012 1013
	DMI_MATCH(DMI_BIOS_VENDOR, "Micro-Star")}, NULL},
	{
	ec_flag_msi, "MSI hardware", {
	DMI_MATCH(DMI_SYS_VENDOR, "Micro-Star")}, NULL},
	{
	ec_flag_msi, "MSI hardware", {
	DMI_MATCH(DMI_CHASSIS_VENDOR, "MICRO-Star")}, NULL},
A
Alexey Starikovskiy 已提交
1014 1015 1016 1017 1018 1019 1020
	{
	ec_validate_ecdt, "ASUS hardware", {
	DMI_MATCH(DMI_BIOS_VENDOR, "ASUS") }, NULL},
	{},
};


1021 1022 1023
int __init acpi_ec_ecdt_probe(void)
{
	acpi_status status;
1024
	struct acpi_ec *saved_ec = NULL;
L
Len Brown 已提交
1025
	struct acpi_table_ecdt *ecdt_ptr;
L
Luming Yu 已提交
1026

1027 1028
	boot_ec = make_acpi_ec();
	if (!boot_ec)
1029 1030 1031 1032
		return -ENOMEM;
	/*
	 * Generate a boot ec context
	 */
A
Alexey Starikovskiy 已提交
1033
	dmi_check_system(ec_dmi_table);
1034 1035
	status = acpi_get_table(ACPI_SIG_ECDT, 1,
				(struct acpi_table_header **)&ecdt_ptr);
1036
	if (ACPI_SUCCESS(status)) {
1037
		pr_info(PREFIX "EC description table is found, configuring boot EC\n");
1038 1039 1040
		boot_ec->command_addr = ecdt_ptr->control.address;
		boot_ec->data_addr = ecdt_ptr->data.address;
		boot_ec->gpe = ecdt_ptr->gpe;
1041
		boot_ec->handle = ACPI_ROOT_OBJECT;
1042
		acpi_get_handle(ACPI_ROOT_OBJECT, ecdt_ptr->id, &boot_ec->handle);
1043
		/* Don't trust ECDT, which comes from ASUSTek */
A
Alexey Starikovskiy 已提交
1044
		if (!EC_FLAGS_VALIDATE_ECDT)
1045
			goto install;
1046 1047 1048
		saved_ec = kmalloc(sizeof(struct acpi_ec), GFP_KERNEL);
		if (!saved_ec)
			return -ENOMEM;
1049
		memcpy(saved_ec, boot_ec, sizeof(struct acpi_ec));
1050
	/* fall through */
1051
	}
A
Alexey Starikovskiy 已提交
1052

1053 1054 1055
	if (EC_FLAGS_SKIP_DSDT_SCAN)
		return -ENODEV;

1056 1057 1058 1059 1060 1061 1062 1063
	/* This workaround is needed only on some broken machines,
	 * which require early EC, but fail to provide ECDT */
	printk(KERN_DEBUG PREFIX "Look up EC in DSDT\n");
	status = acpi_get_devices(ec_device_ids[0].id, ec_parse_device,
					boot_ec, NULL);
	/* Check that acpi_get_devices actually find something */
	if (ACPI_FAILURE(status) || !boot_ec->handle)
		goto error;
1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086
	if (saved_ec) {
		/* try to find good ECDT from ASUSTek */
		if (saved_ec->command_addr != boot_ec->command_addr ||
		    saved_ec->data_addr != boot_ec->data_addr ||
		    saved_ec->gpe != boot_ec->gpe ||
		    saved_ec->handle != boot_ec->handle)
			pr_info(PREFIX "ASUSTek keeps feeding us with broken "
			"ECDT tables, which are very hard to workaround. "
			"Trying to use DSDT EC info instead. Please send "
			"output of acpidump to linux-acpi@vger.kernel.org\n");
		kfree(saved_ec);
		saved_ec = NULL;
	} else {
		/* We really need to limit this workaround, the only ASUS,
		* which needs it, has fake EC._INI method, so use it as flag.
		* Keep boot_ec struct as it will be needed soon.
		*/
		acpi_handle dummy;
		if (!dmi_name_in_vendors("ASUS") ||
		    ACPI_FAILURE(acpi_get_handle(boot_ec->handle, "_INI",
							&dummy)))
			return -ENODEV;
	}
1087 1088
install:
	if (!ec_install_handlers(boot_ec)) {
1089
		first_ec = boot_ec;
1090
		return 0;
1091
	}
1092
error:
1093 1094
	kfree(boot_ec);
	boot_ec = NULL;
L
Linus Torvalds 已提交
1095 1096 1097
	return -ENODEV;
}

1098 1099 1100
static int acpi_ec_suspend(struct acpi_device *device, pm_message_t state)
{
	struct acpi_ec *ec = acpi_driver_data(device);
1101
	/* Stop using the GPE, but keep it reference counted. */
1102
	acpi_set_gpe(NULL, ec->gpe, ACPI_GPE_DISABLE);
1103 1104 1105 1106 1107 1108
	return 0;
}

static int acpi_ec_resume(struct acpi_device *device)
{
	struct acpi_ec *ec = acpi_driver_data(device);
1109
	/* Enable the GPE again, but don't reference count it once more. */
1110
	acpi_set_gpe(NULL, ec->gpe, ACPI_GPE_ENABLE);
1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125
	return 0;
}

static struct acpi_driver acpi_ec_driver = {
	.name = "ec",
	.class = ACPI_EC_CLASS,
	.ids = ec_device_ids,
	.ops = {
		.add = acpi_ec_add,
		.remove = acpi_ec_remove,
		.suspend = acpi_ec_suspend,
		.resume = acpi_ec_resume,
		},
};

1126
int __init acpi_ec_init(void)
L
Linus Torvalds 已提交
1127
{
L
Len Brown 已提交
1128
	int result = 0;
L
Linus Torvalds 已提交
1129 1130 1131

	acpi_ec_dir = proc_mkdir(ACPI_EC_CLASS, acpi_root_dir);
	if (!acpi_ec_dir)
1132
		return -ENODEV;
L
Linus Torvalds 已提交
1133 1134 1135 1136 1137

	/* Now register the driver for the EC */
	result = acpi_bus_register_driver(&acpi_ec_driver);
	if (result < 0) {
		remove_proc_entry(ACPI_EC_CLASS, acpi_root_dir);
1138
		return -ENODEV;
L
Linus Torvalds 已提交
1139 1140
	}

1141
	return result;
L
Linus Torvalds 已提交
1142 1143 1144 1145
}

/* EC driver currently not unloadable */
#if 0
L
Len Brown 已提交
1146
static void __exit acpi_ec_exit(void)
L
Linus Torvalds 已提交
1147 1148 1149 1150 1151 1152
{

	acpi_bus_unregister_driver(&acpi_ec_driver);

	remove_proc_entry(ACPI_EC_CLASS, acpi_root_dir);

1153
	return;
L
Linus Torvalds 已提交
1154
}
1155
#endif	/* 0 */