bond_options.c 38.9 KB
Newer Older
1 2 3
/*
 * drivers/net/bond/bond_options.c - bonding options
 * Copyright (c) 2013 Jiri Pirko <jiri@resnulli.us>
4
 * Copyright (c) 2013 Scott Feldman <sfeldma@cumulusnetworks.com>
5 6 7 8 9 10 11 12 13
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 */

#include <linux/errno.h>
#include <linux/if.h>
14
#include <linux/netdevice.h>
15
#include <linux/spinlock.h>
16
#include <linux/rcupdate.h>
17
#include <linux/ctype.h>
18
#include <linux/inet.h>
19 20
#include "bonding.h"

21
static int bond_option_active_slave_set(struct bonding *bond,
22
					const struct bond_opt_value *newval);
23
static int bond_option_miimon_set(struct bonding *bond,
24
				  const struct bond_opt_value *newval);
25
static int bond_option_updelay_set(struct bonding *bond,
26
				   const struct bond_opt_value *newval);
27
static int bond_option_downdelay_set(struct bonding *bond,
28
				     const struct bond_opt_value *newval);
29
static int bond_option_use_carrier_set(struct bonding *bond,
30
				       const struct bond_opt_value *newval);
31
static int bond_option_arp_interval_set(struct bonding *bond,
32
					const struct bond_opt_value *newval);
33 34 35
static int bond_option_arp_ip_target_add(struct bonding *bond, __be32 target);
static int bond_option_arp_ip_target_rem(struct bonding *bond, __be32 target);
static int bond_option_arp_ip_targets_set(struct bonding *bond,
36
					  const struct bond_opt_value *newval);
37
static int bond_option_arp_validate_set(struct bonding *bond,
38
					const struct bond_opt_value *newval);
39
static int bond_option_arp_all_targets_set(struct bonding *bond,
40
					   const struct bond_opt_value *newval);
41
static int bond_option_primary_set(struct bonding *bond,
42
				   const struct bond_opt_value *newval);
43
static int bond_option_primary_reselect_set(struct bonding *bond,
44
					    const struct bond_opt_value *newval);
45
static int bond_option_fail_over_mac_set(struct bonding *bond,
46
					 const struct bond_opt_value *newval);
47
static int bond_option_xmit_hash_policy_set(struct bonding *bond,
48
					    const struct bond_opt_value *newval);
49
static int bond_option_resend_igmp_set(struct bonding *bond,
50
				       const struct bond_opt_value *newval);
51
static int bond_option_num_peer_notif_set(struct bonding *bond,
52
					  const struct bond_opt_value *newval);
53
static int bond_option_all_slaves_active_set(struct bonding *bond,
54
					     const struct bond_opt_value *newval);
55
static int bond_option_min_links_set(struct bonding *bond,
56
				     const struct bond_opt_value *newval);
57
static int bond_option_lp_interval_set(struct bonding *bond,
58
				       const struct bond_opt_value *newval);
59
static int bond_option_pps_set(struct bonding *bond,
60
			       const struct bond_opt_value *newval);
61
static int bond_option_lacp_rate_set(struct bonding *bond,
62
				     const struct bond_opt_value *newval);
63
static int bond_option_ad_select_set(struct bonding *bond,
64
				     const struct bond_opt_value *newval);
65
static int bond_option_queue_id_set(struct bonding *bond,
66
				    const struct bond_opt_value *newval);
67
static int bond_option_mode_set(struct bonding *bond,
68
				const struct bond_opt_value *newval);
69
static int bond_option_slaves_set(struct bonding *bond,
70
				  const struct bond_opt_value *newval);
71 72
static int bond_option_tlb_dynamic_lb_set(struct bonding *bond,
				  const struct bond_opt_value *newval);
73 74 75


static const struct bond_opt_value bond_mode_tbl[] = {
76 77 78 79 80 81 82 83 84 85
	{ "balance-rr",    BOND_MODE_ROUNDROBIN,   BOND_VALFLAG_DEFAULT},
	{ "active-backup", BOND_MODE_ACTIVEBACKUP, 0},
	{ "balance-xor",   BOND_MODE_XOR,          0},
	{ "broadcast",     BOND_MODE_BROADCAST,    0},
	{ "802.3ad",       BOND_MODE_8023AD,       0},
	{ "balance-tlb",   BOND_MODE_TLB,          0},
	{ "balance-alb",   BOND_MODE_ALB,          0},
	{ NULL,            -1,                     0},
};

86
static const struct bond_opt_value bond_pps_tbl[] = {
87 88 89 90 91
	{ "default", 1,         BOND_VALFLAG_DEFAULT},
	{ "maxval",  USHRT_MAX, BOND_VALFLAG_MAX},
	{ NULL,      -1,        0},
};

92
static const struct bond_opt_value bond_xmit_hashtype_tbl[] = {
93 94 95 96 97 98 99 100
	{ "layer2",   BOND_XMIT_POLICY_LAYER2, BOND_VALFLAG_DEFAULT},
	{ "layer3+4", BOND_XMIT_POLICY_LAYER34, 0},
	{ "layer2+3", BOND_XMIT_POLICY_LAYER23, 0},
	{ "encap2+3", BOND_XMIT_POLICY_ENCAP23, 0},
	{ "encap3+4", BOND_XMIT_POLICY_ENCAP34, 0},
	{ NULL,       -1,                       0},
};

101
static const struct bond_opt_value bond_arp_validate_tbl[] = {
102 103 104 105 106 107 108 109
	{ "none",		BOND_ARP_VALIDATE_NONE,		BOND_VALFLAG_DEFAULT},
	{ "active",		BOND_ARP_VALIDATE_ACTIVE,	0},
	{ "backup",		BOND_ARP_VALIDATE_BACKUP,	0},
	{ "all",		BOND_ARP_VALIDATE_ALL,		0},
	{ "filter",		BOND_ARP_FILTER,		0},
	{ "filter_active",	BOND_ARP_FILTER_ACTIVE,		0},
	{ "filter_backup",	BOND_ARP_FILTER_BACKUP,		0},
	{ NULL,			-1,				0},
110 111
};

112
static const struct bond_opt_value bond_arp_all_targets_tbl[] = {
113 114 115 116 117
	{ "any", BOND_ARP_TARGETS_ANY, BOND_VALFLAG_DEFAULT},
	{ "all", BOND_ARP_TARGETS_ALL, 0},
	{ NULL,  -1,                   0},
};

118
static const struct bond_opt_value bond_fail_over_mac_tbl[] = {
119 120 121 122 123 124
	{ "none",   BOND_FOM_NONE,   BOND_VALFLAG_DEFAULT},
	{ "active", BOND_FOM_ACTIVE, 0},
	{ "follow", BOND_FOM_FOLLOW, 0},
	{ NULL,     -1,              0},
};

125
static const struct bond_opt_value bond_intmax_tbl[] = {
126 127
	{ "off",     0,       BOND_VALFLAG_DEFAULT},
	{ "maxval",  INT_MAX, BOND_VALFLAG_MAX},
128
	{ NULL,      -1,      0}
129 130
};

131
static const struct bond_opt_value bond_lacp_rate_tbl[] = {
132 133 134 135 136
	{ "slow", AD_LACP_SLOW, 0},
	{ "fast", AD_LACP_FAST, 0},
	{ NULL,   -1,           0},
};

137
static const struct bond_opt_value bond_ad_select_tbl[] = {
138 139 140 141 142 143
	{ "stable",    BOND_AD_STABLE,    BOND_VALFLAG_DEFAULT},
	{ "bandwidth", BOND_AD_BANDWIDTH, 0},
	{ "count",     BOND_AD_COUNT,     0},
	{ NULL,        -1,                0},
};

144
static const struct bond_opt_value bond_num_peer_notif_tbl[] = {
145 146 147 148 149 150
	{ "off",     0,   0},
	{ "maxval",  255, BOND_VALFLAG_MAX},
	{ "default", 1,   BOND_VALFLAG_DEFAULT},
	{ NULL,      -1,  0}
};

151
static const struct bond_opt_value bond_primary_reselect_tbl[] = {
152 153 154 155 156 157
	{ "always",  BOND_PRI_RESELECT_ALWAYS,  BOND_VALFLAG_DEFAULT},
	{ "better",  BOND_PRI_RESELECT_BETTER,  0},
	{ "failure", BOND_PRI_RESELECT_FAILURE, 0},
	{ NULL,      -1},
};

158
static const struct bond_opt_value bond_use_carrier_tbl[] = {
159 160 161 162 163
	{ "off", 0,  0},
	{ "on",  1,  BOND_VALFLAG_DEFAULT},
	{ NULL,  -1, 0}
};

164
static const struct bond_opt_value bond_all_slaves_active_tbl[] = {
165 166 167 168 169
	{ "off", 0,  BOND_VALFLAG_DEFAULT},
	{ "on",  1,  0},
	{ NULL,  -1, 0}
};

170
static const struct bond_opt_value bond_resend_igmp_tbl[] = {
171 172 173 174 175 176
	{ "off",     0,   0},
	{ "maxval",  255, BOND_VALFLAG_MAX},
	{ "default", 1,   BOND_VALFLAG_DEFAULT},
	{ NULL,      -1,  0}
};

177
static const struct bond_opt_value bond_lp_interval_tbl[] = {
178 179
	{ "minval",  1,       BOND_VALFLAG_MIN | BOND_VALFLAG_DEFAULT},
	{ "maxval",  INT_MAX, BOND_VALFLAG_MAX},
180
	{ NULL,      -1,      0},
181 182
};

183 184 185 186 187 188
static const struct bond_opt_value bond_tlb_dynamic_lb_tbl[] = {
	{ "off", 0,  0},
	{ "on",  1,  BOND_VALFLAG_DEFAULT},
	{ NULL,  -1, 0}
};

189
static const struct bond_option bond_opts[] = {
190 191 192 193 194 195 196 197
	[BOND_OPT_MODE] = {
		.id = BOND_OPT_MODE,
		.name = "mode",
		.desc = "bond device mode",
		.flags = BOND_OPTFLAG_NOSLAVES | BOND_OPTFLAG_IFDOWN,
		.values = bond_mode_tbl,
		.set = bond_option_mode_set
	},
198 199 200 201 202 203 204 205
	[BOND_OPT_PACKETS_PER_SLAVE] = {
		.id = BOND_OPT_PACKETS_PER_SLAVE,
		.name = "packets_per_slave",
		.desc = "Packets to send per slave in RR mode",
		.unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ROUNDROBIN)),
		.values = bond_pps_tbl,
		.set = bond_option_pps_set
	},
206 207 208
	[BOND_OPT_XMIT_HASH] = {
		.id = BOND_OPT_XMIT_HASH,
		.name = "xmit_hash_policy",
209
		.desc = "balance-xor, 802.3ad, and tlb hashing method",
210 211 212
		.values = bond_xmit_hashtype_tbl,
		.set = bond_option_xmit_hash_policy_set
	},
213 214 215 216
	[BOND_OPT_ARP_VALIDATE] = {
		.id = BOND_OPT_ARP_VALIDATE,
		.name = "arp_validate",
		.desc = "validate src/dst of ARP probes",
217 218
		.unsuppmodes = BIT(BOND_MODE_8023AD) | BIT(BOND_MODE_TLB) |
			       BIT(BOND_MODE_ALB),
219 220 221
		.values = bond_arp_validate_tbl,
		.set = bond_option_arp_validate_set
	},
222 223 224 225 226 227 228
	[BOND_OPT_ARP_ALL_TARGETS] = {
		.id = BOND_OPT_ARP_ALL_TARGETS,
		.name = "arp_all_targets",
		.desc = "fail on any/all arp targets timeout",
		.values = bond_arp_all_targets_tbl,
		.set = bond_option_arp_all_targets_set
	},
229 230 231 232 233 234 235 236
	[BOND_OPT_FAIL_OVER_MAC] = {
		.id = BOND_OPT_FAIL_OVER_MAC,
		.name = "fail_over_mac",
		.desc = "For active-backup, do not set all slaves to the same MAC",
		.flags = BOND_OPTFLAG_NOSLAVES,
		.values = bond_fail_over_mac_tbl,
		.set = bond_option_fail_over_mac_set
	},
237 238 239 240 241 242 243 244 245
	[BOND_OPT_ARP_INTERVAL] = {
		.id = BOND_OPT_ARP_INTERVAL,
		.name = "arp_interval",
		.desc = "arp interval in milliseconds",
		.unsuppmodes = BIT(BOND_MODE_8023AD) | BIT(BOND_MODE_TLB) |
			       BIT(BOND_MODE_ALB),
		.values = bond_intmax_tbl,
		.set = bond_option_arp_interval_set
	},
246 247 248 249 250 251 252
	[BOND_OPT_ARP_TARGETS] = {
		.id = BOND_OPT_ARP_TARGETS,
		.name = "arp_ip_target",
		.desc = "arp targets in n.n.n.n form",
		.flags = BOND_OPTFLAG_RAWVAL,
		.set = bond_option_arp_ip_targets_set
	},
253 254 255 256 257 258 259
	[BOND_OPT_DOWNDELAY] = {
		.id = BOND_OPT_DOWNDELAY,
		.name = "downdelay",
		.desc = "Delay before considering link down, in milliseconds",
		.values = bond_intmax_tbl,
		.set = bond_option_downdelay_set
	},
260 261 262 263 264 265 266
	[BOND_OPT_UPDELAY] = {
		.id = BOND_OPT_UPDELAY,
		.name = "updelay",
		.desc = "Delay before considering link up, in milliseconds",
		.values = bond_intmax_tbl,
		.set = bond_option_updelay_set
	},
267 268 269 270 271 272 273 274 275
	[BOND_OPT_LACP_RATE] = {
		.id = BOND_OPT_LACP_RATE,
		.name = "lacp_rate",
		.desc = "LACPDU tx rate to request from 802.3ad partner",
		.flags = BOND_OPTFLAG_IFDOWN,
		.unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_8023AD)),
		.values = bond_lacp_rate_tbl,
		.set = bond_option_lacp_rate_set
	},
276 277 278 279 280 281 282
	[BOND_OPT_MINLINKS] = {
		.id = BOND_OPT_MINLINKS,
		.name = "min_links",
		.desc = "Minimum number of available links before turning on carrier",
		.values = bond_intmax_tbl,
		.set = bond_option_min_links_set
	},
283 284 285 286 287 288 289 290
	[BOND_OPT_AD_SELECT] = {
		.id = BOND_OPT_AD_SELECT,
		.name = "ad_select",
		.desc = "803.ad aggregation selection logic",
		.flags = BOND_OPTFLAG_IFDOWN,
		.values = bond_ad_select_tbl,
		.set = bond_option_ad_select_set
	},
291 292 293 294 295 296 297
	[BOND_OPT_NUM_PEER_NOTIF] = {
		.id = BOND_OPT_NUM_PEER_NOTIF,
		.name = "num_unsol_na",
		.desc = "Number of peer notifications to send on failover event",
		.values = bond_num_peer_notif_tbl,
		.set = bond_option_num_peer_notif_set
	},
298 299 300 301 302 303 304
	[BOND_OPT_MIIMON] = {
		.id = BOND_OPT_MIIMON,
		.name = "miimon",
		.desc = "Link check interval in milliseconds",
		.values = bond_intmax_tbl,
		.set = bond_option_miimon_set
	},
305 306 307 308 309 310 311 312 313 314
	[BOND_OPT_PRIMARY] = {
		.id = BOND_OPT_PRIMARY,
		.name = "primary",
		.desc = "Primary network device to use",
		.flags = BOND_OPTFLAG_RAWVAL,
		.unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ACTIVEBACKUP) |
						BIT(BOND_MODE_TLB) |
						BIT(BOND_MODE_ALB)),
		.set = bond_option_primary_set
	},
315 316 317 318 319 320 321
	[BOND_OPT_PRIMARY_RESELECT] = {
		.id = BOND_OPT_PRIMARY_RESELECT,
		.name = "primary_reselect",
		.desc = "Reselect primary slave once it comes up",
		.values = bond_primary_reselect_tbl,
		.set = bond_option_primary_reselect_set
	},
322 323 324 325 326 327 328
	[BOND_OPT_USE_CARRIER] = {
		.id = BOND_OPT_USE_CARRIER,
		.name = "use_carrier",
		.desc = "Use netif_carrier_ok (vs MII ioctls) in miimon",
		.values = bond_use_carrier_tbl,
		.set = bond_option_use_carrier_set
	},
329 330 331 332 333 334 335 336 337 338
	[BOND_OPT_ACTIVE_SLAVE] = {
		.id = BOND_OPT_ACTIVE_SLAVE,
		.name = "active_slave",
		.desc = "Currently active slave",
		.flags = BOND_OPTFLAG_RAWVAL,
		.unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ACTIVEBACKUP) |
						BIT(BOND_MODE_TLB) |
						BIT(BOND_MODE_ALB)),
		.set = bond_option_active_slave_set
	},
339 340 341 342 343 344 345
	[BOND_OPT_QUEUE_ID] = {
		.id = BOND_OPT_QUEUE_ID,
		.name = "queue_id",
		.desc = "Set queue id of a slave",
		.flags = BOND_OPTFLAG_RAWVAL,
		.set = bond_option_queue_id_set
	},
346 347 348 349 350 351 352
	[BOND_OPT_ALL_SLAVES_ACTIVE] = {
		.id = BOND_OPT_ALL_SLAVES_ACTIVE,
		.name = "all_slaves_active",
		.desc = "Keep all frames received on an interface by setting active flag for all slaves",
		.values = bond_all_slaves_active_tbl,
		.set = bond_option_all_slaves_active_set
	},
353 354 355 356 357 358 359
	[BOND_OPT_RESEND_IGMP] = {
		.id = BOND_OPT_RESEND_IGMP,
		.name = "resend_igmp",
		.desc = "Number of IGMP membership reports to send on link failure",
		.values = bond_resend_igmp_tbl,
		.set = bond_option_resend_igmp_set
	},
360 361 362 363 364 365 366
	[BOND_OPT_LP_INTERVAL] = {
		.id = BOND_OPT_LP_INTERVAL,
		.name = "lp_interval",
		.desc = "The number of seconds between instances where the bonding driver sends learning packets to each slave's peer switch",
		.values = bond_lp_interval_tbl,
		.set = bond_option_lp_interval_set
	},
367 368 369 370 371 372 373
	[BOND_OPT_SLAVES] = {
		.id = BOND_OPT_SLAVES,
		.name = "slaves",
		.desc = "Slave membership management",
		.flags = BOND_OPTFLAG_RAWVAL,
		.set = bond_option_slaves_set
	},
374 375
	[BOND_OPT_TLB_DYNAMIC_LB] = {
		.id = BOND_OPT_TLB_DYNAMIC_LB,
376
		.name = "tlb_dynamic_lb",
377 378 379 380 381 382
		.desc = "Enable dynamic flow shuffling",
		.unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_TLB)),
		.values = bond_tlb_dynamic_lb_tbl,
		.flags = BOND_OPTFLAG_IFDOWN,
		.set = bond_option_tlb_dynamic_lb_set,
	},
383 384 385
	{ }
};

386 387 388 389 390 391 392 393 394 395 396 397 398 399 400
/* Searches for an option by name */
const struct bond_option *bond_opt_get_by_name(const char *name)
{
	const struct bond_option *opt;
	int option;

	for (option = 0; option < BOND_OPT_LAST; option++) {
		opt = bond_opt_get(option);
		if (opt && !strcmp(opt->name, name))
			return opt;
	}

	return NULL;
}

401
/* Searches for a value in opt's values[] table */
402
const struct bond_opt_value *bond_opt_get_val(unsigned int option, u64 val)
403
{
404
	const struct bond_option *opt;
405 406 407 408 409 410 411 412 413 414 415 416 417
	int i;

	opt = bond_opt_get(option);
	if (WARN_ON(!opt))
		return NULL;
	for (i = 0; opt->values && opt->values[i].string; i++)
		if (opt->values[i].value == val)
			return &opt->values[i];

	return NULL;
}

/* Searches for a value in opt's values[] table which matches the flagmask */
418
static const struct bond_opt_value *bond_opt_get_flags(const struct bond_option *opt,
419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434
						 u32 flagmask)
{
	int i;

	for (i = 0; opt->values && opt->values[i].string; i++)
		if (opt->values[i].flags & flagmask)
			return &opt->values[i];

	return NULL;
}

/* If maxval is missing then there's no range to check. In case minval is
 * missing then it's considered to be 0.
 */
static bool bond_opt_check_range(const struct bond_option *opt, u64 val)
{
435
	const struct bond_opt_value *minval, *maxval;
436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454

	minval = bond_opt_get_flags(opt, BOND_VALFLAG_MIN);
	maxval = bond_opt_get_flags(opt, BOND_VALFLAG_MAX);
	if (!maxval || (minval && val < minval->value) || val > maxval->value)
		return false;

	return true;
}

/**
 * bond_opt_parse - parse option value
 * @opt: the option to parse against
 * @val: value to parse
 *
 * This function tries to extract the value from @val and check if it's
 * a possible match for the option and returns NULL if a match isn't found,
 * or the struct_opt_value that matched. It also strips the new line from
 * @val->string if it's present.
 */
455 456
const struct bond_opt_value *bond_opt_parse(const struct bond_option *opt,
					    struct bond_opt_value *val)
457 458
{
	char *p, valstr[BOND_OPT_MAX_NAMELEN + 1] = { 0, };
459 460
	const struct bond_opt_value *tbl;
	const struct bond_opt_value *ret = NULL;
461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538
	bool checkval;
	int i, rv;

	/* No parsing if the option wants a raw val */
	if (opt->flags & BOND_OPTFLAG_RAWVAL)
		return val;

	tbl = opt->values;
	if (!tbl)
		goto out;

	/* ULLONG_MAX is used to bypass string processing */
	checkval = val->value != ULLONG_MAX;
	if (!checkval) {
		if (!val->string)
			goto out;
		p = strchr(val->string, '\n');
		if (p)
			*p = '\0';
		for (p = val->string; *p; p++)
			if (!(isdigit(*p) || isspace(*p)))
				break;
		/* The following code extracts the string to match or the value
		 * and sets checkval appropriately
		 */
		if (*p) {
			rv = sscanf(val->string, "%32s", valstr);
		} else {
			rv = sscanf(val->string, "%llu", &val->value);
			checkval = true;
		}
		if (!rv)
			goto out;
	}

	for (i = 0; tbl[i].string; i++) {
		/* Check for exact match */
		if (checkval) {
			if (val->value == tbl[i].value)
				ret = &tbl[i];
		} else {
			if (!strcmp(valstr, "default") &&
			    (tbl[i].flags & BOND_VALFLAG_DEFAULT))
				ret = &tbl[i];

			if (!strcmp(valstr, tbl[i].string))
				ret = &tbl[i];
		}
		/* Found an exact match */
		if (ret)
			goto out;
	}
	/* Possible range match */
	if (checkval && bond_opt_check_range(opt, val->value))
		ret = val;
out:
	return ret;
}

/* Check opt's dependencies against bond mode and currently set options */
static int bond_opt_check_deps(struct bonding *bond,
			       const struct bond_option *opt)
{
	struct bond_params *params = &bond->params;

	if (test_bit(params->mode, &opt->unsuppmodes))
		return -EACCES;
	if ((opt->flags & BOND_OPTFLAG_NOSLAVES) && bond_has_slaves(bond))
		return -ENOTEMPTY;
	if ((opt->flags & BOND_OPTFLAG_IFDOWN) && (bond->dev->flags & IFF_UP))
		return -EBUSY;

	return 0;
}

static void bond_opt_dep_print(struct bonding *bond,
			       const struct bond_option *opt)
{
539
	const struct bond_opt_value *modeval;
540 541 542
	struct bond_params *params;

	params = &bond->params;
543
	modeval = bond_opt_get_val(BOND_OPT_MODE, params->mode);
544
	if (test_bit(params->mode, &opt->unsuppmodes))
545 546
		netdev_err(bond->dev, "option %s: mode dependency failed, not supported in mode %s(%llu)\n",
			   opt->name, modeval->string, modeval->value);
547 548 549 550
}

static void bond_opt_error_interpret(struct bonding *bond,
				     const struct bond_option *opt,
551
				     int error, const struct bond_opt_value *val)
552
{
553
	const struct bond_opt_value *minval, *maxval;
554 555 556 557 558 559 560 561 562 563
	char *p;

	switch (error) {
	case -EINVAL:
		if (val) {
			if (val->string) {
				/* sometimes RAWVAL opts may have new lines */
				p = strchr(val->string, '\n');
				if (p)
					*p = '\0';
564 565
				netdev_err(bond->dev, "option %s: invalid value (%s)\n",
					   opt->name, val->string);
566
			} else {
567 568
				netdev_err(bond->dev, "option %s: invalid value (%llu)\n",
					   opt->name, val->value);
569 570 571 572 573 574
			}
		}
		minval = bond_opt_get_flags(opt, BOND_VALFLAG_MIN);
		maxval = bond_opt_get_flags(opt, BOND_VALFLAG_MAX);
		if (!maxval)
			break;
575 576
		netdev_err(bond->dev, "option %s: allowed values %llu - %llu\n",
			   opt->name, minval ? minval->value : 0, maxval->value);
577 578 579 580 581
		break;
	case -EACCES:
		bond_opt_dep_print(bond, opt);
		break;
	case -ENOTEMPTY:
582 583
		netdev_err(bond->dev, "option %s: unable to set because the bond device has slaves\n",
			   opt->name);
584 585
		break;
	case -EBUSY:
586 587
		netdev_err(bond->dev, "option %s: unable to set because the bond device is up\n",
			   opt->name);
588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606
		break;
	default:
		break;
	}
}

/**
 * __bond_opt_set - set a bonding option
 * @bond: target bond device
 * @option: option to set
 * @val: value to set it to
 *
 * This function is used to change the bond's option value, it can be
 * used for both enabling/changing an option and for disabling it. RTNL lock
 * must be obtained before calling this function.
 */
int __bond_opt_set(struct bonding *bond,
		   unsigned int option, struct bond_opt_value *val)
{
607
	const struct bond_opt_value *retval = NULL;
608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627
	const struct bond_option *opt;
	int ret = -ENOENT;

	ASSERT_RTNL();

	opt = bond_opt_get(option);
	if (WARN_ON(!val) || WARN_ON(!opt))
		goto out;
	ret = bond_opt_check_deps(bond, opt);
	if (ret)
		goto out;
	retval = bond_opt_parse(opt, val);
	if (!retval) {
		ret = -EINVAL;
		goto out;
	}
	ret = opt->set(bond, retval);
out:
	if (ret)
		bond_opt_error_interpret(bond, opt, ret, val);
628 629
	else
		call_netdevice_notifiers(NETDEV_CHANGEINFODATA, bond->dev);
630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663

	return ret;
}

/**
 * bond_opt_tryset_rtnl - try to acquire rtnl and call __bond_opt_set
 * @bond: target bond device
 * @option: option to set
 * @buf: value to set it to
 *
 * This function tries to acquire RTNL without blocking and if successful
 * calls __bond_opt_set. It is mainly used for sysfs option manipulation.
 */
int bond_opt_tryset_rtnl(struct bonding *bond, unsigned int option, char *buf)
{
	struct bond_opt_value optval;
	int ret;

	if (!rtnl_trylock())
		return restart_syscall();
	bond_opt_initstr(&optval, buf);
	ret = __bond_opt_set(bond, option, &optval);
	rtnl_unlock();

	return ret;
}

/**
 * bond_opt_get - get a pointer to an option
 * @option: option for which to return a pointer
 *
 * This function checks if option is valid and if so returns a pointer
 * to its entry in the bond_opts[] option array.
 */
664
const struct bond_option *bond_opt_get(unsigned int option)
665 666 667 668 669 670 671
{
	if (!BOND_OPT_VALID(option))
		return NULL;

	return &bond_opts[option];
}

672 673
static int bond_option_mode_set(struct bonding *bond,
				const struct bond_opt_value *newval)
674
{
675
	if (!bond_mode_uses_arp(newval->value) && bond->params.arp_interval) {
676 677
		netdev_info(bond->dev, "%s mode is incompatible with arp monitoring, start mii monitoring\n",
			    newval->string);
678 679 680 681
		/* disable arp monitoring */
		bond->params.arp_interval = 0;
		/* set miimon to default value */
		bond->params.miimon = BOND_DEFAULT_MIIMON;
682 683
		netdev_info(bond->dev, "Setting MII monitoring interval to %d\n",
			    bond->params.miimon);
684 685 686 687
	}

	/* don't cache arp_validate between modes */
	bond->params.arp_validate = BOND_ARP_VALIDATE_NONE;
688 689
	bond->params.mode = newval->value;

690 691
	return 0;
}
692

693 694 695
static struct net_device *__bond_option_active_slave_get(struct bonding *bond,
							 struct slave *slave)
{
696
	return bond_uses_primary(bond) && slave ? slave->dev : NULL;
697 698 699 700 701 702 703 704 705
}

struct net_device *bond_option_active_slave_get_rcu(struct bonding *bond)
{
	struct slave *slave = rcu_dereference(bond->curr_active_slave);

	return __bond_option_active_slave_get(bond, slave);
}

706
static int bond_option_active_slave_set(struct bonding *bond,
707
					const struct bond_opt_value *newval)
708
{
709 710
	char ifname[IFNAMSIZ] = { 0, };
	struct net_device *slave_dev;
711 712
	int ret = 0;

713 714 715 716 717 718 719 720 721
	sscanf(newval->string, "%15s", ifname); /* IFNAMSIZ */
	if (!strlen(ifname) || newval->string[0] == '\n') {
		slave_dev = NULL;
	} else {
		slave_dev = __dev_get_by_name(dev_net(bond->dev), ifname);
		if (!slave_dev)
			return -ENODEV;
	}

722 723
	if (slave_dev) {
		if (!netif_is_bond_slave(slave_dev)) {
724 725
			netdev_err(bond->dev, "Device %s is not bonding slave\n",
				   slave_dev->name);
726 727 728 729
			return -EINVAL;
		}

		if (bond->dev != netdev_master_upper_dev_get(slave_dev)) {
730 731
			netdev_err(bond->dev, "Device %s is not our slave\n",
				   slave_dev->name);
732 733 734 735 736 737 738 739 740
			return -EINVAL;
		}
	}

	block_netpoll_tx();
	write_lock_bh(&bond->curr_slave_lock);

	/* check to see if we are clearing active */
	if (!slave_dev) {
741
		netdev_info(bond->dev, "Clearing current active slave\n");
742
		RCU_INIT_POINTER(bond->curr_active_slave, NULL);
743 744
		bond_select_active_slave(bond);
	} else {
745
		struct slave *old_active = bond_deref_active_protected(bond);
746 747 748 749 750 751
		struct slave *new_active = bond_slave_get_rtnl(slave_dev);

		BUG_ON(!new_active);

		if (new_active == old_active) {
			/* do nothing */
752 753
			netdev_info(bond->dev, "%s is already the current active slave\n",
				    new_active->dev->name);
754 755
		} else {
			if (old_active && (new_active->link == BOND_LINK_UP) &&
756
			    bond_slave_is_up(new_active)) {
757 758
				netdev_info(bond->dev, "Setting %s as active slave\n",
					    new_active->dev->name);
759 760
				bond_change_active_slave(bond, new_active);
			} else {
761 762 763
				netdev_err(bond->dev, "Could not set %s as active slave; either %s is down or the link is down\n",
					   new_active->dev->name,
					   new_active->dev->name);
764 765 766 767 768 769 770
				ret = -EINVAL;
			}
		}
	}

	write_unlock_bh(&bond->curr_slave_lock);
	unblock_netpoll_tx();
771

772 773
	return ret;
}
774

775 776 777 778
/* There are two tricky bits here.  First, if MII monitoring is activated, then
 * we must disable ARP monitoring.  Second, if the timer isn't running, we must
 * start it.
 */
779
static int bond_option_miimon_set(struct bonding *bond,
780
				  const struct bond_opt_value *newval)
781
{
782 783
	netdev_info(bond->dev, "Setting MII monitoring interval to %llu\n",
		    newval->value);
784
	bond->params.miimon = newval->value;
785
	if (bond->params.updelay)
786
		netdev_info(bond->dev, "Note: Updating updelay (to %d) since it is a multiple of the miimon value\n",
787 788
			bond->params.updelay * bond->params.miimon);
	if (bond->params.downdelay)
789 790
		netdev_info(bond->dev, "Note: Updating downdelay (to %d) since it is a multiple of the miimon value\n",
			    bond->params.downdelay * bond->params.miimon);
791
	if (newval->value && bond->params.arp_interval) {
792
		netdev_info(bond->dev, "MII monitoring cannot be used with ARP monitoring - disabling ARP monitoring...\n");
793 794 795 796 797 798 799 800 801 802
		bond->params.arp_interval = 0;
		if (bond->params.arp_validate)
			bond->params.arp_validate = BOND_ARP_VALIDATE_NONE;
	}
	if (bond->dev->flags & IFF_UP) {
		/* If the interface is up, we may need to fire off
		 * the MII timer. If the interface is down, the
		 * timer will get fired off when the open function
		 * is called.
		 */
803
		if (!newval->value) {
804 805 806 807 808 809
			cancel_delayed_work_sync(&bond->mii_work);
		} else {
			cancel_delayed_work_sync(&bond->arp_work);
			queue_delayed_work(bond->wq, &bond->mii_work, 0);
		}
	}
810

811 812
	return 0;
}
813

814 815 816 817
/* Set up and down delays. These must be multiples of the
 * MII monitoring value, and are stored internally as the multiplier.
 * Thus, we must translate to MS for the real world.
 */
818
static int bond_option_updelay_set(struct bonding *bond,
819
				   const struct bond_opt_value *newval)
820
{
N
Nikolay Aleksandrov 已提交
821 822
	int value = newval->value;

823
	if (!bond->params.miimon) {
824
		netdev_err(bond->dev, "Unable to set up delay as MII monitoring is disabled\n");
825 826
		return -EPERM;
	}
N
Nikolay Aleksandrov 已提交
827
	if ((value % bond->params.miimon) != 0) {
828 829 830 831
		netdev_warn(bond->dev, "up delay (%d) is not a multiple of miimon (%d), updelay rounded to %d ms\n",
			    value, bond->params.miimon,
			    (value / bond->params.miimon) *
			    bond->params.miimon);
832
	}
N
Nikolay Aleksandrov 已提交
833
	bond->params.updelay = value / bond->params.miimon;
834 835
	netdev_info(bond->dev, "Setting up delay to %d\n",
		    bond->params.updelay * bond->params.miimon);
836 837 838

	return 0;
}
839

840
static int bond_option_downdelay_set(struct bonding *bond,
841
				     const struct bond_opt_value *newval)
842
{
N
Nikolay Aleksandrov 已提交
843 844
	int value = newval->value;

845
	if (!bond->params.miimon) {
846
		netdev_err(bond->dev, "Unable to set down delay as MII monitoring is disabled\n");
847 848
		return -EPERM;
	}
N
Nikolay Aleksandrov 已提交
849
	if ((value % bond->params.miimon) != 0) {
850 851 852 853
		netdev_warn(bond->dev, "down delay (%d) is not a multiple of miimon (%d), delay rounded to %d ms\n",
			    value, bond->params.miimon,
			    (value / bond->params.miimon) *
			    bond->params.miimon);
854
	}
N
Nikolay Aleksandrov 已提交
855
	bond->params.downdelay = value / bond->params.miimon;
856 857
	netdev_info(bond->dev, "Setting down delay to %d\n",
		    bond->params.downdelay * bond->params.miimon);
858 859 860

	return 0;
}
861

862
static int bond_option_use_carrier_set(struct bonding *bond,
863
				       const struct bond_opt_value *newval)
864
{
865 866
	netdev_info(bond->dev, "Setting use_carrier to %llu\n",
		    newval->value);
867
	bond->params.use_carrier = newval->value;
868 869 870

	return 0;
}
871

872 873 874 875
/* There are two tricky bits here.  First, if ARP monitoring is activated, then
 * we must disable MII monitoring.  Second, if the ARP timer isn't running,
 * we must start it.
 */
876
static int bond_option_arp_interval_set(struct bonding *bond,
877
					const struct bond_opt_value *newval)
878
{
879 880
	netdev_info(bond->dev, "Setting ARP monitoring interval to %llu\n",
		    newval->value);
881 882
	bond->params.arp_interval = newval->value;
	if (newval->value) {
883
		if (bond->params.miimon) {
884
			netdev_info(bond->dev, "ARP monitoring cannot be used with MII monitoring. Disabling MII monitoring\n");
885 886 887
			bond->params.miimon = 0;
		}
		if (!bond->params.arp_targets[0])
888
			netdev_info(bond->dev, "ARP monitoring has been set up, but no ARP targets have been specified\n");
889 890 891 892 893 894 895
	}
	if (bond->dev->flags & IFF_UP) {
		/* If the interface is up, we may need to fire off
		 * the ARP timer.  If the interface is down, the
		 * timer will get fired off when the open function
		 * is called.
		 */
896
		if (!newval->value) {
897 898 899 900 901
			if (bond->params.arp_validate)
				bond->recv_probe = NULL;
			cancel_delayed_work_sync(&bond->arp_work);
		} else {
			/* arp_validate can be set only in active-backup mode */
902
			bond->recv_probe = bond_arp_rcv;
903 904 905 906 907 908 909
			cancel_delayed_work_sync(&bond->mii_work);
			queue_delayed_work(bond->wq, &bond->arp_work, 0);
		}
	}

	return 0;
}
910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930

static void _bond_options_arp_ip_target_set(struct bonding *bond, int slot,
					    __be32 target,
					    unsigned long last_rx)
{
	__be32 *targets = bond->params.arp_targets;
	struct list_head *iter;
	struct slave *slave;

	if (slot >= 0 && slot < BOND_MAX_ARP_TARGETS) {
		bond_for_each_slave(bond, slave, iter)
			slave->target_last_arp_rx[slot] = last_rx;
		targets[slot] = target;
	}
}

static int _bond_option_arp_ip_target_add(struct bonding *bond, __be32 target)
{
	__be32 *targets = bond->params.arp_targets;
	int ind;

931
	if (!bond_is_ip_target_ok(target)) {
932 933
		netdev_err(bond->dev, "invalid ARP target %pI4 specified for addition\n",
			   &target);
934 935 936 937
		return -EINVAL;
	}

	if (bond_get_targets_ip(targets, target) != -1) { /* dup */
938 939
		netdev_err(bond->dev, "ARP target %pI4 is already present\n",
			   &target);
940 941 942 943 944
		return -EINVAL;
	}

	ind = bond_get_targets_ip(targets, 0); /* first free slot */
	if (ind == -1) {
945
		netdev_err(bond->dev, "ARP target table is full!\n");
946 947 948
		return -EINVAL;
	}

949
	netdev_info(bond->dev, "Adding ARP target %pI4\n", &target);
950 951 952 953 954 955

	_bond_options_arp_ip_target_set(bond, ind, target, jiffies);

	return 0;
}

956
static int bond_option_arp_ip_target_add(struct bonding *bond, __be32 target)
957 958 959 960 961 962 963 964 965 966 967
{
	int ret;

	/* not to race with bond_arp_rcv */
	write_lock_bh(&bond->lock);
	ret = _bond_option_arp_ip_target_add(bond, target);
	write_unlock_bh(&bond->lock);

	return ret;
}

968
static int bond_option_arp_ip_target_rem(struct bonding *bond, __be32 target)
969 970 971 972 973 974 975
{
	__be32 *targets = bond->params.arp_targets;
	struct list_head *iter;
	struct slave *slave;
	unsigned long *targets_rx;
	int ind, i;

976
	if (!bond_is_ip_target_ok(target)) {
977 978
		netdev_err(bond->dev, "invalid ARP target %pI4 specified for removal\n",
			   &target);
979 980 981 982 983
		return -EINVAL;
	}

	ind = bond_get_targets_ip(targets, target);
	if (ind == -1) {
984 985
		netdev_err(bond->dev, "unable to remove nonexistent ARP target %pI4\n",
			   &target);
986 987 988 989
		return -EINVAL;
	}

	if (ind == 0 && !targets[1] && bond->params.arp_interval)
990
		netdev_warn(bond->dev, "Removing last arp target with arp_interval on\n");
991

992
	netdev_info(bond->dev, "Removing ARP target %pI4\n", &target);
993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011

	/* not to race with bond_arp_rcv */
	write_lock_bh(&bond->lock);

	bond_for_each_slave(bond, slave, iter) {
		targets_rx = slave->target_last_arp_rx;
		for (i = ind; (i < BOND_MAX_ARP_TARGETS-1) && targets[i+1]; i++)
			targets_rx[i] = targets_rx[i+1];
		targets_rx[i] = 0;
	}
	for (i = ind; (i < BOND_MAX_ARP_TARGETS-1) && targets[i+1]; i++)
		targets[i] = targets[i+1];
	targets[i] = 0;

	write_unlock_bh(&bond->lock);

	return 0;
}

1012
void bond_option_arp_ip_targets_clear(struct bonding *bond)
1013
{
1014
	int i;
1015 1016 1017 1018 1019

	/* not to race with bond_arp_rcv */
	write_lock_bh(&bond->lock);
	for (i = 0; i < BOND_MAX_ARP_TARGETS; i++)
		_bond_options_arp_ip_target_set(bond, i, 0, 0);
1020 1021
	write_unlock_bh(&bond->lock);
}
1022

1023
static int bond_option_arp_ip_targets_set(struct bonding *bond,
1024
					  const struct bond_opt_value *newval)
1025 1026 1027 1028 1029 1030
{
	int ret = -EPERM;
	__be32 target;

	if (newval->string) {
		if (!in4_pton(newval->string+1, -1, (u8 *)&target, -1, NULL)) {
1031 1032
			netdev_err(bond->dev, "invalid ARP target %pI4 specified\n",
				   &target);
1033 1034 1035 1036 1037 1038 1039
			return ret;
		}
		if (newval->string[0] == '+')
			ret = bond_option_arp_ip_target_add(bond, target);
		else if (newval->string[0] == '-')
			ret = bond_option_arp_ip_target_rem(bond, target);
		else
1040
			netdev_err(bond->dev, "no command found in arp_ip_targets file - use +<addr> or -<addr>\n");
1041 1042 1043
	} else {
		target = newval->value;
		ret = bond_option_arp_ip_target_add(bond, target);
1044 1045 1046 1047
	}

	return ret;
}
1048

1049
static int bond_option_arp_validate_set(struct bonding *bond,
1050
					const struct bond_opt_value *newval)
1051
{
1052 1053
	netdev_info(bond->dev, "Setting arp_validate to %s (%llu)\n",
		    newval->string, newval->value);
1054 1055

	if (bond->dev->flags & IFF_UP) {
1056
		if (!newval->value)
1057 1058 1059 1060
			bond->recv_probe = NULL;
		else if (bond->params.arp_interval)
			bond->recv_probe = bond_arp_rcv;
	}
1061
	bond->params.arp_validate = newval->value;
1062 1063 1064

	return 0;
}
1065

1066
static int bond_option_arp_all_targets_set(struct bonding *bond,
1067
					   const struct bond_opt_value *newval)
1068
{
1069 1070
	netdev_info(bond->dev, "Setting arp_all_targets to %s (%llu)\n",
		    newval->string, newval->value);
1071
	bond->params.arp_all_targets = newval->value;
1072 1073 1074

	return 0;
}
1075

1076
static int bond_option_primary_set(struct bonding *bond,
1077
				   const struct bond_opt_value *newval)
1078
{
1079
	char *p, *primary = newval->string;
1080 1081 1082 1083 1084 1085 1086
	struct list_head *iter;
	struct slave *slave;

	block_netpoll_tx();
	read_lock(&bond->lock);
	write_lock_bh(&bond->curr_slave_lock);

1087 1088 1089
	p = strchr(primary, '\n');
	if (p)
		*p = '\0';
1090 1091
	/* check to see if we are clearing primary */
	if (!strlen(primary)) {
1092
		netdev_info(bond->dev, "Setting primary slave to None\n");
1093 1094 1095 1096 1097 1098 1099 1100
		bond->primary_slave = NULL;
		memset(bond->params.primary, 0, sizeof(bond->params.primary));
		bond_select_active_slave(bond);
		goto out;
	}

	bond_for_each_slave(bond, slave, iter) {
		if (strncmp(slave->dev->name, primary, IFNAMSIZ) == 0) {
1101 1102
			netdev_info(bond->dev, "Setting %s as primary slave\n",
				    slave->dev->name);
1103 1104 1105 1106 1107 1108 1109
			bond->primary_slave = slave;
			strcpy(bond->params.primary, slave->dev->name);
			bond_select_active_slave(bond);
			goto out;
		}
	}

1110
	if (bond->primary_slave) {
1111
		netdev_info(bond->dev, "Setting primary slave to None\n");
1112 1113 1114
		bond->primary_slave = NULL;
		bond_select_active_slave(bond);
	}
1115 1116 1117
	strncpy(bond->params.primary, primary, IFNAMSIZ);
	bond->params.primary[IFNAMSIZ - 1] = 0;

1118 1119
	netdev_info(bond->dev, "Recording %s as primary, but it has not been enslaved to %s yet\n",
		    primary, bond->dev->name);
1120 1121 1122 1123 1124 1125

out:
	write_unlock_bh(&bond->curr_slave_lock);
	read_unlock(&bond->lock);
	unblock_netpoll_tx();

1126
	return 0;
1127
}
1128

1129
static int bond_option_primary_reselect_set(struct bonding *bond,
1130
					    const struct bond_opt_value *newval)
1131
{
1132 1133
	netdev_info(bond->dev, "Setting primary_reselect to %s (%llu)\n",
		    newval->string, newval->value);
1134
	bond->params.primary_reselect = newval->value;
1135 1136 1137 1138 1139 1140 1141 1142 1143

	block_netpoll_tx();
	write_lock_bh(&bond->curr_slave_lock);
	bond_select_active_slave(bond);
	write_unlock_bh(&bond->curr_slave_lock);
	unblock_netpoll_tx();

	return 0;
}
1144

1145
static int bond_option_fail_over_mac_set(struct bonding *bond,
1146
					 const struct bond_opt_value *newval)
1147
{
1148 1149
	netdev_info(bond->dev, "Setting fail_over_mac to %s (%llu)\n",
		    newval->string, newval->value);
1150
	bond->params.fail_over_mac = newval->value;
1151 1152 1153

	return 0;
}
1154

1155
static int bond_option_xmit_hash_policy_set(struct bonding *bond,
1156
					    const struct bond_opt_value *newval)
1157
{
1158 1159
	netdev_info(bond->dev, "Setting xmit hash policy to %s (%llu)\n",
		    newval->string, newval->value);
1160
	bond->params.xmit_policy = newval->value;
1161 1162 1163

	return 0;
}
1164

1165
static int bond_option_resend_igmp_set(struct bonding *bond,
1166
				       const struct bond_opt_value *newval)
1167
{
1168 1169
	netdev_info(bond->dev, "Setting resend_igmp to %llu\n",
		    newval->value);
1170
	bond->params.resend_igmp = newval->value;
1171 1172 1173

	return 0;
}
1174

1175
static int bond_option_num_peer_notif_set(struct bonding *bond,
1176
				   const struct bond_opt_value *newval)
1177
{
1178 1179
	bond->params.num_peer_notif = newval->value;

1180 1181
	return 0;
}
1182

1183
static int bond_option_all_slaves_active_set(struct bonding *bond,
1184
					     const struct bond_opt_value *newval)
1185 1186 1187 1188
{
	struct list_head *iter;
	struct slave *slave;

1189
	if (newval->value == bond->params.all_slaves_active)
1190
		return 0;
1191
	bond->params.all_slaves_active = newval->value;
1192 1193
	bond_for_each_slave(bond, slave, iter) {
		if (!bond_is_active_slave(slave)) {
1194
			if (newval->value)
1195 1196 1197 1198 1199 1200 1201 1202
				slave->inactive = 0;
			else
				slave->inactive = 1;
		}
	}

	return 0;
}
1203

1204
static int bond_option_min_links_set(struct bonding *bond,
1205
				     const struct bond_opt_value *newval)
1206
{
1207 1208
	netdev_info(bond->dev, "Setting min links value to %llu\n",
		    newval->value);
1209
	bond->params.min_links = newval->value;
1210 1211 1212

	return 0;
}
1213

1214
static int bond_option_lp_interval_set(struct bonding *bond,
1215
				       const struct bond_opt_value *newval)
1216
{
1217
	bond->params.lp_interval = newval->value;
1218 1219 1220

	return 0;
}
1221

1222
static int bond_option_pps_set(struct bonding *bond,
1223
			       const struct bond_opt_value *newval)
1224
{
1225 1226
	bond->params.packets_per_slave = newval->value;
	if (newval->value > 0) {
1227
		bond->params.reciprocal_packets_per_slave =
1228
			reciprocal_value(newval->value);
1229 1230 1231 1232 1233 1234 1235
	} else {
		/* reciprocal_packets_per_slave is unused if
		 * packets_per_slave is 0 or 1, just initialize it
		 */
		bond->params.reciprocal_packets_per_slave =
			(struct reciprocal_value) { 0 };
	}
1236 1237 1238

	return 0;
}
1239

1240
static int bond_option_lacp_rate_set(struct bonding *bond,
1241
				     const struct bond_opt_value *newval)
1242
{
1243 1244
	netdev_info(bond->dev, "Setting LACP rate to %s (%llu)\n",
		    newval->string, newval->value);
1245
	bond->params.lacp_fast = newval->value;
1246
	bond_3ad_update_lacp_rate(bond);
1247 1248 1249

	return 0;
}
1250

1251
static int bond_option_ad_select_set(struct bonding *bond,
1252
				     const struct bond_opt_value *newval)
1253
{
1254 1255
	netdev_info(bond->dev, "Setting ad_select to %s (%llu)\n",
		    newval->string, newval->value);
1256
	bond->params.ad_select = newval->value;
1257 1258 1259

	return 0;
}
1260

1261
static int bond_option_queue_id_set(struct bonding *bond,
1262
				    const struct bond_opt_value *newval)
1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283
{
	struct slave *slave, *update_slave;
	struct net_device *sdev;
	struct list_head *iter;
	char *delim;
	int ret = 0;
	u16 qid;

	/* delim will point to queue id if successful */
	delim = strchr(newval->string, ':');
	if (!delim)
		goto err_no_cmd;

	/* Terminate string that points to device name and bump it
	 * up one, so we can read the queue id there.
	 */
	*delim = '\0';
	if (sscanf(++delim, "%hd\n", &qid) != 1)
		goto err_no_cmd;

	/* Check buffer length, valid ifname and queue id */
1284
	if (!dev_valid_name(newval->string) ||
1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315
	    qid > bond->dev->real_num_tx_queues)
		goto err_no_cmd;

	/* Get the pointer to that interface if it exists */
	sdev = __dev_get_by_name(dev_net(bond->dev), newval->string);
	if (!sdev)
		goto err_no_cmd;

	/* Search for thes slave and check for duplicate qids */
	update_slave = NULL;
	bond_for_each_slave(bond, slave, iter) {
		if (sdev == slave->dev)
			/* We don't need to check the matching
			 * slave for dups, since we're overwriting it
			 */
			update_slave = slave;
		else if (qid && qid == slave->queue_id) {
			goto err_no_cmd;
		}
	}

	if (!update_slave)
		goto err_no_cmd;

	/* Actually set the qids for the slave */
	update_slave->queue_id = qid;

out:
	return ret;

err_no_cmd:
1316
	netdev_info(bond->dev, "invalid input for queue_id set\n");
1317 1318 1319 1320
	ret = -EPERM;
	goto out;

}
1321

1322
static int bond_option_slaves_set(struct bonding *bond,
1323
				  const struct bond_opt_value *newval)
1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337
{
	char command[IFNAMSIZ + 1] = { 0, };
	struct net_device *dev;
	char *ifname;
	int ret;

	sscanf(newval->string, "%16s", command); /* IFNAMSIZ*/
	ifname = command + 1;
	if ((strlen(command) <= 1) ||
	    !dev_valid_name(ifname))
		goto err_no_cmd;

	dev = __dev_get_by_name(dev_net(bond->dev), ifname);
	if (!dev) {
1338 1339
		netdev_info(bond->dev, "interface %s does not exist!\n",
			    ifname);
1340 1341 1342 1343 1344 1345
		ret = -ENODEV;
		goto out;
	}

	switch (command[0]) {
	case '+':
1346
		netdev_info(bond->dev, "Adding slave %s\n", dev->name);
1347 1348 1349 1350
		ret = bond_enslave(bond->dev, dev);
		break;

	case '-':
1351
		netdev_info(bond->dev, "Removing slave %s\n", dev->name);
1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362
		ret = bond_release(bond->dev, dev);
		break;

	default:
		goto err_no_cmd;
	}

out:
	return ret;

err_no_cmd:
1363
	netdev_err(bond->dev, "no command found in slaves file - use +ifname or -ifname\n");
1364 1365 1366
	ret = -EPERM;
	goto out;
}
1367 1368 1369 1370

static int bond_option_tlb_dynamic_lb_set(struct bonding *bond,
					  const struct bond_opt_value *newval)
{
1371 1372
	netdev_info(bond->dev, "Setting dynamic-lb to %s (%llu)\n",
		    newval->string, newval->value);
1373 1374 1375 1376
	bond->params.tlb_dynamic_lb = newval->value;

	return 0;
}