gpiolib-sysfs.c 18.5 KB
Newer Older
1 2 3 4 5 6 7 8
#include <linux/idr.h>
#include <linux/mutex.h>
#include <linux/device.h>
#include <linux/sysfs.h>
#include <linux/gpio/consumer.h>
#include <linux/gpio/driver.h>
#include <linux/interrupt.h>
#include <linux/kdev_t.h>
9
#include <linux/slab.h>
10 11 12

#include "gpiolib.h"

13 14
struct gpiod_data {
	struct gpio_desc *desc;
15
	struct kernfs_node *value_kn;
16 17
};

18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43
/* lock protects against unexport_gpio() being called while
 * sysfs files are active.
 */
static DEFINE_MUTEX(sysfs_lock);

/*
 * /sys/class/gpio/gpioN... only for GPIOs that are exported
 *   /direction
 *      * MAY BE OMITTED if kernel won't allow direction changes
 *      * is read/write as "in" or "out"
 *      * may also be written as "high" or "low", initializing
 *        output value as specified ("out" implies "low")
 *   /value
 *      * always readable, subject to hardware behavior
 *      * may be writable, as zero/nonzero
 *   /edge
 *      * configures behavior of poll(2) on /value
 *      * available only if pin can generate IRQs on input
 *      * is read/write as "none", "falling", "rising", or "both"
 *   /active_low
 *      * configures polarity of /value
 *      * is read/write as zero/nonzero
 *      * also affects existing and subsequent "falling" and "rising"
 *        /edge configuration
 */

44
static ssize_t direction_show(struct device *dev,
45 46
		struct device_attribute *attr, char *buf)
{
47 48
	struct gpiod_data *data = dev_get_drvdata(dev);
	struct gpio_desc *desc = data->desc;
49 50 51 52
	ssize_t			status;

	mutex_lock(&sysfs_lock);

53 54
	gpiod_get_direction(desc);
	status = sprintf(buf, "%s\n",
55 56 57 58 59 60 61
			test_bit(FLAG_IS_OUT, &desc->flags)
				? "out" : "in");

	mutex_unlock(&sysfs_lock);
	return status;
}

62
static ssize_t direction_store(struct device *dev,
63 64
		struct device_attribute *attr, const char *buf, size_t size)
{
65 66
	struct gpiod_data *data = dev_get_drvdata(dev);
	struct gpio_desc *desc = data->desc;
67 68 69 70
	ssize_t			status;

	mutex_lock(&sysfs_lock);

71
	if (sysfs_streq(buf, "high"))
72 73 74 75 76 77 78 79 80 81 82
		status = gpiod_direction_output_raw(desc, 1);
	else if (sysfs_streq(buf, "out") || sysfs_streq(buf, "low"))
		status = gpiod_direction_output_raw(desc, 0);
	else if (sysfs_streq(buf, "in"))
		status = gpiod_direction_input(desc);
	else
		status = -EINVAL;

	mutex_unlock(&sysfs_lock);
	return status ? : size;
}
83
static DEVICE_ATTR_RW(direction);
84

85
static ssize_t value_show(struct device *dev,
86 87
		struct device_attribute *attr, char *buf)
{
88 89
	struct gpiod_data *data = dev_get_drvdata(dev);
	struct gpio_desc *desc = data->desc;
90 91 92 93
	ssize_t			status;

	mutex_lock(&sysfs_lock);

94
	status = sprintf(buf, "%d\n", gpiod_get_value_cansleep(desc));
95 96 97 98 99

	mutex_unlock(&sysfs_lock);
	return status;
}

100
static ssize_t value_store(struct device *dev,
101 102
		struct device_attribute *attr, const char *buf, size_t size)
{
103 104
	struct gpiod_data *data = dev_get_drvdata(dev);
	struct gpio_desc *desc = data->desc;
105 106 107 108
	ssize_t			status;

	mutex_lock(&sysfs_lock);

109
	if (!test_bit(FLAG_IS_OUT, &desc->flags)) {
110
		status = -EPERM;
111
	} else {
112 113 114 115 116 117 118 119 120 121 122 123
		long		value;

		status = kstrtol(buf, 0, &value);
		if (status == 0) {
			gpiod_set_value_cansleep(desc, value);
			status = size;
		}
	}

	mutex_unlock(&sysfs_lock);
	return status;
}
124
static DEVICE_ATTR_RW(value);
125 126 127

static irqreturn_t gpio_sysfs_irq(int irq, void *priv)
{
128 129 130
	struct gpiod_data *data = priv;

	sysfs_notify_dirent(data->value_kn);
131 132 133 134

	return IRQ_HANDLED;
}

135
static int gpio_setup_irq(struct device *dev, unsigned long gpio_flags)
136
{
137 138
	struct gpiod_data	*data = dev_get_drvdata(dev);
	struct gpio_desc	*desc = data->desc;
139
	unsigned long		irq_flags;
140
	int			ret, irq;
141 142 143 144 145

	irq = gpiod_to_irq(desc);
	if (irq < 0)
		return -EIO;

146 147
	if (data->value_kn)
		free_irq(irq, data);
148 149 150 151

	desc->flags &= ~GPIO_TRIGGER_MASK;

	if (!gpio_flags) {
152
		gpiochip_unlock_as_irq(desc->chip, gpio_chip_hwgpio(desc));
153
		ret = 0;
154
		goto free_kn;
155 156 157 158 159 160 161 162 163 164
	}

	irq_flags = IRQF_SHARED;
	if (test_bit(FLAG_TRIG_FALL, &gpio_flags))
		irq_flags |= test_bit(FLAG_ACTIVE_LOW, &desc->flags) ?
			IRQF_TRIGGER_RISING : IRQF_TRIGGER_FALLING;
	if (test_bit(FLAG_TRIG_RISE, &gpio_flags))
		irq_flags |= test_bit(FLAG_ACTIVE_LOW, &desc->flags) ?
			IRQF_TRIGGER_FALLING : IRQF_TRIGGER_RISING;

165 166 167
	if (!data->value_kn) {
		data->value_kn = sysfs_get_dirent(dev->kobj.sd, "value");
		if (!data->value_kn) {
168 169 170 171 172
			ret = -ENODEV;
			goto err_out;
		}
	}

173 174 175 176 177 178 179 180 181
	/*
	 * FIXME: This should be done in the irq_request_resources callback
	 *        when the irq is requested, but a few drivers currently fail
	 *        to do so.
	 *
	 *        Remove this redundant call (along with the corresponding
	 *        unlock) when those drivers have been fixed.
	 */
	ret = gpiochip_lock_as_irq(desc->chip, gpio_chip_hwgpio(desc));
182
	if (ret < 0)
183
		goto free_kn;
184

185
	ret = request_any_context_irq(irq, gpio_sysfs_irq, irq_flags,
186
				"gpiolib", data);
187 188
	if (ret < 0)
		goto err_unlock;
189 190 191 192

	desc->flags |= gpio_flags;
	return 0;

193 194
err_unlock:
	gpiochip_unlock_as_irq(desc->chip, gpio_chip_hwgpio(desc));
195 196 197 198 199
free_kn:
	if (data->value_kn) {
		sysfs_put(data->value_kn);
		data->value_kn = NULL;
	}
200 201 202 203 204 205 206 207 208 209 210 211 212 213
err_out:
	return ret;
}

static const struct {
	const char *name;
	unsigned long flags;
} trigger_types[] = {
	{ "none",    0 },
	{ "falling", BIT(FLAG_TRIG_FALL) },
	{ "rising",  BIT(FLAG_TRIG_RISE) },
	{ "both",    BIT(FLAG_TRIG_FALL) | BIT(FLAG_TRIG_RISE) },
};

214
static ssize_t edge_show(struct device *dev,
215 216
		struct device_attribute *attr, char *buf)
{
217 218
	struct gpiod_data *data = dev_get_drvdata(dev);
	struct gpio_desc *desc = data->desc;
219 220 221
	unsigned long mask;
	ssize_t	status = 0;
	int i;
222 223 224

	mutex_lock(&sysfs_lock);

225 226 227 228 229 230
	for (i = 0; i < ARRAY_SIZE(trigger_types); i++) {
		mask = desc->flags & GPIO_TRIGGER_MASK;
		if (mask == trigger_types[i].flags) {
			status = sprintf(buf, "%s\n", trigger_types[i].name);
			break;
		}
231 232 233 234 235 236
	}

	mutex_unlock(&sysfs_lock);
	return status;
}

237
static ssize_t edge_store(struct device *dev,
238 239
		struct device_attribute *attr, const char *buf, size_t size)
{
240 241 242
	struct gpiod_data *data = dev_get_drvdata(dev);
	struct gpio_desc *desc = data->desc;
	unsigned long flags;
243 244 245 246 247 248 249 250 251
	ssize_t			status;
	int			i;

	for (i = 0; i < ARRAY_SIZE(trigger_types); i++)
		if (sysfs_streq(trigger_types[i].name, buf))
			goto found;
	return -EINVAL;

found:
252 253
	flags = trigger_types[i].flags;

254 255
	mutex_lock(&sysfs_lock);

256 257 258 259 260 261
	if ((desc->flags & GPIO_TRIGGER_MASK) == flags) {
		status = size;
		goto out_unlock;
	}

	status = gpio_setup_irq(dev, flags);
262 263
	if (!status)
		status = size;
264

265
out_unlock:
266 267 268 269
	mutex_unlock(&sysfs_lock);

	return status;
}
270
static DEVICE_ATTR_RW(edge);
271

272
static int sysfs_set_active_low(struct device *dev, int value)
273
{
274 275
	struct gpiod_data	*data = dev_get_drvdata(dev);
	struct gpio_desc	*desc = data->desc;
276 277 278 279 280 281 282 283 284 285 286
	int			status = 0;

	if (!!test_bit(FLAG_ACTIVE_LOW, &desc->flags) == !!value)
		return 0;

	if (value)
		set_bit(FLAG_ACTIVE_LOW, &desc->flags);
	else
		clear_bit(FLAG_ACTIVE_LOW, &desc->flags);

	/* reconfigure poll(2) support if enabled on one edge only */
287 288
	if (!!test_bit(FLAG_TRIG_RISE, &desc->flags) ^
				!!test_bit(FLAG_TRIG_FALL, &desc->flags)) {
289 290
		unsigned long trigger_flags = desc->flags & GPIO_TRIGGER_MASK;

291 292
		gpio_setup_irq(dev, 0);
		status = gpio_setup_irq(dev, trigger_flags);
293 294 295 296 297
	}

	return status;
}

298
static ssize_t active_low_show(struct device *dev,
299 300
		struct device_attribute *attr, char *buf)
{
301 302
	struct gpiod_data *data = dev_get_drvdata(dev);
	struct gpio_desc *desc = data->desc;
303 304 305 306
	ssize_t			status;

	mutex_lock(&sysfs_lock);

307
	status = sprintf(buf, "%d\n",
308 309 310 311 312 313 314
				!!test_bit(FLAG_ACTIVE_LOW, &desc->flags));

	mutex_unlock(&sysfs_lock);

	return status;
}

315
static ssize_t active_low_store(struct device *dev,
316 317 318
		struct device_attribute *attr, const char *buf, size_t size)
{
	ssize_t			status;
319
	long			value;
320 321 322

	mutex_lock(&sysfs_lock);

323 324
	status = kstrtol(buf, 0, &value);
	if (status == 0)
325
		status = sysfs_set_active_low(dev, value != 0);
326 327 328 329 330

	mutex_unlock(&sysfs_lock);

	return status ? : size;
}
331
static DEVICE_ATTR_RW(active_low);
332

333 334 335 336
static umode_t gpio_is_visible(struct kobject *kobj, struct attribute *attr,
			       int n)
{
	struct device *dev = container_of(kobj, struct device, kobj);
337 338
	struct gpiod_data *data = dev_get_drvdata(dev);
	struct gpio_desc *desc = data->desc;
339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354
	umode_t mode = attr->mode;
	bool show_direction = test_bit(FLAG_SYSFS_DIR, &desc->flags);

	if (attr == &dev_attr_direction.attr) {
		if (!show_direction)
			mode = 0;
	} else if (attr == &dev_attr_edge.attr) {
		if (gpiod_to_irq(desc) < 0)
			mode = 0;
		if (!show_direction && test_bit(FLAG_IS_OUT, &desc->flags))
			mode = 0;
	}

	return mode;
}

355
static struct attribute *gpio_attrs[] = {
356 357
	&dev_attr_direction.attr,
	&dev_attr_edge.attr,
358 359 360 361
	&dev_attr_value.attr,
	&dev_attr_active_low.attr,
	NULL,
};
362 363 364 365 366 367 368 369 370 371

static const struct attribute_group gpio_group = {
	.attrs = gpio_attrs,
	.is_visible = gpio_is_visible,
};

static const struct attribute_group *gpio_groups[] = {
	&gpio_group,
	NULL
};
372 373 374 375 376 377 378 379

/*
 * /sys/class/gpio/gpiochipN/
 *   /base ... matching gpio_chip.base (N)
 *   /label ... matching gpio_chip.label
 *   /ngpio ... matching gpio_chip.ngpio
 */

380
static ssize_t base_show(struct device *dev,
381 382 383 384 385 386
			       struct device_attribute *attr, char *buf)
{
	const struct gpio_chip	*chip = dev_get_drvdata(dev);

	return sprintf(buf, "%d\n", chip->base);
}
387
static DEVICE_ATTR_RO(base);
388

389
static ssize_t label_show(struct device *dev,
390 391 392 393 394 395
			       struct device_attribute *attr, char *buf)
{
	const struct gpio_chip	*chip = dev_get_drvdata(dev);

	return sprintf(buf, "%s\n", chip->label ? : "");
}
396
static DEVICE_ATTR_RO(label);
397

398
static ssize_t ngpio_show(struct device *dev,
399 400 401 402 403 404
			       struct device_attribute *attr, char *buf)
{
	const struct gpio_chip	*chip = dev_get_drvdata(dev);

	return sprintf(buf, "%u\n", chip->ngpio);
}
405
static DEVICE_ATTR_RO(ngpio);
406

407
static struct attribute *gpiochip_attrs[] = {
408 409 410 411 412
	&dev_attr_base.attr,
	&dev_attr_label.attr,
	&dev_attr_ngpio.attr,
	NULL,
};
413
ATTRIBUTE_GROUPS(gpiochip);
414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528

/*
 * /sys/class/gpio/export ... write-only
 *	integer N ... number of GPIO to export (full access)
 * /sys/class/gpio/unexport ... write-only
 *	integer N ... number of GPIO to unexport
 */
static ssize_t export_store(struct class *class,
				struct class_attribute *attr,
				const char *buf, size_t len)
{
	long			gpio;
	struct gpio_desc	*desc;
	int			status;

	status = kstrtol(buf, 0, &gpio);
	if (status < 0)
		goto done;

	desc = gpio_to_desc(gpio);
	/* reject invalid GPIOs */
	if (!desc) {
		pr_warn("%s: invalid GPIO %ld\n", __func__, gpio);
		return -EINVAL;
	}

	/* No extra locking here; FLAG_SYSFS just signifies that the
	 * request and export were done by on behalf of userspace, so
	 * they may be undone on its behalf too.
	 */

	status = gpiod_request(desc, "sysfs");
	if (status < 0) {
		if (status == -EPROBE_DEFER)
			status = -ENODEV;
		goto done;
	}
	status = gpiod_export(desc, true);
	if (status < 0)
		gpiod_free(desc);
	else
		set_bit(FLAG_SYSFS, &desc->flags);

done:
	if (status)
		pr_debug("%s: status %d\n", __func__, status);
	return status ? : len;
}

static ssize_t unexport_store(struct class *class,
				struct class_attribute *attr,
				const char *buf, size_t len)
{
	long			gpio;
	struct gpio_desc	*desc;
	int			status;

	status = kstrtol(buf, 0, &gpio);
	if (status < 0)
		goto done;

	desc = gpio_to_desc(gpio);
	/* reject bogus commands (gpio_unexport ignores them) */
	if (!desc) {
		pr_warn("%s: invalid GPIO %ld\n", __func__, gpio);
		return -EINVAL;
	}

	status = -EINVAL;

	/* No extra locking here; FLAG_SYSFS just signifies that the
	 * request and export were done by on behalf of userspace, so
	 * they may be undone on its behalf too.
	 */
	if (test_and_clear_bit(FLAG_SYSFS, &desc->flags)) {
		status = 0;
		gpiod_free(desc);
	}
done:
	if (status)
		pr_debug("%s: status %d\n", __func__, status);
	return status ? : len;
}

static struct class_attribute gpio_class_attrs[] = {
	__ATTR(export, 0200, NULL, export_store),
	__ATTR(unexport, 0200, NULL, unexport_store),
	__ATTR_NULL,
};

static struct class gpio_class = {
	.name =		"gpio",
	.owner =	THIS_MODULE,

	.class_attrs =	gpio_class_attrs,
};


/**
 * gpiod_export - export a GPIO through sysfs
 * @gpio: gpio to make available, already requested
 * @direction_may_change: true if userspace may change gpio direction
 * Context: arch_initcall or later
 *
 * When drivers want to make a GPIO accessible to userspace after they
 * have requested it -- perhaps while debugging, or as part of their
 * public interface -- they may use this routine.  If the GPIO can
 * change direction (some can't) and the caller allows it, userspace
 * will see "direction" sysfs attribute which may be used to change
 * the gpio's direction.  A "value" attribute will always be provided.
 *
 * Returns zero on success, else an error.
 */
int gpiod_export(struct gpio_desc *desc, bool direction_may_change)
{
529
	struct gpio_chip	*chip;
530
	struct gpiod_data	*data;
531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547
	unsigned long		flags;
	int			status;
	const char		*ioname = NULL;
	struct device		*dev;
	int			offset;

	/* can't export until sysfs is available ... */
	if (!gpio_class.p) {
		pr_debug("%s: called too early!\n", __func__);
		return -ENOENT;
	}

	if (!desc) {
		pr_debug("%s: invalid gpio descriptor\n", __func__);
		return -EINVAL;
	}

548 549
	chip = desc->chip;

550 551
	mutex_lock(&sysfs_lock);

552
	/* check if chip is being removed */
553
	if (!chip || !chip->cdev) {
554
		status = -ENODEV;
555
		goto err_unlock;
556 557
	}

558 559 560 561 562 563 564 565 566
	spin_lock_irqsave(&gpio_lock, flags);
	if (!test_bit(FLAG_REQUESTED, &desc->flags) ||
	     test_bit(FLAG_EXPORT, &desc->flags)) {
		spin_unlock_irqrestore(&gpio_lock, flags);
		gpiod_dbg(desc, "%s: unavailable (requested=%d, exported=%d)\n",
				__func__,
				test_bit(FLAG_REQUESTED, &desc->flags),
				test_bit(FLAG_EXPORT, &desc->flags));
		status = -EPERM;
567
		goto err_unlock;
568 569
	}

570
	if (chip->direction_input && chip->direction_output &&
571 572 573 574
			direction_may_change) {
		set_bit(FLAG_SYSFS_DIR, &desc->flags);
	}

575 576
	spin_unlock_irqrestore(&gpio_lock, flags);

577 578 579 580 581 582 583 584
	data = kzalloc(sizeof(*data), GFP_KERNEL);
	if (!data) {
		status = -ENOMEM;
		goto err_unlock;
	}

	data->desc = desc;

585
	offset = gpio_chip_hwgpio(desc);
586 587
	if (chip->names && chip->names[offset])
		ioname = chip->names[offset];
588

589
	dev = device_create_with_groups(&gpio_class, chip->dev,
590
					MKDEV(0, 0), data, gpio_groups,
591 592
					ioname ? ioname : "gpio%u",
					desc_to_gpio(desc));
593 594
	if (IS_ERR(dev)) {
		status = PTR_ERR(dev);
595
		goto err_free_data;
596 597 598 599 600 601
	}

	set_bit(FLAG_EXPORT, &desc->flags);
	mutex_unlock(&sysfs_lock);
	return 0;

602 603 604
err_free_data:
	kfree(data);
err_unlock:
605 606 607 608 609 610
	mutex_unlock(&sysfs_lock);
	gpiod_dbg(desc, "%s: status %d\n", __func__, status);
	return status;
}
EXPORT_SYMBOL_GPL(gpiod_export);

611
static int match_export(struct device *dev, const void *desc)
612
{
613 614 615
	struct gpiod_data *data = dev_get_drvdata(dev);

	return data->desc == desc;
616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647
}

/**
 * gpiod_export_link - create a sysfs link to an exported GPIO node
 * @dev: device under which to create symlink
 * @name: name of the symlink
 * @gpio: gpio to create symlink to, already exported
 *
 * Set up a symlink from /sys/.../dev/name to /sys/class/gpio/gpioN
 * node. Caller is responsible for unlinking.
 *
 * Returns zero on success, else an error.
 */
int gpiod_export_link(struct device *dev, const char *name,
		      struct gpio_desc *desc)
{
	int			status = -EINVAL;

	if (!desc) {
		pr_warn("%s: invalid GPIO\n", __func__);
		return -EINVAL;
	}

	mutex_lock(&sysfs_lock);

	if (test_bit(FLAG_EXPORT, &desc->flags)) {
		struct device *tdev;

		tdev = class_find_device(&gpio_class, NULL, desc, match_export);
		if (tdev != NULL) {
			status = sysfs_create_link(&dev->kobj, &tdev->kobj,
						name);
648
			put_device(tdev);
649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670
		} else {
			status = -ENODEV;
		}
	}

	mutex_unlock(&sysfs_lock);

	if (status)
		gpiod_dbg(desc, "%s: status %d\n", __func__, status);

	return status;
}
EXPORT_SYMBOL_GPL(gpiod_export_link);

/**
 * gpiod_unexport - reverse effect of gpio_export()
 * @gpio: gpio to make unavailable
 *
 * This is implicit on gpio_free().
 */
void gpiod_unexport(struct gpio_desc *desc)
{
671
	struct gpiod_data	*data;
672 673 674 675 676 677 678 679 680 681 682 683 684 685
	int			status = 0;
	struct device		*dev = NULL;

	if (!desc) {
		pr_warn("%s: invalid GPIO\n", __func__);
		return;
	}

	mutex_lock(&sysfs_lock);

	if (test_bit(FLAG_EXPORT, &desc->flags)) {

		dev = class_find_device(&gpio_class, NULL, desc, match_export);
		if (dev) {
686
			clear_bit(FLAG_SYSFS_DIR, &desc->flags);
687 688 689 690 691 692 693 694
			clear_bit(FLAG_EXPORT, &desc->flags);
		} else
			status = -ENODEV;
	}

	mutex_unlock(&sysfs_lock);

	if (dev) {
695
		data = dev_get_drvdata(dev);
696
		device_unregister(dev);
697 698 699 700
		/*
		 * Release irq after deregistration to prevent race with
		 * edge_store.
		 */
701 702
		if (desc->flags & GPIO_TRIGGER_MASK)
			gpio_setup_irq(dev, 0);
703
		put_device(dev);
704
		kfree(data);
705 706 707 708 709 710 711
	}

	if (status)
		gpiod_dbg(desc, "%s: status %d\n", __func__, status);
}
EXPORT_SYMBOL_GPL(gpiod_unexport);

712
int gpiochip_sysfs_register(struct gpio_chip *chip)
713 714 715
{
	struct device	*dev;

716 717
	/*
	 * Many systems add gpio chips for SOC support very early,
718
	 * before driver model support is available.  In those cases we
719
	 * register later, in gpiolib_sysfs_init() ... here we just
720 721 722 723 724 725
	 * verify that _some_ field of gpio_class got initialized.
	 */
	if (!gpio_class.p)
		return 0;

	/* use chip->base for the ID; it's already known to be unique */
726 727 728 729
	dev = device_create_with_groups(&gpio_class, chip->dev, MKDEV(0, 0),
					chip, gpiochip_groups,
					"gpiochip%d", chip->base);
	if (IS_ERR(dev))
730
		return PTR_ERR(dev);
731 732

	mutex_lock(&sysfs_lock);
733
	chip->cdev = dev;
734 735
	mutex_unlock(&sysfs_lock);

736
	return 0;
737 738
}

739
void gpiochip_sysfs_unregister(struct gpio_chip *chip)
740
{
741 742
	struct gpio_desc *desc;
	unsigned int i;
743

744 745
	if (!chip->cdev)
		return;
746

747 748 749 750 751 752
	device_unregister(chip->cdev);

	/* prevent further gpiod exports */
	mutex_lock(&sysfs_lock);
	chip->cdev = NULL;
	mutex_unlock(&sysfs_lock);
753 754 755 756 757 758 759

	/* unregister gpiod class devices owned by sysfs */
	for (i = 0; i < chip->ngpio; i++) {
		desc = &chip->desc[i];
		if (test_and_clear_bit(FLAG_SYSFS, &desc->flags))
			gpiod_free(desc);
	}
760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779
}

static int __init gpiolib_sysfs_init(void)
{
	int		status;
	unsigned long	flags;
	struct gpio_chip *chip;

	status = class_register(&gpio_class);
	if (status < 0)
		return status;

	/* Scan and register the gpio_chips which registered very
	 * early (e.g. before the class_register above was called).
	 *
	 * We run before arch_initcall() so chip->dev nodes can have
	 * registered, and so arch_initcall() can always gpio_export().
	 */
	spin_lock_irqsave(&gpio_lock, flags);
	list_for_each_entry(chip, &gpio_chips, list) {
780
		if (chip->cdev)
781 782
			continue;

783
		/*
784 785 786
		 * TODO we yield gpio_lock here because
		 * gpiochip_sysfs_register() acquires a mutex. This is unsafe
		 * and needs to be fixed.
787 788 789 790 791
		 *
		 * Also it would be nice to use gpiochip_find() here so we
		 * can keep gpio_chips local to gpiolib.c, but the yield of
		 * gpio_lock prevents us from doing this.
		 */
792
		spin_unlock_irqrestore(&gpio_lock, flags);
793
		status = gpiochip_sysfs_register(chip);
794 795 796 797 798 799 800 801
		spin_lock_irqsave(&gpio_lock, flags);
	}
	spin_unlock_irqrestore(&gpio_lock, flags);


	return status;
}
postcore_initcall(gpiolib_sysfs_init);