iser_memory.c 15.4 KB
Newer Older
1 2
/*
 * Copyright (c) 2004, 2005, 2006 Voltaire, Inc. All rights reserved.
3
 * Copyright (c) 2013-2014 Mellanox Technologies. All rights reserved.
4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36
 *
 * This software is available to you under a choice of one of two
 * licenses.  You may choose to be licensed under the terms of the GNU
 * General Public License (GPL) Version 2, available from the file
 * COPYING in the main directory of this source tree, or the
 * OpenIB.org BSD license below:
 *
 *     Redistribution and use in source and binary forms, with or
 *     without modification, are permitted provided that the following
 *     conditions are met:
 *
 *	- Redistributions of source code must retain the above
 *	  copyright notice, this list of conditions and the following
 *	  disclaimer.
 *
 *	- Redistributions in binary form must reproduce the above
 *	  copyright notice, this list of conditions and the following
 *	  disclaimer in the documentation and/or other materials
 *	  provided with the distribution.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
 * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
 * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
 * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
 * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
 * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/slab.h>
#include <linux/mm.h>
A
Al Viro 已提交
37
#include <linux/highmem.h>
38 39 40
#include <linux/scatterlist.h>

#include "iscsi_iser.h"
41 42 43 44 45 46 47 48 49 50
static
int iser_fast_reg_fmr(struct iscsi_iser_task *iser_task,
		      struct iser_data_buf *mem,
		      struct iser_reg_resources *rsc,
		      struct iser_mem_reg *mem_reg);
static
int iser_fast_reg_mr(struct iscsi_iser_task *iser_task,
		     struct iser_data_buf *mem,
		     struct iser_reg_resources *rsc,
		     struct iser_mem_reg *mem_reg);
51

52
static const struct iser_reg_ops fastreg_ops = {
S
Sagi Grimberg 已提交
53 54
	.alloc_reg_res	= iser_alloc_fastreg_pool,
	.free_reg_res	= iser_free_fastreg_pool,
55 56
	.reg_mem	= iser_fast_reg_mr,
	.unreg_mem	= iser_unreg_mem_fastreg,
57 58
	.reg_desc_get	= iser_reg_desc_get_fr,
	.reg_desc_put	= iser_reg_desc_put_fr,
S
Sagi Grimberg 已提交
59 60
};

61
static const struct iser_reg_ops fmr_ops = {
S
Sagi Grimberg 已提交
62 63
	.alloc_reg_res	= iser_alloc_fmr_pool,
	.free_reg_res	= iser_free_fmr_pool,
64 65
	.reg_mem	= iser_fast_reg_fmr,
	.unreg_mem	= iser_unreg_mem_fmr,
66 67
	.reg_desc_get	= iser_reg_desc_get_fmr,
	.reg_desc_put	= iser_reg_desc_put_fmr,
S
Sagi Grimberg 已提交
68 69
};

70 71 72 73 74
void iser_reg_comp(struct ib_cq *cq, struct ib_wc *wc)
{
	iser_err_comp(wc, "memreg");
}

S
Sagi Grimberg 已提交
75 76
int iser_assign_reg_ops(struct iser_device *device)
{
77
	struct ib_device *ib_dev = device->ib_device;
S
Sagi Grimberg 已提交
78 79

	/* Assign function handles  - based on FMR support */
80 81
	if (ib_dev->alloc_fmr && ib_dev->dealloc_fmr &&
	    ib_dev->map_phys_fmr && ib_dev->unmap_fmr) {
S
Sagi Grimberg 已提交
82 83
		iser_info("FMR supported, using FMR for registration\n");
		device->reg_ops = &fmr_ops;
84
	} else if (ib_dev->attrs.device_cap_flags & IB_DEVICE_MEM_MGT_EXTENSIONS) {
S
Sagi Grimberg 已提交
85 86 87 88 89 90 91 92 93 94
		iser_info("FastReg supported, using FastReg for registration\n");
		device->reg_ops = &fastreg_ops;
	} else {
		iser_err("IB device does not support FMRs nor FastRegs, can't register memory\n");
		return -1;
	}

	return 0;
}

95
struct iser_fr_desc *
96
iser_reg_desc_get_fr(struct ib_conn *ib_conn)
97
{
98
	struct iser_fr_pool *fr_pool = &ib_conn->fr_pool;
99
	struct iser_fr_desc *desc;
100 101
	unsigned long flags;

102
	spin_lock_irqsave(&fr_pool->lock, flags);
103
	desc = list_first_entry(&fr_pool->list,
104
				struct iser_fr_desc, list);
105
	list_del(&desc->list);
106
	spin_unlock_irqrestore(&fr_pool->lock, flags);
107 108 109 110 111

	return desc;
}

void
112 113
iser_reg_desc_put_fr(struct ib_conn *ib_conn,
		     struct iser_fr_desc *desc)
114
{
115
	struct iser_fr_pool *fr_pool = &ib_conn->fr_pool;
116 117
	unsigned long flags;

118
	spin_lock_irqsave(&fr_pool->lock, flags);
119
	list_add(&desc->list, &fr_pool->list);
120
	spin_unlock_irqrestore(&fr_pool->lock, flags);
121 122
}

123 124 125 126 127 128 129 130 131 132 133 134 135 136 137
struct iser_fr_desc *
iser_reg_desc_get_fmr(struct ib_conn *ib_conn)
{
	struct iser_fr_pool *fr_pool = &ib_conn->fr_pool;

	return list_first_entry(&fr_pool->list,
				struct iser_fr_desc, list);
}

void
iser_reg_desc_put_fmr(struct ib_conn *ib_conn,
		      struct iser_fr_desc *desc)
{
}

138 139
static void iser_data_buf_dump(struct iser_data_buf *data,
			       struct ib_device *ibdev)
140
{
J
Jens Axboe 已提交
141
	struct scatterlist *sg;
142 143
	int i;

144
	for_each_sg(data->sg, sg, data->dma_nents, i)
145
		iser_dbg("sg[%d] dma_addr:0x%lX page:0x%p "
E
Erez Zilber 已提交
146
			 "off:0x%x sz:0x%x dma_len:0x%x\n",
J
Jens Axboe 已提交
147
			 i, (unsigned long)ib_sg_dma_address(ibdev, sg),
J
Jens Axboe 已提交
148
			 sg_page(sg), sg->offset,
J
Jens Axboe 已提交
149
			 sg->length, ib_sg_dma_len(ibdev, sg));
150 151 152 153 154 155
}

static void iser_dump_page_vec(struct iser_page_vec *page_vec)
{
	int i;

S
Sagi Grimberg 已提交
156 157 158 159
	iser_err("page vec npages %d data length %d\n",
		 page_vec->npages, page_vec->fake_mr.length);
	for (i = 0; i < page_vec->npages; i++)
		iser_err("vec[%d]: %llx\n", i, page_vec->pages[i]);
160 161
}

162 163 164 165
int iser_dma_map_task_data(struct iscsi_iser_task *iser_task,
			    struct iser_data_buf *data,
			    enum iser_data_dir iser_dir,
			    enum dma_data_direction dma_dir)
166
{
167
	struct ib_device *dev;
168

169
	iser_task->dir[iser_dir] = 1;
S
Sagi Grimberg 已提交
170
	dev = iser_task->iser_conn->ib_conn.device->ib_device;
171

172
	data->dma_nents = ib_dma_map_sg(dev, data->sg, data->size, dma_dir);
173 174 175 176 177 178 179
	if (data->dma_nents == 0) {
		iser_err("dma_map_sg failed!!!\n");
		return -EINVAL;
	}
	return 0;
}

180
void iser_dma_unmap_task_data(struct iscsi_iser_task *iser_task,
181 182
			      struct iser_data_buf *data,
			      enum dma_data_direction dir)
183
{
184
	struct ib_device *dev;
185

S
Sagi Grimberg 已提交
186
	dev = iser_task->iser_conn->ib_conn.device->ib_device;
187
	ib_dma_unmap_sg(dev, data->sg, data->size, dir);
188 189
}

190 191 192 193 194 195
static int
iser_reg_dma(struct iser_device *device, struct iser_data_buf *mem,
	     struct iser_mem_reg *reg)
{
	struct scatterlist *sg = mem->sg;

196
	reg->sge.lkey = device->pd->local_dma_lkey;
197 198 199 200 201
	/*
	 * FIXME: rework the registration code path to differentiate
	 * rkey/lkey use cases
	 */
	reg->rkey = device->mr ? device->mr->rkey : 0;
202 203 204 205 206 207 208 209 210 211
	reg->sge.addr = ib_sg_dma_address(device->ib_device, &sg[0]);
	reg->sge.length = ib_sg_dma_len(device->ib_device, &sg[0]);

	iser_dbg("Single DMA entry: lkey=0x%x, rkey=0x%x, addr=0x%llx,"
		 " length=0x%x\n", reg->sge.lkey, reg->rkey,
		 reg->sge.addr, reg->sge.length);

	return 0;
}

S
Sagi Grimberg 已提交
212 213 214 215 216 217 218 219 220 221
static int iser_set_page(struct ib_mr *mr, u64 addr)
{
	struct iser_page_vec *page_vec =
		container_of(mr, struct iser_page_vec, fake_mr);

	page_vec->pages[page_vec->npages++] = addr;

	return 0;
}

222
static
223
int iser_fast_reg_fmr(struct iscsi_iser_task *iser_task,
224
		      struct iser_data_buf *mem,
225
		      struct iser_reg_resources *rsc,
226
		      struct iser_mem_reg *reg)
227
{
228 229
	struct ib_conn *ib_conn = &iser_task->iser_conn->ib_conn;
	struct iser_device *device = ib_conn->device;
230 231
	struct iser_page_vec *page_vec = rsc->page_vec;
	struct ib_fmr_pool *fmr_pool = rsc->fmr_pool;
232 233 234
	struct ib_pool_fmr *fmr;
	int ret, plen;

S
Sagi Grimberg 已提交
235 236 237 238 239
	page_vec->npages = 0;
	page_vec->fake_mr.page_size = SIZE_4K;
	plen = ib_sg_to_pages(&page_vec->fake_mr, mem->sg,
			      mem->size, iser_set_page);
	if (unlikely(plen < mem->size)) {
240 241 242 243 244
		iser_err("page vec too short to hold this SG\n");
		iser_data_buf_dump(mem, device->ib_device);
		iser_dump_page_vec(page_vec);
		return -EINVAL;
	}
245

S
Sagi Grimberg 已提交
246 247
	fmr  = ib_fmr_pool_map_phys(fmr_pool, page_vec->pages,
				    page_vec->npages, page_vec->pages[0]);
248 249 250 251
	if (IS_ERR(fmr)) {
		ret = PTR_ERR(fmr);
		iser_err("ib_fmr_pool_map_phys failed: %d\n", ret);
		return ret;
252 253
	}

254 255
	reg->sge.lkey = fmr->fmr->lkey;
	reg->rkey = fmr->fmr->rkey;
S
Sagi Grimberg 已提交
256 257
	reg->sge.addr = page_vec->fake_mr.iova;
	reg->sge.length = page_vec->fake_mr.length;
258
	reg->mem_h = fmr;
259

260 261 262 263
	iser_dbg("fmr reg: lkey=0x%x, rkey=0x%x, addr=0x%llx,"
		 " length=0x%x\n", reg->sge.lkey, reg->rkey,
		 reg->sge.addr, reg->sge.length);

264 265 266 267 268 269 270 271 272 273
	return 0;
}

/**
 * Unregister (previosuly registered using FMR) memory.
 * If memory is non-FMR does nothing.
 */
void iser_unreg_mem_fmr(struct iscsi_iser_task *iser_task,
			enum iser_data_dir cmd_dir)
{
274
	struct iser_mem_reg *reg = &iser_task->rdma_reg[cmd_dir];
275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291
	int ret;

	if (!reg->mem_h)
		return;

	iser_dbg("PHYSICAL Mem.Unregister mem_h %p\n", reg->mem_h);

	ret = ib_fmr_pool_unmap((struct ib_pool_fmr *)reg->mem_h);
	if (ret)
		iser_err("ib_fmr_pool_unmap failed %d\n", ret);

	reg->mem_h = NULL;
}

void iser_unreg_mem_fastreg(struct iscsi_iser_task *iser_task,
			    enum iser_data_dir cmd_dir)
{
292
	struct iser_device *device = iser_task->iser_conn->ib_conn.device;
293
	struct iser_mem_reg *reg = &iser_task->rdma_reg[cmd_dir];
294

295
	if (!reg->mem_h)
296 297
		return;

298 299
	device->reg_ops->reg_desc_put(&iser_task->iser_conn->ib_conn,
				     reg->mem_h);
300 301 302
	reg->mem_h = NULL;
}

S
Sagi Grimberg 已提交
303
static void
304 305 306
iser_set_dif_domain(struct scsi_cmnd *sc, struct ib_sig_attrs *sig_attrs,
		    struct ib_sig_domain *domain)
{
307
	domain->sig_type = IB_SIG_TYPE_T10_DIF;
S
Sagi Grimberg 已提交
308 309
	domain->sig.dif.pi_interval = scsi_prot_interval(sc);
	domain->sig.dif.ref_tag = scsi_prot_ref_tag(sc);
310 311 312 313 314 315 316
	/*
	 * At the moment we hard code those, but in the future
	 * we will take them from sc.
	 */
	domain->sig.dif.apptag_check_mask = 0xffff;
	domain->sig.dif.app_escape = true;
	domain->sig.dif.ref_escape = true;
S
Sagi Grimberg 已提交
317
	if (sc->prot_flags & SCSI_PROT_REF_INCREMENT)
318
		domain->sig.dif.ref_remap = true;
319
};
320 321 322 323 324 325 326

static int
iser_set_sig_attrs(struct scsi_cmnd *sc, struct ib_sig_attrs *sig_attrs)
{
	switch (scsi_get_prot_op(sc)) {
	case SCSI_PROT_WRITE_INSERT:
	case SCSI_PROT_READ_STRIP:
327
		sig_attrs->mem.sig_type = IB_SIG_TYPE_NONE;
328
		iser_set_dif_domain(sc, sig_attrs, &sig_attrs->wire);
329 330 331 332
		sig_attrs->wire.sig.dif.bg_type = IB_T10DIF_CRC;
		break;
	case SCSI_PROT_READ_INSERT:
	case SCSI_PROT_WRITE_STRIP:
333
		sig_attrs->wire.sig_type = IB_SIG_TYPE_NONE;
334
		iser_set_dif_domain(sc, sig_attrs, &sig_attrs->mem);
S
Sagi Grimberg 已提交
335 336
		sig_attrs->mem.sig.dif.bg_type = sc->prot_flags & SCSI_PROT_IP_CHECKSUM ?
						IB_T10DIF_CSUM : IB_T10DIF_CRC;
337 338 339
		break;
	case SCSI_PROT_READ_PASS:
	case SCSI_PROT_WRITE_PASS:
340
		iser_set_dif_domain(sc, sig_attrs, &sig_attrs->wire);
341
		sig_attrs->wire.sig.dif.bg_type = IB_T10DIF_CRC;
342
		iser_set_dif_domain(sc, sig_attrs, &sig_attrs->mem);
S
Sagi Grimberg 已提交
343 344
		sig_attrs->mem.sig.dif.bg_type = sc->prot_flags & SCSI_PROT_IP_CHECKSUM ?
						IB_T10DIF_CSUM : IB_T10DIF_CRC;
345 346 347 348 349 350
		break;
	default:
		iser_err("Unsupported PI operation %d\n",
			 scsi_get_prot_op(sc));
		return -EINVAL;
	}
351

352 353 354
	return 0;
}

S
Sagi Grimberg 已提交
355
static inline void
356 357
iser_set_prot_checks(struct scsi_cmnd *sc, u8 *mask)
{
S
Sagi Grimberg 已提交
358 359 360 361 362
	*mask = 0;
	if (sc->prot_flags & SCSI_PROT_REF_CHECK)
		*mask |= ISER_CHECK_REFTAG;
	if (sc->prot_flags & SCSI_PROT_GUARD_CHECK)
		*mask |= ISER_CHECK_GUARD;
363 364
}

365
static void
366 367 368
iser_inv_rkey(struct ib_send_wr *inv_wr,
	      struct ib_mr *mr,
	      struct ib_cqe *cqe)
369 370 371 372
{
	u32 rkey;

	inv_wr->opcode = IB_WR_LOCAL_INV;
373
	inv_wr->wr_cqe = cqe;
374
	inv_wr->ex.invalidate_rkey = mr->rkey;
375 376
	inv_wr->send_flags = 0;
	inv_wr->num_sge = 0;
377 378 379 380 381

	rkey = ib_inc_rkey(mr->rkey);
	ib_update_fast_reg_key(mr, rkey);
}

382 383
static int
iser_reg_sig_mr(struct iscsi_iser_task *iser_task,
384
		struct iser_pi_context *pi_ctx,
385 386 387
		struct iser_mem_reg *data_reg,
		struct iser_mem_reg *prot_reg,
		struct iser_mem_reg *sig_reg)
388
{
389 390
	struct iser_tx_desc *tx_desc = &iser_task->desc;
	struct ib_sig_attrs *sig_attrs = &tx_desc->sig_attrs;
391
	struct ib_cqe *cqe = &iser_task->iser_conn->ib_conn.reg_cqe;
C
Christoph Hellwig 已提交
392
	struct ib_sig_handover_wr *wr;
393 394
	int ret;

395 396
	memset(sig_attrs, 0, sizeof(*sig_attrs));
	ret = iser_set_sig_attrs(iser_task->sc, sig_attrs);
397 398 399
	if (ret)
		goto err;

400
	iser_set_prot_checks(iser_task->sc, &sig_attrs->check_mask);
401

C
Christoph Hellwig 已提交
402
	if (!pi_ctx->sig_mr_valid)
403
		iser_inv_rkey(iser_tx_next_wr(tx_desc), pi_ctx->sig_mr, cqe);
C
Christoph Hellwig 已提交
404 405 406

	wr = sig_handover_wr(iser_tx_next_wr(tx_desc));
	wr->wr.opcode = IB_WR_REG_SIG_MR;
407
	wr->wr.wr_cqe = cqe;
C
Christoph Hellwig 已提交
408 409 410 411 412
	wr->wr.sg_list = &data_reg->sge;
	wr->wr.num_sge = 1;
	wr->wr.send_flags = 0;
	wr->sig_attrs = sig_attrs;
	wr->sig_mr = pi_ctx->sig_mr;
413
	if (scsi_prot_sg_count(iser_task->sc))
C
Christoph Hellwig 已提交
414
		wr->prot = &prot_reg->sge;
415
	else
C
Christoph Hellwig 已提交
416 417 418 419
		wr->prot = NULL;
	wr->access_flags = IB_ACCESS_LOCAL_WRITE |
			   IB_ACCESS_REMOTE_READ |
			   IB_ACCESS_REMOTE_WRITE;
420
	pi_ctx->sig_mr_valid = 0;
421

422 423 424 425
	sig_reg->sge.lkey = pi_ctx->sig_mr->lkey;
	sig_reg->rkey = pi_ctx->sig_mr->rkey;
	sig_reg->sge.addr = 0;
	sig_reg->sge.length = scsi_transfer_length(iser_task->sc);
426

427
	iser_dbg("lkey=0x%x rkey=0x%x addr=0x%llx length=%u\n",
428 429
		 sig_reg->sge.lkey, sig_reg->rkey, sig_reg->sge.addr,
		 sig_reg->sge.length);
430 431 432 433
err:
	return ret;
}

434 435
static int iser_fast_reg_mr(struct iscsi_iser_task *iser_task,
			    struct iser_data_buf *mem,
436
			    struct iser_reg_resources *rsc,
437
			    struct iser_mem_reg *reg)
438
{
439
	struct iser_tx_desc *tx_desc = &iser_task->desc;
440
	struct ib_cqe *cqe = &iser_task->iser_conn->ib_conn.reg_cqe;
441 442 443
	struct ib_mr *mr = rsc->mr;
	struct ib_reg_wr *wr;
	int n;
444

C
Christoph Hellwig 已提交
445
	if (!rsc->mr_valid)
446
		iser_inv_rkey(iser_tx_next_wr(tx_desc), mr, cqe);
C
Christoph Hellwig 已提交
447

448 449 450 451 452 453 454 455 456
	n = ib_map_mr_sg(mr, mem->sg, mem->size, SIZE_4K);
	if (unlikely(n != mem->size)) {
		iser_err("failed to map sg (%d/%d)\n",
			 n, mem->size);
		return n < 0 ? n : -EINVAL;
	}

	wr = reg_wr(iser_tx_next_wr(tx_desc));
	wr->wr.opcode = IB_WR_REG_MR;
457
	wr->wr.wr_cqe = cqe;
C
Christoph Hellwig 已提交
458
	wr->wr.send_flags = 0;
459 460 461 462 463 464 465
	wr->wr.num_sge = 0;
	wr->mr = mr;
	wr->key = mr->rkey;
	wr->access = IB_ACCESS_LOCAL_WRITE  |
		     IB_ACCESS_REMOTE_WRITE |
		     IB_ACCESS_REMOTE_READ;

466
	rsc->mr_valid = 0;
467

468 469
	reg->sge.lkey = mr->lkey;
	reg->rkey = mr->rkey;
470 471
	reg->sge.addr = mr->iova;
	reg->sge.length = mr->length;
472

473 474
	iser_dbg("lkey=0x%x rkey=0x%x addr=0x%llx length=0x%x\n",
		 reg->sge.lkey, reg->rkey, reg->sge.addr, reg->sge.length);
475

476
	return 0;
477 478
}

479 480 481 482
static int
iser_reg_prot_sg(struct iscsi_iser_task *task,
		 struct iser_data_buf *mem,
		 struct iser_fr_desc *desc,
483
		 bool use_dma_key,
484 485 486 487
		 struct iser_mem_reg *reg)
{
	struct iser_device *device = task->iser_conn->ib_conn.device;

488
	if (use_dma_key)
489 490 491 492 493 494 495 496 497
		return iser_reg_dma(device, mem, reg);

	return device->reg_ops->reg_mem(task, mem, &desc->pi_ctx->rsc, reg);
}

static int
iser_reg_data_sg(struct iscsi_iser_task *task,
		 struct iser_data_buf *mem,
		 struct iser_fr_desc *desc,
498
		 bool use_dma_key,
499 500 501 502
		 struct iser_mem_reg *reg)
{
	struct iser_device *device = task->iser_conn->ib_conn.device;

503
	if (use_dma_key)
504 505 506 507 508 509
		return iser_reg_dma(device, mem, reg);

	return device->reg_ops->reg_mem(task, mem, &desc->rsc, reg);
}

int iser_reg_rdma_mem(struct iscsi_iser_task *task,
510 511
		      enum iser_data_dir dir,
		      bool all_imm)
512 513 514 515 516
{
	struct ib_conn *ib_conn = &task->iser_conn->ib_conn;
	struct iser_device *device = ib_conn->device;
	struct iser_data_buf *mem = &task->data[dir];
	struct iser_mem_reg *reg = &task->rdma_reg[dir];
517
	struct iser_mem_reg *data_reg;
518
	struct iser_fr_desc *desc = NULL;
519
	bool use_dma_key;
520 521
	int err;

522 523
	use_dma_key = mem->dma_nents == 1 && (all_imm || !iser_always_reg) &&
		      scsi_get_prot_op(task->sc) == SCSI_PROT_NORMAL;
524 525

	if (!use_dma_key) {
526
		desc = device->reg_ops->reg_desc_get(ib_conn);
527
		reg->mem_h = desc;
528
	}
529

530 531 532 533 534
	if (scsi_get_prot_op(task->sc) == SCSI_PROT_NORMAL)
		data_reg = reg;
	else
		data_reg = &task->desc.data_reg;

535
	err = iser_reg_data_sg(task, mem, desc, use_dma_key, data_reg);
536
	if (unlikely(err))
537 538
		goto err_reg;

539
	if (scsi_get_prot_op(task->sc) != SCSI_PROT_NORMAL) {
540
		struct iser_mem_reg *prot_reg = &task->desc.prot_reg;
541

542 543
		if (scsi_prot_sg_count(task->sc)) {
			mem = &task->prot[dir];
544 545
			err = iser_reg_prot_sg(task, mem, desc,
					       use_dma_key, prot_reg);
546
			if (unlikely(err))
547 548 549
				goto err_reg;
		}

550 551
		err = iser_reg_sig_mr(task, desc->pi_ctx, data_reg,
				      prot_reg, reg);
552 553 554
		if (unlikely(err))
			goto err_reg;

555
		desc->pi_ctx->sig_protected = 1;
556
	}
557

558
	return 0;
559

560
err_reg:
561
	if (desc)
562
		device->reg_ops->reg_desc_put(ib_conn, desc);
563

564 565
	return err;
}
566 567 568 569 570 571 572 573

void iser_unreg_rdma_mem(struct iscsi_iser_task *task,
			 enum iser_data_dir dir)
{
	struct iser_device *device = task->iser_conn->ib_conn.device;

	device->reg_ops->unreg_mem(task, dir);
}