intel_lvds.c 32.5 KB
Newer Older
J
Jesse Barnes 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29
/*
 * Copyright © 2006-2007 Intel Corporation
 * Copyright (c) 2006 Dave Airlie <airlied@linux.ie>
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 *
 * Authors:
 *	Eric Anholt <eric@anholt.net>
 *      Dave Airlie <airlied@linux.ie>
 *      Jesse Barnes <jesse.barnes@intel.com>
 */

30
#include <acpi/button.h>
31
#include <linux/dmi.h>
J
Jesse Barnes 已提交
32
#include <linux/i2c.h>
33
#include <linux/slab.h>
34 35 36
#include <drm/drmP.h>
#include <drm/drm_crtc.h>
#include <drm/drm_edid.h>
J
Jesse Barnes 已提交
37
#include "intel_drv.h"
38
#include <drm/i915_drm.h>
J
Jesse Barnes 已提交
39
#include "i915_drv.h"
40
#include <linux/acpi.h>
J
Jesse Barnes 已提交
41

42
/* Private structure for the integrated LVDS support */
43 44
struct intel_lvds_connector {
	struct intel_connector base;
45

46
	struct notifier_block lid_notifier;
47 48
};

49
struct intel_lvds_encoder {
C
Chris Wilson 已提交
50
	struct intel_encoder base;
51

52 53
	u32 pfit_control;
	u32 pfit_pgm_ratios;
54
	bool pfit_dirty;
55

56
	struct intel_lvds_connector *attached_connector;
57 58
};

59
static struct intel_lvds_encoder *to_lvds_encoder(struct drm_encoder *encoder)
C
Chris Wilson 已提交
60
{
61
	return container_of(encoder, struct intel_lvds_encoder, base.base);
C
Chris Wilson 已提交
62 63
}

64
static struct intel_lvds_connector *to_lvds_connector(struct drm_connector *connector)
65
{
66
	return container_of(connector, struct intel_lvds_connector, base.base);
67 68
}

69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94
static bool intel_lvds_get_hw_state(struct intel_encoder *encoder,
				    enum pipe *pipe)
{
	struct drm_device *dev = encoder->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	u32 lvds_reg, tmp;

	if (HAS_PCH_SPLIT(dev)) {
		lvds_reg = PCH_LVDS;
	} else {
		lvds_reg = LVDS;
	}

	tmp = I915_READ(lvds_reg);

	if (!(tmp & LVDS_PORT_EN))
		return false;

	if (HAS_PCH_CPT(dev))
		*pipe = PORT_TO_PIPE_CPT(tmp);
	else
		*pipe = PORT_TO_PIPE(tmp);

	return true;
}

J
Jesse Barnes 已提交
95 96 97
/**
 * Sets the power state for the panel.
 */
98
static void intel_enable_lvds(struct intel_encoder *encoder)
J
Jesse Barnes 已提交
99
{
100
	struct drm_device *dev = encoder->base.dev;
101
	struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
102
	struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc);
J
Jesse Barnes 已提交
103
	struct drm_i915_private *dev_priv = dev->dev_private;
104
	u32 ctl_reg, lvds_reg, stat_reg;
105

106
	if (HAS_PCH_SPLIT(dev)) {
107
		ctl_reg = PCH_PP_CONTROL;
108
		lvds_reg = PCH_LVDS;
109
		stat_reg = PCH_PP_STATUS;
110 111
	} else {
		ctl_reg = PP_CONTROL;
112
		lvds_reg = LVDS;
113
		stat_reg = PP_STATUS;
114
	}
J
Jesse Barnes 已提交
115

116
	I915_WRITE(lvds_reg, I915_READ(lvds_reg) | LVDS_PORT_EN);
117

118
	if (lvds_encoder->pfit_dirty) {
119 120 121 122 123 124 125
		/*
		 * Enable automatic panel scaling so that non-native modes
		 * fill the screen.  The panel fitter should only be
		 * adjusted whilst the pipe is disabled, according to
		 * register description and PRM.
		 */
		DRM_DEBUG_KMS("applying panel-fitter: %x, %x\n",
126 127
			      lvds_encoder->pfit_control,
			      lvds_encoder->pfit_pgm_ratios);
128

129 130 131
		I915_WRITE(PFIT_PGM_RATIOS, lvds_encoder->pfit_pgm_ratios);
		I915_WRITE(PFIT_CONTROL, lvds_encoder->pfit_control);
		lvds_encoder->pfit_dirty = false;
132 133 134 135
	}

	I915_WRITE(ctl_reg, I915_READ(ctl_reg) | POWER_TARGET_ON);
	POSTING_READ(lvds_reg);
136 137
	if (wait_for((I915_READ(stat_reg) & PP_ON) != 0, 1000))
		DRM_ERROR("timed out waiting for panel to power on\n");
138

139
	intel_panel_enable_backlight(dev, intel_crtc->pipe);
140 141
}

142
static void intel_disable_lvds(struct intel_encoder *encoder)
143
{
144
	struct drm_device *dev = encoder->base.dev;
145
	struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
146
	struct drm_i915_private *dev_priv = dev->dev_private;
147
	u32 ctl_reg, lvds_reg, stat_reg;
148 149 150 151

	if (HAS_PCH_SPLIT(dev)) {
		ctl_reg = PCH_PP_CONTROL;
		lvds_reg = PCH_LVDS;
152
		stat_reg = PCH_PP_STATUS;
153 154 155
	} else {
		ctl_reg = PP_CONTROL;
		lvds_reg = LVDS;
156
		stat_reg = PP_STATUS;
157 158
	}

159
	intel_panel_disable_backlight(dev);
160 161

	I915_WRITE(ctl_reg, I915_READ(ctl_reg) & ~POWER_TARGET_ON);
162 163
	if (wait_for((I915_READ(stat_reg) & PP_ON) == 0, 1000))
		DRM_ERROR("timed out waiting for panel to power off\n");
164

165
	if (lvds_encoder->pfit_control) {
166
		I915_WRITE(PFIT_CONTROL, 0);
167
		lvds_encoder->pfit_dirty = true;
J
Jesse Barnes 已提交
168
	}
169 170

	I915_WRITE(lvds_reg, I915_READ(lvds_reg) & ~LVDS_PORT_EN);
171
	POSTING_READ(lvds_reg);
J
Jesse Barnes 已提交
172 173 174 175 176
}

static int intel_lvds_mode_valid(struct drm_connector *connector,
				 struct drm_display_mode *mode)
{
177 178
	struct intel_connector *intel_connector = to_intel_connector(connector);
	struct drm_display_mode *fixed_mode = intel_connector->panel.fixed_mode;
J
Jesse Barnes 已提交
179

180 181 182 183
	if (mode->hdisplay > fixed_mode->hdisplay)
		return MODE_PANEL;
	if (mode->vdisplay > fixed_mode->vdisplay)
		return MODE_PANEL;
J
Jesse Barnes 已提交
184 185 186 187

	return MODE_OK;
}

188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207
static void
centre_horizontally(struct drm_display_mode *mode,
		    int width)
{
	u32 border, sync_pos, blank_width, sync_width;

	/* keep the hsync and hblank widths constant */
	sync_width = mode->crtc_hsync_end - mode->crtc_hsync_start;
	blank_width = mode->crtc_hblank_end - mode->crtc_hblank_start;
	sync_pos = (blank_width - sync_width + 1) / 2;

	border = (mode->hdisplay - width + 1) / 2;
	border += border & 1; /* make the border even */

	mode->crtc_hdisplay = width;
	mode->crtc_hblank_start = width + border;
	mode->crtc_hblank_end = mode->crtc_hblank_start + blank_width;

	mode->crtc_hsync_start = mode->crtc_hblank_start + sync_pos;
	mode->crtc_hsync_end = mode->crtc_hsync_start + sync_width;
208 209

	mode->private_flags |= INTEL_MODE_CRTC_TIMINGS_SET;
210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230
}

static void
centre_vertically(struct drm_display_mode *mode,
		  int height)
{
	u32 border, sync_pos, blank_width, sync_width;

	/* keep the vsync and vblank widths constant */
	sync_width = mode->crtc_vsync_end - mode->crtc_vsync_start;
	blank_width = mode->crtc_vblank_end - mode->crtc_vblank_start;
	sync_pos = (blank_width - sync_width + 1) / 2;

	border = (mode->vdisplay - height + 1) / 2;

	mode->crtc_vdisplay = height;
	mode->crtc_vblank_start = height + border;
	mode->crtc_vblank_end = mode->crtc_vblank_start + blank_width;

	mode->crtc_vsync_start = mode->crtc_vblank_start + sync_pos;
	mode->crtc_vsync_end = mode->crtc_vsync_start + sync_width;
231 232

	mode->private_flags |= INTEL_MODE_CRTC_TIMINGS_SET;
233 234 235 236 237 238 239 240 241 242 243 244 245 246 247
}

static inline u32 panel_fitter_scaling(u32 source, u32 target)
{
	/*
	 * Floating point operation is not supported. So the FACTOR
	 * is defined, which can avoid the floating point computation
	 * when calculating the panel ratio.
	 */
#define ACCURACY 12
#define FACTOR (1 << ACCURACY)
	u32 ratio = source * FACTOR / target;
	return (FACTOR * ratio + FACTOR/2) / FACTOR;
}

J
Jesse Barnes 已提交
248
static bool intel_lvds_mode_fixup(struct drm_encoder *encoder,
249
				  const struct drm_display_mode *mode,
J
Jesse Barnes 已提交
250 251 252 253
				  struct drm_display_mode *adjusted_mode)
{
	struct drm_device *dev = encoder->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
254
	struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(encoder);
255 256
	struct intel_connector *intel_connector =
		&lvds_encoder->attached_connector->base;
257
	struct intel_crtc *intel_crtc = lvds_encoder->base.new_crtc;
258
	u32 pfit_control = 0, pfit_pgm_ratios = 0, border = 0;
259
	int pipe;
J
Jesse Barnes 已提交
260 261

	/* Should never happen!! */
262
	if (INTEL_INFO(dev)->gen < 4 && intel_crtc->pipe == 0) {
263
		DRM_ERROR("Can't support LVDS on pipe A\n");
J
Jesse Barnes 已提交
264 265 266
		return false;
	}

267
	if (intel_encoder_check_is_cloned(&lvds_encoder->base))
268
		return false;
269

J
Jesse Barnes 已提交
270
	/*
271
	 * We have timings from the BIOS for the panel, put them in
J
Jesse Barnes 已提交
272 273 274 275
	 * to the adjusted mode.  The CRTC will be set up for this mode,
	 * with the panel scaling set up to source from the H/VDisplay
	 * of the original mode.
	 */
276
	intel_fixed_panel_mode(intel_connector->panel.fixed_mode,
277
			       adjusted_mode);
278 279

	if (HAS_PCH_SPLIT(dev)) {
280 281
		intel_pch_panel_fitting(dev,
					intel_connector->panel.fitting_mode,
282 283 284
					mode, adjusted_mode);
		return true;
	}
J
Jesse Barnes 已提交
285

286 287
	/* Native modes don't need fitting */
	if (adjusted_mode->hdisplay == mode->hdisplay &&
288
	    adjusted_mode->vdisplay == mode->vdisplay)
289 290 291
		goto out;

	/* 965+ wants fuzzy fitting */
292
	if (INTEL_INFO(dev)->gen >= 4)
293 294 295
		pfit_control |= ((intel_crtc->pipe << PFIT_PIPE_SHIFT) |
				 PFIT_FILTER_FUZZY);

296 297 298 299 300 301
	/*
	 * Enable automatic panel scaling for non-native modes so that they fill
	 * the screen.  Should be enabled before the pipe is enabled, according
	 * to register description and PRM.
	 * Change the value here to see the borders for debugging
	 */
302 303
	for_each_pipe(pipe)
		I915_WRITE(BCLRPAT(pipe), 0);
304

305 306
	drm_mode_set_crtcinfo(adjusted_mode, 0);

307
	switch (intel_connector->panel.fitting_mode) {
308
	case DRM_MODE_SCALE_CENTER:
309 310 311 312
		/*
		 * For centered modes, we have to calculate border widths &
		 * heights and modify the values programmed into the CRTC.
		 */
313 314 315
		centre_horizontally(adjusted_mode, mode->hdisplay);
		centre_vertically(adjusted_mode, mode->vdisplay);
		border = LVDS_BORDER_ENABLE;
316
		break;
317

318
	case DRM_MODE_SCALE_ASPECT:
319
		/* Scale but preserve the aspect ratio */
320
		if (INTEL_INFO(dev)->gen >= 4) {
321 322 323
			u32 scaled_width = adjusted_mode->hdisplay * mode->vdisplay;
			u32 scaled_height = mode->hdisplay * adjusted_mode->vdisplay;

324
			/* 965+ is easy, it does everything in hw */
325
			if (scaled_width > scaled_height)
326
				pfit_control |= PFIT_ENABLE | PFIT_SCALING_PILLAR;
327
			else if (scaled_width < scaled_height)
328 329 330
				pfit_control |= PFIT_ENABLE | PFIT_SCALING_LETTER;
			else if (adjusted_mode->hdisplay != mode->hdisplay)
				pfit_control |= PFIT_ENABLE | PFIT_SCALING_AUTO;
331
		} else {
332 333
			u32 scaled_width = adjusted_mode->hdisplay * mode->vdisplay;
			u32 scaled_height = mode->hdisplay * adjusted_mode->vdisplay;
334 335 336 337 338
			/*
			 * For earlier chips we have to calculate the scaling
			 * ratio by hand and program it into the
			 * PFIT_PGM_RATIO register
			 */
339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366
			if (scaled_width > scaled_height) { /* pillar */
				centre_horizontally(adjusted_mode, scaled_height / mode->vdisplay);

				border = LVDS_BORDER_ENABLE;
				if (mode->vdisplay != adjusted_mode->vdisplay) {
					u32 bits = panel_fitter_scaling(mode->vdisplay, adjusted_mode->vdisplay);
					pfit_pgm_ratios |= (bits << PFIT_HORIZ_SCALE_SHIFT |
							    bits << PFIT_VERT_SCALE_SHIFT);
					pfit_control |= (PFIT_ENABLE |
							 VERT_INTERP_BILINEAR |
							 HORIZ_INTERP_BILINEAR);
				}
			} else if (scaled_width < scaled_height) { /* letter */
				centre_vertically(adjusted_mode, scaled_width / mode->hdisplay);

				border = LVDS_BORDER_ENABLE;
				if (mode->hdisplay != adjusted_mode->hdisplay) {
					u32 bits = panel_fitter_scaling(mode->hdisplay, adjusted_mode->hdisplay);
					pfit_pgm_ratios |= (bits << PFIT_HORIZ_SCALE_SHIFT |
							    bits << PFIT_VERT_SCALE_SHIFT);
					pfit_control |= (PFIT_ENABLE |
							 VERT_INTERP_BILINEAR |
							 HORIZ_INTERP_BILINEAR);
				}
			} else
				/* Aspects match, Let hw scale both directions */
				pfit_control |= (PFIT_ENABLE |
						 VERT_AUTO_SCALE | HORIZ_AUTO_SCALE |
367 368 369 370 371 372 373 374 375 376
						 VERT_INTERP_BILINEAR |
						 HORIZ_INTERP_BILINEAR);
		}
		break;

	case DRM_MODE_SCALE_FULLSCREEN:
		/*
		 * Full scaling, even if it changes the aspect ratio.
		 * Fortunately this is all done for us in hw.
		 */
377 378 379 380 381 382 383 384 385 386 387
		if (mode->vdisplay != adjusted_mode->vdisplay ||
		    mode->hdisplay != adjusted_mode->hdisplay) {
			pfit_control |= PFIT_ENABLE;
			if (INTEL_INFO(dev)->gen >= 4)
				pfit_control |= PFIT_SCALING_AUTO;
			else
				pfit_control |= (VERT_AUTO_SCALE |
						 VERT_INTERP_BILINEAR |
						 HORIZ_AUTO_SCALE |
						 HORIZ_INTERP_BILINEAR);
		}
388
		break;
389

390 391 392 393 394
	default:
		break;
	}

out:
395
	/* If not enabling scaling, be consistent and always use 0. */
396 397 398 399
	if ((pfit_control & PFIT_ENABLE) == 0) {
		pfit_control = 0;
		pfit_pgm_ratios = 0;
	}
400 401 402 403 404

	/* Make sure pre-965 set dither correctly */
	if (INTEL_INFO(dev)->gen < 4 && dev_priv->lvds_dither)
		pfit_control |= PANEL_8TO6_DITHER_ENABLE;

405 406 407 408 409
	if (pfit_control != lvds_encoder->pfit_control ||
	    pfit_pgm_ratios != lvds_encoder->pfit_pgm_ratios) {
		lvds_encoder->pfit_control = pfit_control;
		lvds_encoder->pfit_pgm_ratios = pfit_pgm_ratios;
		lvds_encoder->pfit_dirty = true;
410
	}
411 412
	dev_priv->lvds_border_bits = border;

J
Jesse Barnes 已提交
413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435
	/*
	 * XXX: It would be nice to support lower refresh rates on the
	 * panels to reduce power consumption, and perhaps match the
	 * user's requested refresh rate.
	 */

	return true;
}

static void intel_lvds_mode_set(struct drm_encoder *encoder,
				struct drm_display_mode *mode,
				struct drm_display_mode *adjusted_mode)
{
	/*
	 * The LVDS pin pair will already have been turned on in the
	 * intel_crtc_mode_set since it has a large impact on the DPLL
	 * settings.
	 */
}

/**
 * Detect the LVDS connection.
 *
436 437 438
 * Since LVDS doesn't have hotlug, we use the lid as a proxy.  Open means
 * connected and closed means disconnected.  We also send hotplug events as
 * needed, using lid status notification from the input layer.
J
Jesse Barnes 已提交
439
 */
440
static enum drm_connector_status
441
intel_lvds_detect(struct drm_connector *connector, bool force)
J
Jesse Barnes 已提交
442
{
443
	struct drm_device *dev = connector->dev;
444
	enum drm_connector_status status;
445

446 447 448
	status = intel_panel_detect(dev);
	if (status != connector_status_unknown)
		return status;
449

450
	return connector_status_connected;
J
Jesse Barnes 已提交
451 452 453 454 455 456 457
}

/**
 * Return the list of DDC modes if available, or the BIOS fixed mode otherwise.
 */
static int intel_lvds_get_modes(struct drm_connector *connector)
{
458
	struct intel_lvds_connector *lvds_connector = to_lvds_connector(connector);
J
Jesse Barnes 已提交
459
	struct drm_device *dev = connector->dev;
460
	struct drm_display_mode *mode;
J
Jesse Barnes 已提交
461

462
	/* use cached edid if we have one */
463
	if (!IS_ERR_OR_NULL(lvds_connector->base.edid))
464
		return drm_add_edid_modes(connector, lvds_connector->base.edid);
J
Jesse Barnes 已提交
465

466
	mode = drm_mode_duplicate(dev, lvds_connector->base.panel.fixed_mode);
C
Chris Wilson 已提交
467
	if (mode == NULL)
468
		return 0;
J
Jesse Barnes 已提交
469

470 471
	drm_mode_probed_add(connector, mode);
	return 1;
J
Jesse Barnes 已提交
472 473
}

474 475
static int intel_no_modeset_on_lid_dmi_callback(const struct dmi_system_id *id)
{
476
	DRM_INFO("Skipping forced modeset for %s\n", id->ident);
477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493
	return 1;
}

/* The GPU hangs up on these systems if modeset is performed on LID open */
static const struct dmi_system_id intel_no_modeset_on_lid[] = {
	{
		.callback = intel_no_modeset_on_lid_dmi_callback,
		.ident = "Toshiba Tecra A11",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
			DMI_MATCH(DMI_PRODUCT_NAME, "TECRA A11"),
		},
	},

	{ }	/* terminating entry */
};

494 495 496 497 498 499 500 501 502
/*
 * Lid events. Note the use of 'modeset_on_lid':
 *  - we set it on lid close, and reset it on open
 *  - we use it as a "only once" bit (ie we ignore
 *    duplicate events where it was already properly
 *    set/reset)
 *  - the suspend/resume paths will also set it to
 *    zero, since they restore the mode ("lid open").
 */
503 504 505
static int intel_lid_notify(struct notifier_block *nb, unsigned long val,
			    void *unused)
{
506 507 508 509 510
	struct intel_lvds_connector *lvds_connector =
		container_of(nb, struct intel_lvds_connector, lid_notifier);
	struct drm_connector *connector = &lvds_connector->base.base;
	struct drm_device *dev = connector->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
511

512 513 514
	if (dev->switch_power_state != DRM_SWITCH_POWER_ON)
		return NOTIFY_OK;

515 516 517 518
	/*
	 * check and update the status of LVDS connector after receiving
	 * the LID nofication event.
	 */
519
	connector->status = connector->funcs->detect(connector, false);
520

521 522 523
	/* Don't force modeset on machines where it causes a GPU lockup */
	if (dmi_check_system(intel_no_modeset_on_lid))
		return NOTIFY_OK;
524 525 526
	if (!acpi_lid_open()) {
		dev_priv->modeset_on_lid = 1;
		return NOTIFY_OK;
527
	}
528

529 530 531 532 533 534
	if (!dev_priv->modeset_on_lid)
		return NOTIFY_OK;

	dev_priv->modeset_on_lid = 0;

	mutex_lock(&dev->mode_config.mutex);
D
Daniel Vetter 已提交
535
	intel_modeset_check_state(dev);
536
	mutex_unlock(&dev->mode_config.mutex);
537

538 539 540
	return NOTIFY_OK;
}

J
Jesse Barnes 已提交
541 542 543 544 545 546 547 548 549
/**
 * intel_lvds_destroy - unregister and free LVDS structures
 * @connector: connector to free
 *
 * Unregister the DDC bus for this connector then free the driver private
 * structure.
 */
static void intel_lvds_destroy(struct drm_connector *connector)
{
550 551
	struct intel_lvds_connector *lvds_connector =
		to_lvds_connector(connector);
J
Jesse Barnes 已提交
552

553 554
	if (lvds_connector->lid_notifier.notifier_call)
		acpi_lid_notifier_unregister(&lvds_connector->lid_notifier);
J
Jesse Barnes 已提交
555

556 557 558
	if (!IS_ERR_OR_NULL(lvds_connector->base.edid))
		kfree(lvds_connector->base.edid);

559
	intel_panel_destroy_backlight(connector->dev);
560
	intel_panel_fini(&lvds_connector->base.panel);
561

J
Jesse Barnes 已提交
562 563 564 565 566
	drm_sysfs_connector_remove(connector);
	drm_connector_cleanup(connector);
	kfree(connector);
}

567 568 569 570
static int intel_lvds_set_property(struct drm_connector *connector,
				   struct drm_property *property,
				   uint64_t value)
{
571
	struct intel_connector *intel_connector = to_intel_connector(connector);
572 573
	struct drm_device *dev = connector->dev;

574
	if (property == dev->mode_config.scaling_mode_property) {
575
		struct drm_crtc *crtc;
576

577 578
		if (value == DRM_MODE_SCALE_NONE) {
			DRM_DEBUG_KMS("no scaling not supported\n");
579
			return -EINVAL;
580
		}
581

582
		if (intel_connector->panel.fitting_mode == value) {
583 584 585
			/* the LVDS scaling property is not changed */
			return 0;
		}
586
		intel_connector->panel.fitting_mode = value;
587 588

		crtc = intel_attached_encoder(connector)->base.crtc;
589 590 591 592 593
		if (crtc && crtc->enabled) {
			/*
			 * If the CRTC is enabled, the display will be changed
			 * according to the new panel fitting mode.
			 */
594 595
			intel_set_mode(crtc, &crtc->mode,
				       crtc->x, crtc->y, crtc->fb);
596 597 598
		}
	}

599 600 601
	return 0;
}

J
Jesse Barnes 已提交
602 603 604
static const struct drm_encoder_helper_funcs intel_lvds_helper_funcs = {
	.mode_fixup = intel_lvds_mode_fixup,
	.mode_set = intel_lvds_mode_set,
605
	.disable = intel_encoder_noop,
J
Jesse Barnes 已提交
606 607 608 609 610
};

static const struct drm_connector_helper_funcs intel_lvds_connector_helper_funcs = {
	.get_modes = intel_lvds_get_modes,
	.mode_valid = intel_lvds_mode_valid,
611
	.best_encoder = intel_best_encoder,
J
Jesse Barnes 已提交
612 613 614
};

static const struct drm_connector_funcs intel_lvds_connector_funcs = {
615
	.dpms = intel_connector_dpms,
J
Jesse Barnes 已提交
616 617
	.detect = intel_lvds_detect,
	.fill_modes = drm_helper_probe_single_connector_modes,
618
	.set_property = intel_lvds_set_property,
J
Jesse Barnes 已提交
619 620 621 622
	.destroy = intel_lvds_destroy,
};

static const struct drm_encoder_funcs intel_lvds_enc_funcs = {
C
Chris Wilson 已提交
623
	.destroy = intel_encoder_destroy,
J
Jesse Barnes 已提交
624 625
};

626 627
static int __init intel_no_lvds_dmi_callback(const struct dmi_system_id *id)
{
628
	DRM_INFO("Skipping LVDS initialization for %s\n", id->ident);
629 630
	return 1;
}
J
Jesse Barnes 已提交
631

632
/* These systems claim to have LVDS, but really don't */
633
static const struct dmi_system_id intel_no_lvds[] = {
634 635 636 637
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Apple Mac Mini (Core series)",
		.matches = {
638
			DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
639 640 641 642 643 644 645
			DMI_MATCH(DMI_PRODUCT_NAME, "Macmini1,1"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Apple Mac Mini (Core 2 series)",
		.matches = {
646
			DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665
			DMI_MATCH(DMI_PRODUCT_NAME, "Macmini2,1"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "MSI IM-945GSE-A",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "MSI"),
			DMI_MATCH(DMI_PRODUCT_NAME, "A9830IMS"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Dell Studio Hybrid",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
			DMI_MATCH(DMI_PRODUCT_NAME, "Studio Hybrid 140g"),
		},
	},
666 667
	{
		.callback = intel_no_lvds_dmi_callback,
668 669 670 671 672 673 674 675
		.ident = "Dell OptiPlex FX170",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
			DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex FX170"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
676 677 678 679 680 681
		.ident = "AOpen Mini PC",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "AOpen"),
			DMI_MATCH(DMI_PRODUCT_NAME, "i965GMx-IF"),
		},
	},
682 683 684 685 686 687 688 689
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "AOpen Mini PC MP915",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
			DMI_MATCH(DMI_BOARD_NAME, "i915GMx-F"),
		},
	},
690 691 692 693 694 695 696 697
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "AOpen i915GMm-HFS",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
			DMI_MATCH(DMI_BOARD_NAME, "i915GMm-HFS"),
		},
	},
698 699 700 701 702 703 704 705
	{
		.callback = intel_no_lvds_dmi_callback,
                .ident = "AOpen i45GMx-I",
                .matches = {
                        DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
                        DMI_MATCH(DMI_BOARD_NAME, "i45GMx-I"),
                },
        },
706 707 708 709 710 711 712
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Aopen i945GTt-VFA",
		.matches = {
			DMI_MATCH(DMI_PRODUCT_VERSION, "AO00001JW"),
		},
	},
713 714 715 716 717 718 719 720
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Clientron U800",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
			DMI_MATCH(DMI_PRODUCT_NAME, "U800"),
		},
	},
721
	{
722 723 724 725 726 727 728 729
                .callback = intel_no_lvds_dmi_callback,
                .ident = "Clientron E830",
                .matches = {
                        DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
                        DMI_MATCH(DMI_PRODUCT_NAME, "E830"),
                },
        },
        {
730 731 732 733 734 735 736
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Asus EeeBox PC EB1007",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK Computer INC."),
			DMI_MATCH(DMI_PRODUCT_NAME, "EB1007"),
		},
	},
737 738 739 740 741 742 743 744
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Asus AT5NM10T-I",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
			DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"),
		},
	},
745 746 747 748 749 750 751 752
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Hewlett-Packard HP t5740e Thin Client",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
			DMI_MATCH(DMI_PRODUCT_NAME, "HP t5740e Thin Client"),
		},
	},
753 754 755 756 757
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Hewlett-Packard t5745",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
758
			DMI_MATCH(DMI_PRODUCT_NAME, "hp t5745"),
759 760 761 762 763 764 765
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Hewlett-Packard st5747",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
766
			DMI_MATCH(DMI_PRODUCT_NAME, "hp st5747"),
767 768
		},
	},
769 770 771 772 773 774 775 776
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "MSI Wind Box DC500",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "MICRO-STAR INTERNATIONAL CO., LTD"),
			DMI_MATCH(DMI_BOARD_NAME, "MS-7469"),
		},
	},
777 778 779 780 781 782 783 784
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "ZOTAC ZBOXSD-ID12/ID13",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "ZOTAC"),
			DMI_MATCH(DMI_BOARD_NAME, "ZBOXSD-ID12/ID13"),
		},
	},
785 786 787 788 789 790 791 792
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Gigabyte GA-D525TUD",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
			DMI_MATCH(DMI_BOARD_NAME, "D525TUD"),
		},
	},
793 794 795 796 797 798 799 800
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Supermicro X7SPA-H",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Supermicro"),
			DMI_MATCH(DMI_PRODUCT_NAME, "X7SPA-H"),
		},
	},
801 802 803

	{ }	/* terminating entry */
};
J
Jesse Barnes 已提交
804

805 806 807 808 809 810 811 812
/**
 * intel_find_lvds_downclock - find the reduced downclock for LVDS in EDID
 * @dev: drm device
 * @connector: LVDS connector
 *
 * Find the reduced downclock for LVDS in EDID.
 */
static void intel_find_lvds_downclock(struct drm_device *dev,
813 814
				      struct drm_display_mode *fixed_mode,
				      struct drm_connector *connector)
815 816
{
	struct drm_i915_private *dev_priv = dev->dev_private;
817
	struct drm_display_mode *scan;
818 819
	int temp_downclock;

820
	temp_downclock = fixed_mode->clock;
821 822 823 824 825 826 827 828
	list_for_each_entry(scan, &connector->probed_modes, head) {
		/*
		 * If one mode has the same resolution with the fixed_panel
		 * mode while they have the different refresh rate, it means
		 * that the reduced downclock is found for the LVDS. In such
		 * case we can set the different FPx0/1 to dynamically select
		 * between low and high frequency.
		 */
829 830 831 832 833 834 835 836
		if (scan->hdisplay == fixed_mode->hdisplay &&
		    scan->hsync_start == fixed_mode->hsync_start &&
		    scan->hsync_end == fixed_mode->hsync_end &&
		    scan->htotal == fixed_mode->htotal &&
		    scan->vdisplay == fixed_mode->vdisplay &&
		    scan->vsync_start == fixed_mode->vsync_start &&
		    scan->vsync_end == fixed_mode->vsync_end &&
		    scan->vtotal == fixed_mode->vtotal) {
837 838 839 840 841 842 843 844 845
			if (scan->clock < temp_downclock) {
				/*
				 * The downclock is already found. But we
				 * expect to find the lower downclock.
				 */
				temp_downclock = scan->clock;
			}
		}
	}
846
	if (temp_downclock < fixed_mode->clock && i915_lvds_downclock) {
847 848 849 850
		/* We found the downclock for LVDS. */
		dev_priv->lvds_downclock_avail = 1;
		dev_priv->lvds_downclock = temp_downclock;
		DRM_DEBUG_KMS("LVDS downclock is found in EDID. "
851 852
			      "Normal clock %dKhz, downclock %dKhz\n",
			      fixed_mode->clock, temp_downclock);
853 854 855
	}
}

856 857 858 859 860 861 862
/*
 * Enumerate the child dev array parsed from VBT to check whether
 * the LVDS is present.
 * If it is present, return 1.
 * If it is not present, return false.
 * If no child dev is parsed from VBT, it assumes that the LVDS is present.
 */
863 864
static bool lvds_is_present_in_vbt(struct drm_device *dev,
				   u8 *i2c_pin)
865 866
{
	struct drm_i915_private *dev_priv = dev->dev_private;
867
	int i;
868 869

	if (!dev_priv->child_dev_num)
870
		return true;
871 872

	for (i = 0; i < dev_priv->child_dev_num; i++) {
873 874 875 876 877
		struct child_device_config *child = dev_priv->child_dev + i;

		/* If the device type is not LFP, continue.
		 * We have to check both the new identifiers as well as the
		 * old for compatibility with some BIOSes.
878
		 */
879 880
		if (child->device_type != DEVICE_TYPE_INT_LFP &&
		    child->device_type != DEVICE_TYPE_LFP)
881 882
			continue;

883 884
		if (intel_gmbus_is_port_valid(child->i2c_pin))
			*i2c_pin = child->i2c_pin;
885

886 887 888 889
		/* However, we cannot trust the BIOS writers to populate
		 * the VBT correctly.  Since LVDS requires additional
		 * information from AIM blocks, a non-zero addin offset is
		 * a good indicator that the LVDS is actually present.
890
		 */
891 892 893 894 895 896 897 898 899 900
		if (child->addin_offset)
			return true;

		/* But even then some BIOS writers perform some black magic
		 * and instantiate the device without reference to any
		 * additional data.  Trust that if the VBT was written into
		 * the OpRegion then they have validated the LVDS's existence.
		 */
		if (dev_priv->opregion.vbt)
			return true;
901
	}
902 903

	return false;
904 905
}

906 907 908 909 910 911 912 913 914 915 916 917
static bool intel_lvds_supported(struct drm_device *dev)
{
	/* With the introduction of the PCH we gained a dedicated
	 * LVDS presence pin, use it. */
	if (HAS_PCH_SPLIT(dev))
		return true;

	/* Otherwise LVDS was only attached to mobile products,
	 * except for the inglorious 830gm */
	return IS_MOBILE(dev) && !IS_I830(dev);
}

J
Jesse Barnes 已提交
918 919 920 921 922 923 924
/**
 * intel_lvds_init - setup LVDS connectors on this device
 * @dev: drm device
 *
 * Create the connector, register the LVDS DDC bus, and try to figure out what
 * modes we can display on the LVDS panel (if present).
 */
925
bool intel_lvds_init(struct drm_device *dev)
J
Jesse Barnes 已提交
926 927
{
	struct drm_i915_private *dev_priv = dev->dev_private;
928
	struct intel_lvds_encoder *lvds_encoder;
929
	struct intel_encoder *intel_encoder;
930
	struct intel_lvds_connector *lvds_connector;
931
	struct intel_connector *intel_connector;
J
Jesse Barnes 已提交
932 933 934
	struct drm_connector *connector;
	struct drm_encoder *encoder;
	struct drm_display_mode *scan; /* *modes, *bios_mode; */
935
	struct drm_display_mode *fixed_mode = NULL;
936
	struct edid *edid;
J
Jesse Barnes 已提交
937 938
	struct drm_crtc *crtc;
	u32 lvds;
939 940
	int pipe;
	u8 pin;
J
Jesse Barnes 已提交
941

942 943 944
	if (!intel_lvds_supported(dev))
		return false;

945 946
	/* Skip init on machines we know falsely report LVDS */
	if (dmi_check_system(intel_no_lvds))
947
		return false;
948

949 950
	pin = GMBUS_PORT_PANEL;
	if (!lvds_is_present_in_vbt(dev, &pin)) {
951
		DRM_DEBUG_KMS("LVDS is not present in VBT\n");
952
		return false;
A
Adam Jackson 已提交
953
	}
954

955
	if (HAS_PCH_SPLIT(dev)) {
956
		if ((I915_READ(PCH_LVDS) & LVDS_DETECTED) == 0)
957
			return false;
958
		if (dev_priv->edp.support) {
959
			DRM_DEBUG_KMS("disable LVDS for eDP support\n");
960
			return false;
961
		}
962 963
	}

964 965
	lvds_encoder = kzalloc(sizeof(struct intel_lvds_encoder), GFP_KERNEL);
	if (!lvds_encoder)
966
		return false;
J
Jesse Barnes 已提交
967

968 969
	lvds_connector = kzalloc(sizeof(struct intel_lvds_connector), GFP_KERNEL);
	if (!lvds_connector) {
970
		kfree(lvds_encoder);
971
		return false;
972 973
	}

974 975
	lvds_encoder->attached_connector = lvds_connector;

976
	if (!HAS_PCH_SPLIT(dev)) {
977
		lvds_encoder->pfit_control = I915_READ(PFIT_CONTROL);
978 979
	}

980
	intel_encoder = &lvds_encoder->base;
981
	encoder = &intel_encoder->base;
982
	intel_connector = &lvds_connector->base;
C
Chris Wilson 已提交
983
	connector = &intel_connector->base;
984
	drm_connector_init(dev, &intel_connector->base, &intel_lvds_connector_funcs,
J
Jesse Barnes 已提交
985 986
			   DRM_MODE_CONNECTOR_LVDS);

987
	drm_encoder_init(dev, &intel_encoder->base, &intel_lvds_enc_funcs,
J
Jesse Barnes 已提交
988 989
			 DRM_MODE_ENCODER_LVDS);

990 991
	intel_encoder->enable = intel_enable_lvds;
	intel_encoder->disable = intel_disable_lvds;
992 993
	intel_encoder->get_hw_state = intel_lvds_get_hw_state;
	intel_connector->get_hw_state = intel_connector_get_hw_state;
994

995
	intel_connector_attach_encoder(intel_connector, intel_encoder);
996
	intel_encoder->type = INTEL_OUTPUT_LVDS;
J
Jesse Barnes 已提交
997

998
	intel_encoder->cloneable = false;
J
Jesse Barnes 已提交
999 1000
	if (HAS_PCH_SPLIT(dev))
		intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
1001 1002
	else if (IS_GEN4(dev))
		intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
J
Jesse Barnes 已提交
1003 1004 1005
	else
		intel_encoder->crtc_mask = (1 << 1);

J
Jesse Barnes 已提交
1006 1007 1008 1009 1010 1011
	drm_encoder_helper_add(encoder, &intel_lvds_helper_funcs);
	drm_connector_helper_add(connector, &intel_lvds_connector_helper_funcs);
	connector->display_info.subpixel_order = SubPixelHorizontalRGB;
	connector->interlace_allowed = false;
	connector->doublescan_allowed = false;

1012 1013
	/* create the scaling mode property */
	drm_mode_create_scaling_mode_property(dev);
1014
	drm_object_attach_property(&connector->base,
1015
				      dev->mode_config.scaling_mode_property,
1016
				      DRM_MODE_SCALE_ASPECT);
1017
	intel_connector->panel.fitting_mode = DRM_MODE_SCALE_ASPECT;
J
Jesse Barnes 已提交
1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031
	/*
	 * LVDS discovery:
	 * 1) check for EDID on DDC
	 * 2) check for VBT data
	 * 3) check to see if LVDS is already on
	 *    if none of the above, no panel
	 * 4) make sure lid is open
	 *    if closed, act like it's not there for now
	 */

	/*
	 * Attempt to get the fixed panel mode from DDC.  Assume that the
	 * preferred mode is the right one.
	 */
1032 1033 1034
	edid = drm_get_edid(connector, intel_gmbus_get_adapter(dev_priv, pin));
	if (edid) {
		if (drm_add_edid_modes(connector, edid)) {
1035
			drm_mode_connector_update_edid_property(connector,
1036
								edid);
1037
		} else {
1038 1039
			kfree(edid);
			edid = ERR_PTR(-EINVAL);
1040
		}
1041 1042
	} else {
		edid = ERR_PTR(-ENOENT);
1043
	}
1044 1045 1046
	lvds_connector->base.edid = edid;

	if (IS_ERR_OR_NULL(edid)) {
1047 1048 1049 1050 1051 1052 1053 1054 1055
		/* Didn't get an EDID, so
		 * Set wide sync ranges so we get all modes
		 * handed to valid_mode for checking
		 */
		connector->display_info.min_vfreq = 0;
		connector->display_info.max_vfreq = 200;
		connector->display_info.min_hfreq = 0;
		connector->display_info.max_hfreq = 200;
	}
J
Jesse Barnes 已提交
1056 1057 1058

	list_for_each_entry(scan, &connector->probed_modes, head) {
		if (scan->type & DRM_MODE_TYPE_PREFERRED) {
1059 1060 1061
			DRM_DEBUG_KMS("using preferred mode from EDID: ");
			drm_mode_debug_printmodeline(scan);

1062
			fixed_mode = drm_mode_duplicate(dev, scan);
1063 1064 1065 1066 1067
			if (fixed_mode) {
				intel_find_lvds_downclock(dev, fixed_mode,
							  connector);
				goto out;
			}
J
Jesse Barnes 已提交
1068 1069 1070 1071
		}
	}

	/* Failed to get EDID, what about VBT? */
1072
	if (dev_priv->lfp_lvds_vbt_mode) {
1073 1074 1075
		DRM_DEBUG_KMS("using mode from VBT: ");
		drm_mode_debug_printmodeline(dev_priv->lfp_lvds_vbt_mode);

1076 1077 1078
		fixed_mode = drm_mode_duplicate(dev, dev_priv->lfp_lvds_vbt_mode);
		if (fixed_mode) {
			fixed_mode->type |= DRM_MODE_TYPE_PREFERRED;
1079 1080
			goto out;
		}
J
Jesse Barnes 已提交
1081 1082 1083 1084 1085 1086 1087
	}

	/*
	 * If we didn't get EDID, try checking if the panel is already turned
	 * on.  If so, assume that whatever is currently programmed is the
	 * correct mode.
	 */
1088

1089
	/* Ironlake: FIXME if still fail, not try pipe mode now */
1090
	if (HAS_PCH_SPLIT(dev))
1091 1092
		goto failed;

J
Jesse Barnes 已提交
1093 1094
	lvds = I915_READ(LVDS);
	pipe = (lvds & LVDS_PIPEB_SELECT) ? 1 : 0;
1095
	crtc = intel_get_crtc_for_pipe(dev, pipe);
J
Jesse Barnes 已提交
1096 1097

	if (crtc && (lvds & LVDS_PORT_EN)) {
1098 1099
		fixed_mode = intel_crtc_mode_get(dev, crtc);
		if (fixed_mode) {
1100 1101
			DRM_DEBUG_KMS("using current (BIOS) mode: ");
			drm_mode_debug_printmodeline(fixed_mode);
1102
			fixed_mode->type |= DRM_MODE_TYPE_PREFERRED;
1103
			goto out;
J
Jesse Barnes 已提交
1104 1105 1106 1107
		}
	}

	/* If we still don't have a mode after all that, give up. */
1108
	if (!fixed_mode)
J
Jesse Barnes 已提交
1109 1110 1111
		goto failed;

out:
1112 1113 1114 1115
	/*
	 * Unlock registers and just
	 * leave them unlocked
	 */
1116
	if (HAS_PCH_SPLIT(dev)) {
1117 1118 1119 1120 1121
		I915_WRITE(PCH_PP_CONTROL,
			   I915_READ(PCH_PP_CONTROL) | PANEL_UNLOCK_REGS);
	} else {
		I915_WRITE(PP_CONTROL,
			   I915_READ(PP_CONTROL) | PANEL_UNLOCK_REGS);
1122
	}
1123 1124
	lvds_connector->lid_notifier.notifier_call = intel_lid_notify;
	if (acpi_lid_notifier_register(&lvds_connector->lid_notifier)) {
1125
		DRM_DEBUG_KMS("lid notifier registration failed\n");
1126
		lvds_connector->lid_notifier.notifier_call = NULL;
1127
	}
J
Jesse Barnes 已提交
1128
	drm_sysfs_connector_add(connector);
1129

1130
	intel_panel_init(&intel_connector->panel, fixed_mode);
1131
	intel_panel_setup_backlight(connector);
1132

1133
	return true;
J
Jesse Barnes 已提交
1134 1135

failed:
1136
	DRM_DEBUG_KMS("No LVDS modes found, disabling.\n");
J
Jesse Barnes 已提交
1137
	drm_connector_cleanup(connector);
1138
	drm_encoder_cleanup(encoder);
1139 1140
	if (fixed_mode)
		drm_mode_destroy(dev, fixed_mode);
1141
	kfree(lvds_encoder);
1142
	kfree(lvds_connector);
1143
	return false;
J
Jesse Barnes 已提交
1144
}