intel_psr.c 30.4 KB
Newer Older
R
Rodrigo Vivi 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
/*
 * Copyright © 2014 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 */

R
Rodrigo Vivi 已提交
24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53
/**
 * DOC: Panel Self Refresh (PSR/SRD)
 *
 * Since Haswell Display controller supports Panel Self-Refresh on display
 * panels witch have a remote frame buffer (RFB) implemented according to PSR
 * spec in eDP1.3. PSR feature allows the display to go to lower standby states
 * when system is idle but display is on as it eliminates display refresh
 * request to DDR memory completely as long as the frame buffer for that
 * display is unchanged.
 *
 * Panel Self Refresh must be supported by both Hardware (source) and
 * Panel (sink).
 *
 * PSR saves power by caching the framebuffer in the panel RFB, which allows us
 * to power down the link and memory controller. For DSI panels the same idea
 * is called "manual mode".
 *
 * The implementation uses the hardware-based PSR support which automatically
 * enters/exits self-refresh mode. The hardware takes care of sending the
 * required DP aux message and could even retrain the link (that part isn't
 * enabled yet though). The hardware also keeps track of any frontbuffer
 * changes to know when to exit self-refresh mode again. Unfortunately that
 * part doesn't work too well, hence why the i915 PSR support uses the
 * software frontbuffer tracking to make sure it doesn't miss a screen
 * update. For this integration intel_psr_invalidate() and intel_psr_flush()
 * get called by the frontbuffer tracking code. Note that because of locking
 * issues the self-refresh re-enable code is done from a work queue, which
 * must be correctly synchronized/cancelled when shutting down the pipe."
 */

R
Rodrigo Vivi 已提交
54 55 56 57 58 59 60 61 62 63
#include <drm/drmP.h>

#include "intel_drv.h"
#include "i915_drv.h"

static bool is_edp_psr(struct intel_dp *intel_dp)
{
	return intel_dp->psr_dpcd[0] & DP_PSR_IS_SUPPORTED;
}

64 65
static bool vlv_is_psr_active_on_pipe(struct drm_device *dev, int pipe)
{
66
	struct drm_i915_private *dev_priv = to_i915(dev);
67 68 69 70 71 72 73 74
	uint32_t val;

	val = I915_READ(VLV_PSRSTAT(pipe)) &
	      VLV_EDP_PSR_CURR_STATE_MASK;
	return (val == VLV_EDP_PSR_ACTIVE_NORFB_UP) ||
	       (val == VLV_EDP_PSR_ACTIVE_SF_UPDATE);
}

R
Rodrigo Vivi 已提交
75
static void intel_psr_write_vsc(struct intel_dp *intel_dp,
76
				const struct edp_vsc_psr *vsc_psr)
R
Rodrigo Vivi 已提交
77 78 79
{
	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
	struct drm_device *dev = dig_port->base.base.dev;
80
	struct drm_i915_private *dev_priv = to_i915(dev);
R
Rodrigo Vivi 已提交
81
	struct intel_crtc *crtc = to_intel_crtc(dig_port->base.base.crtc);
82
	enum transcoder cpu_transcoder = crtc->config->cpu_transcoder;
83
	i915_reg_t ctl_reg = HSW_TVIDEO_DIP_CTL(cpu_transcoder);
R
Rodrigo Vivi 已提交
84 85 86 87 88 89 90 91 92
	uint32_t *data = (uint32_t *) vsc_psr;
	unsigned int i;

	/* As per BSPec (Pipe Video Data Island Packet), we need to disable
	   the video DIP being updated before program video DIP data buffer
	   registers for DIP being updated. */
	I915_WRITE(ctl_reg, 0);
	POSTING_READ(ctl_reg);

93 94 95 96
	for (i = 0; i < sizeof(*vsc_psr); i += 4) {
		I915_WRITE(HSW_TVIDEO_DIP_VSC_DATA(cpu_transcoder,
						   i >> 2), *data);
		data++;
R
Rodrigo Vivi 已提交
97
	}
98 99 100
	for (; i < VIDEO_DIP_VSC_DATA_SIZE; i += 4)
		I915_WRITE(HSW_TVIDEO_DIP_VSC_DATA(cpu_transcoder,
						   i >> 2), 0);
R
Rodrigo Vivi 已提交
101 102 103 104 105

	I915_WRITE(ctl_reg, VIDEO_DIP_ENABLE_VSC_HSW);
	POSTING_READ(ctl_reg);
}

106 107
static void vlv_psr_setup_vsc(struct intel_dp *intel_dp,
			      const struct intel_crtc_state *crtc_state)
108
{
109 110
	struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc);
	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
111 112 113
	uint32_t val;

	/* VLV auto-generate VSC package as per EDP 1.3 spec, Table 3.10 */
114
	val  = I915_READ(VLV_VSCSDP(crtc->pipe));
115 116
	val &= ~VLV_EDP_PSR_SDP_FREQ_MASK;
	val |= VLV_EDP_PSR_SDP_FREQ_EVFRAME;
117
	I915_WRITE(VLV_VSCSDP(crtc->pipe), val);
118 119
}

120 121
static void hsw_psr_setup_vsc(struct intel_dp *intel_dp,
			      const struct intel_crtc_state *crtc_state)
122
{
123
	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
124 125
	struct drm_i915_private *dev_priv = to_i915(intel_dig_port->base.base.dev);
	struct edp_vsc_psr psr_vsc;
126

127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142
	if (dev_priv->psr.psr2_support) {
		/* Prepare VSC Header for SU as per EDP 1.4 spec, Table 6.11 */
		memset(&psr_vsc, 0, sizeof(psr_vsc));
		psr_vsc.sdp_header.HB0 = 0;
		psr_vsc.sdp_header.HB1 = 0x7;
		if (dev_priv->psr.colorimetry_support &&
		    dev_priv->psr.y_cord_support) {
			psr_vsc.sdp_header.HB2 = 0x5;
			psr_vsc.sdp_header.HB3 = 0x13;
		} else if (dev_priv->psr.y_cord_support) {
			psr_vsc.sdp_header.HB2 = 0x4;
			psr_vsc.sdp_header.HB3 = 0xe;
		} else {
			psr_vsc.sdp_header.HB2 = 0x3;
			psr_vsc.sdp_header.HB3 = 0xc;
		}
143
	} else {
144 145 146 147 148 149
		/* Prepare VSC packet as per EDP 1.3 spec, Table 3.10 */
		memset(&psr_vsc, 0, sizeof(psr_vsc));
		psr_vsc.sdp_header.HB0 = 0;
		psr_vsc.sdp_header.HB1 = 0x7;
		psr_vsc.sdp_header.HB2 = 0x2;
		psr_vsc.sdp_header.HB3 = 0x8;
150 151
	}

152 153 154
	intel_psr_write_vsc(intel_dp, &psr_vsc);
}

155 156 157
static void vlv_psr_enable_sink(struct intel_dp *intel_dp)
{
	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG,
158
			   DP_PSR_ENABLE | DP_PSR_MAIN_LINK_ACTIVE);
159 160
}

161 162
static i915_reg_t psr_aux_ctl_reg(struct drm_i915_private *dev_priv,
				       enum port port)
163 164 165 166 167 168 169
{
	if (INTEL_INFO(dev_priv)->gen >= 9)
		return DP_AUX_CH_CTL(port);
	else
		return EDP_PSR_AUX_CTL;
}

170 171
static i915_reg_t psr_aux_data_reg(struct drm_i915_private *dev_priv,
					enum port port, int index)
172 173 174 175 176 177 178
{
	if (INTEL_INFO(dev_priv)->gen >= 9)
		return DP_AUX_CH_DATA(port, index);
	else
		return EDP_PSR_AUX_DATA(index);
}

179
static void hsw_psr_enable_sink(struct intel_dp *intel_dp)
R
Rodrigo Vivi 已提交
180 181 182
{
	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
	struct drm_device *dev = dig_port->base.base.dev;
183
	struct drm_i915_private *dev_priv = to_i915(dev);
R
Rodrigo Vivi 已提交
184
	uint32_t aux_clock_divider;
185
	i915_reg_t aux_ctl_reg;
R
Rodrigo Vivi 已提交
186 187 188 189 190 191 192
	static const uint8_t aux_msg[] = {
		[0] = DP_AUX_NATIVE_WRITE << 4,
		[1] = DP_SET_POWER >> 8,
		[2] = DP_SET_POWER & 0xff,
		[3] = 1 - 1,
		[4] = DP_SET_POWER_D0,
	};
193
	enum port port = dig_port->port;
194
	u32 aux_ctl;
R
Rodrigo Vivi 已提交
195 196 197 198 199 200
	int i;

	BUILD_BUG_ON(sizeof(aux_msg) > 20);

	aux_clock_divider = intel_dp->get_aux_clock_divider(intel_dp, 0);

201 202 203 204 205
	/* Enable AUX frame sync at sink */
	if (dev_priv->psr.aux_frame_sync)
		drm_dp_dpcd_writeb(&intel_dp->aux,
				DP_SINK_DEVICE_AUX_FRAME_SYNC_CONF,
				DP_AUX_FRAME_SYNC_ENABLE);
206 207 208 209 210
	/* Enable ALPM at sink for psr2 */
	if (dev_priv->psr.psr2_support && dev_priv->psr.alpm)
		drm_dp_dpcd_writeb(&intel_dp->aux,
				DP_RECEIVER_ALPM_CONFIG,
				DP_ALPM_ENABLE);
211 212 213 214 215 216 217
	if (dev_priv->psr.link_standby)
		drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG,
				   DP_PSR_ENABLE | DP_PSR_MAIN_LINK_ACTIVE);
	else
		drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG,
				   DP_PSR_ENABLE);

218
	aux_ctl_reg = psr_aux_ctl_reg(dev_priv, port);
219

R
Rodrigo Vivi 已提交
220 221
	/* Setup AUX registers */
	for (i = 0; i < sizeof(aux_msg); i += 4)
222
		I915_WRITE(psr_aux_data_reg(dev_priv, port, i >> 2),
R
Rodrigo Vivi 已提交
223 224
			   intel_dp_pack_aux(&aux_msg[i], sizeof(aux_msg) - i));

225 226 227
	aux_ctl = intel_dp->get_aux_send_ctl(intel_dp, 0, sizeof(aux_msg),
					     aux_clock_divider);
	I915_WRITE(aux_ctl_reg, aux_ctl);
R
Rodrigo Vivi 已提交
228 229
}

230 231
static void vlv_psr_enable_source(struct intel_dp *intel_dp,
				  const struct intel_crtc_state *crtc_state)
232 233
{
	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
234 235
	struct drm_i915_private *dev_priv = to_i915(dig_port->base.base.dev);
	struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc);
236

237
	/* Transition from PSR_state 0 (disabled) to PSR_state 1 (inactive) */
238
	I915_WRITE(VLV_PSRCTL(crtc->pipe),
239 240 241 242 243
		   VLV_EDP_PSR_MODE_SW_TIMER |
		   VLV_EDP_PSR_SRC_TRANSMITTER_STATE |
		   VLV_EDP_PSR_ENABLE);
}

244 245 246 247
static void vlv_psr_activate(struct intel_dp *intel_dp)
{
	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
	struct drm_device *dev = dig_port->base.base.dev;
248
	struct drm_i915_private *dev_priv = to_i915(dev);
249 250 251
	struct drm_crtc *crtc = dig_port->base.base.crtc;
	enum pipe pipe = to_intel_crtc(crtc)->pipe;

252 253 254 255 256
	/*
	 * Let's do the transition from PSR_state 1 (inactive) to
	 * PSR_state 2 (transition to active - static frame transmission).
	 * Then Hardware is responsible for the transition to
	 * PSR_state 3 (active - no Remote Frame Buffer (RFB) update).
257 258 259 260 261
	 */
	I915_WRITE(VLV_PSRCTL(pipe), I915_READ(VLV_PSRCTL(pipe)) |
		   VLV_EDP_PSR_ACTIVE_ENTRY);
}

R
Rodrigo Vivi 已提交
262
static void hsw_activate_psr1(struct intel_dp *intel_dp)
R
Rodrigo Vivi 已提交
263 264 265
{
	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
	struct drm_device *dev = dig_port->base.base.dev;
266
	struct drm_i915_private *dev_priv = to_i915(dev);
267

R
Rodrigo Vivi 已提交
268
	uint32_t max_sleep_time = 0x1f;
269 270 271 272 273 274
	/*
	 * Let's respect VBT in case VBT asks a higher idle_frame value.
	 * Let's use 6 as the minimum to cover all known cases including
	 * the off-by-one issue that HW has in some cases. Also there are
	 * cases where sink should be able to train
	 * with the 5 or 6 idle patterns.
275
	 */
276
	uint32_t idle_frames = max(6, dev_priv->vbt.psr.idle_frames);
277 278 279 280
	uint32_t val = EDP_PSR_ENABLE;

	val |= max_sleep_time << EDP_PSR_MAX_SLEEP_TIME_SHIFT;
	val |= idle_frames << EDP_PSR_IDLE_FRAME_SHIFT;
281

282
	if (IS_HASWELL(dev_priv))
283
		val |= EDP_PSR_MIN_LINK_ENTRY_TIME_8_LINES;
R
Rodrigo Vivi 已提交
284

285 286 287
	if (dev_priv->psr.link_standby)
		val |= EDP_PSR_LINK_STANDBY;

288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311
	if (dev_priv->vbt.psr.tp1_wakeup_time > 5)
		val |= EDP_PSR_TP1_TIME_2500us;
	else if (dev_priv->vbt.psr.tp1_wakeup_time > 1)
		val |= EDP_PSR_TP1_TIME_500us;
	else if (dev_priv->vbt.psr.tp1_wakeup_time > 0)
		val |= EDP_PSR_TP1_TIME_100us;
	else
		val |= EDP_PSR_TP1_TIME_0us;

	if (dev_priv->vbt.psr.tp2_tp3_wakeup_time > 5)
		val |= EDP_PSR_TP2_TP3_TIME_2500us;
	else if (dev_priv->vbt.psr.tp2_tp3_wakeup_time > 1)
		val |= EDP_PSR_TP2_TP3_TIME_500us;
	else if (dev_priv->vbt.psr.tp2_tp3_wakeup_time > 0)
		val |= EDP_PSR_TP2_TP3_TIME_100us;
	else
		val |= EDP_PSR_TP2_TP3_TIME_0us;

	if (intel_dp_source_supports_hbr2(intel_dp) &&
	    drm_dp_tps3_supported(intel_dp->dpcd))
		val |= EDP_PSR_TP1_TP3_SEL;
	else
		val |= EDP_PSR_TP1_TP2_SEL;

312
	val |= I915_READ(EDP_PSR_CTL) & EDP_PSR_RESTORE_PSR_ACTIVE_CTX_MASK;
313
	I915_WRITE(EDP_PSR_CTL, val);
314
}
315

R
Rodrigo Vivi 已提交
316
static void hsw_activate_psr2(struct intel_dp *intel_dp)
317 318 319 320 321 322 323 324 325 326 327 328 329 330 331
{
	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
	struct drm_device *dev = dig_port->base.base.dev;
	struct drm_i915_private *dev_priv = to_i915(dev);
	/*
	 * Let's respect VBT in case VBT asks a higher idle_frame value.
	 * Let's use 6 as the minimum to cover all known cases including
	 * the off-by-one issue that HW has in some cases. Also there are
	 * cases where sink should be able to train
	 * with the 5 or 6 idle patterns.
	 */
	uint32_t idle_frames = max(6, dev_priv->vbt.psr.idle_frames);
	uint32_t val;

	val = idle_frames << EDP_PSR_IDLE_FRAME_SHIFT;
332 333 334 335

	/* FIXME: selective update is probably totally broken because it doesn't
	 * mesh at all with our frontbuffer tracking. And the hw alone isn't
	 * good enough. */
336 337 338
	val |= EDP_PSR2_ENABLE |
		EDP_SU_TRACK_ENABLE |
		EDP_FRAMES_BEFORE_SU_ENTRY;
339 340 341 342 343 344 345 346 347

	if (dev_priv->vbt.psr.tp2_tp3_wakeup_time > 5)
		val |= EDP_PSR2_TP2_TIME_2500;
	else if (dev_priv->vbt.psr.tp2_tp3_wakeup_time > 1)
		val |= EDP_PSR2_TP2_TIME_500;
	else if (dev_priv->vbt.psr.tp2_tp3_wakeup_time > 0)
		val |= EDP_PSR2_TP2_TIME_100;
	else
		val |= EDP_PSR2_TP2_TIME_50;
348

349
	I915_WRITE(EDP_PSR2_CTL, val);
R
Rodrigo Vivi 已提交
350 351
}

R
Rodrigo Vivi 已提交
352
static void hsw_psr_activate(struct intel_dp *intel_dp)
353 354 355 356 357
{
	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
	struct drm_device *dev = dig_port->base.base.dev;
	struct drm_i915_private *dev_priv = to_i915(dev);

R
Rodrigo Vivi 已提交
358 359 360 361 362
	/* On HSW+ after we enable PSR on source it will activate it
	 * as soon as it match configure idle_frame count. So
	 * we just actually enable it here on activation time.
	 */

363 364
	/* psr1 and psr2 are mutually exclusive.*/
	if (dev_priv->psr.psr2_support)
R
Rodrigo Vivi 已提交
365
		hsw_activate_psr2(intel_dp);
366
	else
R
Rodrigo Vivi 已提交
367
		hsw_activate_psr1(intel_dp);
368 369
}

R
Rodrigo Vivi 已提交
370 371 372 373
static bool intel_psr_match_conditions(struct intel_dp *intel_dp)
{
	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
	struct drm_device *dev = dig_port->base.base.dev;
374
	struct drm_i915_private *dev_priv = to_i915(dev);
R
Rodrigo Vivi 已提交
375 376
	struct drm_crtc *crtc = dig_port->base.base.crtc;
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
377 378 379
	const struct drm_display_mode *adjusted_mode =
		&intel_crtc->config->base.adjusted_mode;
	int psr_setup_time;
R
Rodrigo Vivi 已提交
380 381 382 383 384 385 386

	lockdep_assert_held(&dev_priv->psr.lock);
	WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
	WARN_ON(!drm_modeset_is_locked(&crtc->mutex));

	dev_priv->psr.source_ok = false;

387 388 389 390 391 392 393
	/*
	 * HSW spec explicitly says PSR is tied to port A.
	 * BDW+ platforms with DDI implementation of PSR have different
	 * PSR registers per transcoder and we only implement transcoder EDP
	 * ones. Since by Display design transcoder EDP is tied to port A
	 * we can safely escape based on the port A.
	 */
394
	if (HAS_DDI(dev_priv) && dig_port->port != PORT_A) {
395
		DRM_DEBUG_KMS("PSR condition failed: Port not supported\n");
R
Rodrigo Vivi 已提交
396 397 398
		return false;
	}

399
	if (!i915_modparams.enable_psr) {
R
Rodrigo Vivi 已提交
400 401 402 403
		DRM_DEBUG_KMS("PSR disable by flag\n");
		return false;
	}

404
	if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) &&
405 406 407 408 409
	    !dev_priv->psr.link_standby) {
		DRM_ERROR("PSR condition failed: Link off requested but not supported on this platform\n");
		return false;
	}

410
	if (IS_HASWELL(dev_priv) &&
411
	    I915_READ(HSW_STEREO_3D_CTL(intel_crtc->config->cpu_transcoder)) &
412
		      S3D_ENABLE) {
R
Rodrigo Vivi 已提交
413 414 415 416
		DRM_DEBUG_KMS("PSR condition failed: Stereo 3D is Enabled\n");
		return false;
	}

417
	if (IS_HASWELL(dev_priv) &&
418
	    adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE) {
R
Rodrigo Vivi 已提交
419 420 421 422
		DRM_DEBUG_KMS("PSR condition failed: Interlaced is Enabled\n");
		return false;
	}

423 424 425 426 427 428 429 430 431 432 433 434 435 436
	psr_setup_time = drm_dp_psr_setup_time(intel_dp->psr_dpcd);
	if (psr_setup_time < 0) {
		DRM_DEBUG_KMS("PSR condition failed: Invalid PSR setup time (0x%02x)\n",
			      intel_dp->psr_dpcd[1]);
		return false;
	}

	if (intel_usecs_to_scanlines(adjusted_mode, psr_setup_time) >
	    adjusted_mode->crtc_vtotal - adjusted_mode->crtc_vdisplay - 1) {
		DRM_DEBUG_KMS("PSR condition failed: PSR setup time (%d us) too long\n",
			      psr_setup_time);
		return false;
	}

437
	/* PSR2 is restricted to work with panel resolutions upto 3200x2000 */
438 439 440
	if (dev_priv->psr.psr2_support &&
	    (intel_crtc->config->pipe_src_w > 3200 ||
	     intel_crtc->config->pipe_src_h > 2000)) {
441 442 443
		dev_priv->psr.psr2_support = false;
		return false;
	}
444 445 446 447 448 449 450 451 452

	/*
	 * FIXME:enable psr2 only for y-cordinate psr2 panels
	 * After gtc implementation , remove this restriction.
	 */
	if (!dev_priv->psr.y_cord_support &&  dev_priv->psr.psr2_support) {
		DRM_DEBUG_KMS("PSR2 disabled, panel does not support Y coordinate\n");
		return false;
	}
453

R
Rodrigo Vivi 已提交
454 455 456 457
	dev_priv->psr.source_ok = true;
	return true;
}

458
static void intel_psr_activate(struct intel_dp *intel_dp)
R
Rodrigo Vivi 已提交
459 460 461
{
	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
	struct drm_device *dev = intel_dig_port->base.base.dev;
462
	struct drm_i915_private *dev_priv = to_i915(dev);
R
Rodrigo Vivi 已提交
463

464 465 466 467
	if (dev_priv->psr.psr2_support)
		WARN_ON(I915_READ(EDP_PSR2_CTL) & EDP_PSR2_ENABLE);
	else
		WARN_ON(I915_READ(EDP_PSR_CTL) & EDP_PSR_ENABLE);
R
Rodrigo Vivi 已提交
468 469 470
	WARN_ON(dev_priv->psr.active);
	lockdep_assert_held(&dev_priv->psr.lock);

R
Rodrigo Vivi 已提交
471
	dev_priv->psr.activate(intel_dp);
R
Rodrigo Vivi 已提交
472 473 474
	dev_priv->psr.active = true;
}

475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510
static void hsw_psr_enable_source(struct intel_dp *intel_dp,
				  const struct intel_crtc_state *crtc_state)
{
	struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
	struct drm_device *dev = dig_port->base.base.dev;
	struct drm_i915_private *dev_priv = to_i915(dev);
	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
	u32 chicken;

	if (dev_priv->psr.psr2_support) {
		chicken = PSR2_VSC_ENABLE_PROG_HEADER;
		if (dev_priv->psr.y_cord_support)
			chicken |= PSR2_ADD_VERTICAL_LINE_COUNT;
		I915_WRITE(CHICKEN_TRANS(cpu_transcoder), chicken);

		I915_WRITE(EDP_PSR_DEBUG_CTL,
			   EDP_PSR_DEBUG_MASK_MEMUP |
			   EDP_PSR_DEBUG_MASK_HPD |
			   EDP_PSR_DEBUG_MASK_LPSP |
			   EDP_PSR_DEBUG_MASK_MAX_SLEEP |
			   EDP_PSR_DEBUG_MASK_DISP_REG_WRITE);
	} else {
		/*
		 * Per Spec: Avoid continuous PSR exit by masking MEMUP
		 * and HPD. also mask LPSP to avoid dependency on other
		 * drivers that might block runtime_pm besides
		 * preventing  other hw tracking issues now we can rely
		 * on frontbuffer tracking.
		 */
		I915_WRITE(EDP_PSR_DEBUG_CTL,
			   EDP_PSR_DEBUG_MASK_MEMUP |
			   EDP_PSR_DEBUG_MASK_HPD |
			   EDP_PSR_DEBUG_MASK_LPSP);
	}
}

R
Rodrigo Vivi 已提交
511 512 513
/**
 * intel_psr_enable - Enable PSR
 * @intel_dp: Intel DP
514
 * @crtc_state: new CRTC state
R
Rodrigo Vivi 已提交
515 516 517
 *
 * This function can only be called after the pipe is fully trained and enabled.
 */
518 519
void intel_psr_enable(struct intel_dp *intel_dp,
		      const struct intel_crtc_state *crtc_state)
R
Rodrigo Vivi 已提交
520 521 522
{
	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
	struct drm_device *dev = intel_dig_port->base.base.dev;
523
	struct drm_i915_private *dev_priv = to_i915(dev);
R
Rodrigo Vivi 已提交
524

525
	if (!HAS_PSR(dev_priv))
R
Rodrigo Vivi 已提交
526 527 528 529 530 531 532
		return;

	if (!is_edp_psr(intel_dp)) {
		DRM_DEBUG_KMS("PSR not supported by this panel\n");
		return;
	}

533
	WARN_ON(dev_priv->drrs.dp);
R
Rodrigo Vivi 已提交
534 535 536 537 538 539 540 541 542 543 544
	mutex_lock(&dev_priv->psr.lock);
	if (dev_priv->psr.enabled) {
		DRM_DEBUG_KMS("PSR already in use\n");
		goto unlock;
	}

	if (!intel_psr_match_conditions(intel_dp))
		goto unlock;

	dev_priv->psr.busy_frontbuffer_bits = 0;

545
	dev_priv->psr.setup_vsc(intel_dp, crtc_state);
546
	dev_priv->psr.enable_sink(intel_dp);
547
	dev_priv->psr.enable_source(intel_dp, crtc_state);
548 549 550 551 552 553 554 555 556 557 558 559 560 561 562
	dev_priv->psr.enabled = intel_dp;

	if (INTEL_GEN(dev_priv) >= 9) {
		intel_psr_activate(intel_dp);
	} else {
		/*
		 * FIXME: Activation should happen immediately since this
		 * function is just called after pipe is fully trained and
		 * enabled.
		 * However on some platforms we face issues when first
		 * activation follows a modeset so quickly.
		 *     - On VLV/CHV we get bank screen on first activation
		 *     - On HSW/BDW we get a recoverable frozen screen until
		 *       next exit-activate sequence.
		 */
563 564
		schedule_delayed_work(&dev_priv->psr.work,
				      msecs_to_jiffies(intel_dp->panel_power_cycle_delay * 5));
565
	}
566

R
Rodrigo Vivi 已提交
567 568 569 570
unlock:
	mutex_unlock(&dev_priv->psr.lock);
}

571 572
static void vlv_psr_disable(struct intel_dp *intel_dp,
			    const struct intel_crtc_state *old_crtc_state)
R
Rodrigo Vivi 已提交
573 574 575
{
	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
	struct drm_device *dev = intel_dig_port->base.base.dev;
576
	struct drm_i915_private *dev_priv = to_i915(dev);
577
	struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->base.crtc);
578
	uint32_t val;
R
Rodrigo Vivi 已提交
579

580
	if (dev_priv->psr.active) {
581
		/* Put VLV PSR back to PSR_state 0 (disabled). */
582
		if (intel_wait_for_register(dev_priv,
583
					    VLV_PSRSTAT(crtc->pipe),
584 585 586
					    VLV_EDP_PSR_IN_TRANS,
					    0,
					    1))
587 588
			WARN(1, "PSR transition took longer than expected\n");

589
		val = I915_READ(VLV_PSRCTL(crtc->pipe));
590 591 592
		val &= ~VLV_EDP_PSR_ACTIVE_ENTRY;
		val &= ~VLV_EDP_PSR_ENABLE;
		val &= ~VLV_EDP_PSR_MODE_MASK;
593
		I915_WRITE(VLV_PSRCTL(crtc->pipe), val);
594 595 596

		dev_priv->psr.active = false;
	} else {
597
		WARN_ON(vlv_is_psr_active_on_pipe(dev, crtc->pipe));
R
Rodrigo Vivi 已提交
598
	}
599 600
}

601 602
static void hsw_psr_disable(struct intel_dp *intel_dp,
			    const struct intel_crtc_state *old_crtc_state)
603 604 605
{
	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
	struct drm_device *dev = intel_dig_port->base.base.dev;
606
	struct drm_i915_private *dev_priv = to_i915(dev);
R
Rodrigo Vivi 已提交
607 608

	if (dev_priv->psr.active) {
609 610 611
		i915_reg_t psr_ctl;
		u32 psr_status_mask;

612 613 614 615 616
		if (dev_priv->psr.aux_frame_sync)
			drm_dp_dpcd_writeb(&intel_dp->aux,
					DP_SINK_DEVICE_AUX_FRAME_SYNC_CONF,
					0);

617
		if (dev_priv->psr.psr2_support) {
618 619 620 621 622 623 624
			psr_ctl = EDP_PSR2_CTL;
			psr_status_mask = EDP_PSR2_STATUS_STATE_MASK;

			I915_WRITE(psr_ctl,
				   I915_READ(psr_ctl) &
				   ~(EDP_PSR2_ENABLE | EDP_SU_TRACK_ENABLE));

625
		} else {
626 627 628 629 630
			psr_ctl = EDP_PSR_STATUS_CTL;
			psr_status_mask = EDP_PSR_STATUS_STATE_MASK;

			I915_WRITE(psr_ctl,
				   I915_READ(psr_ctl) & ~EDP_PSR_ENABLE);
631
		}
632 633 634 635 636 637 638

		/* Wait till PSR is idle */
		if (intel_wait_for_register(dev_priv,
					    psr_ctl, psr_status_mask, 0,
					    2000))
			DRM_ERROR("Timed out waiting for PSR Idle State\n");

R
Rodrigo Vivi 已提交
639 640
		dev_priv->psr.active = false;
	} else {
641 642 643 644
		if (dev_priv->psr.psr2_support)
			WARN_ON(I915_READ(EDP_PSR2_CTL) & EDP_PSR2_ENABLE);
		else
			WARN_ON(I915_READ(EDP_PSR_CTL) & EDP_PSR_ENABLE);
R
Rodrigo Vivi 已提交
645
	}
646 647 648 649 650
}

/**
 * intel_psr_disable - Disable PSR
 * @intel_dp: Intel DP
651
 * @old_crtc_state: old CRTC state
652 653 654
 *
 * This function needs to be called before disabling pipe.
 */
655 656
void intel_psr_disable(struct intel_dp *intel_dp,
		       const struct intel_crtc_state *old_crtc_state)
657 658 659
{
	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
	struct drm_device *dev = intel_dig_port->base.base.dev;
660
	struct drm_i915_private *dev_priv = to_i915(dev);
661

662 663 664
	if (!HAS_PSR(dev_priv))
		return;

665 666 667 668 669 670
	mutex_lock(&dev_priv->psr.lock);
	if (!dev_priv->psr.enabled) {
		mutex_unlock(&dev_priv->psr.lock);
		return;
	}

671
	dev_priv->psr.disable_source(intel_dp, old_crtc_state);
R
Rodrigo Vivi 已提交
672

673 674 675
	/* Disable PSR on Sink */
	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG, 0);

R
Rodrigo Vivi 已提交
676 677 678 679 680 681 682 683 684 685 686
	dev_priv->psr.enabled = NULL;
	mutex_unlock(&dev_priv->psr.lock);

	cancel_delayed_work_sync(&dev_priv->psr.work);
}

static void intel_psr_work(struct work_struct *work)
{
	struct drm_i915_private *dev_priv =
		container_of(work, typeof(*dev_priv), psr.work.work);
	struct intel_dp *intel_dp = dev_priv->psr.enabled;
687 688
	struct drm_crtc *crtc = dp_to_dig_port(intel_dp)->base.base.crtc;
	enum pipe pipe = to_intel_crtc(crtc)->pipe;
R
Rodrigo Vivi 已提交
689 690 691 692 693 694

	/* We have to make sure PSR is ready for re-enable
	 * otherwise it keeps disabled until next full enable/disable cycle.
	 * PSR might take some time to get fully disabled
	 * and be ready for re-enable.
	 */
695
	if (HAS_DDI(dev_priv)) {
696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713
		if (dev_priv->psr.psr2_support) {
			if (intel_wait_for_register(dev_priv,
						EDP_PSR2_STATUS_CTL,
						EDP_PSR2_STATUS_STATE_MASK,
						0,
						50)) {
				DRM_ERROR("Timed out waiting for PSR2 Idle for re-enable\n");
				return;
			}
		} else {
			if (intel_wait_for_register(dev_priv,
						EDP_PSR_STATUS_CTL,
						EDP_PSR_STATUS_STATE_MASK,
						0,
						50)) {
				DRM_ERROR("Timed out waiting for PSR Idle for re-enable\n");
				return;
			}
714 715
		}
	} else {
716 717 718 719 720
		if (intel_wait_for_register(dev_priv,
					    VLV_PSRSTAT(pipe),
					    VLV_EDP_PSR_IN_TRANS,
					    0,
					    1)) {
721 722 723
			DRM_ERROR("Timed out waiting for PSR Idle for re-enable\n");
			return;
		}
R
Rodrigo Vivi 已提交
724 725 726 727 728 729 730 731 732 733 734 735 736 737 738
	}
	mutex_lock(&dev_priv->psr.lock);
	intel_dp = dev_priv->psr.enabled;

	if (!intel_dp)
		goto unlock;

	/*
	 * The delayed work can race with an invalidate hence we need to
	 * recheck. Since psr_flush first clears this and then reschedules we
	 * won't ever miss a flush when bailing out here.
	 */
	if (dev_priv->psr.busy_frontbuffer_bits)
		goto unlock;

739
	intel_psr_activate(intel_dp);
R
Rodrigo Vivi 已提交
740 741 742 743
unlock:
	mutex_unlock(&dev_priv->psr.lock);
}

744
static void intel_psr_exit(struct drm_i915_private *dev_priv)
R
Rodrigo Vivi 已提交
745
{
746 747 748 749
	struct intel_dp *intel_dp = dev_priv->psr.enabled;
	struct drm_crtc *crtc = dp_to_dig_port(intel_dp)->base.base.crtc;
	enum pipe pipe = to_intel_crtc(crtc)->pipe;
	u32 val;
R
Rodrigo Vivi 已提交
750

751 752 753
	if (!dev_priv->psr.active)
		return;

754
	if (HAS_DDI(dev_priv)) {
755 756 757 758
		if (dev_priv->psr.aux_frame_sync)
			drm_dp_dpcd_writeb(&intel_dp->aux,
					DP_SINK_DEVICE_AUX_FRAME_SYNC_CONF,
					0);
759 760 761 762 763 764 765 766 767
		if (dev_priv->psr.psr2_support) {
			val = I915_READ(EDP_PSR2_CTL);
			WARN_ON(!(val & EDP_PSR2_ENABLE));
			I915_WRITE(EDP_PSR2_CTL, val & ~EDP_PSR2_ENABLE);
		} else {
			val = I915_READ(EDP_PSR_CTL);
			WARN_ON(!(val & EDP_PSR_ENABLE));
			I915_WRITE(EDP_PSR_CTL, val & ~EDP_PSR_ENABLE);
		}
768 769 770
	} else {
		val = I915_READ(VLV_PSRCTL(pipe));

771 772 773 774 775 776 777 778
		/*
		 * Here we do the transition drirectly from
		 * PSR_state 3 (active - no Remote Frame Buffer (RFB) update) to
		 * PSR_state 5 (exit).
		 * PSR State 4 (active with single frame update) can be skipped.
		 * On PSR_state 5 (exit) Hardware is responsible to transition
		 * back to PSR_state 1 (inactive).
		 * Now we are at Same state after vlv_psr_enable_source.
779 780 781 782
		 */
		val &= ~VLV_EDP_PSR_ACTIVE_ENTRY;
		I915_WRITE(VLV_PSRCTL(pipe), val);

783 784
		/*
		 * Send AUX wake up - Spec says after transitioning to PSR
785 786 787 788 789 790 791 792
		 * active we have to send AUX wake up by writing 01h in DPCD
		 * 600h of sink device.
		 * XXX: This might slow down the transition, but without this
		 * HW doesn't complete the transition to PSR_state 1 and we
		 * never get the screen updated.
		 */
		drm_dp_dpcd_writeb(&intel_dp->aux, DP_SET_POWER,
				   DP_SET_POWER_D0);
R
Rodrigo Vivi 已提交
793 794
	}

795
	dev_priv->psr.active = false;
R
Rodrigo Vivi 已提交
796 797
}

798 799
/**
 * intel_psr_single_frame_update - Single Frame Update
800
 * @dev_priv: i915 device
801
 * @frontbuffer_bits: frontbuffer plane tracking bits
802 803 804 805 806 807
 *
 * Some platforms support a single frame update feature that is used to
 * send and update only one frame on Remote Frame Buffer.
 * So far it is only implemented for Valleyview and Cherryview because
 * hardware requires this to be done before a page flip.
 */
808
void intel_psr_single_frame_update(struct drm_i915_private *dev_priv,
809
				   unsigned frontbuffer_bits)
810 811 812 813 814
{
	struct drm_crtc *crtc;
	enum pipe pipe;
	u32 val;

815 816 817
	if (!HAS_PSR(dev_priv))
		return;

818 819 820 821
	/*
	 * Single frame update is already supported on BDW+ but it requires
	 * many W/A and it isn't really needed.
	 */
822
	if (!IS_VALLEYVIEW(dev_priv) && !IS_CHERRYVIEW(dev_priv))
823 824 825 826 827 828 829 830 831 832 833
		return;

	mutex_lock(&dev_priv->psr.lock);
	if (!dev_priv->psr.enabled) {
		mutex_unlock(&dev_priv->psr.lock);
		return;
	}

	crtc = dp_to_dig_port(dev_priv->psr.enabled)->base.base.crtc;
	pipe = to_intel_crtc(crtc)->pipe;

834 835
	if (frontbuffer_bits & INTEL_FRONTBUFFER_ALL_MASK(pipe)) {
		val = I915_READ(VLV_PSRCTL(pipe));
836

837 838 839 840 841 842
		/*
		 * We need to set this bit before writing registers for a flip.
		 * This bit will be self-clear when it gets to the PSR active state.
		 */
		I915_WRITE(VLV_PSRCTL(pipe), val | VLV_EDP_PSR_SINGLE_FRAME_UPDATE);
	}
843 844 845
	mutex_unlock(&dev_priv->psr.lock);
}

R
Rodrigo Vivi 已提交
846 847
/**
 * intel_psr_invalidate - Invalidade PSR
848
 * @dev_priv: i915 device
R
Rodrigo Vivi 已提交
849 850 851 852 853 854 855 856 857
 * @frontbuffer_bits: frontbuffer plane tracking bits
 *
 * Since the hardware frontbuffer tracking has gaps we need to integrate
 * with the software frontbuffer tracking. This function gets called every
 * time frontbuffer rendering starts and a buffer gets dirtied. PSR must be
 * disabled if the frontbuffer mask contains a buffer relevant to PSR.
 *
 * Dirty frontbuffers relevant to PSR are tracked in busy_frontbuffer_bits."
 */
858
void intel_psr_invalidate(struct drm_i915_private *dev_priv,
859
			  unsigned frontbuffer_bits)
R
Rodrigo Vivi 已提交
860 861 862 863
{
	struct drm_crtc *crtc;
	enum pipe pipe;

864 865 866
	if (!HAS_PSR(dev_priv))
		return;

R
Rodrigo Vivi 已提交
867 868 869 870 871 872 873 874 875 876 877
	mutex_lock(&dev_priv->psr.lock);
	if (!dev_priv->psr.enabled) {
		mutex_unlock(&dev_priv->psr.lock);
		return;
	}

	crtc = dp_to_dig_port(dev_priv->psr.enabled)->base.base.crtc;
	pipe = to_intel_crtc(crtc)->pipe;

	frontbuffer_bits &= INTEL_FRONTBUFFER_ALL_MASK(pipe);
	dev_priv->psr.busy_frontbuffer_bits |= frontbuffer_bits;
878 879

	if (frontbuffer_bits)
880
		intel_psr_exit(dev_priv);
881

R
Rodrigo Vivi 已提交
882 883 884
	mutex_unlock(&dev_priv->psr.lock);
}

R
Rodrigo Vivi 已提交
885 886
/**
 * intel_psr_flush - Flush PSR
887
 * @dev_priv: i915 device
R
Rodrigo Vivi 已提交
888
 * @frontbuffer_bits: frontbuffer plane tracking bits
889
 * @origin: which operation caused the flush
R
Rodrigo Vivi 已提交
890 891 892 893 894 895 896 897
 *
 * Since the hardware frontbuffer tracking has gaps we need to integrate
 * with the software frontbuffer tracking. This function gets called every
 * time frontbuffer rendering has completed and flushed out to memory. PSR
 * can be enabled again if no other frontbuffer relevant to PSR is dirty.
 *
 * Dirty frontbuffers relevant to PSR are tracked in busy_frontbuffer_bits.
 */
898
void intel_psr_flush(struct drm_i915_private *dev_priv,
899
		     unsigned frontbuffer_bits, enum fb_op_origin origin)
R
Rodrigo Vivi 已提交
900 901 902 903
{
	struct drm_crtc *crtc;
	enum pipe pipe;

904 905 906
	if (!HAS_PSR(dev_priv))
		return;

R
Rodrigo Vivi 已提交
907 908 909 910 911 912 913 914
	mutex_lock(&dev_priv->psr.lock);
	if (!dev_priv->psr.enabled) {
		mutex_unlock(&dev_priv->psr.lock);
		return;
	}

	crtc = dp_to_dig_port(dev_priv->psr.enabled)->base.base.crtc;
	pipe = to_intel_crtc(crtc)->pipe;
915 916

	frontbuffer_bits &= INTEL_FRONTBUFFER_ALL_MASK(pipe);
R
Rodrigo Vivi 已提交
917 918
	dev_priv->psr.busy_frontbuffer_bits &= ~frontbuffer_bits;

919 920
	/* By definition flush = invalidate + flush */
	if (frontbuffer_bits)
921
		intel_psr_exit(dev_priv);
922

R
Rodrigo Vivi 已提交
923
	if (!dev_priv->psr.active && !dev_priv->psr.busy_frontbuffer_bits)
924 925
		if (!work_busy(&dev_priv->psr.work.work))
			schedule_delayed_work(&dev_priv->psr.work,
926
					      msecs_to_jiffies(100));
R
Rodrigo Vivi 已提交
927 928 929
	mutex_unlock(&dev_priv->psr.lock);
}

R
Rodrigo Vivi 已提交
930 931
/**
 * intel_psr_init - Init basic PSR work and mutex.
932
 * @dev_priv: i915 device private
R
Rodrigo Vivi 已提交
933 934 935 936
 *
 * This function is  called only once at driver load to initialize basic
 * PSR stuff.
 */
937
void intel_psr_init(struct drm_i915_private *dev_priv)
R
Rodrigo Vivi 已提交
938
{
939 940 941
	if (!HAS_PSR(dev_priv))
		return;

942 943 944
	dev_priv->psr_mmio_base = IS_HASWELL(dev_priv) ?
		HSW_EDP_PSR_BASE : BDW_EDP_PSR_BASE;

945
	/* Per platform default: all disabled. */
946 947
	if (i915_modparams.enable_psr == -1)
		i915_modparams.enable_psr = 0;
948

949
	/* Set link_standby x link_off defaults */
950
	if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
951 952
		/* HSW and BDW require workarounds that we don't implement. */
		dev_priv->psr.link_standby = false;
953
	else if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
954 955 956 957 958 959
		/* On VLV and CHV only standby mode is supported. */
		dev_priv->psr.link_standby = true;
	else
		/* For new platforms let's respect VBT back again */
		dev_priv->psr.link_standby = dev_priv->vbt.psr.full_link;

960
	/* Override link_standby x link_off defaults */
961
	if (i915_modparams.enable_psr == 2 && !dev_priv->psr.link_standby) {
962 963 964
		DRM_DEBUG_KMS("PSR: Forcing link standby\n");
		dev_priv->psr.link_standby = true;
	}
965
	if (i915_modparams.enable_psr == 3 && dev_priv->psr.link_standby) {
966 967 968 969
		DRM_DEBUG_KMS("PSR: Forcing main link off\n");
		dev_priv->psr.link_standby = false;
	}

R
Rodrigo Vivi 已提交
970 971
	INIT_DELAYED_WORK(&dev_priv->psr.work, intel_psr_work);
	mutex_init(&dev_priv->psr.lock);
972 973

	if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) {
974
		dev_priv->psr.enable_source = vlv_psr_enable_source;
975
		dev_priv->psr.disable_source = vlv_psr_disable;
976
		dev_priv->psr.enable_sink = vlv_psr_enable_sink;
R
Rodrigo Vivi 已提交
977
		dev_priv->psr.activate = vlv_psr_activate;
978
		dev_priv->psr.setup_vsc = vlv_psr_setup_vsc;
979
	} else {
980
		dev_priv->psr.enable_source = hsw_psr_enable_source;
981
		dev_priv->psr.disable_source = hsw_psr_disable;
982
		dev_priv->psr.enable_sink = hsw_psr_enable_sink;
R
Rodrigo Vivi 已提交
983
		dev_priv->psr.activate = hsw_psr_activate;
984
		dev_priv->psr.setup_vsc = hsw_psr_setup_vsc;
985
	}
R
Rodrigo Vivi 已提交
986
}