intel_crt.c 15.2 KB
Newer Older
J
Jesse Barnes 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27
/*
 * Copyright © 2006-2007 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 *
 * Authors:
 *	Eric Anholt <eric@anholt.net>
 */

#include <linux/i2c.h>
28
#include <linux/slab.h>
J
Jesse Barnes 已提交
29 30 31 32 33 34 35 36 37 38 39 40
#include "drmP.h"
#include "drm.h"
#include "drm_crtc.h"
#include "drm_crtc_helper.h"
#include "intel_drv.h"
#include "i915_drm.h"
#include "i915_drv.h"

static void intel_crt_dpms(struct drm_encoder *encoder, int mode)
{
	struct drm_device *dev = encoder->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
41
	u32 temp, reg;
J
Jesse Barnes 已提交
42

43
	if (HAS_PCH_SPLIT(dev))
44 45 46 47 48
		reg = PCH_ADPA;
	else
		reg = ADPA;

	temp = I915_READ(reg);
J
Jesse Barnes 已提交
49
	temp &= ~(ADPA_HSYNC_CNTL_DISABLE | ADPA_VSYNC_CNTL_DISABLE);
50
	temp &= ~ADPA_DAC_ENABLE;
J
Jesse Barnes 已提交
51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66

	switch(mode) {
	case DRM_MODE_DPMS_ON:
		temp |= ADPA_DAC_ENABLE;
		break;
	case DRM_MODE_DPMS_STANDBY:
		temp |= ADPA_DAC_ENABLE | ADPA_HSYNC_CNTL_DISABLE;
		break;
	case DRM_MODE_DPMS_SUSPEND:
		temp |= ADPA_DAC_ENABLE | ADPA_VSYNC_CNTL_DISABLE;
		break;
	case DRM_MODE_DPMS_OFF:
		temp |= ADPA_HSYNC_CNTL_DISABLE | ADPA_VSYNC_CNTL_DISABLE;
		break;
	}

67
	I915_WRITE(reg, temp);
J
Jesse Barnes 已提交
68 69 70 71 72
}

static int intel_crt_mode_valid(struct drm_connector *connector,
				struct drm_display_mode *mode)
{
73 74 75
	struct drm_device *dev = connector->dev;

	int max_clock = 0;
J
Jesse Barnes 已提交
76 77 78
	if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
		return MODE_NO_DBLESCAN;

79 80 81 82 83 84 85 86 87
	if (mode->clock < 25000)
		return MODE_CLOCK_LOW;

	if (!IS_I9XX(dev))
		max_clock = 350000;
	else
		max_clock = 400000;
	if (mode->clock > max_clock)
		return MODE_CLOCK_HIGH;
J
Jesse Barnes 已提交
88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109

	return MODE_OK;
}

static bool intel_crt_mode_fixup(struct drm_encoder *encoder,
				 struct drm_display_mode *mode,
				 struct drm_display_mode *adjusted_mode)
{
	return true;
}

static void intel_crt_mode_set(struct drm_encoder *encoder,
			       struct drm_display_mode *mode,
			       struct drm_display_mode *adjusted_mode)
{

	struct drm_device *dev = encoder->dev;
	struct drm_crtc *crtc = encoder->crtc;
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
	struct drm_i915_private *dev_priv = dev->dev_private;
	int dpll_md_reg;
	u32 adpa, dpll_md;
110
	u32 adpa_reg;
J
Jesse Barnes 已提交
111 112 113 114 115 116

	if (intel_crtc->pipe == 0)
		dpll_md_reg = DPLL_A_MD;
	else
		dpll_md_reg = DPLL_B_MD;

117
	if (HAS_PCH_SPLIT(dev))
118 119 120 121
		adpa_reg = PCH_ADPA;
	else
		adpa_reg = ADPA;

J
Jesse Barnes 已提交
122 123 124 125
	/*
	 * Disable separate mode multiplier used when cloning SDVO to CRT
	 * XXX this needs to be adjusted when we really are cloning
	 */
126
	if (IS_I965G(dev) && !HAS_PCH_SPLIT(dev)) {
J
Jesse Barnes 已提交
127 128 129 130 131 132 133 134 135 136 137
		dpll_md = I915_READ(dpll_md_reg);
		I915_WRITE(dpll_md_reg,
			   dpll_md & ~DPLL_MD_UDI_MULTIPLIER_MASK);
	}

	adpa = 0;
	if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
		adpa |= ADPA_HSYNC_ACTIVE_HIGH;
	if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
		adpa |= ADPA_VSYNC_ACTIVE_HIGH;

138
	if (intel_crtc->pipe == 0) {
139 140 141 142
		if (HAS_PCH_CPT(dev))
			adpa |= PORT_TRANS_A_SEL_CPT;
		else
			adpa |= ADPA_PIPE_A_SELECT;
143
		if (!HAS_PCH_SPLIT(dev))
144
			I915_WRITE(BCLRPAT_A, 0);
145
	} else {
146 147 148 149
		if (HAS_PCH_CPT(dev))
			adpa |= PORT_TRANS_B_SEL_CPT;
		else
			adpa |= ADPA_PIPE_B_SELECT;
150
		if (!HAS_PCH_SPLIT(dev))
151
			I915_WRITE(BCLRPAT_B, 0);
152
	}
J
Jesse Barnes 已提交
153

154 155 156
	I915_WRITE(adpa_reg, adpa);
}

157
static bool intel_ironlake_crt_detect_hotplug(struct drm_connector *connector)
158 159 160
{
	struct drm_device *dev = connector->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
161
	u32 adpa, temp;
162
	bool ret;
163
	bool turn_off_dac = false;
164

165
	temp = adpa = I915_READ(PCH_ADPA);
Z
Zhenyu Wang 已提交
166

167 168 169 170 171 172 173 174 175 176
	if (HAS_PCH_SPLIT(dev))
		turn_off_dac = true;

	adpa &= ~ADPA_CRT_HOTPLUG_MASK;
	if (turn_off_dac)
		adpa &= ~ADPA_DAC_ENABLE;

	/* disable HPD first */
	I915_WRITE(PCH_ADPA, adpa);
	(void)I915_READ(PCH_ADPA);
177 178 179 180 181 182 183 184 185

	adpa |= (ADPA_CRT_HOTPLUG_PERIOD_128 |
			ADPA_CRT_HOTPLUG_WARMUP_10MS |
			ADPA_CRT_HOTPLUG_SAMPLE_4S |
			ADPA_CRT_HOTPLUG_VOLTAGE_50 | /* default */
			ADPA_CRT_HOTPLUG_VOLREF_325MV |
			ADPA_CRT_HOTPLUG_ENABLE |
			ADPA_CRT_HOTPLUG_FORCE_TRIGGER);

186
	DRM_DEBUG_KMS("pch crt adpa 0x%x", adpa);
187 188
	I915_WRITE(PCH_ADPA, adpa);

189 190 191
	if (wait_for((I915_READ(PCH_ADPA) & ADPA_CRT_HOTPLUG_FORCE_TRIGGER) == 0,
		     1000, 1))
		DRM_ERROR("timed out waiting for FORCE_TRIGGER");
192

193
	if (turn_off_dac) {
194 195 196 197
		I915_WRITE(PCH_ADPA, temp);
		(void)I915_READ(PCH_ADPA);
	}

198 199
	/* Check the status to see if both blue and green are on now */
	adpa = I915_READ(PCH_ADPA);
Z
Zhenyu Wang 已提交
200 201 202
	adpa &= ADPA_CRT_HOTPLUG_MONITOR_MASK;
	if ((adpa == ADPA_CRT_HOTPLUG_MONITOR_COLOR) ||
		(adpa == ADPA_CRT_HOTPLUG_MONITOR_MONO))
203 204 205 206 207
		ret = true;
	else
		ret = false;

	return ret;
J
Jesse Barnes 已提交
208 209 210 211 212 213 214 215 216 217 218 219 220 221
}

/**
 * Uses CRT_HOTPLUG_EN and CRT_HOTPLUG_STAT to detect CRT presence.
 *
 * Not for i915G/i915GM
 *
 * \return true if CRT is connected.
 * \return false if CRT is disconnected.
 */
static bool intel_crt_detect_hotplug(struct drm_connector *connector)
{
	struct drm_device *dev = connector->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
222 223
	u32 hotplug_en, orig, stat;
	bool ret = false;
224
	int i, tries = 0;
225

226
	if (HAS_PCH_SPLIT(dev))
227
		return intel_ironlake_crt_detect_hotplug(connector);
228

229 230 231 232
	/*
	 * On 4 series desktop, CRT detect sequence need to be done twice
	 * to get a reliable result.
	 */
J
Jesse Barnes 已提交
233

234 235 236 237
	if (IS_G4X(dev) && !IS_GM45(dev))
		tries = 2;
	else
		tries = 1;
238
	hotplug_en = orig = I915_READ(PORT_HOTPLUG_EN);
239 240 241 242 243 244
	hotplug_en |= CRT_HOTPLUG_FORCE_DETECT;

	for (i = 0; i < tries ; i++) {
		/* turn on the FORCE_DETECT */
		I915_WRITE(PORT_HOTPLUG_EN, hotplug_en);
		/* wait for FORCE_DETECT to go off */
245 246 247 248
		if (wait_for((I915_READ(PORT_HOTPLUG_EN) &
			      CRT_HOTPLUG_FORCE_DETECT) == 0,
			     1000, 1))
			DRM_ERROR("timed out waiting for FORCE_DETECT to go off");
249
	}
J
Jesse Barnes 已提交
250

251 252 253 254 255 256
	stat = I915_READ(PORT_HOTPLUG_STAT);
	if ((stat & CRT_HOTPLUG_MONITOR_MASK) != CRT_HOTPLUG_MONITOR_NONE)
		ret = true;

	/* clear the interrupt we just generated, if any */
	I915_WRITE(PORT_HOTPLUG_STAT, CRT_HOTPLUG_INT_STATUS);
J
Jesse Barnes 已提交
257

258 259 260 261
	/* and put the bits back */
	I915_WRITE(PORT_HOTPLUG_EN, orig);

	return ret;
J
Jesse Barnes 已提交
262 263
}

264
static bool intel_crt_detect_ddc(struct drm_encoder *encoder)
J
Jesse Barnes 已提交
265
{
266
	struct intel_encoder *intel_encoder = enc_to_intel_encoder(encoder);
J
Jesse Barnes 已提交
267 268

	/* CRT should always be at 0, but check anyway */
269
	if (intel_encoder->type != INTEL_OUTPUT_ANALOG)
J
Jesse Barnes 已提交
270 271
		return false;

272
	return intel_ddc_probe(intel_encoder);
J
Jesse Barnes 已提交
273 274
}

275
static enum drm_connector_status
276
intel_crt_load_detect(struct drm_crtc *crtc, struct intel_encoder *intel_encoder)
277
{
278
	struct drm_encoder *encoder = &intel_encoder->enc;
279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331
	struct drm_device *dev = encoder->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
	uint32_t pipe = intel_crtc->pipe;
	uint32_t save_bclrpat;
	uint32_t save_vtotal;
	uint32_t vtotal, vactive;
	uint32_t vsample;
	uint32_t vblank, vblank_start, vblank_end;
	uint32_t dsl;
	uint32_t bclrpat_reg;
	uint32_t vtotal_reg;
	uint32_t vblank_reg;
	uint32_t vsync_reg;
	uint32_t pipeconf_reg;
	uint32_t pipe_dsl_reg;
	uint8_t	st00;
	enum drm_connector_status status;

	if (pipe == 0) {
		bclrpat_reg = BCLRPAT_A;
		vtotal_reg = VTOTAL_A;
		vblank_reg = VBLANK_A;
		vsync_reg = VSYNC_A;
		pipeconf_reg = PIPEACONF;
		pipe_dsl_reg = PIPEADSL;
	} else {
		bclrpat_reg = BCLRPAT_B;
		vtotal_reg = VTOTAL_B;
		vblank_reg = VBLANK_B;
		vsync_reg = VSYNC_B;
		pipeconf_reg = PIPEBCONF;
		pipe_dsl_reg = PIPEBDSL;
	}

	save_bclrpat = I915_READ(bclrpat_reg);
	save_vtotal = I915_READ(vtotal_reg);
	vblank = I915_READ(vblank_reg);

	vtotal = ((save_vtotal >> 16) & 0xfff) + 1;
	vactive = (save_vtotal & 0x7ff) + 1;

	vblank_start = (vblank & 0xfff) + 1;
	vblank_end = ((vblank >> 16) & 0xfff) + 1;

	/* Set the border color to purple. */
	I915_WRITE(bclrpat_reg, 0x500050);

	if (IS_I9XX(dev)) {
		uint32_t pipeconf = I915_READ(pipeconf_reg);
		I915_WRITE(pipeconf_reg, pipeconf | PIPECONF_FORCE_BORDER);
		/* Wait for next Vblank to substitue
		 * border color for Color info */
332
		intel_wait_for_vblank(dev, pipe);
333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402
		st00 = I915_READ8(VGA_MSR_WRITE);
		status = ((st00 & (1 << 4)) != 0) ?
			connector_status_connected :
			connector_status_disconnected;

		I915_WRITE(pipeconf_reg, pipeconf);
	} else {
		bool restore_vblank = false;
		int count, detect;

		/*
		* If there isn't any border, add some.
		* Yes, this will flicker
		*/
		if (vblank_start <= vactive && vblank_end >= vtotal) {
			uint32_t vsync = I915_READ(vsync_reg);
			uint32_t vsync_start = (vsync & 0xffff) + 1;

			vblank_start = vsync_start;
			I915_WRITE(vblank_reg,
				   (vblank_start - 1) |
				   ((vblank_end - 1) << 16));
			restore_vblank = true;
		}
		/* sample in the vertical border, selecting the larger one */
		if (vblank_start - vactive >= vtotal - vblank_end)
			vsample = (vblank_start + vactive) >> 1;
		else
			vsample = (vtotal + vblank_end) >> 1;

		/*
		 * Wait for the border to be displayed
		 */
		while (I915_READ(pipe_dsl_reg) >= vactive)
			;
		while ((dsl = I915_READ(pipe_dsl_reg)) <= vsample)
			;
		/*
		 * Watch ST00 for an entire scanline
		 */
		detect = 0;
		count = 0;
		do {
			count++;
			/* Read the ST00 VGA status register */
			st00 = I915_READ8(VGA_MSR_WRITE);
			if (st00 & (1 << 4))
				detect++;
		} while ((I915_READ(pipe_dsl_reg) == dsl));

		/* restore vblank if necessary */
		if (restore_vblank)
			I915_WRITE(vblank_reg, vblank);
		/*
		 * If more than 3/4 of the scanline detected a monitor,
		 * then it is assumed to be present. This works even on i830,
		 * where there isn't any way to force the border color across
		 * the screen
		 */
		status = detect * 4 > count * 3 ?
			 connector_status_connected :
			 connector_status_disconnected;
	}

	/* Restore previous settings */
	I915_WRITE(bclrpat_reg, save_bclrpat);

	return status;
}

403 404 405
static enum drm_connector_status
intel_crt_detect(struct drm_connector *connector,
		 bool nondestructive)
J
Jesse Barnes 已提交
406 407
{
	struct drm_device *dev = connector->dev;
408 409
	struct drm_encoder *encoder = intel_attached_encoder(connector);
	struct intel_encoder *intel_encoder = enc_to_intel_encoder(encoder);
410 411 412
	struct drm_crtc *crtc;
	int dpms_mode;
	enum drm_connector_status status;
J
Jesse Barnes 已提交
413 414 415 416 417 418 419 420

	if (IS_I9XX(dev) && !IS_I915G(dev) && !IS_I915GM(dev)) {
		if (intel_crt_detect_hotplug(connector))
			return connector_status_connected;
		else
			return connector_status_disconnected;
	}

421
	if (intel_crt_detect_ddc(encoder))
J
Jesse Barnes 已提交
422 423
		return connector_status_connected;

424 425 426
	if (nondestructive)
		return connector->status;

427 428
	/* for pre-945g platforms use load detect */
	if (encoder->crtc && encoder->crtc->enabled) {
429
		status = intel_crt_load_detect(encoder->crtc, intel_encoder);
430
	} else {
431
		crtc = intel_get_load_detect_pipe(intel_encoder, connector,
432 433
						  NULL, &dpms_mode);
		if (crtc) {
434
			status = intel_crt_load_detect(crtc, intel_encoder);
435 436
			intel_release_load_detect_pipe(intel_encoder,
						       connector, dpms_mode);
437 438 439 440 441
		} else
			status = connector_status_unknown;
	}

	return status;
J
Jesse Barnes 已提交
442 443 444 445 446 447 448 449 450 451 452
}

static void intel_crt_destroy(struct drm_connector *connector)
{
	drm_sysfs_connector_remove(connector);
	drm_connector_cleanup(connector);
	kfree(connector);
}

static int intel_crt_get_modes(struct drm_connector *connector)
{
453
	int ret;
454 455
	struct drm_encoder *encoder = intel_attached_encoder(connector);
	struct intel_encoder *intel_encoder = enc_to_intel_encoder(encoder);
456
	struct i2c_adapter *ddc_bus;
457 458 459
	struct drm_device *dev = connector->dev;


460
	ret = intel_ddc_get_modes(connector, intel_encoder->ddc_bus);
461 462 463 464
	if (ret || !IS_G4X(dev))
		goto end;

	/* Try to probe digital port for output in DVI-I -> VGA mode. */
465
	ddc_bus = intel_i2c_create(connector->dev, GPIOD, "CRTDDC_D");
466

467
	if (!ddc_bus) {
468 469 470 471 472
		dev_printk(KERN_ERR, &connector->dev->pdev->dev,
			   "DDC bus registration failed for CRTDDC_D.\n");
		goto end;
	}
	/* Try to get modes by GPIOD port */
473 474
	ret = intel_ddc_get_modes(connector, ddc_bus);
	intel_i2c_destroy(ddc_bus);
475 476 477 478

end:
	return ret;

J
Jesse Barnes 已提交
479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500
}

static int intel_crt_set_property(struct drm_connector *connector,
				  struct drm_property *property,
				  uint64_t value)
{
	return 0;
}

/*
 * Routines for controlling stuff on the analog port
 */

static const struct drm_encoder_helper_funcs intel_crt_helper_funcs = {
	.dpms = intel_crt_dpms,
	.mode_fixup = intel_crt_mode_fixup,
	.prepare = intel_encoder_prepare,
	.commit = intel_encoder_commit,
	.mode_set = intel_crt_mode_set,
};

static const struct drm_connector_funcs intel_crt_connector_funcs = {
501
	.dpms = drm_helper_connector_dpms,
J
Jesse Barnes 已提交
502 503 504 505 506 507 508 509 510
	.detect = intel_crt_detect,
	.fill_modes = drm_helper_probe_single_connector_modes,
	.destroy = intel_crt_destroy,
	.set_property = intel_crt_set_property,
};

static const struct drm_connector_helper_funcs intel_crt_connector_helper_funcs = {
	.mode_valid = intel_crt_mode_valid,
	.get_modes = intel_crt_get_modes,
511
	.best_encoder = intel_attached_encoder,
J
Jesse Barnes 已提交
512 513 514
};

static const struct drm_encoder_funcs intel_crt_enc_funcs = {
C
Chris Wilson 已提交
515
	.destroy = intel_encoder_destroy,
J
Jesse Barnes 已提交
516 517 518 519 520
};

void intel_crt_init(struct drm_device *dev)
{
	struct drm_connector *connector;
521
	struct intel_encoder *intel_encoder;
522
	struct intel_connector *intel_connector;
523
	struct drm_i915_private *dev_priv = dev->dev_private;
524
	u32 i2c_reg;
J
Jesse Barnes 已提交
525

526 527
	intel_encoder = kzalloc(sizeof(struct intel_encoder), GFP_KERNEL);
	if (!intel_encoder)
J
Jesse Barnes 已提交
528 529
		return;

530 531 532 533 534 535 536 537
	intel_connector = kzalloc(sizeof(struct intel_connector), GFP_KERNEL);
	if (!intel_connector) {
		kfree(intel_encoder);
		return;
	}

	connector = &intel_connector->base;
	drm_connector_init(dev, &intel_connector->base,
J
Jesse Barnes 已提交
538 539
			   &intel_crt_connector_funcs, DRM_MODE_CONNECTOR_VGA);

540
	drm_encoder_init(dev, &intel_encoder->enc, &intel_crt_enc_funcs,
J
Jesse Barnes 已提交
541 542
			 DRM_MODE_ENCODER_DAC);

543
	drm_mode_connector_attach_encoder(&intel_connector->base,
544
					  &intel_encoder->enc);
J
Jesse Barnes 已提交
545 546

	/* Set up the DDC bus. */
547
	if (HAS_PCH_SPLIT(dev))
548
		i2c_reg = PCH_GPIOA;
549
	else {
550
		i2c_reg = GPIOA;
551
		/* Use VBT information for CRT DDC if available */
552
		if (dev_priv->crt_ddc_bus != 0)
553 554
			i2c_reg = dev_priv->crt_ddc_bus;
	}
555 556
	intel_encoder->ddc_bus = intel_i2c_create(dev, i2c_reg, "CRTDDC_A");
	if (!intel_encoder->ddc_bus) {
J
Jesse Barnes 已提交
557 558 559 560 561
		dev_printk(KERN_ERR, &dev->pdev->dev, "DDC bus registration "
			   "failed.\n");
		return;
	}

562 563
	intel_encoder->type = INTEL_OUTPUT_ANALOG;
	intel_encoder->clone_mask = (1 << INTEL_SDVO_NON_TV_CLONE_BIT) |
564 565
				   (1 << INTEL_ANALOG_CLONE_BIT) |
				   (1 << INTEL_SDVO_LVDS_CLONE_BIT);
566
	intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
567
	connector->interlace_allowed = 1;
J
Jesse Barnes 已提交
568 569
	connector->doublescan_allowed = 0;

570
	drm_encoder_helper_add(&intel_encoder->enc, &intel_crt_helper_funcs);
J
Jesse Barnes 已提交
571 572 573
	drm_connector_helper_add(connector, &intel_crt_connector_helper_funcs);

	drm_sysfs_connector_add(connector);
574

575 576 577 578 579
	if (I915_HAS_HOTPLUG(dev))
		connector->polled = DRM_CONNECTOR_POLL_HPD;
	else
		connector->polled = DRM_CONNECTOR_POLL_CONNECT;

580
	dev_priv->hotplug_supported_mask |= CRT_HOTPLUG_INT_STATUS;
J
Jesse Barnes 已提交
581
}