vc4_hdmi.c 42.7 KB
Newer Older
1
// SPDX-License-Identifier: GPL-2.0-only
2 3 4 5 6 7 8 9 10 11
/*
 * Copyright (C) 2015 Broadcom
 * Copyright (c) 2014 The Linux Foundation. All rights reserved.
 * Copyright (C) 2013 Red Hat
 * Author: Rob Clark <robdclark@gmail.com>
 */

/**
 * DOC: VC4 Falcon HDMI module
 *
12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31
 * The HDMI core has a state machine and a PHY.  On BCM2835, most of
 * the unit operates off of the HSM clock from CPRMAN.  It also
 * internally uses the PLLH_PIX clock for the PHY.
 *
 * HDMI infoframes are kept within a small packet ram, where each
 * packet can be individually enabled for including in a frame.
 *
 * HDMI audio is implemented entirely within the HDMI IP block.  A
 * register in the HDMI encoder takes SPDIF frames from the DMA engine
 * and transfers them over an internal MAI (multi-channel audio
 * interconnect) bus to the encoder side for insertion into the video
 * blank regions.
 *
 * The driver's HDMI encoder does not yet support power management.
 * The HDMI encoder's power domain and the HSM/pixel clocks are kept
 * continuously running, and only the HDMI logic and packet ram are
 * powered off/on at disable/enable time.
 *
 * The driver does not yet support CEC control, though the HDMI
 * encoder block has CEC support.
32 33
 */

34 35
#include <drm/drm_atomic_helper.h>
#include <drm/drm_edid.h>
36
#include <drm/drm_probe_helper.h>
T
Thomas Zimmermann 已提交
37
#include <drm/drm_simple_kms_helper.h>
38 39 40 41 42 43 44 45 46 47 48 49
#include <linux/clk.h>
#include <linux/component.h>
#include <linux/i2c.h>
#include <linux/of_address.h>
#include <linux/of_gpio.h>
#include <linux/of_platform.h>
#include <linux/pm_runtime.h>
#include <linux/rational.h>
#include <sound/dmaengine_pcm.h>
#include <sound/pcm_drm_eld.h>
#include <sound/pcm_params.h>
#include <sound/soc.h>
H
Hans Verkuil 已提交
50
#include "media/cec.h"
51
#include "vc4_drv.h"
52
#include "vc4_hdmi.h"
53
#include "vc4_hdmi_regs.h"
54 55
#include "vc4_regs.h"

H
Hans Verkuil 已提交
56 57 58 59
#define HSM_CLOCK_FREQ 163682864
#define CEC_CLOCK_FREQ 40000
#define CEC_CLOCK_DIV  (HSM_CLOCK_FREQ / CEC_CLOCK_FREQ)

60
static int vc4_hdmi_debugfs_regs(struct seq_file *m, void *unused)
61 62
{
	struct drm_info_node *node = (struct drm_info_node *)m->private;
63
	struct vc4_hdmi *vc4_hdmi = node->info_ent->data;
64
	struct drm_printer p = drm_seq_file_printer(m);
65

66 67
	drm_print_regset32(&p, &vc4_hdmi->hdmi_regset);
	drm_print_regset32(&p, &vc4_hdmi->hd_regset);
68 69 70 71

	return 0;
}

72 73 74 75 76 77 78 79 80 81 82 83 84 85 86
static void vc4_hdmi_reset(struct vc4_hdmi *vc4_hdmi)
{
	HDMI_WRITE(HDMI_M_CTL, VC4_HD_M_SW_RST);
	udelay(1);
	HDMI_WRITE(HDMI_M_CTL, 0);

	HDMI_WRITE(HDMI_M_CTL, VC4_HD_M_ENABLE);

	HDMI_WRITE(HDMI_SW_RESET_CONTROL,
		   VC4_HDMI_SW_RESET_HDMI |
		   VC4_HDMI_SW_RESET_FORMAT_DETECT);

	HDMI_WRITE(HDMI_SW_RESET_CONTROL, 0);
}

87 88 89
static enum drm_connector_status
vc4_hdmi_connector_detect(struct drm_connector *connector, bool force)
{
90
	struct vc4_hdmi *vc4_hdmi = connector_to_vc4_hdmi(connector);
91

92 93 94
	if (vc4_hdmi->hpd_gpio) {
		if (gpio_get_value_cansleep(vc4_hdmi->hpd_gpio) ^
		    vc4_hdmi->hpd_active_low)
95
			return connector_status_connected;
96
		cec_phys_addr_invalidate(vc4_hdmi->cec_adap);
H
Hans Verkuil 已提交
97
		return connector_status_disconnected;
98 99
	}

100
	if (drm_probe_ddc(vc4_hdmi->ddc))
101 102
		return connector_status_connected;

103
	if (HDMI_READ(HDMI_HOTPLUG) & VC4_HDMI_HOTPLUG_CONNECTED)
104
		return connector_status_connected;
105
	cec_phys_addr_invalidate(vc4_hdmi->cec_adap);
H
Hans Verkuil 已提交
106
	return connector_status_disconnected;
107 108 109 110 111 112 113 114 115 116
}

static void vc4_hdmi_connector_destroy(struct drm_connector *connector)
{
	drm_connector_unregister(connector);
	drm_connector_cleanup(connector);
}

static int vc4_hdmi_connector_get_modes(struct drm_connector *connector)
{
117 118
	struct vc4_hdmi *vc4_hdmi = connector_to_vc4_hdmi(connector);
	struct vc4_hdmi_encoder *vc4_encoder = &vc4_hdmi->encoder;
119 120 121
	int ret = 0;
	struct edid *edid;

122 123
	edid = drm_get_edid(connector, vc4_hdmi->ddc);
	cec_s_phys_addr_from_edid(vc4_hdmi->cec_adap, edid);
124 125 126 127
	if (!edid)
		return -ENODEV;

	vc4_encoder->hdmi_monitor = drm_detect_hdmi_monitor(edid);
128

129
	drm_connector_update_edid_property(connector, edid);
130
	ret = drm_add_edid_modes(connector, edid);
E
Eric Anholt 已提交
131
	kfree(edid);
132 133 134 135

	return ret;
}

136 137 138 139 140 141
static void vc4_hdmi_connector_reset(struct drm_connector *connector)
{
	drm_atomic_helper_connector_reset(connector);
	drm_atomic_helper_connector_tv_reset(connector);
}

142 143
static const struct drm_connector_funcs vc4_hdmi_connector_funcs = {
	.detect = vc4_hdmi_connector_detect,
144
	.fill_modes = drm_helper_probe_single_connector_modes,
145
	.destroy = vc4_hdmi_connector_destroy,
146
	.reset = vc4_hdmi_connector_reset,
147 148 149 150 151 152 153 154
	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
};

static const struct drm_connector_helper_funcs vc4_hdmi_connector_helper_funcs = {
	.get_modes = vc4_hdmi_connector_get_modes,
};

155
static int vc4_hdmi_connector_init(struct drm_device *dev,
156
				   struct vc4_hdmi *vc4_hdmi)
157
{
158
	struct drm_connector *connector = &vc4_hdmi->connector;
159
	struct drm_encoder *encoder = &vc4_hdmi->encoder.base.base;
160
	int ret;
161

162 163 164
	drm_connector_init_with_ddc(dev, connector,
				    &vc4_hdmi_connector_funcs,
				    DRM_MODE_CONNECTOR_HDMIA,
165
				    vc4_hdmi->ddc);
166 167
	drm_connector_helper_add(connector, &vc4_hdmi_connector_helper_funcs);

168 169 170
	/* Create and attach TV margin props to this connector. */
	ret = drm_mode_create_tv_margin_properties(dev);
	if (ret)
171
		return ret;
172 173 174

	drm_connector_attach_tv_margin_properties(connector);

175 176 177
	connector->polled = (DRM_CONNECTOR_POLL_CONNECT |
			     DRM_CONNECTOR_POLL_DISCONNECT);

178
	connector->interlace_allowed = 1;
179 180
	connector->doublescan_allowed = 0;

181
	drm_connector_attach_encoder(connector, encoder);
182

183
	return 0;
184 185
}

186 187 188
static int vc4_hdmi_stop_packet(struct drm_encoder *encoder,
				enum hdmi_infoframe_type type)
{
189
	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
190 191
	u32 packet_id = type - 0x80;

192 193
	HDMI_WRITE(HDMI_RAM_PACKET_CONFIG,
		   HDMI_READ(HDMI_RAM_PACKET_CONFIG) & ~BIT(packet_id));
194

195
	return wait_for(!(HDMI_READ(HDMI_RAM_PACKET_STATUS) &
196 197 198 199 200 201
			  BIT(packet_id)), 100);
}

static void vc4_hdmi_write_infoframe(struct drm_encoder *encoder,
				     union hdmi_infoframe *frame)
{
202
	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
203
	u32 packet_id = frame->any.type - 0x80;
204 205 206 207 208
	const struct vc4_hdmi_register *ram_packet_start =
		&vc4_hdmi->variant->registers[HDMI_RAM_PACKET_START];
	u32 packet_reg = ram_packet_start->offset + VC4_HDMI_PACKET_STRIDE * packet_id;
	void __iomem *base = __vc4_hdmi_get_field_base(vc4_hdmi,
						       ram_packet_start->reg);
209 210 211 212
	uint8_t buffer[VC4_HDMI_PACKET_STRIDE];
	ssize_t len, i;
	int ret;

213
	WARN_ONCE(!(HDMI_READ(HDMI_RAM_PACKET_CONFIG) &
214 215 216 217 218 219 220 221 222 223 224 225 226 227
		    VC4_HDMI_RAM_PACKET_ENABLE),
		  "Packet RAM has to be on to store the packet.");

	len = hdmi_infoframe_pack(frame, buffer, sizeof(buffer));
	if (len < 0)
		return;

	ret = vc4_hdmi_stop_packet(encoder, frame->any.type);
	if (ret) {
		DRM_ERROR("Failed to wait for infoframe to go idle: %d\n", ret);
		return;
	}

	for (i = 0; i < len; i += 7) {
228 229 230 231
		writel(buffer[i + 0] << 0 |
		       buffer[i + 1] << 8 |
		       buffer[i + 2] << 16,
		       base + packet_reg);
232 233
		packet_reg += 4;

234 235 236 237 238
		writel(buffer[i + 3] << 0 |
		       buffer[i + 4] << 8 |
		       buffer[i + 5] << 16 |
		       buffer[i + 6] << 24,
		       base + packet_reg);
239 240 241
		packet_reg += 4;
	}

242 243 244
	HDMI_WRITE(HDMI_RAM_PACKET_CONFIG,
		   HDMI_READ(HDMI_RAM_PACKET_CONFIG) | BIT(packet_id));
	ret = wait_for((HDMI_READ(HDMI_RAM_PACKET_STATUS) &
245 246 247 248 249 250 251
			BIT(packet_id)), 100);
	if (ret)
		DRM_ERROR("Failed to wait for infoframe to start: %d\n", ret);
}

static void vc4_hdmi_set_avi_infoframe(struct drm_encoder *encoder)
{
252
	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
253
	struct vc4_hdmi_encoder *vc4_encoder = to_vc4_hdmi_encoder(encoder);
254
	struct drm_connector *connector = &vc4_hdmi->connector;
255
	struct drm_connector_state *cstate = connector->state;
256 257 258 259 260
	struct drm_crtc *crtc = encoder->crtc;
	const struct drm_display_mode *mode = &crtc->state->adjusted_mode;
	union hdmi_infoframe frame;
	int ret;

261
	ret = drm_hdmi_avi_infoframe_from_display_mode(&frame.avi,
262
						       connector, mode);
263 264 265 266 267
	if (ret < 0) {
		DRM_ERROR("couldn't fill AVI infoframe\n");
		return;
	}

268
	drm_hdmi_avi_infoframe_quant_range(&frame.avi,
269
					   connector, mode,
270 271
					   vc4_encoder->limited_rgb_range ?
					   HDMI_QUANTIZATION_RANGE_LIMITED :
272
					   HDMI_QUANTIZATION_RANGE_FULL);
273

274
	drm_hdmi_avi_infoframe_bars(&frame.avi, cstate);
275

276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294
	vc4_hdmi_write_infoframe(encoder, &frame);
}

static void vc4_hdmi_set_spd_infoframe(struct drm_encoder *encoder)
{
	union hdmi_infoframe frame;
	int ret;

	ret = hdmi_spd_infoframe_init(&frame.spd, "Broadcom", "Videocore");
	if (ret < 0) {
		DRM_ERROR("couldn't fill SPD infoframe\n");
		return;
	}

	frame.spd.sdi = HDMI_SPD_SDI_PC;

	vc4_hdmi_write_infoframe(encoder, &frame);
}

E
Eric Anholt 已提交
295 296
static void vc4_hdmi_set_audio_infoframe(struct drm_encoder *encoder)
{
297
	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
E
Eric Anholt 已提交
298 299 300 301 302 303 304 305
	union hdmi_infoframe frame;
	int ret;

	ret = hdmi_audio_infoframe_init(&frame.audio);

	frame.audio.coding_type = HDMI_AUDIO_CODING_TYPE_STREAM;
	frame.audio.sample_frequency = HDMI_AUDIO_SAMPLE_FREQUENCY_STREAM;
	frame.audio.sample_size = HDMI_AUDIO_SAMPLE_SIZE_STREAM;
306
	frame.audio.channels = vc4_hdmi->audio.channels;
E
Eric Anholt 已提交
307 308 309 310

	vc4_hdmi_write_infoframe(encoder, &frame);
}

311 312 313 314 315 316
static void vc4_hdmi_set_infoframes(struct drm_encoder *encoder)
{
	vc4_hdmi_set_avi_infoframe(encoder);
	vc4_hdmi_set_spd_infoframe(encoder);
}

317 318
static void vc4_hdmi_encoder_disable(struct drm_encoder *encoder)
{
319
	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
320 321
	int ret;

322
	HDMI_WRITE(HDMI_RAM_PACKET_CONFIG, 0);
323

324 325 326
	if (vc4_hdmi->variant->phy_disable)
		vc4_hdmi->variant->phy_disable(vc4_hdmi);

327 328
	HDMI_WRITE(HDMI_VID_CTL,
		   HDMI_READ(HDMI_VID_CTL) & ~VC4_HD_VID_CTL_ENABLE);
329

330
	clk_disable_unprepare(vc4_hdmi->pixel_clock);
331

332
	ret = pm_runtime_put(&vc4_hdmi->pdev->dev);
333 334 335 336
	if (ret < 0)
		DRM_ERROR("Failed to release power domain: %d\n", ret);
}

337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371
static void vc4_hdmi_csc_setup(struct vc4_hdmi *vc4_hdmi, bool enable)
{
	u32 csc_ctl;

	csc_ctl = VC4_SET_FIELD(VC4_HD_CSC_CTL_ORDER_BGR,
				VC4_HD_CSC_CTL_ORDER);

	if (enable) {
		/* CEA VICs other than #1 requre limited range RGB
		 * output unless overridden by an AVI infoframe.
		 * Apply a colorspace conversion to squash 0-255 down
		 * to 16-235.  The matrix here is:
		 *
		 * [ 0      0      0.8594 16]
		 * [ 0      0.8594 0      16]
		 * [ 0.8594 0      0      16]
		 * [ 0      0      0       1]
		 */
		csc_ctl |= VC4_HD_CSC_CTL_ENABLE;
		csc_ctl |= VC4_HD_CSC_CTL_RGB2YCC;
		csc_ctl |= VC4_SET_FIELD(VC4_HD_CSC_CTL_MODE_CUSTOM,
					 VC4_HD_CSC_CTL_MODE);

		HDMI_WRITE(HDMI_CSC_12_11, (0x000 << 16) | 0x000);
		HDMI_WRITE(HDMI_CSC_14_13, (0x100 << 16) | 0x6e0);
		HDMI_WRITE(HDMI_CSC_22_21, (0x6e0 << 16) | 0x000);
		HDMI_WRITE(HDMI_CSC_24_23, (0x100 << 16) | 0x000);
		HDMI_WRITE(HDMI_CSC_32_31, (0x000 << 16) | 0x6e0);
		HDMI_WRITE(HDMI_CSC_34_33, (0x100 << 16) | 0x000);
	}

	/* The RGB order applies even when CSC is disabled. */
	HDMI_WRITE(HDMI_CSC_CTL, csc_ctl);
}

372 373
static void vc4_hdmi_set_timings(struct vc4_hdmi *vc4_hdmi,
				 struct drm_display_mode *mode)
374 375 376
{
	bool hsync_pos = mode->flags & DRM_MODE_FLAG_PHSYNC;
	bool vsync_pos = mode->flags & DRM_MODE_FLAG_PVSYNC;
377
	bool interlaced = mode->flags & DRM_MODE_FLAG_INTERLACE;
378
	u32 pixel_rep = (mode->flags & DRM_MODE_FLAG_DBLCLK) ? 2 : 1;
379
	u32 verta = (VC4_SET_FIELD(mode->crtc_vsync_end - mode->crtc_vsync_start,
380
				   VC4_HDMI_VERTA_VSP) |
381
		     VC4_SET_FIELD(mode->crtc_vsync_start - mode->crtc_vdisplay,
382
				   VC4_HDMI_VERTA_VFP) |
383
		     VC4_SET_FIELD(mode->crtc_vdisplay, VC4_HDMI_VERTA_VAL));
384
	u32 vertb = (VC4_SET_FIELD(0, VC4_HDMI_VERTB_VSPO) |
385
		     VC4_SET_FIELD(mode->crtc_vtotal - mode->crtc_vsync_end,
386
				   VC4_HDMI_VERTB_VBP));
387 388 389 390 391
	u32 vertb_even = (VC4_SET_FIELD(0, VC4_HDMI_VERTB_VSPO) |
			  VC4_SET_FIELD(mode->crtc_vtotal -
					mode->crtc_vsync_end -
					interlaced,
					VC4_HDMI_VERTB_VBP));
392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426

	HDMI_WRITE(HDMI_HORZA,
		   (vsync_pos ? VC4_HDMI_HORZA_VPOS : 0) |
		   (hsync_pos ? VC4_HDMI_HORZA_HPOS : 0) |
		   VC4_SET_FIELD(mode->hdisplay * pixel_rep,
				 VC4_HDMI_HORZA_HAP));

	HDMI_WRITE(HDMI_HORZB,
		   VC4_SET_FIELD((mode->htotal -
				  mode->hsync_end) * pixel_rep,
				 VC4_HDMI_HORZB_HBP) |
		   VC4_SET_FIELD((mode->hsync_end -
				  mode->hsync_start) * pixel_rep,
				 VC4_HDMI_HORZB_HSP) |
		   VC4_SET_FIELD((mode->hsync_start -
				  mode->hdisplay) * pixel_rep,
				 VC4_HDMI_HORZB_HFP));

	HDMI_WRITE(HDMI_VERTA0, verta);
	HDMI_WRITE(HDMI_VERTA1, verta);

	HDMI_WRITE(HDMI_VERTB0, vertb_even);
	HDMI_WRITE(HDMI_VERTB1, vertb);

	HDMI_WRITE(HDMI_VID_CTL,
		   (vsync_pos ? 0 : VC4_HD_VID_CTL_VSYNC_LOW) |
		   (hsync_pos ? 0 : VC4_HD_VID_CTL_HSYNC_LOW));
}

static void vc4_hdmi_encoder_enable(struct drm_encoder *encoder)
{
	struct drm_display_mode *mode = &encoder->crtc->state->adjusted_mode;
	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
	struct vc4_hdmi_encoder *vc4_encoder = to_vc4_hdmi_encoder(encoder);
	bool debug_dump_regs = false;
427 428
	int ret;

429
	ret = pm_runtime_get_sync(&vc4_hdmi->pdev->dev);
430 431 432 433 434
	if (ret < 0) {
		DRM_ERROR("Failed to retain power domain: %d\n", ret);
		return;
	}

435
	ret = clk_set_rate(vc4_hdmi->pixel_clock,
436 437 438 439 440 441 442
			   mode->clock * 1000 *
			   ((mode->flags & DRM_MODE_FLAG_DBLCLK) ? 2 : 1));
	if (ret) {
		DRM_ERROR("Failed to set pixel clock rate: %d\n", ret);
		return;
	}

443
	ret = clk_prepare_enable(vc4_hdmi->pixel_clock);
444 445 446 447 448
	if (ret) {
		DRM_ERROR("Failed to turn on pixel clock: %d\n", ret);
		return;
	}

449 450
	if (vc4_hdmi->variant->reset)
		vc4_hdmi->variant->reset(vc4_hdmi);
451

452 453
	if (vc4_hdmi->variant->phy_init)
		vc4_hdmi->variant->phy_init(vc4_hdmi, mode);
454 455

	if (debug_dump_regs) {
456
		struct drm_printer p = drm_info_printer(&vc4_hdmi->pdev->dev);
457

458 459 460
		dev_info(&vc4_hdmi->pdev->dev, "HDMI regs before:\n");
		drm_print_regset32(&p, &vc4_hdmi->hdmi_regset);
		drm_print_regset32(&p, &vc4_hdmi->hd_regset);
461 462
	}

463
	HDMI_WRITE(HDMI_VID_CTL, 0);
464

465 466
	HDMI_WRITE(HDMI_SCHEDULER_CONTROL,
		   HDMI_READ(HDMI_SCHEDULER_CONTROL) |
467 468 469
		   VC4_HDMI_SCHEDULER_CONTROL_MANUAL_FORMAT |
		   VC4_HDMI_SCHEDULER_CONTROL_IGNORE_VSYNC_PREDICTS);

470 471
	if (vc4_hdmi->variant->set_timings)
		vc4_hdmi->variant->set_timings(vc4_hdmi, mode);
472

473
	if (vc4_encoder->hdmi_monitor &&
474 475 476
	    drm_default_rgb_quant_range(mode) == HDMI_QUANTIZATION_RANGE_LIMITED) {
		if (vc4_hdmi->variant->csc_setup)
			vc4_hdmi->variant->csc_setup(vc4_hdmi, true);
477

478 479
		vc4_encoder->limited_rgb_range = true;
	} else {
480 481 482
		if (vc4_hdmi->variant->csc_setup)
			vc4_hdmi->variant->csc_setup(vc4_hdmi, false);

483
		vc4_encoder->limited_rgb_range = false;
484 485
	}

486
	HDMI_WRITE(HDMI_FIFO_CTL, VC4_HDMI_FIFO_CTL_MASTER_SLAVE_N);
487 488

	if (debug_dump_regs) {
489
		struct drm_printer p = drm_info_printer(&vc4_hdmi->pdev->dev);
490

491 492 493
		dev_info(&vc4_hdmi->pdev->dev, "HDMI regs after:\n");
		drm_print_regset32(&p, &vc4_hdmi->hdmi_regset);
		drm_print_regset32(&p, &vc4_hdmi->hd_regset);
494 495
	}

496 497 498 499 500
	HDMI_WRITE(HDMI_VID_CTL,
		   HDMI_READ(HDMI_VID_CTL) |
		   VC4_HD_VID_CTL_ENABLE |
		   VC4_HD_VID_CTL_UNDERFLOW_ENABLE |
		   VC4_HD_VID_CTL_FRAME_COUNTER_RESET);
501 502

	if (vc4_encoder->hdmi_monitor) {
503 504
		HDMI_WRITE(HDMI_SCHEDULER_CONTROL,
			   HDMI_READ(HDMI_SCHEDULER_CONTROL) |
505 506
			   VC4_HDMI_SCHEDULER_CONTROL_MODE_HDMI);

507
		ret = wait_for(HDMI_READ(HDMI_SCHEDULER_CONTROL) &
508
			       VC4_HDMI_SCHEDULER_CONTROL_HDMI_ACTIVE, 1000);
509 510 511
		WARN_ONCE(ret, "Timeout waiting for "
			  "VC4_HDMI_SCHEDULER_CONTROL_HDMI_ACTIVE\n");
	} else {
512 513
		HDMI_WRITE(HDMI_RAM_PACKET_CONFIG,
			   HDMI_READ(HDMI_RAM_PACKET_CONFIG) &
514
			   ~(VC4_HDMI_RAM_PACKET_ENABLE));
515 516
		HDMI_WRITE(HDMI_SCHEDULER_CONTROL,
			   HDMI_READ(HDMI_SCHEDULER_CONTROL) &
517 518
			   ~VC4_HDMI_SCHEDULER_CONTROL_MODE_HDMI);

519
		ret = wait_for(!(HDMI_READ(HDMI_SCHEDULER_CONTROL) &
520
				 VC4_HDMI_SCHEDULER_CONTROL_HDMI_ACTIVE), 1000);
521 522 523 524 525 526 527
		WARN_ONCE(ret, "Timeout waiting for "
			  "!VC4_HDMI_SCHEDULER_CONTROL_HDMI_ACTIVE\n");
	}

	if (vc4_encoder->hdmi_monitor) {
		u32 drift;

528
		WARN_ON(!(HDMI_READ(HDMI_SCHEDULER_CONTROL) &
529
			  VC4_HDMI_SCHEDULER_CONTROL_HDMI_ACTIVE));
530 531
		HDMI_WRITE(HDMI_SCHEDULER_CONTROL,
			   HDMI_READ(HDMI_SCHEDULER_CONTROL) |
532 533
			   VC4_HDMI_SCHEDULER_CONTROL_VERT_ALWAYS_KEEPOUT);

534
		HDMI_WRITE(HDMI_RAM_PACKET_CONFIG,
535 536 537
			   VC4_HDMI_RAM_PACKET_ENABLE);

		vc4_hdmi_set_infoframes(encoder);
538

539
		drift = HDMI_READ(HDMI_FIFO_CTL);
540 541
		drift &= VC4_HDMI_FIFO_VALID_WRITE_MASK;

542
		HDMI_WRITE(HDMI_FIFO_CTL,
543
			   drift & ~VC4_HDMI_FIFO_CTL_RECENTER);
544
		HDMI_WRITE(HDMI_FIFO_CTL,
545
			   drift | VC4_HDMI_FIFO_CTL_RECENTER);
546
		usleep_range(1000, 1100);
547
		HDMI_WRITE(HDMI_FIFO_CTL,
548
			   drift & ~VC4_HDMI_FIFO_CTL_RECENTER);
549
		HDMI_WRITE(HDMI_FIFO_CTL,
550 551
			   drift | VC4_HDMI_FIFO_CTL_RECENTER);

552
		ret = wait_for(HDMI_READ(HDMI_FIFO_CTL) &
553 554 555 556 557 558
			       VC4_HDMI_FIFO_CTL_RECENTER_DONE, 1);
		WARN_ONCE(ret, "Timeout waiting for "
			  "VC4_HDMI_FIFO_CTL_RECENTER_DONE");
	}
}

559 560 561 562
static enum drm_mode_status
vc4_hdmi_encoder_mode_valid(struct drm_encoder *crtc,
			    const struct drm_display_mode *mode)
{
563 564 565 566 567 568 569 570 571 572 573 574 575 576 577
	/*
	 * As stated in RPi's vc4 firmware "HDMI state machine (HSM) clock must
	 * be faster than pixel clock, infinitesimally faster, tested in
	 * simulation. Otherwise, exact value is unimportant for HDMI
	 * operation." This conflicts with bcm2835's vc4 documentation, which
	 * states HSM's clock has to be at least 108% of the pixel clock.
	 *
	 * Real life tests reveal that vc4's firmware statement holds up, and
	 * users are able to use pixel clocks closer to HSM's, namely for
	 * 1920x1200@60Hz. So it was decided to have leave a 1% margin between
	 * both clocks. Which, for RPi0-3 implies a maximum pixel clock of
	 * 162MHz.
	 *
	 * Additionally, the AXI clock needs to be at least 25% of
	 * pixel clock, but HSM ends up being the limiting factor.
578
	 */
579
	if (mode->clock > HSM_CLOCK_FREQ / (1000 * 101 / 100))
580 581 582 583 584
		return MODE_CLOCK_HIGH;

	return MODE_OK;
}

585
static const struct drm_encoder_helper_funcs vc4_hdmi_encoder_helper_funcs = {
586
	.mode_valid = vc4_hdmi_encoder_mode_valid,
587 588 589 590
	.disable = vc4_hdmi_encoder_disable,
	.enable = vc4_hdmi_encoder_enable,
};

E
Eric Anholt 已提交
591
/* HDMI audio codec callbacks */
592
static void vc4_hdmi_audio_set_mai_clock(struct vc4_hdmi *vc4_hdmi)
E
Eric Anholt 已提交
593
{
594
	u32 hsm_clock = clk_get_rate(vc4_hdmi->hsm_clock);
E
Eric Anholt 已提交
595 596
	unsigned long n, m;

597
	rational_best_approximation(hsm_clock, vc4_hdmi->audio.samplerate,
E
Eric Anholt 已提交
598 599 600 601 602 603
				    VC4_HD_MAI_SMP_N_MASK >>
				    VC4_HD_MAI_SMP_N_SHIFT,
				    (VC4_HD_MAI_SMP_M_MASK >>
				     VC4_HD_MAI_SMP_M_SHIFT) + 1,
				    &n, &m);

604 605 606
	HDMI_WRITE(HDMI_MAI_SMP,
		   VC4_SET_FIELD(n, VC4_HD_MAI_SMP_N) |
		   VC4_SET_FIELD(m - 1, VC4_HD_MAI_SMP_M));
E
Eric Anholt 已提交
607 608
}

609
static void vc4_hdmi_set_n_cts(struct vc4_hdmi *vc4_hdmi)
E
Eric Anholt 已提交
610
{
611
	struct drm_encoder *encoder = &vc4_hdmi->encoder.base.base;
E
Eric Anholt 已提交
612 613
	struct drm_crtc *crtc = encoder->crtc;
	const struct drm_display_mode *mode = &crtc->state->adjusted_mode;
614
	u32 samplerate = vc4_hdmi->audio.samplerate;
E
Eric Anholt 已提交
615 616 617 618 619 620 621 622
	u32 n, cts;
	u64 tmp;

	n = 128 * samplerate / 1000;
	tmp = (u64)(mode->clock * 1000) * n;
	do_div(tmp, 128 * samplerate);
	cts = tmp;

623
	HDMI_WRITE(HDMI_CRP_CFG,
E
Eric Anholt 已提交
624 625 626 627 628 629 630 631
		   VC4_HDMI_CRP_CFG_EXTERNAL_CTS_EN |
		   VC4_SET_FIELD(n, VC4_HDMI_CRP_CFG_N));

	/*
	 * We could get slightly more accurate clocks in some cases by
	 * providing a CTS_1 value.  The two CTS values are alternated
	 * between based on the period fields
	 */
632 633
	HDMI_WRITE(HDMI_CTS_0, cts);
	HDMI_WRITE(HDMI_CTS_1, cts);
E
Eric Anholt 已提交
634 635 636 637 638 639 640 641 642 643 644 645
}

static inline struct vc4_hdmi *dai_to_hdmi(struct snd_soc_dai *dai)
{
	struct snd_soc_card *card = snd_soc_dai_get_drvdata(dai);

	return snd_soc_card_get_drvdata(card);
}

static int vc4_hdmi_audio_startup(struct snd_pcm_substream *substream,
				  struct snd_soc_dai *dai)
{
646 647
	struct vc4_hdmi *vc4_hdmi = dai_to_hdmi(dai);
	struct drm_encoder *encoder = &vc4_hdmi->encoder.base.base;
648
	struct drm_connector *connector = &vc4_hdmi->connector;
E
Eric Anholt 已提交
649 650
	int ret;

651
	if (vc4_hdmi->audio.substream && vc4_hdmi->audio.substream != substream)
E
Eric Anholt 已提交
652 653
		return -EINVAL;

654
	vc4_hdmi->audio.substream = substream;
E
Eric Anholt 已提交
655 656 657 658 659

	/*
	 * If the HDMI encoder hasn't probed, or the encoder is
	 * currently in DVI mode, treat the codec dai as missing.
	 */
660
	if (!encoder->crtc || !(HDMI_READ(HDMI_RAM_PACKET_CONFIG) &
E
Eric Anholt 已提交
661 662 663
				VC4_HDMI_RAM_PACKET_ENABLE))
		return -ENODEV;

664
	ret = snd_pcm_hw_constraint_eld(substream->runtime, connector->eld);
E
Eric Anholt 已提交
665 666 667 668 669 670 671 672 673 674 675
	if (ret)
		return ret;

	return 0;
}

static int vc4_hdmi_audio_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
{
	return 0;
}

676
static void vc4_hdmi_audio_reset(struct vc4_hdmi *vc4_hdmi)
E
Eric Anholt 已提交
677
{
678 679
	struct drm_encoder *encoder = &vc4_hdmi->encoder.base.base;
	struct device *dev = &vc4_hdmi->pdev->dev;
E
Eric Anholt 已提交
680 681 682 683 684 685
	int ret;

	ret = vc4_hdmi_stop_packet(encoder, HDMI_INFOFRAME_TYPE_AUDIO);
	if (ret)
		dev_err(dev, "Failed to stop audio infoframe: %d\n", ret);

686 687 688
	HDMI_WRITE(HDMI_MAI_CTL, VC4_HD_MAI_CTL_RESET);
	HDMI_WRITE(HDMI_MAI_CTL, VC4_HD_MAI_CTL_ERRORF);
	HDMI_WRITE(HDMI_MAI_CTL, VC4_HD_MAI_CTL_FLUSH);
E
Eric Anholt 已提交
689 690 691 692 693
}

static void vc4_hdmi_audio_shutdown(struct snd_pcm_substream *substream,
				    struct snd_soc_dai *dai)
{
694
	struct vc4_hdmi *vc4_hdmi = dai_to_hdmi(dai);
E
Eric Anholt 已提交
695

696
	if (substream != vc4_hdmi->audio.substream)
E
Eric Anholt 已提交
697 698
		return;

699
	vc4_hdmi_audio_reset(vc4_hdmi);
E
Eric Anholt 已提交
700

701
	vc4_hdmi->audio.substream = NULL;
E
Eric Anholt 已提交
702 703 704 705 706 707 708
}

/* HDMI audio codec callbacks */
static int vc4_hdmi_audio_hw_params(struct snd_pcm_substream *substream,
				    struct snd_pcm_hw_params *params,
				    struct snd_soc_dai *dai)
{
709 710
	struct vc4_hdmi *vc4_hdmi = dai_to_hdmi(dai);
	struct device *dev = &vc4_hdmi->pdev->dev;
E
Eric Anholt 已提交
711 712 713
	u32 audio_packet_config, channel_mask;
	u32 channel_map, i;

714
	if (substream != vc4_hdmi->audio.substream)
E
Eric Anholt 已提交
715 716 717 718 719 720
		return -EINVAL;

	dev_dbg(dev, "%s: %u Hz, %d bit, %d channels\n", __func__,
		params_rate(params), params_width(params),
		params_channels(params));

721 722
	vc4_hdmi->audio.channels = params_channels(params);
	vc4_hdmi->audio.samplerate = params_rate(params);
E
Eric Anholt 已提交
723

724 725 726 727 728 729
	HDMI_WRITE(HDMI_MAI_CTL,
		   VC4_HD_MAI_CTL_RESET |
		   VC4_HD_MAI_CTL_FLUSH |
		   VC4_HD_MAI_CTL_DLATE |
		   VC4_HD_MAI_CTL_ERRORE |
		   VC4_HD_MAI_CTL_ERRORF);
E
Eric Anholt 已提交
730

731
	vc4_hdmi_audio_set_mai_clock(vc4_hdmi);
E
Eric Anholt 已提交
732 733 734 735 736 737

	audio_packet_config =
		VC4_HDMI_AUDIO_PACKET_ZERO_DATA_ON_SAMPLE_FLAT |
		VC4_HDMI_AUDIO_PACKET_ZERO_DATA_ON_INACTIVE_CHANNELS |
		VC4_SET_FIELD(0xf, VC4_HDMI_AUDIO_PACKET_B_FRAME_IDENTIFIER);

738
	channel_mask = GENMASK(vc4_hdmi->audio.channels - 1, 0);
E
Eric Anholt 已提交
739 740 741 742
	audio_packet_config |= VC4_SET_FIELD(channel_mask,
					     VC4_HDMI_AUDIO_PACKET_CEA_MASK);

	/* Set the MAI threshold.  This logic mimics the firmware's. */
743
	if (vc4_hdmi->audio.samplerate > 96000) {
744 745 746
		HDMI_WRITE(HDMI_MAI_THR,
			   VC4_SET_FIELD(0x12, VC4_HD_MAI_THR_DREQHIGH) |
			   VC4_SET_FIELD(0x12, VC4_HD_MAI_THR_DREQLOW));
747
	} else if (vc4_hdmi->audio.samplerate > 48000) {
748 749 750
		HDMI_WRITE(HDMI_MAI_THR,
			   VC4_SET_FIELD(0x14, VC4_HD_MAI_THR_DREQHIGH) |
			   VC4_SET_FIELD(0x12, VC4_HD_MAI_THR_DREQLOW));
E
Eric Anholt 已提交
751
	} else {
752 753 754 755 756
		HDMI_WRITE(HDMI_MAI_THR,
			   VC4_SET_FIELD(0x10, VC4_HD_MAI_THR_PANICHIGH) |
			   VC4_SET_FIELD(0x10, VC4_HD_MAI_THR_PANICLOW) |
			   VC4_SET_FIELD(0x10, VC4_HD_MAI_THR_DREQHIGH) |
			   VC4_SET_FIELD(0x10, VC4_HD_MAI_THR_DREQLOW));
E
Eric Anholt 已提交
757 758
	}

759
	HDMI_WRITE(HDMI_MAI_CONFIG,
E
Eric Anholt 已提交
760 761 762 763 764 765 766 767 768
		   VC4_HDMI_MAI_CONFIG_BIT_REVERSE |
		   VC4_SET_FIELD(channel_mask, VC4_HDMI_MAI_CHANNEL_MASK));

	channel_map = 0;
	for (i = 0; i < 8; i++) {
		if (channel_mask & BIT(i))
			channel_map |= i << (3 * i);
	}

769 770
	HDMI_WRITE(HDMI_MAI_CHANNEL_MAP, channel_map);
	HDMI_WRITE(HDMI_AUDIO_PACKET_CONFIG, audio_packet_config);
771
	vc4_hdmi_set_n_cts(vc4_hdmi);
E
Eric Anholt 已提交
772 773 774 775 776 777 778

	return 0;
}

static int vc4_hdmi_audio_trigger(struct snd_pcm_substream *substream, int cmd,
				  struct snd_soc_dai *dai)
{
779 780
	struct vc4_hdmi *vc4_hdmi = dai_to_hdmi(dai);
	struct drm_encoder *encoder = &vc4_hdmi->encoder.base.base;
E
Eric Anholt 已提交
781 782 783 784

	switch (cmd) {
	case SNDRV_PCM_TRIGGER_START:
		vc4_hdmi_set_audio_infoframe(encoder);
785 786 787

		if (vc4_hdmi->variant->phy_rng_enable)
			vc4_hdmi->variant->phy_rng_enable(vc4_hdmi);
788 789 790 791 792

		HDMI_WRITE(HDMI_MAI_CTL,
			   VC4_SET_FIELD(vc4_hdmi->audio.channels,
					 VC4_HD_MAI_CTL_CHNUM) |
			   VC4_HD_MAI_CTL_ENABLE);
E
Eric Anholt 已提交
793 794
		break;
	case SNDRV_PCM_TRIGGER_STOP:
795 796 797 798
		HDMI_WRITE(HDMI_MAI_CTL,
			   VC4_HD_MAI_CTL_DLATE |
			   VC4_HD_MAI_CTL_ERRORE |
			   VC4_HD_MAI_CTL_ERRORF);
799 800 801 802

		if (vc4_hdmi->variant->phy_rng_disable)
			vc4_hdmi->variant->phy_rng_disable(vc4_hdmi);

E
Eric Anholt 已提交
803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822
		break;
	default:
		break;
	}

	return 0;
}

static inline struct vc4_hdmi *
snd_component_to_hdmi(struct snd_soc_component *component)
{
	struct snd_soc_card *card = snd_soc_component_get_drvdata(component);

	return snd_soc_card_get_drvdata(card);
}

static int vc4_hdmi_audio_eld_ctl_info(struct snd_kcontrol *kcontrol,
				       struct snd_ctl_elem_info *uinfo)
{
	struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
823
	struct vc4_hdmi *vc4_hdmi = snd_component_to_hdmi(component);
824
	struct drm_connector *connector = &vc4_hdmi->connector;
E
Eric Anholt 已提交
825 826

	uinfo->type = SNDRV_CTL_ELEM_TYPE_BYTES;
827
	uinfo->count = sizeof(connector->eld);
E
Eric Anholt 已提交
828 829 830 831 832 833 834 835

	return 0;
}

static int vc4_hdmi_audio_eld_ctl_get(struct snd_kcontrol *kcontrol,
				      struct snd_ctl_elem_value *ucontrol)
{
	struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
836
	struct vc4_hdmi *vc4_hdmi = snd_component_to_hdmi(component);
837
	struct drm_connector *connector = &vc4_hdmi->connector;
E
Eric Anholt 已提交
838

839 840
	memcpy(ucontrol->value.bytes.data, connector->eld,
	       sizeof(connector->eld));
E
Eric Anholt 已提交
841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863

	return 0;
}

static const struct snd_kcontrol_new vc4_hdmi_audio_controls[] = {
	{
		.access = SNDRV_CTL_ELEM_ACCESS_READ |
			  SNDRV_CTL_ELEM_ACCESS_VOLATILE,
		.iface = SNDRV_CTL_ELEM_IFACE_PCM,
		.name = "ELD",
		.info = vc4_hdmi_audio_eld_ctl_info,
		.get = vc4_hdmi_audio_eld_ctl_get,
	},
};

static const struct snd_soc_dapm_widget vc4_hdmi_audio_widgets[] = {
	SND_SOC_DAPM_OUTPUT("TX"),
};

static const struct snd_soc_dapm_route vc4_hdmi_audio_routes[] = {
	{ "TX", NULL, "Playback" },
};

864 865 866 867 868 869 870 871 872 873 874
static const struct snd_soc_component_driver vc4_hdmi_audio_component_drv = {
	.controls		= vc4_hdmi_audio_controls,
	.num_controls		= ARRAY_SIZE(vc4_hdmi_audio_controls),
	.dapm_widgets		= vc4_hdmi_audio_widgets,
	.num_dapm_widgets	= ARRAY_SIZE(vc4_hdmi_audio_widgets),
	.dapm_routes		= vc4_hdmi_audio_routes,
	.num_dapm_routes	= ARRAY_SIZE(vc4_hdmi_audio_routes),
	.idle_bias_on		= 1,
	.use_pmdown_time	= 1,
	.endianness		= 1,
	.non_legacy_dai_naming	= 1,
E
Eric Anholt 已提交
875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904
};

static const struct snd_soc_dai_ops vc4_hdmi_audio_dai_ops = {
	.startup = vc4_hdmi_audio_startup,
	.shutdown = vc4_hdmi_audio_shutdown,
	.hw_params = vc4_hdmi_audio_hw_params,
	.set_fmt = vc4_hdmi_audio_set_fmt,
	.trigger = vc4_hdmi_audio_trigger,
};

static struct snd_soc_dai_driver vc4_hdmi_audio_codec_dai_drv = {
	.name = "vc4-hdmi-hifi",
	.playback = {
		.stream_name = "Playback",
		.channels_min = 2,
		.channels_max = 8,
		.rates = SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 |
			 SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_88200 |
			 SNDRV_PCM_RATE_96000 | SNDRV_PCM_RATE_176400 |
			 SNDRV_PCM_RATE_192000,
		.formats = SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE,
	},
};

static const struct snd_soc_component_driver vc4_hdmi_audio_cpu_dai_comp = {
	.name = "vc4-hdmi-cpu-dai-component",
};

static int vc4_hdmi_audio_cpu_dai_probe(struct snd_soc_dai *dai)
{
905
	struct vc4_hdmi *vc4_hdmi = dai_to_hdmi(dai);
E
Eric Anholt 已提交
906

907
	snd_soc_dai_init_dma_data(dai, &vc4_hdmi->audio.dma_data, NULL);
E
Eric Anholt 已提交
908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932

	return 0;
}

static struct snd_soc_dai_driver vc4_hdmi_audio_cpu_dai_drv = {
	.name = "vc4-hdmi-cpu-dai",
	.probe  = vc4_hdmi_audio_cpu_dai_probe,
	.playback = {
		.stream_name = "Playback",
		.channels_min = 1,
		.channels_max = 8,
		.rates = SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 |
			 SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_88200 |
			 SNDRV_PCM_RATE_96000 | SNDRV_PCM_RATE_176400 |
			 SNDRV_PCM_RATE_192000,
		.formats = SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE,
	},
	.ops = &vc4_hdmi_audio_dai_ops,
};

static const struct snd_dmaengine_pcm_config pcm_conf = {
	.chan_names[SNDRV_PCM_STREAM_PLAYBACK] = "audio-rx",
	.prepare_slave_config = snd_dmaengine_pcm_prepare_slave_config,
};

933
static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi)
E
Eric Anholt 已提交
934
{
935 936
	const struct vc4_hdmi_register *mai_data =
		&vc4_hdmi->variant->registers[HDMI_MAI_DATA];
937 938 939
	struct snd_soc_dai_link *dai_link = &vc4_hdmi->audio.link;
	struct snd_soc_card *card = &vc4_hdmi->audio.card;
	struct device *dev = &vc4_hdmi->pdev->dev;
E
Eric Anholt 已提交
940 941 942 943 944 945 946 947 948
	const __be32 *addr;
	int ret;

	if (!of_find_property(dev->of_node, "dmas", NULL)) {
		dev_warn(dev,
			 "'dmas' DT property is missing, no HDMI audio\n");
		return 0;
	}

949 950 951 952 953
	if (mai_data->reg != VC4_HD) {
		WARN_ONCE(true, "MAI isn't in the HD block\n");
		return -EINVAL;
	}

E
Eric Anholt 已提交
954 955 956 957 958 959 960 961
	/*
	 * Get the physical address of VC4_HD_MAI_DATA. We need to retrieve
	 * the bus address specified in the DT, because the physical address
	 * (the one returned by platform_get_resource()) is not appropriate
	 * for DMA transfers.
	 * This VC/MMU should probably be exposed to avoid this kind of hacks.
	 */
	addr = of_get_address(dev->of_node, 1, NULL, NULL);
962
	vc4_hdmi->audio.dma_data.addr = be32_to_cpup(addr) + mai_data->offset;
963 964
	vc4_hdmi->audio.dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
	vc4_hdmi->audio.dma_data.maxburst = 2;
E
Eric Anholt 已提交
965 966 967 968 969 970 971 972 973 974 975 976 977 978

	ret = devm_snd_dmaengine_pcm_register(dev, &pcm_conf, 0);
	if (ret) {
		dev_err(dev, "Could not register PCM component: %d\n", ret);
		return ret;
	}

	ret = devm_snd_soc_register_component(dev, &vc4_hdmi_audio_cpu_dai_comp,
					      &vc4_hdmi_audio_cpu_dai_drv, 1);
	if (ret) {
		dev_err(dev, "Could not register CPU DAI: %d\n", ret);
		return ret;
	}

979 980
	/* register component and codec dai */
	ret = devm_snd_soc_register_component(dev, &vc4_hdmi_audio_component_drv,
E
Eric Anholt 已提交
981 982
				     &vc4_hdmi_audio_codec_dai_drv, 1);
	if (ret) {
983
		dev_err(dev, "Could not register component: %d\n", ret);
E
Eric Anholt 已提交
984 985 986
		return ret;
	}

987 988 989
	dai_link->cpus		= &vc4_hdmi->audio.cpu;
	dai_link->codecs	= &vc4_hdmi->audio.codec;
	dai_link->platforms	= &vc4_hdmi->audio.platform;
990 991 992

	dai_link->num_cpus	= 1;
	dai_link->num_codecs	= 1;
993
	dai_link->num_platforms	= 1;
994

E
Eric Anholt 已提交
995 996
	dai_link->name = "MAI";
	dai_link->stream_name = "MAI PCM";
997 998 999
	dai_link->codecs->dai_name = vc4_hdmi_audio_codec_dai_drv.name;
	dai_link->cpus->dai_name = dev_name(dev);
	dai_link->codecs->name = dev_name(dev);
1000
	dai_link->platforms->name = dev_name(dev);
E
Eric Anholt 已提交
1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013

	card->dai_link = dai_link;
	card->num_links = 1;
	card->name = "vc4-hdmi";
	card->dev = dev;

	/*
	 * Be careful, snd_soc_register_card() calls dev_set_drvdata() and
	 * stores a pointer to the snd card object in dev->driver_data. This
	 * means we cannot use it for something else. The hdmi back-pointer is
	 * now stored in card->drvdata and should be retrieved with
	 * snd_soc_card_get_drvdata() if needed.
	 */
1014
	snd_soc_card_set_drvdata(card, vc4_hdmi);
E
Eric Anholt 已提交
1015
	ret = devm_snd_soc_register_card(dev, card);
1016
	if (ret)
E
Eric Anholt 已提交
1017 1018 1019 1020 1021 1022
		dev_err(dev, "Could not register sound card: %d\n", ret);

	return ret;

}

H
Hans Verkuil 已提交
1023 1024 1025
#ifdef CONFIG_DRM_VC4_HDMI_CEC
static irqreturn_t vc4_cec_irq_handler_thread(int irq, void *priv)
{
1026
	struct vc4_hdmi *vc4_hdmi = priv;
1027 1028 1029 1030 1031 1032 1033

	if (vc4_hdmi->cec_irq_was_rx) {
		if (vc4_hdmi->cec_rx_msg.len)
			cec_received_msg(vc4_hdmi->cec_adap,
					 &vc4_hdmi->cec_rx_msg);
	} else if (vc4_hdmi->cec_tx_ok) {
		cec_transmit_done(vc4_hdmi->cec_adap, CEC_TX_STATUS_OK,
H
Hans Verkuil 已提交
1034 1035 1036 1037 1038 1039
				  0, 0, 0, 0);
	} else {
		/*
		 * This CEC implementation makes 1 retry, so if we
		 * get a NACK, then that means it made 2 attempts.
		 */
1040
		cec_transmit_done(vc4_hdmi->cec_adap, CEC_TX_STATUS_NACK,
H
Hans Verkuil 已提交
1041 1042 1043 1044 1045
				  0, 2, 0, 0);
	}
	return IRQ_HANDLED;
}

1046
static void vc4_cec_read_msg(struct vc4_hdmi *vc4_hdmi, u32 cntrl1)
H
Hans Verkuil 已提交
1047
{
1048
	struct cec_msg *msg = &vc4_hdmi->cec_rx_msg;
H
Hans Verkuil 已提交
1049 1050 1051 1052 1053
	unsigned int i;

	msg->len = 1 + ((cntrl1 & VC4_HDMI_CEC_REC_WRD_CNT_MASK) >>
					VC4_HDMI_CEC_REC_WRD_CNT_SHIFT);
	for (i = 0; i < msg->len; i += 4) {
1054
		u32 val = HDMI_READ(HDMI_CEC_RX_DATA_1 + i);
H
Hans Verkuil 已提交
1055 1056 1057 1058 1059 1060 1061 1062 1063 1064

		msg->msg[i] = val & 0xff;
		msg->msg[i + 1] = (val >> 8) & 0xff;
		msg->msg[i + 2] = (val >> 16) & 0xff;
		msg->msg[i + 3] = (val >> 24) & 0xff;
	}
}

static irqreturn_t vc4_cec_irq_handler(int irq, void *priv)
{
1065
	struct vc4_hdmi *vc4_hdmi = priv;
1066
	u32 stat = HDMI_READ(HDMI_CEC_CPU_STATUS);
H
Hans Verkuil 已提交
1067 1068 1069 1070
	u32 cntrl1, cntrl5;

	if (!(stat & VC4_HDMI_CPU_CEC))
		return IRQ_NONE;
1071
	vc4_hdmi->cec_rx_msg.len = 0;
1072 1073
	cntrl1 = HDMI_READ(HDMI_CEC_CNTRL_1);
	cntrl5 = HDMI_READ(HDMI_CEC_CNTRL_5);
1074 1075
	vc4_hdmi->cec_irq_was_rx = cntrl5 & VC4_HDMI_CEC_RX_CEC_INT;
	if (vc4_hdmi->cec_irq_was_rx) {
1076
		vc4_cec_read_msg(vc4_hdmi, cntrl1);
H
Hans Verkuil 已提交
1077
		cntrl1 |= VC4_HDMI_CEC_CLEAR_RECEIVE_OFF;
1078
		HDMI_WRITE(HDMI_CEC_CNTRL_1, cntrl1);
H
Hans Verkuil 已提交
1079 1080
		cntrl1 &= ~VC4_HDMI_CEC_CLEAR_RECEIVE_OFF;
	} else {
1081
		vc4_hdmi->cec_tx_ok = cntrl1 & VC4_HDMI_CEC_TX_STATUS_GOOD;
H
Hans Verkuil 已提交
1082 1083
		cntrl1 &= ~VC4_HDMI_CEC_START_XMIT_BEGIN;
	}
1084 1085
	HDMI_WRITE(HDMI_CEC_CNTRL_1, cntrl1);
	HDMI_WRITE(HDMI_CEC_CPU_CLEAR, VC4_HDMI_CPU_CEC);
H
Hans Verkuil 已提交
1086 1087 1088 1089 1090 1091

	return IRQ_WAKE_THREAD;
}

static int vc4_hdmi_cec_adap_enable(struct cec_adapter *adap, bool enable)
{
1092
	struct vc4_hdmi *vc4_hdmi = cec_get_drvdata(adap);
H
Hans Verkuil 已提交
1093 1094
	/* clock period in microseconds */
	const u32 usecs = 1000000 / CEC_CLOCK_FREQ;
1095
	u32 val = HDMI_READ(HDMI_CEC_CNTRL_5);
H
Hans Verkuil 已提交
1096 1097 1098 1099 1100 1101 1102 1103

	val &= ~(VC4_HDMI_CEC_TX_SW_RESET | VC4_HDMI_CEC_RX_SW_RESET |
		 VC4_HDMI_CEC_CNT_TO_4700_US_MASK |
		 VC4_HDMI_CEC_CNT_TO_4500_US_MASK);
	val |= ((4700 / usecs) << VC4_HDMI_CEC_CNT_TO_4700_US_SHIFT) |
	       ((4500 / usecs) << VC4_HDMI_CEC_CNT_TO_4500_US_SHIFT);

	if (enable) {
1104
		HDMI_WRITE(HDMI_CEC_CNTRL_5, val |
H
Hans Verkuil 已提交
1105
			   VC4_HDMI_CEC_TX_SW_RESET | VC4_HDMI_CEC_RX_SW_RESET);
1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124
		HDMI_WRITE(HDMI_CEC_CNTRL_5, val);
		HDMI_WRITE(HDMI_CEC_CNTRL_2,
			   ((1500 / usecs) << VC4_HDMI_CEC_CNT_TO_1500_US_SHIFT) |
			   ((1300 / usecs) << VC4_HDMI_CEC_CNT_TO_1300_US_SHIFT) |
			   ((800 / usecs) << VC4_HDMI_CEC_CNT_TO_800_US_SHIFT) |
			   ((600 / usecs) << VC4_HDMI_CEC_CNT_TO_600_US_SHIFT) |
			   ((400 / usecs) << VC4_HDMI_CEC_CNT_TO_400_US_SHIFT));
		HDMI_WRITE(HDMI_CEC_CNTRL_3,
			   ((2750 / usecs) << VC4_HDMI_CEC_CNT_TO_2750_US_SHIFT) |
			   ((2400 / usecs) << VC4_HDMI_CEC_CNT_TO_2400_US_SHIFT) |
			   ((2050 / usecs) << VC4_HDMI_CEC_CNT_TO_2050_US_SHIFT) |
			   ((1700 / usecs) << VC4_HDMI_CEC_CNT_TO_1700_US_SHIFT));
		HDMI_WRITE(HDMI_CEC_CNTRL_4,
			   ((4300 / usecs) << VC4_HDMI_CEC_CNT_TO_4300_US_SHIFT) |
			   ((3900 / usecs) << VC4_HDMI_CEC_CNT_TO_3900_US_SHIFT) |
			   ((3600 / usecs) << VC4_HDMI_CEC_CNT_TO_3600_US_SHIFT) |
			   ((3500 / usecs) << VC4_HDMI_CEC_CNT_TO_3500_US_SHIFT));

		HDMI_WRITE(HDMI_CEC_CPU_MASK_CLEAR, VC4_HDMI_CPU_CEC);
H
Hans Verkuil 已提交
1125
	} else {
1126 1127
		HDMI_WRITE(HDMI_CEC_CPU_MASK_SET, VC4_HDMI_CPU_CEC);
		HDMI_WRITE(HDMI_CEC_CNTRL_5, val |
H
Hans Verkuil 已提交
1128 1129 1130 1131 1132 1133 1134
			   VC4_HDMI_CEC_TX_SW_RESET | VC4_HDMI_CEC_RX_SW_RESET);
	}
	return 0;
}

static int vc4_hdmi_cec_adap_log_addr(struct cec_adapter *adap, u8 log_addr)
{
1135
	struct vc4_hdmi *vc4_hdmi = cec_get_drvdata(adap);
H
Hans Verkuil 已提交
1136

1137 1138
	HDMI_WRITE(HDMI_CEC_CNTRL_1,
		   (HDMI_READ(HDMI_CEC_CNTRL_1) & ~VC4_HDMI_CEC_ADDR_MASK) |
H
Hans Verkuil 已提交
1139 1140 1141 1142 1143 1144 1145
		   (log_addr & 0xf) << VC4_HDMI_CEC_ADDR_SHIFT);
	return 0;
}

static int vc4_hdmi_cec_adap_transmit(struct cec_adapter *adap, u8 attempts,
				      u32 signal_free_time, struct cec_msg *msg)
{
1146
	struct vc4_hdmi *vc4_hdmi = cec_get_drvdata(adap);
H
Hans Verkuil 已提交
1147 1148 1149 1150
	u32 val;
	unsigned int i;

	for (i = 0; i < msg->len; i += 4)
1151
		HDMI_WRITE(HDMI_CEC_TX_DATA_1 + i,
H
Hans Verkuil 已提交
1152 1153 1154 1155 1156
			   (msg->msg[i]) |
			   (msg->msg[i + 1] << 8) |
			   (msg->msg[i + 2] << 16) |
			   (msg->msg[i + 3] << 24));

1157
	val = HDMI_READ(HDMI_CEC_CNTRL_1);
H
Hans Verkuil 已提交
1158
	val &= ~VC4_HDMI_CEC_START_XMIT_BEGIN;
1159
	HDMI_WRITE(HDMI_CEC_CNTRL_1, val);
H
Hans Verkuil 已提交
1160 1161 1162 1163
	val &= ~VC4_HDMI_CEC_MESSAGE_LENGTH_MASK;
	val |= (msg->len - 1) << VC4_HDMI_CEC_MESSAGE_LENGTH_SHIFT;
	val |= VC4_HDMI_CEC_START_XMIT_BEGIN;

1164
	HDMI_WRITE(HDMI_CEC_CNTRL_1, val);
H
Hans Verkuil 已提交
1165 1166 1167 1168 1169 1170 1171 1172 1173 1174
	return 0;
}

static const struct cec_adap_ops vc4_hdmi_cec_adap_ops = {
	.adap_enable = vc4_hdmi_cec_adap_enable,
	.adap_log_addr = vc4_hdmi_cec_adap_log_addr,
	.adap_transmit = vc4_hdmi_cec_adap_transmit,
};
#endif

1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210
static int vc4_hdmi_build_regset(struct vc4_hdmi *vc4_hdmi,
				 struct debugfs_regset32 *regset,
				 enum vc4_hdmi_regs reg)
{
	const struct vc4_hdmi_variant *variant = vc4_hdmi->variant;
	struct debugfs_reg32 *regs, *new_regs;
	unsigned int count = 0;
	unsigned int i;

	regs = kcalloc(variant->num_registers, sizeof(*regs),
		       GFP_KERNEL);
	if (!regs)
		return -ENOMEM;

	for (i = 0; i < variant->num_registers; i++) {
		const struct vc4_hdmi_register *field =	&variant->registers[i];

		if (field->reg != reg)
			continue;

		regs[count].name = field->name;
		regs[count].offset = field->offset;
		count++;
	}

	new_regs = krealloc(regs, count * sizeof(*regs), GFP_KERNEL);
	if (!new_regs)
		return -ENOMEM;

	regset->base = __vc4_hdmi_get_field_base(vc4_hdmi, reg);
	regset->regs = new_regs;
	regset->nregs = count;

	return 0;
}

1211
static int vc4_hdmi_init_resources(struct vc4_hdmi *vc4_hdmi)
1212
{
1213 1214
	struct platform_device *pdev = vc4_hdmi->pdev;
	struct device *dev = &pdev->dev;
1215 1216
	int ret;

1217 1218 1219
	vc4_hdmi->hdmicore_regs = vc4_ioremap_regs(pdev, 0);
	if (IS_ERR(vc4_hdmi->hdmicore_regs))
		return PTR_ERR(vc4_hdmi->hdmicore_regs);
1220

1221 1222 1223
	vc4_hdmi->hd_regs = vc4_ioremap_regs(pdev, 1);
	if (IS_ERR(vc4_hdmi->hd_regs))
		return PTR_ERR(vc4_hdmi->hd_regs);
1224

1225 1226 1227
	ret = vc4_hdmi_build_regset(vc4_hdmi, &vc4_hdmi->hd_regset, VC4_HD);
	if (ret)
		return ret;
1228

1229 1230 1231
	ret = vc4_hdmi_build_regset(vc4_hdmi, &vc4_hdmi->hdmi_regset, VC4_HDMI);
	if (ret)
		return ret;
1232

1233 1234 1235
	vc4_hdmi->pixel_clock = devm_clk_get(dev, "pixel");
	if (IS_ERR(vc4_hdmi->pixel_clock)) {
		ret = PTR_ERR(vc4_hdmi->pixel_clock);
1236 1237 1238
		if (ret != -EPROBE_DEFER)
			DRM_ERROR("Failed to get pixel clock\n");
		return ret;
1239
	}
1240

1241 1242
	vc4_hdmi->hsm_clock = devm_clk_get(dev, "hdmi");
	if (IS_ERR(vc4_hdmi->hsm_clock)) {
1243
		DRM_ERROR("Failed to get HDMI state machine clock\n");
1244
		return PTR_ERR(vc4_hdmi->hsm_clock);
1245 1246
	}

1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277
	return 0;
}

static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
{
#ifdef CONFIG_DRM_VC4_HDMI_CEC
	struct cec_connector_info conn_info;
#endif
	const struct vc4_hdmi_variant *variant = of_device_get_match_data(dev);
	struct platform_device *pdev = to_platform_device(dev);
	struct drm_device *drm = dev_get_drvdata(master);
	struct vc4_hdmi *vc4_hdmi;
	struct drm_encoder *encoder;
	struct device_node *ddc_node;
	u32 value;
	int ret;

	vc4_hdmi = devm_kzalloc(dev, sizeof(*vc4_hdmi), GFP_KERNEL);
	if (!vc4_hdmi)
		return -ENOMEM;

	dev_set_drvdata(dev, vc4_hdmi);
	encoder = &vc4_hdmi->encoder.base.base;
	vc4_hdmi->encoder.base.type = VC4_ENCODER_TYPE_HDMI0;
	vc4_hdmi->pdev = pdev;
	vc4_hdmi->variant = variant;

	ret = variant->init_resources(vc4_hdmi);
	if (ret)
		return ret;

1278 1279 1280 1281 1282 1283
	ddc_node = of_parse_phandle(dev->of_node, "ddc", 0);
	if (!ddc_node) {
		DRM_ERROR("Failed to find ddc node in device tree\n");
		return -ENODEV;
	}

1284
	vc4_hdmi->ddc = of_find_i2c_adapter_by_node(ddc_node);
1285
	of_node_put(ddc_node);
1286
	if (!vc4_hdmi->ddc) {
1287 1288 1289 1290
		DRM_DEBUG("Failed to get ddc i2c adapter by node\n");
		return -EPROBE_DEFER;
	}

H
Hans Verkuil 已提交
1291 1292 1293 1294
	/* This is the rate that is set by the firmware.  The number
	 * needs to be a bit higher than the pixel clock rate
	 * (generally 148.5Mhz).
	 */
1295
	ret = clk_set_rate(vc4_hdmi->hsm_clock, HSM_CLOCK_FREQ);
H
Hans Verkuil 已提交
1296 1297 1298 1299 1300
	if (ret) {
		DRM_ERROR("Failed to set HSM clock rate: %d\n", ret);
		goto err_put_i2c;
	}

1301
	ret = clk_prepare_enable(vc4_hdmi->hsm_clock);
H
Hans Verkuil 已提交
1302 1303 1304 1305 1306 1307
	if (ret) {
		DRM_ERROR("Failed to turn on HDMI state machine clock: %d\n",
			  ret);
		goto err_put_i2c;
	}

1308 1309 1310 1311
	/* Only use the GPIO HPD pin if present in the DT, otherwise
	 * we'll use the HDMI core's register.
	 */
	if (of_find_property(dev->of_node, "hpd-gpios", &value)) {
1312 1313
		enum of_gpio_flags hpd_gpio_flags;

1314 1315 1316 1317 1318
		vc4_hdmi->hpd_gpio = of_get_named_gpio_flags(dev->of_node,
							     "hpd-gpios", 0,
							     &hpd_gpio_flags);
		if (vc4_hdmi->hpd_gpio < 0) {
			ret = vc4_hdmi->hpd_gpio;
H
Hans Verkuil 已提交
1319
			goto err_unprepare_hsm;
1320
		}
1321

1322
		vc4_hdmi->hpd_active_low = hpd_gpio_flags & OF_GPIO_ACTIVE_LOW;
1323 1324
	}

1325
	pm_runtime_enable(dev);
1326

1327 1328
	drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_TMDS);
	drm_encoder_helper_add(encoder, &vc4_hdmi_encoder_helper_funcs);
1329

1330
	ret = vc4_hdmi_connector_init(drm, vc4_hdmi);
1331
	if (ret)
1332
		goto err_destroy_encoder;
1333

H
Hans Verkuil 已提交
1334
#ifdef CONFIG_DRM_VC4_HDMI_CEC
1335
	vc4_hdmi->cec_adap = cec_allocate_adapter(&vc4_hdmi_cec_adap_ops,
1336
						  vc4_hdmi, "vc4",
1337 1338 1339
						  CEC_CAP_DEFAULTS |
						  CEC_CAP_CONNECTOR_INFO, 1);
	ret = PTR_ERR_OR_ZERO(vc4_hdmi->cec_adap);
H
Hans Verkuil 已提交
1340 1341
	if (ret < 0)
		goto err_destroy_conn;
1342

1343
	cec_fill_conn_info_from_drm(&conn_info, &vc4_hdmi->connector);
1344
	cec_s_conn_info(vc4_hdmi->cec_adap, &conn_info);
1345

1346 1347
	HDMI_WRITE(HDMI_CEC_CPU_MASK_SET, 0xffffffff);
	value = HDMI_READ(HDMI_CEC_CNTRL_1);
H
Hans Verkuil 已提交
1348 1349 1350 1351 1352 1353 1354 1355
	value &= ~VC4_HDMI_CEC_DIV_CLK_CNT_MASK;
	/*
	 * Set the logical address to Unregistered and set the clock
	 * divider: the hsm_clock rate and this divider setting will
	 * give a 40 kHz CEC clock.
	 */
	value |= VC4_HDMI_CEC_ADDR_MASK |
		 (4091 << VC4_HDMI_CEC_DIV_CLK_CNT_SHIFT);
1356
	HDMI_WRITE(HDMI_CEC_CNTRL_1, value);
H
Hans Verkuil 已提交
1357 1358 1359
	ret = devm_request_threaded_irq(dev, platform_get_irq(pdev, 0),
					vc4_cec_irq_handler,
					vc4_cec_irq_handler_thread, 0,
1360
					"vc4 hdmi cec", vc4_hdmi);
H
Hans Verkuil 已提交
1361 1362
	if (ret)
		goto err_delete_cec_adap;
1363
	ret = cec_register_adapter(vc4_hdmi->cec_adap, dev);
H
Hans Verkuil 已提交
1364 1365 1366
	if (ret < 0)
		goto err_delete_cec_adap;
#endif
1367

1368
	ret = vc4_hdmi_audio_init(vc4_hdmi);
E
Eric Anholt 已提交
1369 1370 1371
	if (ret)
		goto err_destroy_encoder;

1372
	vc4_debugfs_add_file(drm, "hdmi_regs", vc4_hdmi_debugfs_regs, vc4_hdmi);
1373

1374 1375
	return 0;

H
Hans Verkuil 已提交
1376 1377
#ifdef CONFIG_DRM_VC4_HDMI_CEC
err_delete_cec_adap:
1378
	cec_delete_adapter(vc4_hdmi->cec_adap);
H
Hans Verkuil 已提交
1379
err_destroy_conn:
1380
	vc4_hdmi_connector_destroy(&vc4_hdmi->connector);
H
Hans Verkuil 已提交
1381
#endif
1382
err_destroy_encoder:
1383
	drm_encoder_cleanup(encoder);
H
Hans Verkuil 已提交
1384
err_unprepare_hsm:
1385
	clk_disable_unprepare(vc4_hdmi->hsm_clock);
1386
	pm_runtime_disable(dev);
1387
err_put_i2c:
1388
	put_device(&vc4_hdmi->ddc->dev);
1389 1390 1391 1392 1393 1394 1395

	return ret;
}

static void vc4_hdmi_unbind(struct device *dev, struct device *master,
			    void *data)
{
1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417
	struct vc4_hdmi *vc4_hdmi;

	/*
	 * ASoC makes it a bit hard to retrieve a pointer to the
	 * vc4_hdmi structure. Registering the card will overwrite our
	 * device drvdata with a pointer to the snd_soc_card structure,
	 * which can then be used to retrieve whatever drvdata we want
	 * to associate.
	 *
	 * However, that doesn't fly in the case where we wouldn't
	 * register an ASoC card (because of an old DT that is missing
	 * the dmas properties for example), then the card isn't
	 * registered and the device drvdata wouldn't be set.
	 *
	 * We can deal with both cases by making sure a snd_soc_card
	 * pointer and a vc4_hdmi structure are pointing to the same
	 * memory address, so we can treat them indistinctly without any
	 * issue.
	 */
	BUILD_BUG_ON(offsetof(struct vc4_hdmi_audio, card) != 0);
	BUILD_BUG_ON(offsetof(struct vc4_hdmi, audio) != 0);
	vc4_hdmi = dev_get_drvdata(dev);
1418

1419 1420 1421
	kfree(vc4_hdmi->hdmi_regset.regs);
	kfree(vc4_hdmi->hd_regset.regs);

1422
	cec_unregister_adapter(vc4_hdmi->cec_adap);
1423
	vc4_hdmi_connector_destroy(&vc4_hdmi->connector);
1424
	drm_encoder_cleanup(&vc4_hdmi->encoder.base.base);
1425

1426
	clk_disable_unprepare(vc4_hdmi->hsm_clock);
1427 1428
	pm_runtime_disable(dev);

1429
	put_device(&vc4_hdmi->ddc->dev);
1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447
}

static const struct component_ops vc4_hdmi_ops = {
	.bind   = vc4_hdmi_bind,
	.unbind = vc4_hdmi_unbind,
};

static int vc4_hdmi_dev_probe(struct platform_device *pdev)
{
	return component_add(&pdev->dev, &vc4_hdmi_ops);
}

static int vc4_hdmi_dev_remove(struct platform_device *pdev)
{
	component_del(&pdev->dev, &vc4_hdmi_ops);
	return 0;
}

1448
static const struct vc4_hdmi_variant bcm2835_variant = {
1449 1450 1451
	.registers		= vc4_hdmi_fields,
	.num_registers		= ARRAY_SIZE(vc4_hdmi_fields),

1452
	.init_resources		= vc4_hdmi_init_resources,
1453
	.csc_setup		= vc4_hdmi_csc_setup,
1454
	.reset			= vc4_hdmi_reset,
1455
	.set_timings		= vc4_hdmi_set_timings,
1456 1457
	.phy_init		= vc4_hdmi_phy_init,
	.phy_disable		= vc4_hdmi_phy_disable,
1458 1459
	.phy_rng_enable		= vc4_hdmi_phy_rng_enable,
	.phy_rng_disable	= vc4_hdmi_phy_rng_disable,
1460 1461
};

1462
static const struct of_device_id vc4_hdmi_dt_match[] = {
1463
	{ .compatible = "brcm,bcm2835-hdmi", .data = &bcm2835_variant },
1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474
	{}
};

struct platform_driver vc4_hdmi_driver = {
	.probe = vc4_hdmi_dev_probe,
	.remove = vc4_hdmi_dev_remove,
	.driver = {
		.name = "vc4_hdmi",
		.of_match_table = vc4_hdmi_dt_match,
	},
};