xfs_attr_remote.c 14.9 KB
Newer Older
1 2
/*
 * Copyright (c) 2000-2005 Silicon Graphics, Inc.
3
 * Copyright (c) 2013 Red Hat, Inc.
4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40
 * All Rights Reserved.
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License as
 * published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it would be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write the Free Software Foundation,
 * Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 */
#include "xfs.h"
#include "xfs_fs.h"
#include "xfs_types.h"
#include "xfs_bit.h"
#include "xfs_log.h"
#include "xfs_trans.h"
#include "xfs_sb.h"
#include "xfs_ag.h"
#include "xfs_mount.h"
#include "xfs_error.h"
#include "xfs_da_btree.h"
#include "xfs_bmap_btree.h"
#include "xfs_dinode.h"
#include "xfs_inode.h"
#include "xfs_alloc.h"
#include "xfs_inode_item.h"
#include "xfs_bmap.h"
#include "xfs_attr.h"
#include "xfs_attr_leaf.h"
#include "xfs_attr_remote.h"
#include "xfs_trans_space.h"
#include "xfs_trace.h"
41 42
#include "xfs_cksum.h"
#include "xfs_buf_item.h"
43 44 45

#define ATTR_RMTVALUE_MAPSIZE	1	/* # of map entries at once */

46 47 48 49
/*
 * Each contiguous block has a header, so it is not just a simple attribute
 * length to FSB conversion.
 */
D
Dave Chinner 已提交
50
int
51 52 53 54
xfs_attr3_rmt_blocks(
	struct xfs_mount *mp,
	int		attrlen)
{
55 56 57 58 59
	if (xfs_sb_version_hascrc(&mp->m_sb)) {
		int buflen = XFS_ATTR3_RMT_BUF_SPACE(mp, mp->m_sb.sb_blocksize);
		return (attrlen + buflen - 1) / buflen;
	}
	return XFS_B_TO_FSB(mp, attrlen);
60 61
}

D
Dave Chinner 已提交
62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90
/*
 * Checking of the remote attribute header is split into two parts. The verifier
 * does CRC, location and bounds checking, the unpacking function checks the
 * attribute parameters and owner.
 */
static bool
xfs_attr3_rmt_hdr_ok(
	struct xfs_mount	*mp,
	void			*ptr,
	xfs_ino_t		ino,
	uint32_t		offset,
	uint32_t		size,
	xfs_daddr_t		bno)
{
	struct xfs_attr3_rmt_hdr *rmt = ptr;

	if (bno != be64_to_cpu(rmt->rm_blkno))
		return false;
	if (offset != be32_to_cpu(rmt->rm_offset))
		return false;
	if (size != be32_to_cpu(rmt->rm_bytes))
		return false;
	if (ino != be64_to_cpu(rmt->rm_owner))
		return false;

	/* ok */
	return true;
}

91 92
static bool
xfs_attr3_rmt_verify(
D
Dave Chinner 已提交
93 94 95 96
	struct xfs_mount	*mp,
	void			*ptr,
	int			fsbsize,
	xfs_daddr_t		bno)
97
{
D
Dave Chinner 已提交
98
	struct xfs_attr3_rmt_hdr *rmt = ptr;
99 100 101 102 103 104 105

	if (!xfs_sb_version_hascrc(&mp->m_sb))
		return false;
	if (rmt->rm_magic != cpu_to_be32(XFS_ATTR3_RMT_MAGIC))
		return false;
	if (!uuid_equal(&rmt->rm_uuid, &mp->m_sb.sb_uuid))
		return false;
D
Dave Chinner 已提交
106 107 108
	if (be64_to_cpu(rmt->rm_blkno) != bno)
		return false;
	if (be32_to_cpu(rmt->rm_bytes) > fsbsize - sizeof(*rmt))
109 110
		return false;
	if (be32_to_cpu(rmt->rm_offset) +
111
				be32_to_cpu(rmt->rm_bytes) >= XATTR_SIZE_MAX)
112 113 114 115 116 117 118 119 120 121 122 123
		return false;
	if (rmt->rm_owner == 0)
		return false;

	return true;
}

static void
xfs_attr3_rmt_read_verify(
	struct xfs_buf	*bp)
{
	struct xfs_mount *mp = bp->b_target->bt_mount;
D
Dave Chinner 已提交
124 125 126 127
	char		*ptr;
	int		len;
	bool		corrupt = false;
	xfs_daddr_t	bno;
128 129 130 131 132

	/* no verification of non-crc buffers */
	if (!xfs_sb_version_hascrc(&mp->m_sb))
		return;

D
Dave Chinner 已提交
133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153
	ptr = bp->b_addr;
	bno = bp->b_bn;
	len = BBTOB(bp->b_length);
	ASSERT(len >= XFS_LBSIZE(mp));

	while (len > 0) {
		if (!xfs_verify_cksum(ptr, XFS_LBSIZE(mp),
				      XFS_ATTR3_RMT_CRC_OFF)) {
			corrupt = true;
			break;
		}
		if (!xfs_attr3_rmt_verify(mp, ptr, XFS_LBSIZE(mp), bno)) {
			corrupt = true;
			break;
		}
		len -= XFS_LBSIZE(mp);
		ptr += XFS_LBSIZE(mp);
		bno += mp->m_bsize;
	}

	if (corrupt) {
154 155
		XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp, bp->b_addr);
		xfs_buf_ioerror(bp, EFSCORRUPTED);
D
Dave Chinner 已提交
156 157
	} else
		ASSERT(len == 0);
158 159 160 161 162 163 164 165
}

static void
xfs_attr3_rmt_write_verify(
	struct xfs_buf	*bp)
{
	struct xfs_mount *mp = bp->b_target->bt_mount;
	struct xfs_buf_log_item	*bip = bp->b_fspriv;
D
Dave Chinner 已提交
166 167 168
	char		*ptr;
	int		len;
	xfs_daddr_t	bno;
169 170 171 172 173

	/* no verification of non-crc buffers */
	if (!xfs_sb_version_hascrc(&mp->m_sb))
		return;

D
Dave Chinner 已提交
174 175 176 177 178 179 180 181 182 183 184 185 186 187
	ptr = bp->b_addr;
	bno = bp->b_bn;
	len = BBTOB(bp->b_length);
	ASSERT(len >= XFS_LBSIZE(mp));

	while (len > 0) {
		if (!xfs_attr3_rmt_verify(mp, ptr, XFS_LBSIZE(mp), bno)) {
			XFS_CORRUPTION_ERROR(__func__,
					    XFS_ERRLEVEL_LOW, mp, bp->b_addr);
			xfs_buf_ioerror(bp, EFSCORRUPTED);
			return;
		}
		if (bip) {
			struct xfs_attr3_rmt_hdr *rmt;
188

D
Dave Chinner 已提交
189 190 191 192 193 194 195 196
			rmt = (struct xfs_attr3_rmt_hdr *)ptr;
			rmt->rm_lsn = cpu_to_be64(bip->bli_item.li_lsn);
		}
		xfs_update_cksum(ptr, XFS_LBSIZE(mp), XFS_ATTR3_RMT_CRC_OFF);

		len -= XFS_LBSIZE(mp);
		ptr += XFS_LBSIZE(mp);
		bno += mp->m_bsize;
197
	}
D
Dave Chinner 已提交
198
	ASSERT(len == 0);
199 200 201 202 203 204 205
}

const struct xfs_buf_ops xfs_attr3_rmt_buf_ops = {
	.verify_read = xfs_attr3_rmt_read_verify,
	.verify_write = xfs_attr3_rmt_write_verify,
};

D
Dave Chinner 已提交
206
STATIC int
207 208
xfs_attr3_rmt_hdr_set(
	struct xfs_mount	*mp,
D
Dave Chinner 已提交
209
	void			*ptr,
210 211 212
	xfs_ino_t		ino,
	uint32_t		offset,
	uint32_t		size,
D
Dave Chinner 已提交
213
	xfs_daddr_t		bno)
214
{
D
Dave Chinner 已提交
215
	struct xfs_attr3_rmt_hdr *rmt = ptr;
216 217 218 219 220 221 222 223 224

	if (!xfs_sb_version_hascrc(&mp->m_sb))
		return 0;

	rmt->rm_magic = cpu_to_be32(XFS_ATTR3_RMT_MAGIC);
	rmt->rm_offset = cpu_to_be32(offset);
	rmt->rm_bytes = cpu_to_be32(size);
	uuid_copy(&rmt->rm_uuid, &mp->m_sb.sb_uuid);
	rmt->rm_owner = cpu_to_be64(ino);
D
Dave Chinner 已提交
225
	rmt->rm_blkno = cpu_to_be64(bno);
226 227 228 229 230

	return sizeof(struct xfs_attr3_rmt_hdr);
}

/*
D
Dave Chinner 已提交
231
 * Helper functions to copy attribute data in and out of the one disk extents
232
 */
D
Dave Chinner 已提交
233 234 235 236 237 238 239 240
STATIC int
xfs_attr_rmtval_copyout(
	struct xfs_mount *mp,
	struct xfs_buf	*bp,
	xfs_ino_t	ino,
	int		*offset,
	int		*valuelen,
	char		**dst)
241
{
D
Dave Chinner 已提交
242 243 244
	char		*src = bp->b_addr;
	xfs_daddr_t	bno = bp->b_bn;
	int		len = BBTOB(bp->b_length);
245

D
Dave Chinner 已提交
246
	ASSERT(len >= XFS_LBSIZE(mp));
247

D
Dave Chinner 已提交
248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325
	while (len > 0 && *valuelen > 0) {
		int hdr_size = 0;
		int byte_cnt = XFS_ATTR3_RMT_BUF_SPACE(mp, XFS_LBSIZE(mp));

		byte_cnt = min_t(int, *valuelen, byte_cnt);

		if (xfs_sb_version_hascrc(&mp->m_sb)) {
			if (!xfs_attr3_rmt_hdr_ok(mp, src, ino, *offset,
						  byte_cnt, bno)) {
				xfs_alert(mp,
"remote attribute header mismatch bno/off/len/owner (0x%llx/0x%x/Ox%x/0x%llx)",
					bno, *offset, byte_cnt, ino);
				return EFSCORRUPTED;
			}
			hdr_size = sizeof(struct xfs_attr3_rmt_hdr);
		}

		memcpy(*dst, src + hdr_size, byte_cnt);

		/* roll buffer forwards */
		len -= XFS_LBSIZE(mp);
		src += XFS_LBSIZE(mp);
		bno += mp->m_bsize;

		/* roll attribute data forwards */
		*valuelen -= byte_cnt;
		*dst += byte_cnt;
		*offset += byte_cnt;
	}
	return 0;
}

STATIC void
xfs_attr_rmtval_copyin(
	struct xfs_mount *mp,
	struct xfs_buf	*bp,
	xfs_ino_t	ino,
	int		*offset,
	int		*valuelen,
	char		**src)
{
	char		*dst = bp->b_addr;
	xfs_daddr_t	bno = bp->b_bn;
	int		len = BBTOB(bp->b_length);

	ASSERT(len >= XFS_LBSIZE(mp));

	while (len > 0 && *valuelen > 0) {
		int hdr_size;
		int byte_cnt = XFS_ATTR3_RMT_BUF_SPACE(mp, XFS_LBSIZE(mp));

		byte_cnt = min(*valuelen, byte_cnt);
		hdr_size = xfs_attr3_rmt_hdr_set(mp, dst, ino, *offset,
						 byte_cnt, bno);

		memcpy(dst + hdr_size, *src, byte_cnt);

		/*
		 * If this is the last block, zero the remainder of it.
		 * Check that we are actually the last block, too.
		 */
		if (byte_cnt + hdr_size < XFS_LBSIZE(mp)) {
			ASSERT(*valuelen - byte_cnt == 0);
			ASSERT(len == XFS_LBSIZE(mp));
			memset(dst + hdr_size + byte_cnt, 0,
					XFS_LBSIZE(mp) - hdr_size - byte_cnt);
		}

		/* roll buffer forwards */
		len -= XFS_LBSIZE(mp);
		dst += XFS_LBSIZE(mp);
		bno += mp->m_bsize;

		/* roll attribute data forwards */
		*valuelen -= byte_cnt;
		*src += byte_cnt;
		*offset += byte_cnt;
	}
326 327
}

328 329 330 331 332
/*
 * Read the value associated with an attribute from the out-of-line buffer
 * that we stored it in.
 */
int
333 334
xfs_attr_rmtval_get(
	struct xfs_da_args	*args)
335
{
336 337 338 339
	struct xfs_bmbt_irec	map[ATTR_RMTVALUE_MAPSIZE];
	struct xfs_mount	*mp = args->dp->i_mount;
	struct xfs_buf		*bp;
	xfs_dablk_t		lblkno = args->rmtblkno;
D
Dave Chinner 已提交
340
	char			*dst = args->value;
341 342 343
	int			valuelen = args->valuelen;
	int			nmap;
	int			error;
D
Dave Chinner 已提交
344
	int			blkcnt = args->rmtblkcnt;
345 346
	int			i;
	int			offset = 0;
347 348 349 350 351 352 353 354

	trace_xfs_attr_rmtval_get(args);

	ASSERT(!(args->flags & ATTR_KERNOVAL));

	while (valuelen > 0) {
		nmap = ATTR_RMTVALUE_MAPSIZE;
		error = xfs_bmapi_read(args->dp, (xfs_fileoff_t)lblkno,
355
				       blkcnt, map, &nmap,
356 357
				       XFS_BMAPI_ATTRFORK);
		if (error)
358
			return error;
359 360 361
		ASSERT(nmap >= 1);

		for (i = 0; (i < nmap) && (valuelen > 0); i++) {
D
Dave Chinner 已提交
362 363
			xfs_daddr_t	dblkno;
			int		dblkcnt;
364

365 366 367
			ASSERT((map[i].br_startblock != DELAYSTARTBLOCK) &&
			       (map[i].br_startblock != HOLESTARTBLOCK));
			dblkno = XFS_FSB_TO_DADDR(mp, map[i].br_startblock);
D
Dave Chinner 已提交
368
			dblkcnt = XFS_FSB_TO_BB(mp, map[i].br_blockcount);
369
			error = xfs_trans_read_buf(mp, NULL, mp->m_ddev_targp,
D
Dave Chinner 已提交
370
						   dblkno, dblkcnt, 0, &bp,
371
						   &xfs_attr3_rmt_buf_ops);
372
			if (error)
373 374
				return error;

D
Dave Chinner 已提交
375 376 377
			error = xfs_attr_rmtval_copyout(mp, bp, args->dp->i_ino,
							&offset, &valuelen,
							&dst);
378
			xfs_buf_relse(bp);
D
Dave Chinner 已提交
379 380
			if (error)
				return error;
381

D
Dave Chinner 已提交
382
			/* roll attribute extent map forwards */
383
			lblkno += map[i].br_blockcount;
D
Dave Chinner 已提交
384
			blkcnt -= map[i].br_blockcount;
385 386 387
		}
	}
	ASSERT(valuelen == 0);
388
	return 0;
389 390 391 392 393 394 395
}

/*
 * Write the value associated with an attribute into the out-of-line buffer
 * that we have defined for it.
 */
int
396 397
xfs_attr_rmtval_set(
	struct xfs_da_args	*args)
398
{
399 400 401 402 403
	struct xfs_inode	*dp = args->dp;
	struct xfs_mount	*mp = dp->i_mount;
	struct xfs_bmbt_irec	map;
	xfs_dablk_t		lblkno;
	xfs_fileoff_t		lfileoff = 0;
D
Dave Chinner 已提交
404
	char			*src = args->value;
405 406 407 408 409
	int			blkcnt;
	int			valuelen;
	int			nmap;
	int			error;
	int			offset = 0;
410 411 412 413 414

	trace_xfs_attr_rmtval_set(args);

	/*
	 * Find a "hole" in the attribute address space large enough for
415 416
	 * us to drop the new attribute's value into. Because CRC enable
	 * attributes have headers, we can't just do a straight byte to FSB
D
Dave Chinner 已提交
417
	 * conversion and have to take the header space into account.
418
	 */
419
	blkcnt = xfs_attr3_rmt_blocks(mp, args->valuelen);
420 421
	error = xfs_bmap_first_unused(args->trans, args->dp, blkcnt, &lfileoff,
						   XFS_ATTR_FORK);
422 423 424
	if (error)
		return error;

425 426 427 428 429 430 431
	args->rmtblkno = lblkno = (xfs_dablk_t)lfileoff;
	args->rmtblkcnt = blkcnt;

	/*
	 * Roll through the "value", allocating blocks on disk as required.
	 */
	while (blkcnt > 0) {
432 433
		int	committed;

434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482
		/*
		 * Allocate a single extent, up to the size of the value.
		 */
		xfs_bmap_init(args->flist, args->firstblock);
		nmap = 1;
		error = xfs_bmapi_write(args->trans, dp, (xfs_fileoff_t)lblkno,
				  blkcnt,
				  XFS_BMAPI_ATTRFORK | XFS_BMAPI_METADATA,
				  args->firstblock, args->total, &map, &nmap,
				  args->flist);
		if (!error) {
			error = xfs_bmap_finish(&args->trans, args->flist,
						&committed);
		}
		if (error) {
			ASSERT(committed);
			args->trans = NULL;
			xfs_bmap_cancel(args->flist);
			return(error);
		}

		/*
		 * bmap_finish() may have committed the last trans and started
		 * a new one.  We need the inode to be in all transactions.
		 */
		if (committed)
			xfs_trans_ijoin(args->trans, dp, 0);

		ASSERT(nmap == 1);
		ASSERT((map.br_startblock != DELAYSTARTBLOCK) &&
		       (map.br_startblock != HOLESTARTBLOCK));
		lblkno += map.br_blockcount;
		blkcnt -= map.br_blockcount;

		/*
		 * Start the next trans in the chain.
		 */
		error = xfs_trans_roll(&args->trans, dp);
		if (error)
			return (error);
	}

	/*
	 * Roll through the "value", copying the attribute value to the
	 * already-allocated blocks.  Blocks are written synchronously
	 * so that we can know they are all on disk before we turn off
	 * the INCOMPLETE flag.
	 */
	lblkno = args->rmtblkno;
483
	blkcnt = args->rmtblkcnt;
D
Dave Chinner 已提交
484
	valuelen = args->valuelen;
485
	while (valuelen > 0) {
D
Dave Chinner 已提交
486 487 488 489 490
		struct xfs_buf	*bp;
		xfs_daddr_t	dblkno;
		int		dblkcnt;

		ASSERT(blkcnt > 0);
491 492 493 494

		xfs_bmap_init(args->flist, args->firstblock);
		nmap = 1;
		error = xfs_bmapi_read(dp, (xfs_fileoff_t)lblkno,
495
				       blkcnt, &map, &nmap,
496 497 498 499 500 501 502 503
				       XFS_BMAPI_ATTRFORK);
		if (error)
			return(error);
		ASSERT(nmap == 1);
		ASSERT((map.br_startblock != DELAYSTARTBLOCK) &&
		       (map.br_startblock != HOLESTARTBLOCK));

		dblkno = XFS_FSB_TO_DADDR(mp, map.br_startblock),
504
		dblkcnt = XFS_FSB_TO_BB(mp, map.br_blockcount);
505

506
		bp = xfs_buf_get(mp->m_ddev_targp, dblkno, dblkcnt, 0);
507 508
		if (!bp)
			return ENOMEM;
509
		bp->b_ops = &xfs_attr3_rmt_buf_ops;
510

D
Dave Chinner 已提交
511 512
		xfs_attr_rmtval_copyin(mp, bp, args->dp->i_ino, &offset,
				       &valuelen, &src);
513 514 515 516 517

		error = xfs_bwrite(bp);	/* GROT: NOTE: synchronous write */
		xfs_buf_relse(bp);
		if (error)
			return error;
518

519

D
Dave Chinner 已提交
520
		/* roll attribute extent map forwards */
521
		lblkno += map.br_blockcount;
522
		blkcnt -= map.br_blockcount;
523 524
	}
	ASSERT(valuelen == 0);
525
	return 0;
526 527 528 529 530 531 532
}

/*
 * Remove the value associated with an attribute by deleting the
 * out-of-line buffer that it is stored on.
 */
int
D
Dave Chinner 已提交
533 534
xfs_attr_rmtval_remove(
	struct xfs_da_args	*args)
535
{
D
Dave Chinner 已提交
536 537 538 539 540
	struct xfs_mount	*mp = args->dp->i_mount;
	xfs_dablk_t		lblkno;
	int			blkcnt;
	int			error;
	int			done;
541 542 543 544

	trace_xfs_attr_rmtval_remove(args);

	/*
545 546 547 548 549 550
	 * Roll through the "value", invalidating the attribute value's blocks.
	 * Note that args->rmtblkcnt is the minimum number of data blocks we'll
	 * see for a CRC enabled remote attribute. Each extent will have a
	 * header, and so we may have more blocks than we realise here.  If we
	 * fail to map the blocks correctly, we'll have problems with the buffer
	 * lookups.
551 552
	 */
	lblkno = args->rmtblkno;
D
Dave Chinner 已提交
553 554 555 556 557 558 559
	blkcnt = args->rmtblkcnt;
	while (blkcnt > 0) {
		struct xfs_bmbt_irec	map;
		struct xfs_buf		*bp;
		xfs_daddr_t		dblkno;
		int			dblkcnt;
		int			nmap;
560

561 562 563 564 565
		/*
		 * Try to remember where we decided to put the value.
		 */
		nmap = 1;
		error = xfs_bmapi_read(args->dp, (xfs_fileoff_t)lblkno,
566
				       blkcnt, &map, &nmap, XFS_BMAPI_ATTRFORK);
567 568 569 570 571 572 573
		if (error)
			return(error);
		ASSERT(nmap == 1);
		ASSERT((map.br_startblock != DELAYSTARTBLOCK) &&
		       (map.br_startblock != HOLESTARTBLOCK));

		dblkno = XFS_FSB_TO_DADDR(mp, map.br_startblock),
574
		dblkcnt = XFS_FSB_TO_BB(mp, map.br_blockcount);
575 576 577 578

		/*
		 * If the "remote" value is in the cache, remove it.
		 */
579
		bp = xfs_incore(mp->m_ddev_targp, dblkno, dblkcnt, XBF_TRYLOCK);
580 581 582 583 584 585 586
		if (bp) {
			xfs_buf_stale(bp);
			xfs_buf_relse(bp);
			bp = NULL;
		}

		lblkno += map.br_blockcount;
587
		blkcnt -= map.br_blockcount;
588 589 590 591 592 593
	}

	/*
	 * Keep de-allocating extents until the remote-value region is gone.
	 */
	lblkno = args->rmtblkno;
D
Dave Chinner 已提交
594
	blkcnt = args->rmtblkcnt;
595 596
	done = 0;
	while (!done) {
D
Dave Chinner 已提交
597 598
		int committed;

599 600 601 602 603 604 605 606 607 608 609 610 611
		xfs_bmap_init(args->flist, args->firstblock);
		error = xfs_bunmapi(args->trans, args->dp, lblkno, blkcnt,
				    XFS_BMAPI_ATTRFORK | XFS_BMAPI_METADATA,
				    1, args->firstblock, args->flist,
				    &done);
		if (!error) {
			error = xfs_bmap_finish(&args->trans, args->flist,
						&committed);
		}
		if (error) {
			ASSERT(committed);
			args->trans = NULL;
			xfs_bmap_cancel(args->flist);
612
			return error;
613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631
		}

		/*
		 * bmap_finish() may have committed the last trans and started
		 * a new one.  We need the inode to be in all transactions.
		 */
		if (committed)
			xfs_trans_ijoin(args->trans, args->dp, 0);

		/*
		 * Close out trans and start the next one in the chain.
		 */
		error = xfs_trans_roll(&args->trans, args->dp);
		if (error)
			return (error);
	}
	return(0);
}