eth.c 15.2 KB
Newer Older
L
Linus Torvalds 已提交
1 2 3 4 5 6 7 8 9
/*
 * INET		An implementation of the TCP/IP protocol suite for the LINUX
 *		operating system.  INET is implemented using the  BSD Socket
 *		interface as the means of communication with the user level.
 *
 *		Ethernet-type device handling.
 *
 * Version:	@(#)eth.c	1.0.7	05/25/93
 *
10
 * Authors:	Ross Biro
L
Linus Torvalds 已提交
11 12 13 14
 *		Fred N. van Kempen, <waltje@uWalt.NL.Mugnet.ORG>
 *		Mark Evans, <evansmp@uhura.aston.ac.uk>
 *		Florian  La Roche, <rzsfl@rz.uni-sb.de>
 *		Alan Cox, <gw4pts@gw4pts.ampr.org>
15
 *
L
Linus Torvalds 已提交
16 17 18 19 20 21
 * Fixes:
 *		Mr Linux	: Arp problems
 *		Alan Cox	: Generic queue tidyup (very tiny here)
 *		Alan Cox	: eth_header ntohs should be htons
 *		Alan Cox	: eth_rebuild_header missing an htons and
 *				  minor other things.
22
 *		Tegge		: Arp bug fixes.
L
Linus Torvalds 已提交
23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49
 *		Florian		: Removed many unnecessary functions, code cleanup
 *				  and changes for new arp and skbuff.
 *		Alan Cox	: Redid header building to reflect new format.
 *		Alan Cox	: ARP only when compiled with CONFIG_INET
 *		Greg Page	: 802.2 and SNAP stuff.
 *		Alan Cox	: MAC layer pointers/new format.
 *		Paul Gortmaker	: eth_copy_and_sum shouldn't csum padding.
 *		Alan Cox	: Protect against forwarding explosions with
 *				  older network drivers and IFF_ALLMULTI.
 *	Christer Weinigel	: Better rebuild header message.
 *             Andrew Morton    : 26Feb01: kill ether_setup() - use netdev_boot_setup().
 *
 *		This program is free software; you can redistribute it and/or
 *		modify it under the terms of the GNU General Public License
 *		as published by the Free Software Foundation; either version
 *		2 of the License, or (at your option) any later version.
 */
#include <linux/module.h>
#include <linux/types.h>
#include <linux/kernel.h>
#include <linux/string.h>
#include <linux/mm.h>
#include <linux/socket.h>
#include <linux/in.h>
#include <linux/inet.h>
#include <linux/ip.h>
#include <linux/netdevice.h>
50
#include <linux/nvmem-consumer.h>
L
Linus Torvalds 已提交
51 52 53 54
#include <linux/etherdevice.h>
#include <linux/skbuff.h>
#include <linux/errno.h>
#include <linux/init.h>
55
#include <linux/if_ether.h>
56 57
#include <linux/of_net.h>
#include <linux/pci.h>
L
Linus Torvalds 已提交
58 59 60 61 62
#include <net/dst.h>
#include <net/arp.h>
#include <net/sock.h>
#include <net/ipv6.h>
#include <net/ip.h>
63
#include <net/dsa.h>
64
#include <net/flow_dissector.h>
65
#include <linux/uaccess.h>
66
#include <net/pkt_sched.h>
L
Linus Torvalds 已提交
67 68 69

__setup("ether=", netdev_boot_setup);

S
Stephen Hemminger 已提交
70 71 72 73 74 75 76 77
/**
 * eth_header - create the Ethernet header
 * @skb:	buffer to alter
 * @dev:	source device
 * @type:	Ethernet type field
 * @daddr: destination address (NULL leave destination address)
 * @saddr: source address (NULL use device source address)
 * @len:   packet length (<= skb->len)
L
Linus Torvalds 已提交
78
 *
S
Stephen Hemminger 已提交
79
 *
O
Octavian Purdila 已提交
80 81
 * Set the protocol type. For a packet of type ETH_P_802_3/2 we put the length
 * in here instead.
L
Linus Torvalds 已提交
82
 */
83 84
int eth_header(struct sk_buff *skb, struct net_device *dev,
	       unsigned short type,
85
	       const void *daddr, const void *saddr, unsigned int len)
L
Linus Torvalds 已提交
86
{
87
	struct ethhdr *eth = skb_push(skb, ETH_HLEN);
L
Linus Torvalds 已提交
88

O
Octavian Purdila 已提交
89
	if (type != ETH_P_802_3 && type != ETH_P_802_2)
L
Linus Torvalds 已提交
90 91 92 93 94
		eth->h_proto = htons(type);
	else
		eth->h_proto = htons(len);

	/*
95
	 *      Set the source hardware address.
L
Linus Torvalds 已提交
96
	 */
97 98

	if (!saddr)
99
		saddr = dev->dev_addr;
100
	memcpy(eth->h_source, saddr, ETH_ALEN);
L
Linus Torvalds 已提交
101

102
	if (daddr) {
103
		memcpy(eth->h_dest, daddr, ETH_ALEN);
104 105
		return ETH_HLEN;
	}
106

L
Linus Torvalds 已提交
107
	/*
108
	 *      Anyway, the loopback-device should never use this function...
L
Linus Torvalds 已提交
109 110
	 */

111
	if (dev->flags & (IFF_LOOPBACK | IFF_NOARP)) {
112
		eth_zero_addr(eth->h_dest);
L
Linus Torvalds 已提交
113 114
		return ETH_HLEN;
	}
115

L
Linus Torvalds 已提交
116 117
	return -ETH_HLEN;
}
118
EXPORT_SYMBOL(eth_header);
L
Linus Torvalds 已提交
119

120
/**
121
 * eth_get_headlen - determine the length of header for an ethernet frame
122 123 124 125 126 127 128 129
 * @data: pointer to start of frame
 * @len: total length of frame
 *
 * Make a best effort attempt to pull the length for all of the headers for
 * a given frame in a linear buffer.
 */
u32 eth_get_headlen(void *data, unsigned int len)
{
130
	const unsigned int flags = FLOW_DISSECTOR_F_PARSE_1ST_FRAG;
131
	const struct ethhdr *eth = (const struct ethhdr *)data;
132
	struct flow_keys_basic keys;
133 134

	/* this should never happen, but better safe than sorry */
135
	if (unlikely(len < sizeof(*eth)))
136 137 138
		return len;

	/* parse any remaining L2/L3 headers, check for L4 */
139 140
	if (!skb_flow_dissect_flow_keys_basic(NULL, &keys, data, eth->h_proto,
					      sizeof(*eth), len, flags))
141
		return max_t(u32, keys.control.thoff, sizeof(*eth));
142 143 144 145 146 147

	/* parse for any L4 headers */
	return min_t(u32, __skb_get_poff(NULL, data, &keys, len), len);
}
EXPORT_SYMBOL(eth_get_headlen);

S
Stephen Hemminger 已提交
148 149 150 151 152 153 154 155
/**
 * eth_type_trans - determine the packet's protocol ID.
 * @skb: received socket data
 * @dev: receiving network device
 *
 * The rule here is that we
 * assume 802.3 if the type field is short enough to be a length.
 * This is normal practice and works for any 'now in use' protocol.
L
Linus Torvalds 已提交
156
 */
A
Alexey Dobriyan 已提交
157
__be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev)
L
Linus Torvalds 已提交
158
{
159 160 161
	unsigned short _service_access_point;
	const unsigned short *sap;
	const struct ethhdr *eth;
162

163
	skb->dev = dev;
164
	skb_reset_mac_header(skb);
165 166

	eth = (struct ethhdr *)skb->data;
167
	skb_pull_inline(skb, ETH_HLEN);
168

169 170 171 172 173 174 175 176 177 178
	if (unlikely(!ether_addr_equal_64bits(eth->h_dest,
					      dev->dev_addr))) {
		if (unlikely(is_multicast_ether_addr_64bits(eth->h_dest))) {
			if (ether_addr_equal_64bits(eth->h_dest, dev->broadcast))
				skb->pkt_type = PACKET_BROADCAST;
			else
				skb->pkt_type = PACKET_MULTICAST;
		} else {
			skb->pkt_type = PACKET_OTHERHOST;
		}
L
Linus Torvalds 已提交
179
	}
180

181 182 183 184 185 186
	/*
	 * Some variants of DSA tagging don't have an ethertype field
	 * at all, so we check here whether one of those tagging
	 * variants has been configured on the receiving interface,
	 * and if so, set skb->protocol without looking at the packet.
	 */
187 188
	if (unlikely(netdev_uses_dsa(dev)))
		return htons(ETH_P_XDSA);
189

190
	if (likely(eth_proto_is_802_3(eth->h_proto)))
L
Linus Torvalds 已提交
191
		return eth->h_proto;
192

L
Linus Torvalds 已提交
193
	/*
194 195 196 197
	 *      This is a magic hack to spot IPX packets. Older Novell breaks
	 *      the protocol design and runs IPX over 802.3 without an 802.2 LLC
	 *      layer. We look for FFFF which isn't a used 802.2 SSAP/DSAP. This
	 *      won't work for fault tolerant netware but does for the rest.
L
Linus Torvalds 已提交
198
	 */
199 200
	sap = skb_header_pointer(skb, 0, sizeof(*sap), &_service_access_point);
	if (sap && *sap == 0xFFFF)
L
Linus Torvalds 已提交
201
		return htons(ETH_P_802_3);
202

L
Linus Torvalds 已提交
203
	/*
204
	 *      Real 802.2 LLC
L
Linus Torvalds 已提交
205 206 207
	 */
	return htons(ETH_P_802_2);
}
208
EXPORT_SYMBOL(eth_type_trans);
L
Linus Torvalds 已提交
209

S
Stephen Hemminger 已提交
210 211 212 213 214
/**
 * eth_header_parse - extract hardware address from packet
 * @skb: packet to extract header from
 * @haddr: destination buffer
 */
215
int eth_header_parse(const struct sk_buff *skb, unsigned char *haddr)
L
Linus Torvalds 已提交
216
{
S
Stephen Hemminger 已提交
217
	const struct ethhdr *eth = eth_hdr(skb);
L
Linus Torvalds 已提交
218 219 220
	memcpy(haddr, eth->h_source, ETH_ALEN);
	return ETH_ALEN;
}
221
EXPORT_SYMBOL(eth_header_parse);
L
Linus Torvalds 已提交
222

S
Stephen Hemminger 已提交
223 224 225 226
/**
 * eth_header_cache - fill cache entry from neighbour
 * @neigh: source neighbour
 * @hh: destination cache entry
R
Randy Dunlap 已提交
227
 * @type: Ethernet type field
228
 *
S
Stephen Hemminger 已提交
229 230
 * Create an Ethernet header template from the neighbour.
 */
231
int eth_header_cache(const struct neighbour *neigh, struct hh_cache *hh, __be16 type)
L
Linus Torvalds 已提交
232 233
{
	struct ethhdr *eth;
234
	const struct net_device *dev = neigh->dev;
L
Linus Torvalds 已提交
235

236 237
	eth = (struct ethhdr *)
	    (((u8 *) hh->hh_data) + (HH_DATA_OFF(sizeof(*eth))));
L
Linus Torvalds 已提交
238

239
	if (type == htons(ETH_P_802_3))
L
Linus Torvalds 已提交
240 241 242
		return -1;

	eth->h_proto = type;
243 244
	memcpy(eth->h_source, dev->dev_addr, ETH_ALEN);
	memcpy(eth->h_dest, neigh->ha, ETH_ALEN);
L
Linus Torvalds 已提交
245 246 247
	hh->hh_len = ETH_HLEN;
	return 0;
}
248
EXPORT_SYMBOL(eth_header_cache);
L
Linus Torvalds 已提交
249

S
Stephen Hemminger 已提交
250 251 252 253 254 255
/**
 * eth_header_cache_update - update cache entry
 * @hh: destination cache entry
 * @dev: network device
 * @haddr: new hardware address
 *
L
Linus Torvalds 已提交
256 257
 * Called by Address Resolution module to notify changes in address.
 */
258 259 260
void eth_header_cache_update(struct hh_cache *hh,
			     const struct net_device *dev,
			     const unsigned char *haddr)
L
Linus Torvalds 已提交
261
{
262
	memcpy(((u8 *) hh->hh_data) + HH_DATA_OFF(sizeof(struct ethhdr)),
263
	       haddr, ETH_ALEN);
L
Linus Torvalds 已提交
264
}
265
EXPORT_SYMBOL(eth_header_cache_update);
L
Linus Torvalds 已提交
266

267 268 269 270 271 272 273 274 275 276 277 278
/**
 * eth_header_parser_protocol - extract protocol from L2 header
 * @skb: packet to extract protocol from
 */
__be16 eth_header_parse_protocol(const struct sk_buff *skb)
{
	const struct ethhdr *eth = eth_hdr(skb);

	return eth->h_proto;
}
EXPORT_SYMBOL(eth_header_parse_protocol);

279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308
/**
 * eth_prepare_mac_addr_change - prepare for mac change
 * @dev: network device
 * @p: socket address
 */
int eth_prepare_mac_addr_change(struct net_device *dev, void *p)
{
	struct sockaddr *addr = p;

	if (!(dev->priv_flags & IFF_LIVE_ADDR_CHANGE) && netif_running(dev))
		return -EBUSY;
	if (!is_valid_ether_addr(addr->sa_data))
		return -EADDRNOTAVAIL;
	return 0;
}
EXPORT_SYMBOL(eth_prepare_mac_addr_change);

/**
 * eth_commit_mac_addr_change - commit mac change
 * @dev: network device
 * @p: socket address
 */
void eth_commit_mac_addr_change(struct net_device *dev, void *p)
{
	struct sockaddr *addr = p;

	memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
}
EXPORT_SYMBOL(eth_commit_mac_addr_change);

S
Stephen Hemminger 已提交
309 310 311 312
/**
 * eth_mac_addr - set new Ethernet hardware address
 * @dev: network device
 * @p: socket address
313
 *
S
Stephen Hemminger 已提交
314 315 316 317 318
 * Change hardware address of device.
 *
 * This doesn't change hardware matching, so needs to be overridden
 * for most real devices.
 */
319
int eth_mac_addr(struct net_device *dev, void *p)
L
Linus Torvalds 已提交
320
{
321
	int ret;
322

323 324 325 326
	ret = eth_prepare_mac_addr_change(dev, p);
	if (ret < 0)
		return ret;
	eth_commit_mac_addr_change(dev, p);
L
Linus Torvalds 已提交
327 328
	return 0;
}
329
EXPORT_SYMBOL(eth_mac_addr);
L
Linus Torvalds 已提交
330

S
Stephen Hemminger 已提交
331 332 333 334 335 336 337 338
/**
 * eth_change_mtu - set new MTU size
 * @dev: network device
 * @new_mtu: new Maximum Transfer Unit
 *
 * Allow changing MTU size. Needs to be overridden for devices
 * supporting jumbo frames.
 */
339
int eth_change_mtu(struct net_device *dev, int new_mtu)
L
Linus Torvalds 已提交
340
{
341
	netdev_warn(dev, "%s is deprecated\n", __func__);
L
Linus Torvalds 已提交
342 343 344
	dev->mtu = new_mtu;
	return 0;
}
345
EXPORT_SYMBOL(eth_change_mtu);
L
Linus Torvalds 已提交
346

347
int eth_validate_addr(struct net_device *dev)
348 349
{
	if (!is_valid_ether_addr(dev->dev_addr))
350
		return -EADDRNOTAVAIL;
351 352 353

	return 0;
}
354
EXPORT_SYMBOL(eth_validate_addr);
355

356 357 358 359 360
const struct header_ops eth_header_ops ____cacheline_aligned = {
	.create		= eth_header,
	.parse		= eth_header_parse,
	.cache		= eth_header_cache,
	.cache_update	= eth_header_cache_update,
361
	.parse_protocol	= eth_header_parse_protocol,
362 363
};

S
Stephen Hemminger 已提交
364 365 366
/**
 * ether_setup - setup Ethernet network device
 * @dev: network device
367
 *
S
Stephen Hemminger 已提交
368
 * Fill in the fields of the device structure with Ethernet-generic values.
L
Linus Torvalds 已提交
369 370 371
 */
void ether_setup(struct net_device *dev)
{
372
	dev->header_ops		= &eth_header_ops;
L
Linus Torvalds 已提交
373 374
	dev->type		= ARPHRD_ETHER;
	dev->hard_header_len 	= ETH_HLEN;
375
	dev->min_header_len	= ETH_HLEN;
376
	dev->mtu		= ETH_DATA_LEN;
377 378
	dev->min_mtu		= ETH_MIN_MTU;
	dev->max_mtu		= ETH_DATA_LEN;
L
Linus Torvalds 已提交
379
	dev->addr_len		= ETH_ALEN;
380
	dev->tx_queue_len	= DEFAULT_TX_QUEUE_LEN;
L
Linus Torvalds 已提交
381
	dev->flags		= IFF_BROADCAST|IFF_MULTICAST;
382
	dev->priv_flags		|= IFF_TX_SKB_SHARING;
383

384
	eth_broadcast_addr(dev->broadcast);
L
Linus Torvalds 已提交
385 386 387 388 389

}
EXPORT_SYMBOL(ether_setup);

/**
T
Tom Herbert 已提交
390
 * alloc_etherdev_mqs - Allocates and sets up an Ethernet device
L
Linus Torvalds 已提交
391
 * @sizeof_priv: Size of additional driver-private structure to be allocated
S
Stephen Hemminger 已提交
392
 *	for this Ethernet device
T
Tom Herbert 已提交
393
 * @txqs: The number of TX queues this device has.
R
Randy Dunlap 已提交
394
 * @rxqs: The number of RX queues this device has.
L
Linus Torvalds 已提交
395
 *
S
Stephen Hemminger 已提交
396
 * Fill in the fields of the device structure with Ethernet-generic
L
Linus Torvalds 已提交
397 398 399
 * values. Basically does everything except registering the device.
 *
 * Constructs a new net device, complete with a private data area of
S
Stephen Hemminger 已提交
400
 * size (sizeof_priv).  A 32-byte (not bit) alignment is enforced for
L
Linus Torvalds 已提交
401 402 403
 * this private data area.
 */

T
Tom Herbert 已提交
404 405
struct net_device *alloc_etherdev_mqs(int sizeof_priv, unsigned int txqs,
				      unsigned int rxqs)
L
Linus Torvalds 已提交
406
{
407 408
	return alloc_netdev_mqs(sizeof_priv, "eth%d", NET_NAME_UNKNOWN,
				ether_setup, txqs, rxqs);
L
Linus Torvalds 已提交
409
}
T
Tom Herbert 已提交
410
EXPORT_SYMBOL(alloc_etherdev_mqs);
411

412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439
static void devm_free_netdev(struct device *dev, void *res)
{
	free_netdev(*(struct net_device **)res);
}

struct net_device *devm_alloc_etherdev_mqs(struct device *dev, int sizeof_priv,
					   unsigned int txqs, unsigned int rxqs)
{
	struct net_device **dr;
	struct net_device *netdev;

	dr = devres_alloc(devm_free_netdev, sizeof(*dr), GFP_KERNEL);
	if (!dr)
		return NULL;

	netdev = alloc_etherdev_mqs(sizeof_priv, txqs, rxqs);
	if (!netdev) {
		devres_free(dr);
		return NULL;
	}

	*dr = netdev;
	devres_add(dev, dr);

	return netdev;
}
EXPORT_SYMBOL(devm_alloc_etherdev_mqs);

440 441
ssize_t sysfs_format_mac(char *buf, const unsigned char *addr, int len)
{
442
	return scnprintf(buf, PAGE_SIZE, "%*phC\n", len, addr);
443 444
}
EXPORT_SYMBOL(sysfs_format_mac);
445

446
struct sk_buff *eth_gro_receive(struct list_head *head, struct sk_buff *skb)
447 448
{
	const struct packet_offload *ptype;
449 450 451 452
	unsigned int hlen, off_eth;
	struct sk_buff *pp = NULL;
	struct ethhdr *eh, *eh2;
	struct sk_buff *p;
453 454 455 456 457 458 459 460 461 462 463 464 465 466
	__be16 type;
	int flush = 1;

	off_eth = skb_gro_offset(skb);
	hlen = off_eth + sizeof(*eh);
	eh = skb_gro_header_fast(skb, off_eth);
	if (skb_gro_header_hard(skb, hlen)) {
		eh = skb_gro_header_slow(skb, hlen, off_eth);
		if (unlikely(!eh))
			goto out;
	}

	flush = 0;

467
	list_for_each_entry(p, head, list) {
468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488
		if (!NAPI_GRO_CB(p)->same_flow)
			continue;

		eh2 = (struct ethhdr *)(p->data + off_eth);
		if (compare_ether_header(eh, eh2)) {
			NAPI_GRO_CB(p)->same_flow = 0;
			continue;
		}
	}

	type = eh->h_proto;

	rcu_read_lock();
	ptype = gro_find_receive_by_type(type);
	if (ptype == NULL) {
		flush = 1;
		goto out_unlock;
	}

	skb_gro_pull(skb, sizeof(*eh));
	skb_gro_postpull_rcsum(skb, eh, sizeof(*eh));
S
Sabrina Dubroca 已提交
489
	pp = call_gro_receive(ptype->callbacks.gro_receive, head, skb);
490 491 492 493

out_unlock:
	rcu_read_unlock();
out:
494
	skb_gro_flush_final(skb, pp, flush);
495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522

	return pp;
}
EXPORT_SYMBOL(eth_gro_receive);

int eth_gro_complete(struct sk_buff *skb, int nhoff)
{
	struct ethhdr *eh = (struct ethhdr *)(skb->data + nhoff);
	__be16 type = eh->h_proto;
	struct packet_offload *ptype;
	int err = -ENOSYS;

	if (skb->encapsulation)
		skb_set_inner_mac_header(skb, nhoff);

	rcu_read_lock();
	ptype = gro_find_complete_by_type(type);
	if (ptype != NULL)
		err = ptype->callbacks.gro_complete(skb, nhoff +
						    sizeof(struct ethhdr));

	rcu_read_unlock();
	return err;
}
EXPORT_SYMBOL(eth_gro_complete);

static struct packet_offload eth_packet_offload __read_mostly = {
	.type = cpu_to_be16(ETH_P_TEB),
523
	.priority = 10,
524 525 526 527 528 529 530 531 532 533 534 535 536 537
	.callbacks = {
		.gro_receive = eth_gro_receive,
		.gro_complete = eth_gro_complete,
	},
};

static int __init eth_offload_init(void)
{
	dev_add_offload(&eth_packet_offload);

	return 0;
}

fs_initcall(eth_offload_init);
538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566

unsigned char * __weak arch_get_platform_mac_address(void)
{
	return NULL;
}

int eth_platform_get_mac_address(struct device *dev, u8 *mac_addr)
{
	const unsigned char *addr;
	struct device_node *dp;

	if (dev_is_pci(dev))
		dp = pci_device_to_OF_node(to_pci_dev(dev));
	else
		dp = dev->of_node;

	addr = NULL;
	if (dp)
		addr = of_get_mac_address(dp);
	if (!addr)
		addr = arch_get_platform_mac_address();

	if (!addr)
		return -ENODEV;

	ether_addr_copy(mac_addr, addr);
	return 0;
}
EXPORT_SYMBOL(eth_platform_get_mac_address);
567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603

/**
 * Obtain the MAC address from an nvmem cell named 'mac-address' associated
 * with given device.
 *
 * @dev:	Device with which the mac-address cell is associated.
 * @addrbuf:	Buffer to which the MAC address will be copied on success.
 *
 * Returns 0 on success or a negative error number on failure.
 */
int nvmem_get_mac_address(struct device *dev, void *addrbuf)
{
	struct nvmem_cell *cell;
	const void *mac;
	size_t len;

	cell = nvmem_cell_get(dev, "mac-address");
	if (IS_ERR(cell))
		return PTR_ERR(cell);

	mac = nvmem_cell_read(cell, &len);
	nvmem_cell_put(cell);

	if (IS_ERR(mac))
		return PTR_ERR(mac);

	if (len != ETH_ALEN || !is_valid_ether_addr(mac)) {
		kfree(mac);
		return -EINVAL;
	}

	ether_addr_copy(addrbuf, mac);
	kfree(mac);

	return 0;
}
EXPORT_SYMBOL(nvmem_get_mac_address);