sysfs.c 15.6 KB
Newer Older
1
// SPDX-License-Identifier: GPL-2.0
2 3 4 5 6 7 8 9 10 11 12 13
/*
 *  linux/fs/ext4/sysfs.c
 *
 * Copyright (C) 1992, 1993, 1994, 1995
 * Remy Card (card@masi.ibp.fr)
 * Theodore Ts'o (tytso@mit.edu)
 *
 */

#include <linux/time.h>
#include <linux/fs.h>
#include <linux/seq_file.h>
14
#include <linux/slab.h>
15
#include <linux/proc_fs.h>
16
#include <linux/part_stat.h>
17 18 19 20

#include "ext4.h"
#include "ext4_jbd2.h"

21 22 23 24 25 26 27 28
typedef enum {
	attr_noop,
	attr_delayed_allocation_blocks,
	attr_session_write_kbytes,
	attr_lifetime_write_kbytes,
	attr_reserved_clusters,
	attr_inode_readahead,
	attr_trigger_test_error,
29 30
	attr_first_error_time,
	attr_last_error_time,
31 32
	attr_feature,
	attr_pointer_ui,
33
	attr_pointer_ul,
34 35 36
	attr_pointer_u64,
	attr_pointer_u8,
	attr_pointer_string,
37
	attr_pointer_atomic,
38
	attr_journal_task,
39 40 41 42 43 44 45 46
} attr_id_t;

typedef enum {
	ptr_explicit,
	ptr_ext4_sb_info_offset,
	ptr_ext4_super_block_offset,
} attr_ptr_t;

47
static const char proc_dirname[] = "fs/ext4";
48 49
static struct proc_dir_entry *ext4_proc_root;

50 51
struct ext4_attr {
	struct attribute attr;
52 53
	short attr_id;
	short attr_ptr;
54
	unsigned short attr_size;
55 56
	union {
		int offset;
57
		void *explicit_ptr;
58 59 60
	} u;
};

61
static ssize_t session_write_kbytes_show(struct ext4_sb_info *sbi, char *buf)
62 63 64 65 66 67
{
	struct super_block *sb = sbi->s_buddy_cache->i_sb;

	if (!sb->s_bdev->bd_part)
		return snprintf(buf, PAGE_SIZE, "0\n");
	return snprintf(buf, PAGE_SIZE, "%lu\n",
68 69
			(part_stat_read(sb->s_bdev->bd_part,
					sectors[STAT_WRITE]) -
70 71 72
			 sbi->s_sectors_written_start) >> 1);
}

73
static ssize_t lifetime_write_kbytes_show(struct ext4_sb_info *sbi, char *buf)
74 75 76 77 78 79 80
{
	struct super_block *sb = sbi->s_buddy_cache->i_sb;

	if (!sb->s_bdev->bd_part)
		return snprintf(buf, PAGE_SIZE, "0\n");
	return snprintf(buf, PAGE_SIZE, "%llu\n",
			(unsigned long long)(sbi->s_kbytes_written +
81 82
			((part_stat_read(sb->s_bdev->bd_part,
					 sectors[STAT_WRITE]) -
83 84 85
			  EXT4_SB(sb)->s_sectors_written_start) >> 1)));
}

86
static ssize_t inode_readahead_blks_store(struct ext4_sb_info *sbi,
87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102
					  const char *buf, size_t count)
{
	unsigned long t;
	int ret;

	ret = kstrtoul(skip_spaces(buf), 0, &t);
	if (ret)
		return ret;

	if (t && (!is_power_of_2(t) || t > 0x40000000))
		return -EINVAL;

	sbi->s_inode_readahead_blks = t;
	return count;
}

103
static ssize_t reserved_clusters_store(struct ext4_sb_info *sbi,
104 105 106 107 108
				   const char *buf, size_t count)
{
	unsigned long long val;
	ext4_fsblk_t clusters = (ext4_blocks_count(sbi->s_es) >>
				 sbi->s_cluster_bits);
109
	int ret;
110

111
	ret = kstrtoull(skip_spaces(buf), 0, &val);
112
	if (ret || val >= clusters)
113 114 115 116 117 118
		return -EINVAL;

	atomic64_set(&sbi->s_resv_clusters, val);
	return count;
}

119
static ssize_t trigger_test_error(struct ext4_sb_info *sbi,
120 121 122 123 124 125 126 127 128 129 130 131 132 133 134
				  const char *buf, size_t count)
{
	int len = count;

	if (!capable(CAP_SYS_ADMIN))
		return -EPERM;

	if (len && buf[len-1] == '\n')
		len--;

	if (len)
		ext4_error(sbi->s_sb, "%.*s", len, buf);
	return count;
}

135 136 137 138 139 140 141 142
static ssize_t journal_task_show(struct ext4_sb_info *sbi, char *buf)
{
	if (!sbi->s_journal)
		return snprintf(buf, PAGE_SIZE, "<none>\n");
	return snprintf(buf, PAGE_SIZE, "%d\n",
			task_pid_vnr(sbi->s_journal->j_task));
}

143 144 145 146
#define EXT4_ATTR(_name,_mode,_id)					\
static struct ext4_attr ext4_attr_##_name = {				\
	.attr = {.name = __stringify(_name), .mode = _mode },		\
	.attr_id = attr_##_id,						\
147 148
}

149 150 151 152 153
#define EXT4_ATTR_FUNC(_name,_mode)  EXT4_ATTR(_name,_mode,_name)

#define EXT4_ATTR_FEATURE(_name)   EXT4_ATTR(_name, 0444, feature)

#define EXT4_ATTR_OFFSET(_name,_mode,_id,_struct,_elname)	\
154 155
static struct ext4_attr ext4_attr_##_name = {			\
	.attr = {.name = __stringify(_name), .mode = _mode },	\
156 157
	.attr_id = attr_##_id,					\
	.attr_ptr = ptr_##_struct##_offset,			\
158
	.u = {							\
159
		.offset = offsetof(struct _struct, _elname),\
160 161 162
	},							\
}

163 164 165 166 167 168 169 170 171 172 173
#define EXT4_ATTR_STRING(_name,_mode,_size,_struct,_elname)	\
static struct ext4_attr ext4_attr_##_name = {			\
	.attr = {.name = __stringify(_name), .mode = _mode },	\
	.attr_id = attr_pointer_string,				\
	.attr_size = _size,					\
	.attr_ptr = ptr_##_struct##_offset,			\
	.u = {							\
		.offset = offsetof(struct _struct, _elname),\
	},							\
}

174 175
#define EXT4_RO_ATTR_ES_UI(_name,_elname)				\
	EXT4_ATTR_OFFSET(_name, 0444, pointer_ui, ext4_super_block, _elname)
176

177 178 179 180 181 182 183 184 185
#define EXT4_RO_ATTR_ES_U8(_name,_elname)				\
	EXT4_ATTR_OFFSET(_name, 0444, pointer_u8, ext4_super_block, _elname)

#define EXT4_RO_ATTR_ES_U64(_name,_elname)				\
	EXT4_ATTR_OFFSET(_name, 0444, pointer_u64, ext4_super_block, _elname)

#define EXT4_RO_ATTR_ES_STRING(_name,_elname,_size)			\
	EXT4_ATTR_STRING(_name, 0444, _size, ext4_super_block, _elname)

186 187
#define EXT4_RW_ATTR_SBI_UI(_name,_elname)	\
	EXT4_ATTR_OFFSET(_name, 0644, pointer_ui, ext4_sb_info, _elname)
188

189 190 191
#define EXT4_RW_ATTR_SBI_UL(_name,_elname)	\
	EXT4_ATTR_OFFSET(_name, 0644, pointer_ul, ext4_sb_info, _elname)

192 193 194
#define EXT4_RO_ATTR_SBI_ATOMIC(_name,_elname)	\
	EXT4_ATTR_OFFSET(_name, 0444, pointer_atomic, ext4_sb_info, _elname)

195
#define EXT4_ATTR_PTR(_name,_mode,_id,_ptr) \
196
static struct ext4_attr ext4_attr_##_name = {			\
197 198 199
	.attr = {.name = __stringify(_name), .mode = _mode },	\
	.attr_id = attr_##_id,					\
	.attr_ptr = ptr_explicit,				\
200
	.u = {							\
201
		.explicit_ptr = _ptr,				\
202 203 204
	},							\
}

205 206 207 208 209 210 211 212 213
#define ATTR_LIST(name) &ext4_attr_##name.attr

EXT4_ATTR_FUNC(delayed_allocation_blocks, 0444);
EXT4_ATTR_FUNC(session_write_kbytes, 0444);
EXT4_ATTR_FUNC(lifetime_write_kbytes, 0444);
EXT4_ATTR_FUNC(reserved_clusters, 0644);

EXT4_ATTR_OFFSET(inode_readahead_blks, 0644, inode_readahead,
		 ext4_sb_info, s_inode_readahead_blks);
214 215 216 217 218 219 220 221
EXT4_RW_ATTR_SBI_UI(inode_goal, s_inode_goal);
EXT4_RW_ATTR_SBI_UI(mb_stats, s_mb_stats);
EXT4_RW_ATTR_SBI_UI(mb_max_to_scan, s_mb_max_to_scan);
EXT4_RW_ATTR_SBI_UI(mb_min_to_scan, s_mb_min_to_scan);
EXT4_RW_ATTR_SBI_UI(mb_order2_req, s_mb_order2_reqs);
EXT4_RW_ATTR_SBI_UI(mb_stream_req, s_mb_stream_request);
EXT4_RW_ATTR_SBI_UI(mb_group_prealloc, s_mb_group_prealloc);
EXT4_RW_ATTR_SBI_UI(extent_max_zeroout_kb, s_extent_max_zeroout_kb);
222
EXT4_ATTR(trigger_fs_error, 0200, trigger_test_error);
223 224 225 226 227 228
EXT4_RW_ATTR_SBI_UI(err_ratelimit_interval_ms, s_err_ratelimit_state.interval);
EXT4_RW_ATTR_SBI_UI(err_ratelimit_burst, s_err_ratelimit_state.burst);
EXT4_RW_ATTR_SBI_UI(warning_ratelimit_interval_ms, s_warning_ratelimit_state.interval);
EXT4_RW_ATTR_SBI_UI(warning_ratelimit_burst, s_warning_ratelimit_state.burst);
EXT4_RW_ATTR_SBI_UI(msg_ratelimit_interval_ms, s_msg_ratelimit_state.interval);
EXT4_RW_ATTR_SBI_UI(msg_ratelimit_burst, s_msg_ratelimit_state.burst);
229 230 231
#ifdef CONFIG_EXT4_DEBUG
EXT4_RW_ATTR_SBI_UL(simulate_fail, s_simulate_fail);
#endif
232 233
EXT4_RO_ATTR_SBI_ATOMIC(warning_count, s_warning_count);
EXT4_RO_ATTR_SBI_ATOMIC(msg_count, s_msg_count);
234
EXT4_RO_ATTR_ES_UI(errors_count, s_error_count);
235 236 237 238 239 240 241 242 243 244
EXT4_RO_ATTR_ES_U8(first_error_errcode, s_first_error_errcode);
EXT4_RO_ATTR_ES_U8(last_error_errcode, s_last_error_errcode);
EXT4_RO_ATTR_ES_UI(first_error_ino, s_first_error_ino);
EXT4_RO_ATTR_ES_UI(last_error_ino, s_last_error_ino);
EXT4_RO_ATTR_ES_U64(first_error_block, s_first_error_block);
EXT4_RO_ATTR_ES_U64(last_error_block, s_last_error_block);
EXT4_RO_ATTR_ES_UI(first_error_line, s_first_error_line);
EXT4_RO_ATTR_ES_UI(last_error_line, s_last_error_line);
EXT4_RO_ATTR_ES_STRING(first_error_func, s_first_error_func, 32);
EXT4_RO_ATTR_ES_STRING(last_error_func, s_last_error_func, 32);
245 246
EXT4_ATTR(first_error_time, 0444, first_error_time);
EXT4_ATTR(last_error_time, 0444, last_error_time);
247
EXT4_ATTR(journal_task, 0444, journal_task);
248 249
EXT4_RW_ATTR_SBI_UI(mb_prefetch, s_mb_prefetch);
EXT4_RW_ATTR_SBI_UI(mb_prefetch_limit, s_mb_prefetch_limit);
250

251 252 253
static unsigned int old_bump_val = 128;
EXT4_ATTR_PTR(max_writeback_mb_bump, 0444, pointer_ui, &old_bump_val);

254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276
static struct attribute *ext4_attrs[] = {
	ATTR_LIST(delayed_allocation_blocks),
	ATTR_LIST(session_write_kbytes),
	ATTR_LIST(lifetime_write_kbytes),
	ATTR_LIST(reserved_clusters),
	ATTR_LIST(inode_readahead_blks),
	ATTR_LIST(inode_goal),
	ATTR_LIST(mb_stats),
	ATTR_LIST(mb_max_to_scan),
	ATTR_LIST(mb_min_to_scan),
	ATTR_LIST(mb_order2_req),
	ATTR_LIST(mb_stream_req),
	ATTR_LIST(mb_group_prealloc),
	ATTR_LIST(max_writeback_mb_bump),
	ATTR_LIST(extent_max_zeroout_kb),
	ATTR_LIST(trigger_fs_error),
	ATTR_LIST(err_ratelimit_interval_ms),
	ATTR_LIST(err_ratelimit_burst),
	ATTR_LIST(warning_ratelimit_interval_ms),
	ATTR_LIST(warning_ratelimit_burst),
	ATTR_LIST(msg_ratelimit_interval_ms),
	ATTR_LIST(msg_ratelimit_burst),
	ATTR_LIST(errors_count),
277 278
	ATTR_LIST(warning_count),
	ATTR_LIST(msg_count),
279 280 281 282 283 284 285 286 287 288
	ATTR_LIST(first_error_ino),
	ATTR_LIST(last_error_ino),
	ATTR_LIST(first_error_block),
	ATTR_LIST(last_error_block),
	ATTR_LIST(first_error_line),
	ATTR_LIST(last_error_line),
	ATTR_LIST(first_error_func),
	ATTR_LIST(last_error_func),
	ATTR_LIST(first_error_errcode),
	ATTR_LIST(last_error_errcode),
289 290
	ATTR_LIST(first_error_time),
	ATTR_LIST(last_error_time),
291
	ATTR_LIST(journal_task),
292 293 294
#ifdef CONFIG_EXT4_DEBUG
	ATTR_LIST(simulate_fail),
#endif
295 296
	ATTR_LIST(mb_prefetch),
	ATTR_LIST(mb_prefetch_limit),
297 298
	NULL,
};
299
ATTRIBUTE_GROUPS(ext4);
300 301

/* Features this copy of ext4 supports */
302 303 304
EXT4_ATTR_FEATURE(lazy_itable_init);
EXT4_ATTR_FEATURE(batched_discard);
EXT4_ATTR_FEATURE(meta_bg_resize);
305
#ifdef CONFIG_FS_ENCRYPTION
306
EXT4_ATTR_FEATURE(encryption);
307
EXT4_ATTR_FEATURE(test_dummy_encryption_v2);
308
#endif
309 310 311
#ifdef CONFIG_UNICODE
EXT4_ATTR_FEATURE(casefold);
#endif
E
Eric Biggers 已提交
312 313 314
#ifdef CONFIG_FS_VERITY
EXT4_ATTR_FEATURE(verity);
#endif
315
EXT4_ATTR_FEATURE(metadata_csum_seed);
316 317 318 319 320

static struct attribute *ext4_feat_attrs[] = {
	ATTR_LIST(lazy_itable_init),
	ATTR_LIST(batched_discard),
	ATTR_LIST(meta_bg_resize),
321
#ifdef CONFIG_FS_ENCRYPTION
322
	ATTR_LIST(encryption),
323
	ATTR_LIST(test_dummy_encryption_v2),
324 325 326
#endif
#ifdef CONFIG_UNICODE
	ATTR_LIST(casefold),
E
Eric Biggers 已提交
327 328 329
#endif
#ifdef CONFIG_FS_VERITY
	ATTR_LIST(verity),
330
#endif
331
	ATTR_LIST(metadata_csum_seed),
332 333
	NULL,
};
334
ATTRIBUTE_GROUPS(ext4_feat);
335

336 337 338 339 340 341 342 343 344 345 346 347 348
static void *calc_ptr(struct ext4_attr *a, struct ext4_sb_info *sbi)
{
	switch (a->attr_ptr) {
	case ptr_explicit:
		return a->u.explicit_ptr;
	case ptr_ext4_sb_info_offset:
		return (void *) (((char *) sbi) + a->u.offset);
	case ptr_ext4_super_block_offset:
		return (void *) (((char *) sbi->s_es) + a->u.offset);
	}
	return NULL;
}

349 350
static ssize_t __print_tstamp(char *buf, __le32 lo, __u8 hi)
{
351
	return snprintf(buf, PAGE_SIZE, "%lld\n",
352 353 354 355 356 357
			((time64_t)hi << 32) + le32_to_cpu(lo));
}

#define print_tstamp(buf, es, tstamp) \
	__print_tstamp(buf, (es)->tstamp, (es)->tstamp ## _hi)

358 359 360 361 362 363
static ssize_t ext4_attr_show(struct kobject *kobj,
			      struct attribute *attr, char *buf)
{
	struct ext4_sb_info *sbi = container_of(kobj, struct ext4_sb_info,
						s_kobj);
	struct ext4_attr *a = container_of(attr, struct ext4_attr, attr);
364 365 366 367 368 369 370 371
	void *ptr = calc_ptr(a, sbi);

	switch (a->attr_id) {
	case attr_delayed_allocation_blocks:
		return snprintf(buf, PAGE_SIZE, "%llu\n",
				(s64) EXT4_C2B(sbi,
		       percpu_counter_sum(&sbi->s_dirtyclusters_counter)));
	case attr_session_write_kbytes:
372
		return session_write_kbytes_show(sbi, buf);
373
	case attr_lifetime_write_kbytes:
374
		return lifetime_write_kbytes_show(sbi, buf);
375 376 377 378 379 380 381 382
	case attr_reserved_clusters:
		return snprintf(buf, PAGE_SIZE, "%llu\n",
				(unsigned long long)
				atomic64_read(&sbi->s_resv_clusters));
	case attr_inode_readahead:
	case attr_pointer_ui:
		if (!ptr)
			return 0;
383 384 385 386 387 388
		if (a->attr_ptr == ptr_ext4_super_block_offset)
			return snprintf(buf, PAGE_SIZE, "%u\n",
					le32_to_cpup(ptr));
		else
			return snprintf(buf, PAGE_SIZE, "%u\n",
					*((unsigned int *) ptr));
389 390 391 392 393
	case attr_pointer_ul:
		if (!ptr)
			return 0;
		return snprintf(buf, PAGE_SIZE, "%lu\n",
				*((unsigned long *) ptr));
394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412
	case attr_pointer_u8:
		if (!ptr)
			return 0;
		return snprintf(buf, PAGE_SIZE, "%u\n",
				*((unsigned char *) ptr));
	case attr_pointer_u64:
		if (!ptr)
			return 0;
		if (a->attr_ptr == ptr_ext4_super_block_offset)
			return snprintf(buf, PAGE_SIZE, "%llu\n",
					le64_to_cpup(ptr));
		else
			return snprintf(buf, PAGE_SIZE, "%llu\n",
					*((unsigned long long *) ptr));
	case attr_pointer_string:
		if (!ptr)
			return 0;
		return snprintf(buf, PAGE_SIZE, "%.*s\n", a->attr_size,
				(char *) ptr);
413 414 415 416 417 418 419
	case attr_pointer_atomic:
		if (!ptr)
			return 0;
		return snprintf(buf, PAGE_SIZE, "%d\n",
				atomic_read((atomic_t *) ptr));
	case attr_feature:
		return snprintf(buf, PAGE_SIZE, "supported\n");
420 421 422 423
	case attr_first_error_time:
		return print_tstamp(buf, sbi->s_es, s_first_error_time);
	case attr_last_error_time:
		return print_tstamp(buf, sbi->s_es, s_last_error_time);
424 425
	case attr_journal_task:
		return journal_task_show(sbi, buf);
426 427 428
	}

	return 0;
429 430 431 432 433 434 435 436 437
}

static ssize_t ext4_attr_store(struct kobject *kobj,
			       struct attribute *attr,
			       const char *buf, size_t len)
{
	struct ext4_sb_info *sbi = container_of(kobj, struct ext4_sb_info,
						s_kobj);
	struct ext4_attr *a = container_of(attr, struct ext4_attr, attr);
438 439 440
	void *ptr = calc_ptr(a, sbi);
	unsigned long t;
	int ret;
441

442 443
	switch (a->attr_id) {
	case attr_reserved_clusters:
444
		return reserved_clusters_store(sbi, buf, len);
445 446 447 448 449 450
	case attr_pointer_ui:
		if (!ptr)
			return 0;
		ret = kstrtoul(skip_spaces(buf), 0, &t);
		if (ret)
			return ret;
451 452 453 454
		if (a->attr_ptr == ptr_ext4_super_block_offset)
			*((__le32 *) ptr) = cpu_to_le32(t);
		else
			*((unsigned int *) ptr) = t;
455
		return len;
456 457 458 459 460 461 462 463
	case attr_pointer_ul:
		if (!ptr)
			return 0;
		ret = kstrtoul(skip_spaces(buf), 0, &t);
		if (ret)
			return ret;
		*((unsigned long *) ptr) = t;
		return len;
464
	case attr_inode_readahead:
465
		return inode_readahead_blks_store(sbi, buf, len);
466
	case attr_trigger_test_error:
467
		return trigger_test_error(sbi, buf, len);
468 469
	}
	return 0;
470 471 472 473 474 475 476 477 478 479 480 481 482 483 484
}

static void ext4_sb_release(struct kobject *kobj)
{
	struct ext4_sb_info *sbi = container_of(kobj, struct ext4_sb_info,
						s_kobj);
	complete(&sbi->s_kobj_unregister);
}

static const struct sysfs_ops ext4_attr_ops = {
	.show	= ext4_attr_show,
	.store	= ext4_attr_store,
};

static struct kobj_type ext4_sb_ktype = {
485
	.default_groups = ext4_groups,
486 487 488 489 490
	.sysfs_ops	= &ext4_attr_ops,
	.release	= ext4_sb_release,
};

static struct kobj_type ext4_feat_ktype = {
491
	.default_groups = ext4_feat_groups,
492
	.sysfs_ops	= &ext4_attr_ops,
493
	.release	= (void (*)(struct kobject *))kfree,
494 495
};

T
Tyson Nottingham 已提交
496 497
static struct kobject *ext4_root;

498
static struct kobject *ext4_feat;
499 500 501 502

int ext4_register_sysfs(struct super_block *sb)
{
	struct ext4_sb_info *sbi = EXT4_SB(sb);
503
	int err;
504 505

	init_completion(&sbi->s_kobj_unregister);
T
Tyson Nottingham 已提交
506
	err = kobject_init_and_add(&sbi->s_kobj, &ext4_sb_ktype, ext4_root,
507
				   "%s", sb->s_id);
508 509 510
	if (err) {
		kobject_put(&sbi->s_kobj);
		wait_for_completion(&sbi->s_kobj_unregister);
511
		return err;
512
	}
513 514 515 516

	if (ext4_proc_root)
		sbi->s_proc = proc_mkdir(sb->s_id, ext4_proc_root);
	if (sbi->s_proc) {
C
Christoph Hellwig 已提交
517 518 519 520 521 522 523
		proc_create_single_data("options", S_IRUGO, sbi->s_proc,
				ext4_seq_options_show, sb);
		proc_create_single_data("es_shrinker_info", S_IRUGO,
				sbi->s_proc, ext4_seq_es_shrinker_info_show,
				sb);
		proc_create_seq_data("mb_groups", S_IRUGO, sbi->s_proc,
				&ext4_mb_seq_groups_ops, sb);
524 525 526 527 528 529 530 531
	}
	return 0;
}

void ext4_unregister_sysfs(struct super_block *sb)
{
	struct ext4_sb_info *sbi = EXT4_SB(sb);

C
Christoph Hellwig 已提交
532 533
	if (sbi->s_proc)
		remove_proc_subtree(sb->s_id, ext4_proc_root);
534
	kobject_del(&sbi->s_kobj);
535 536 537 538 539 540
}

int __init ext4_init_sysfs(void)
{
	int ret;

T
Tyson Nottingham 已提交
541 542
	ext4_root = kobject_create_and_add("ext4", fs_kobj);
	if (!ext4_root)
543 544
		return -ENOMEM;

545 546 547
	ext4_feat = kzalloc(sizeof(*ext4_feat), GFP_KERNEL);
	if (!ext4_feat) {
		ret = -ENOMEM;
T
Tyson Nottingham 已提交
548
		goto root_err;
549
	}
550 551

	ret = kobject_init_and_add(ext4_feat, &ext4_feat_ktype,
T
Tyson Nottingham 已提交
552
				   ext4_root, "features");
553 554 555 556 557 558 559 560
	if (ret)
		goto feat_err;

	ext4_proc_root = proc_mkdir(proc_dirname, NULL);
	return ret;

feat_err:
	kobject_put(ext4_feat);
561
	ext4_feat = NULL;
T
Tyson Nottingham 已提交
562 563 564
root_err:
	kobject_put(ext4_root);
	ext4_root = NULL;
565 566 567 568 569
	return ret;
}

void ext4_exit_sysfs(void)
{
570
	kobject_put(ext4_feat);
571
	ext4_feat = NULL;
T
Tyson Nottingham 已提交
572 573
	kobject_put(ext4_root);
	ext4_root = NULL;
574 575
	remove_proc_entry(proc_dirname, NULL);
	ext4_proc_root = NULL;
576 577
}